[jira] [Commented] (HIVE-19565) Vectorization: Fix NULL / Wrong Results issues in STRING Functions

2018-06-15 Thread Matt McCline (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-19565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513902#comment-16513902
 ] 

Matt McCline commented on HIVE-19565:
-

Test failures for branch-3 are unrelated.

> Vectorization: Fix NULL / Wrong Results issues in STRING Functions
> --
>
> Key: HIVE-19565
> URL: https://issues.apache.org/jira/browse/HIVE-19565
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Fix For: 4.0.0
>
> Attachments: HIVE-19565.01-branch-3.patch, HIVE-19565.01.patch
>
>
> Write new UT tests that use random data and intentional isRepeating batches 
> to checks for NULL and Wrong Results for vectorized STRING functions:
>  * char_length
>  * concat
>  * initcap
>  * length
>  * lower
>  * ltrim
>  * octet_length
>  * rtrim
>  * trim
>  * upper
>  * UDF:
>  ** hex
>  ** substr
> BUGs found in LTRIM, CONCAT, and SUBSTR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-19565) Vectorization: Fix NULL / Wrong Results issues in STRING Functions

2018-06-15 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-19565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513843#comment-16513843
 ] 

Hive QA commented on HIVE-19565:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12927922/HIVE-19565.01-branch-3.patch

{color:green}SUCCESS:{color} +1 due to 8 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 14464 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidkafkamini_basic]
 (batchId=254)
org.apache.hive.spark.client.rpc.TestRpc.testServerPort (batchId=306)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/11802/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11802/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11802/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12927922 - PreCommit-HIVE-Build

> Vectorization: Fix NULL / Wrong Results issues in STRING Functions
> --
>
> Key: HIVE-19565
> URL: https://issues.apache.org/jira/browse/HIVE-19565
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Fix For: 4.0.0
>
> Attachments: HIVE-19565.01-branch-3.patch, HIVE-19565.01.patch
>
>
> Write new UT tests that use random data and intentional isRepeating batches 
> to checks for NULL and Wrong Results for vectorized STRING functions:
>  * char_length
>  * concat
>  * initcap
>  * length
>  * lower
>  * ltrim
>  * octet_length
>  * rtrim
>  * trim
>  * upper
>  * UDF:
>  ** hex
>  ** substr
> BUGs found in LTRIM, CONCAT, and SUBSTR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-19565) Vectorization: Fix NULL / Wrong Results issues in STRING Functions

2018-06-15 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-19565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513778#comment-16513778
 ] 

Hive QA commented on HIVE-19565:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  9s{color} 
| {color:red} 
/data/hiveptest/logs/PreCommit-HIVE-Build-11802/patches/PreCommit-HIVE-Build-11802.patch
 does not apply to master. Rebase required? Wrong Branch? See 
http://cwiki.apache.org/confluence/display/Hive/HowToContribute for help. 
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-11802/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Vectorization: Fix NULL / Wrong Results issues in STRING Functions
> --
>
> Key: HIVE-19565
> URL: https://issues.apache.org/jira/browse/HIVE-19565
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Fix For: 4.0.0
>
> Attachments: HIVE-19565.01-branch-3.patch, HIVE-19565.01.patch
>
>
> Write new UT tests that use random data and intentional isRepeating batches 
> to checks for NULL and Wrong Results for vectorized STRING functions:
>  * char_length
>  * concat
>  * initcap
>  * length
>  * lower
>  * ltrim
>  * octet_length
>  * rtrim
>  * trim
>  * upper
>  * UDF:
>  ** hex
>  ** substr
> BUGs found in LTRIM, CONCAT, and SUBSTR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-19565) Vectorization: Fix NULL / Wrong Results issues in STRING Functions

2018-06-15 Thread Matt McCline (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-19565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513386#comment-16513386
 ] 

Matt McCline commented on HIVE-19565:
-

Awaiting branch-3 Hive QA run.

> Vectorization: Fix NULL / Wrong Results issues in STRING Functions
> --
>
> Key: HIVE-19565
> URL: https://issues.apache.org/jira/browse/HIVE-19565
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Fix For: 4.0.0
>
> Attachments: HIVE-19565.01-branch-3.patch, HIVE-19565.01.patch
>
>
> Write new UT tests that use random data and intentional isRepeating batches 
> to checks for NULL and Wrong Results for vectorized STRING functions:
>  * char_length
>  * concat
>  * initcap
>  * length
>  * lower
>  * ltrim
>  * octet_length
>  * rtrim
>  * trim
>  * upper
>  * UDF:
>  ** hex
>  ** substr
> BUGs found in LTRIM, CONCAT, and SUBSTR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-19565) Vectorization: Fix NULL / Wrong Results issues in STRING Functions

2018-06-14 Thread Teddy Choi (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-19565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513371#comment-16513371
 ] 

Teddy Choi commented on HIVE-19565:
---

+1 LGTM. Thanks for better tests!

> Vectorization: Fix NULL / Wrong Results issues in STRING Functions
> --
>
> Key: HIVE-19565
> URL: https://issues.apache.org/jira/browse/HIVE-19565
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Attachments: HIVE-19565.01-branch-3.patch, HIVE-19565.01.patch
>
>
> Write new UT tests that use random data and intentional isRepeating batches 
> to checks for NULL and Wrong Results for vectorized STRING functions:
>  * char_length
>  * concat
>  * initcap
>  * length
>  * lower
>  * ltrim
>  * octet_length
>  * rtrim
>  * trim
>  * upper
>  * UDF:
>  ** hex
>  ** substr
> BUGs found in LTRIM, CONCAT, and SUBSTR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-19565) Vectorization: Fix NULL / Wrong Results issues in STRING Functions

2018-06-14 Thread Matt McCline (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-19565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513281#comment-16513281
 ] 

Matt McCline commented on HIVE-19565:
-

Clean master Hive QA run.

> Vectorization: Fix NULL / Wrong Results issues in STRING Functions
> --
>
> Key: HIVE-19565
> URL: https://issues.apache.org/jira/browse/HIVE-19565
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Attachments: HIVE-19565.01-branch-3.patch, HIVE-19565.01.patch
>
>
> Write new UT tests that use random data and intentional isRepeating batches 
> to checks for NULL and Wrong Results for vectorized STRING functions:
>  * char_length
>  * concat
>  * initcap
>  * length
>  * lower
>  * ltrim
>  * octet_length
>  * rtrim
>  * trim
>  * upper
>  * UDF:
>  ** hex
>  ** substr
> BUGs found in LTRIM, CONCAT, and SUBSTR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-19565) Vectorization: Fix NULL / Wrong Results issues in STRING Functions

2018-06-14 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-19565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512363#comment-16512363
 ] 

Hive QA commented on HIVE-19565:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12927739/HIVE-19565.01.patch

{color:green}SUCCESS:{color} +1 due to 8 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 14526 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/11777/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11777/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11777/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12927739 - PreCommit-HIVE-Build

> Vectorization: Fix NULL / Wrong Results issues in STRING Functions
> --
>
> Key: HIVE-19565
> URL: https://issues.apache.org/jira/browse/HIVE-19565
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Attachments: HIVE-19565.01.patch
>
>
> Write new UT tests that use random data and intentional isRepeating batches 
> to checks for NULL and Wrong Results for vectorized STRING functions:
>  * char_length
>  * concat
>  * initcap
>  * length
>  * lower
>  * ltrim
>  * octet_length
>  * rtrim
>  * trim
>  * upper
>  * UDF:
>  ** hex
>  ** substr
> BUGs found in LTRIM, CONCAT, and SUBSTR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-19565) Vectorization: Fix NULL / Wrong Results issues in STRING Functions

2018-06-14 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-19565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512319#comment-16512319
 ] 

Hive QA commented on HIVE-19565:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  6m 
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 5s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
47s{color} | {color:blue} ql in master has 2279 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
53s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
59s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  1m 
10s{color} | {color:red} ql: The patch generated 180 new + 2960 unchanged - 83 
fixed = 3140 total (was 3043) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  
1s{color} | {color:red} The patch has 2 line(s) that end in whitespace. Use git 
apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply 
{color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
53s{color} | {color:green} ql generated 0 new + 2277 unchanged - 2 fixed = 2277 
total (was 2279) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
12s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 19s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11777/dev-support/hive-personality.sh
 |
| git revision | master / bcbd2d5 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-11777/yetus/diff-checkstyle-ql.txt
 |
| whitespace | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-11777/yetus/whitespace-eol.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-11777/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Vectorization: Fix NULL / Wrong Results issues in STRING Functions
> --
>
> Key: HIVE-19565
> URL: https://issues.apache.org/jira/browse/HIVE-19565
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Matt McCline
>Assignee: Matt McCline
>Priority: Critical
> Attachments: HIVE-19565.01.patch
>
>
> Write new UT tests that use random data and intentional isRepeating batches 
> to checks for NULL and Wrong Results for vectorized STRING functions:
>  * char_length
>  * concat
>  * initcap
>  * length
>  * lower
>  * ltrim
>  * octet_length
>  * rtrim
>  * trim
>  * upper
>  * UDF:
>  ** hex
>  ** substr
> BUGs found in LTRIM, CONCAT, and SUBSTR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)