[jira] [Commented] (HIVE-19681) Fix TestVectorIfStatement
[
https://issues.apache.org/jira/browse/HIVE-19681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487875#comment-16487875
]
Vihang Karajgaonkar commented on HIVE-19681:
Oh I see it now. The random rows are first generated and then modified and then
used by all the three modes. That makes sense to me now. Will close this JIRA
as not a problem. Thanks for the clarification.
> Fix TestVectorIfStatement
> -
>
> Key: HIVE-19681
> URL: https://issues.apache.org/jira/browse/HIVE-19681
> Project: Hive
> Issue Type: Test
> Components: Vectorization
>Affects Versions: 3.1.0, 4.0.0
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Major
>
> {{TestVectorIfStatement}} generates interesting batches (injection of random
> repeating null column values and repeating non-null values) when evaluating
> the vectorized expressions. But the modification of random rows is done after
> the row mode is evaluated. Hence it is likely that comparison results will
> fail. I am not sure how its working in the first place.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19681) Fix TestVectorIfStatement
[
https://issues.apache.org/jira/browse/HIVE-19681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487858#comment-16487858
]
Matt McCline commented on HIVE-19681:
-
Oh, it is a two-step generation process:
1) Generate the random rows.
2) Then, based on more random numbers, decide how to arrange the random rows
into interesting batches. The "trick" is to do some modification of the
original random rows like copying repeated NULLs or repeated values down
columns for the interesting batch being configured.
The interesting batch configuration is kept and used to generate the batches
from the modified random rows. So, the data is the same for row-mode and
vector-mode.
> Fix TestVectorIfStatement
> -
>
> Key: HIVE-19681
> URL: https://issues.apache.org/jira/browse/HIVE-19681
> Project: Hive
> Issue Type: Test
> Components: Vectorization
>Affects Versions: 3.1.0, 4.0.0
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Major
>
> {{TestVectorIfStatement}} generates interesting batches (injection of random
> repeating null column values and repeating non-null values) when evaluating
> the vectorized expressions. But the modification of random rows is done after
> the row mode is evaluated. Hence it is likely that comparison results will
> fail. I am not sure how its working in the first place.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19681) Fix TestVectorIfStatement
[
https://issues.apache.org/jira/browse/HIVE-19681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16487728#comment-16487728
]
Vihang Karajgaonkar commented on HIVE-19681:
Hi [~mmccline] I noticed that you introduced this test in HIVE-19384. Based on
my understanding the row mode operates on unmodified set of {{randomRows}} but
the vector expressions work on the {{interesting batches}} created using
{{batchSource.fillNextBatch}} which injects randomly repeated NULL values and
repeated non-null values. How does it work? How would the results from row mode
and vectorized mode results ever match if this is the understanding?
> Fix TestVectorIfStatement
> -
>
> Key: HIVE-19681
> URL: https://issues.apache.org/jira/browse/HIVE-19681
> Project: Hive
> Issue Type: Test
> Components: Vectorization
>Affects Versions: 3.1.0, 4.0.0
>Reporter: Vihang Karajgaonkar
>Assignee: Vihang Karajgaonkar
>Priority: Major
>
> {{TestVectorIfStatement}} generates interesting batches (injection of random
> repeating null column values and repeating non-null values) when evaluating
> the vectorized expressions. But the modification of random rows is done after
> the row mode is evaluated. Hence it is likely that comparison results will
> fail. I am not sure how its working in the first place.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
