[jira] [Commented] (HIVE-19688) Make catalogs updatable
[ https://issues.apache.org/jira/browse/HIVE-19688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499836#comment-16499836 ] Daniel Dai commented on HIVE-19688: --- +1 > Make catalogs updatable > --- > > Key: HIVE-19688 > URL: https://issues.apache.org/jira/browse/HIVE-19688 > Project: Hive > Issue Type: Sub-task > Components: Metastore >Affects Versions: 3.0.0 >Reporter: Alan Gates >Assignee: Alan Gates >Priority: Major > Attachments: HIVE-19688.1take2.patch, HIVE-19688.patch > > > The initial changes for catalogs did not include an ability to alter > catalogs. We need to add that. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19688) Make catalogs updatable
[
https://issues.apache.org/jira/browse/HIVE-19688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497496#comment-16497496
]
Hive QA commented on HIVE-19688:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12925585/HIVE-19688.1take2.patch
{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14445 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11399/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11399/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11399/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12925585 - PreCommit-HIVE-Build
> Make catalogs updatable
> ---
>
> Key: HIVE-19688
> URL: https://issues.apache.org/jira/browse/HIVE-19688
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore
>Affects Versions: 3.0.0
>Reporter: Alan Gates
>Assignee: Alan Gates
>Priority: Major
> Attachments: HIVE-19688.1take2.patch, HIVE-19688.patch
>
>
> The initial changes for catalogs did not include an ability to alter
> catalogs. We need to add that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19688) Make catalogs updatable
[
https://issues.apache.org/jira/browse/HIVE-19688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497451#comment-16497451
]
Hive QA commented on HIVE-19688:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
45s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
28s{color} | {color:blue} beeline in master has 69 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
33s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
52s{color} | {color:blue} standalone-metastore in master has 214 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
23s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
8s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
34s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
11s{color} | {color:red} beeline: The patch generated 4 new + 73 unchanged - 0
fixed = 77 total (was 73) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
25s{color} | {color:red} standalone-metastore: The patch generated 13 new + 950
unchanged - 0 fixed = 963 total (was 950) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 24 line(s) that end in whitespace. Use
git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
36s{color} | {color:red} beeline generated 1 new + 69 unchanged - 0 fixed = 70
total (was 69) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
11s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 10s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:beeline |
| | org.apache.hive.beeline.HiveSchemaTool.alterCatalog(String, String,
String) passes a nonconstant String to an execute or addBatch method on an SQL
statement At HiveSchemaTool.java:nonconstant String to an execute or addBatch
method on an SQL statement At HiveSchemaTool.java:[line 987] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11399/dev-support/hive-personality.sh
|
| git revision | master / 06807bc |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11399/yetus/diff-checkstyle-beeline.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11399/yetus/diff-checkstyle-standalone-metastore.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11399/yetus/whitespace-eol.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11399/yetus/new-findbugs-beeline.html
|
| modules | C: beeline itests/hive-unit standalone-metastore U: . |
| Console output |
[jira] [Commented] (HIVE-19688) Make catalogs updatable
[
https://issues.apache.org/jira/browse/HIVE-19688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491931#comment-16491931
]
Hive QA commented on HIVE-19688:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12925018/HIVE-19688.patch
{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 14396 tests
executed
*Failed tests:*
{noformat}
TestHiveMetaStoreAlterColumnPar - did not produce a TEST-*.xml file (likely
timed out) (batchId=230)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/11249/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11249/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11249/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12925018 - PreCommit-HIVE-Build
> Make catalogs updatable
> ---
>
> Key: HIVE-19688
> URL: https://issues.apache.org/jira/browse/HIVE-19688
> Project: Hive
> Issue Type: Sub-task
> Components: Metastore
>Affects Versions: 3.0.0
>Reporter: Alan Gates
>Assignee: Alan Gates
>Priority: Major
> Attachments: HIVE-19688.patch
>
>
> The initial changes for catalogs did not include an ability to alter
> catalogs. We need to add that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19688) Make catalogs updatable
[
https://issues.apache.org/jira/browse/HIVE-19688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16491926#comment-16491926
]
Hive QA commented on HIVE-19688:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
26s{color} | {color:blue} beeline in master has 69 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
33s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs
warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m
39s{color} | {color:blue} standalone-metastore in master has 216 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
7s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
25s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
10s{color} | {color:red} beeline: The patch generated 4 new + 72 unchanged - 0
fixed = 76 total (was 72) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
23s{color} | {color:red} standalone-metastore: The patch generated 13 new + 951
unchanged - 0 fixed = 964 total (was 951) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 24 line(s) that end in whitespace. Use
git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m
34s{color} | {color:red} beeline generated 1 new + 69 unchanged - 0 fixed = 70
total (was 69) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
18s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
10s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 54s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:beeline |
| | org.apache.hive.beeline.HiveSchemaTool.alterCatalog(String, String,
String) passes a nonconstant String to an execute or addBatch method on an SQL
statement At HiveSchemaTool.java:nonconstant String to an execute or addBatch
method on an SQL statement At HiveSchemaTool.java:[line 994] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-11249/dev-support/hive-personality.sh
|
| git revision | master / 1f92316 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11249/yetus/diff-checkstyle-beeline.txt
|
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11249/yetus/diff-checkstyle-standalone-metastore.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11249/yetus/whitespace-eol.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-11249/yetus/new-findbugs-beeline.html
|
| modules | C: beeline itests/hive-unit standalone-metastore U: . |
| Console output |
[jira] [Commented] (HIVE-19688) Make catalogs updatable
[ https://issues.apache.org/jira/browse/HIVE-19688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16489742#comment-16489742 ] Alan Gates commented on HIVE-19688: --- As part of adding this I discovered a critical bug in the --createCatalog option for schematool. When it adds a catalog it does a select max(CTLD_ID) from CTLGS and then adds 1. But if the database uses its own sequence to update this field, this operation interferes with that. The next time a createCatalog is done via HiveMetaStoreClient it will fail because the value from the sequence will already be used in the CTLGS table. To fix it I added 2^29 to the value the first time a catalog is added from schematool so that there is not a clash between the catalogs added by HiveMetaStoreClient and those added by schematool. > Make catalogs updatable > --- > > Key: HIVE-19688 > URL: https://issues.apache.org/jira/browse/HIVE-19688 > Project: Hive > Issue Type: Sub-task > Components: Metastore >Affects Versions: 3.0.0 >Reporter: Alan Gates >Assignee: Alan Gates >Priority: Major > Attachments: HIVE-19688.patch > > > The initial changes for catalogs did not include an ability to alter > catalogs. We need to add that. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
