[jira] [Commented] (HIVE-19748) Add appropriate null checks to DecimalColumnStatsAggregator
[ https://issues.apache.org/jira/browse/HIVE-19748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914041#comment-16914041 ] Hive QA commented on HIVE-19748: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12941085/HIVE-19748.1.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18388/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18388/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18388/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2019-08-23 08:14:51.790 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-18388/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2019-08-23 08:14:51.793 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at db59ec6 HIVE-21580: Introduce ISO 8601 week numbering SQL:2016 formats (Karen Coppage via Marta Kuczora) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at db59ec6 HIVE-21580: Introduce ISO 8601 week numbering SQL:2016 formats (Karen Coppage via Marta Kuczora) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2019-08-23 08:14:52.556 + rm -rf ../yetus_PreCommit-HIVE-Build-18388 + mkdir ../yetus_PreCommit-HIVE-Build-18388 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-18388 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-18388/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/columnstats/aggr/DecimalColumnStatsAggregator.java: does not exist in index error: standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/columnstats/aggr/DecimalColumnStatsAggregator.java: does not exist in index error: src/main/java/org/apache/hadoop/hive/metastore/columnstats/aggr/DecimalColumnStatsAggregator.java: does not exist in index The patch does not appear to apply with p0, p1, or p2 + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-18388 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12941085 - PreCommit-HIVE-Build > Add appropriate null checks to DecimalColumnStatsAggregator > --- > > Key: HIVE-19748 > URL: https://issues.apache.org/jira/browse/HIVE-19748 > Project: Hive > Issue Type: Bug > Components: Metastore >Affects Versions: 3.0.0 >Reporter: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-19748.1.patch, HIVE-19748.1.patch, > HIVE-19748.1.patch, HIVE-19748.1.patch > > > In some of our internal testing, we noticed that calls to > MetaStoreUtils.decimalToDoublee(Decimal decimal) from within > DecimalColumnStatsAggregator end up passing null Decimal values to the method. -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-19748) Add appropriate null checks to DecimalColumnStatsAggregator
[ https://issues.apache.org/jira/browse/HIVE-19748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626585#comment-16626585 ] Daniel Dai commented on HIVE-19748: --- The patch needs to rebase since standalone-metastore is splitted into modules. Also do we know at which scenario newData.getHighValue/newData.getLowValue can be null? Does it applicable to datatype other than decimal as well? > Add appropriate null checks to DecimalColumnStatsAggregator > --- > > Key: HIVE-19748 > URL: https://issues.apache.org/jira/browse/HIVE-19748 > Project: Hive > Issue Type: Bug > Components: Metastore >Affects Versions: 3.0.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-19748.1.patch, HIVE-19748.1.patch, > HIVE-19748.1.patch, HIVE-19748.1.patch > > > In some of our internal testing, we noticed that calls to > MetaStoreUtils.decimalToDoublee(Decimal decimal) from within > DecimalColumnStatsAggregator end up passing null Decimal values to the method. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19748) Add appropriate null checks to DecimalColumnStatsAggregator
[ https://issues.apache.org/jira/browse/HIVE-19748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624424#comment-16624424 ] Hive QA commented on HIVE-19748: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12940696/HIVE-19748.1.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/13962/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13962/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13962/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2018-09-22 02:01:14.697 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-13962/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2018-09-22 02:01:14.700 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at cdba00c HIVE-20555: HiveServer2: Preauthenticated subject for http transport is not retained for entire duration of http communication in some cases (Vaibhav Gumashta reviewed by Daniel Dai) + git clean -f -d Removing ${project.basedir}/ Removing itests/${project.basedir}/ Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at cdba00c HIVE-20555: HiveServer2: Preauthenticated subject for http transport is not retained for entire duration of http communication in some cases (Vaibhav Gumashta reviewed by Daniel Dai) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2018-09-22 02:01:15.389 + rm -rf ../yetus_PreCommit-HIVE-Build-13962 + mkdir ../yetus_PreCommit-HIVE-Build-13962 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-13962 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-13962/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch error: a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/columnstats/aggr/DecimalColumnStatsAggregator.java: does not exist in index error: standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/columnstats/aggr/DecimalColumnStatsAggregator.java: does not exist in index error: src/main/java/org/apache/hadoop/hive/metastore/columnstats/aggr/DecimalColumnStatsAggregator.java: does not exist in index The patch does not appear to apply with p0, p1, or p2 + result=1 + '[' 1 -ne 0 ']' + rm -rf yetus_PreCommit-HIVE-Build-13962 + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12940696 - PreCommit-HIVE-Build > Add appropriate null checks to DecimalColumnStatsAggregator > --- > > Key: HIVE-19748 > URL: https://issues.apache.org/jira/browse/HIVE-19748 > Project: Hive > Issue Type: Bug > Components: Metastore >Affects Versions: 3.0.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-19748.1.patch, HIVE-19748.1.patch, > HIVE-19748.1.patch > > > In some of our internal testing, we noticed that calls to > MetaStoreUtils.decimalToDoublee(Decimal decimal) from within > DecimalColumnStatsAggregator end up passing null Decimal values to the method. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19748) Add appropriate null checks to DecimalColumnStatsAggregator
[ https://issues.apache.org/jira/browse/HIVE-19748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499607#comment-16499607 ] Hive QA commented on HIVE-19748: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12925988/HIVE-19748.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 14432 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.metastore.client.TestRuntimeStats.testCleanup[Embedded] (batchId=209) org.apache.hive.jdbc.TestTriggersWorkloadManager.org.apache.hive.jdbc.TestTriggersWorkloadManager (batchId=240) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/11482/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11482/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11482/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12925988 - PreCommit-HIVE-Build > Add appropriate null checks to DecimalColumnStatsAggregator > --- > > Key: HIVE-19748 > URL: https://issues.apache.org/jira/browse/HIVE-19748 > Project: Hive > Issue Type: Bug > Components: Metastore >Affects Versions: 3.0.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-19748.1.patch > > > In some of our internal testing, we noticed that calls to > MetaStoreUtils.decimalToDoublee(Decimal decimal) from within > DecimalColumnStatsAggregator end up passing null Decimal values to the method. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19748) Add appropriate null checks to DecimalColumnStatsAggregator
[ https://issues.apache.org/jira/browse/HIVE-19748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499592#comment-16499592 ] Hive QA commented on HIVE-19748: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 51s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 2m 38s{color} | {color:blue} standalone-metastore in master has 214 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 48s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} standalone-metastore: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 16m 52s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-11482/dev-support/hive-personality.sh | | git revision | master / a929d4c | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: standalone-metastore U: standalone-metastore | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-11482/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Add appropriate null checks to DecimalColumnStatsAggregator > --- > > Key: HIVE-19748 > URL: https://issues.apache.org/jira/browse/HIVE-19748 > Project: Hive > Issue Type: Bug > Components: Metastore >Affects Versions: 3.0.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-19748.1.patch > > > In some of our internal testing, we noticed that calls to > MetaStoreUtils.decimalToDoublee(Decimal decimal) from within > DecimalColumnStatsAggregator end up passing null Decimal values to the method. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19748) Add appropriate null checks to DecimalColumnStatsAggregator
[ https://issues.apache.org/jira/browse/HIVE-19748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16497141#comment-16497141 ] Vaibhav Gumashta commented on HIVE-19748: - cc [~daijy] [~thejas] > Add appropriate null checks to DecimalColumnStatsAggregator > --- > > Key: HIVE-19748 > URL: https://issues.apache.org/jira/browse/HIVE-19748 > Project: Hive > Issue Type: Bug > Components: Metastore >Affects Versions: 3.0.0 >Reporter: Vaibhav Gumashta >Assignee: Vaibhav Gumashta >Priority: Major > Attachments: HIVE-19748.1.patch > > > In some of our internal testing, we noticed that calls to > MetaStoreUtils.decimalToDoublee(Decimal decimal) from within > DecimalColumnStatsAggregator end up passing null Decimal values to the method. -- This message was sent by Atlassian JIRA (v7.6.3#76005)