[jira] [Commented] (HIVE-19971) TestRuntimeStats.testCleanup() is flaky
[ https://issues.apache.org/jira/browse/HIVE-19971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526452#comment-16526452 ] Andrew Sherman commented on HIVE-19971: --- Thanks [~kgyrtkirk] and [~pvary] for the review and push! > TestRuntimeStats.testCleanup() is flaky > --- > > Key: HIVE-19971 > URL: https://issues.apache.org/jira/browse/HIVE-19971 > Project: Hive > Issue Type: Task >Reporter: Andrew Sherman >Assignee: Andrew Sherman >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-19971.1.patch, HIVE-19971.2.patch, > HIVE-19971.3.patch, HIVE-19971.4.patch > > > This test is timing dependent and sometimes fails. [You can see that it > sometimes fails in otherwise clean > runs|https://issues.apache.org/jira/issues/?jql=text%20~%20%22TestRuntimeStats%22]. > The test inserts a stat, sleeps for 2 seconds, inserts another stat, then > deletes stats that are older than 1 second. The test asserts that exactly one > stat is deleted. If the deletion is slow for some reason (perhaps a GC?) then > 2 stats will be deleted and the test will fail. The trouble is that the 1 > second window is too small to work consistently. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19971) TestRuntimeStats.testCleanup() is flaky
[ https://issues.apache.org/jira/browse/HIVE-19971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16526299#comment-16526299 ] Zoltan Haindrich commented on HIVE-19971: - I was looking for if someone have opened a ticket so far to fix this...and yes :D I wanted to fix this also [~pvary] I also don't like the way this test works - but I haven't seen a better way to do it... there were already 2 testruns in which this test didn't fail...and since this will reduce flakiness I will commit it right away... +1 > TestRuntimeStats.testCleanup() is flaky > --- > > Key: HIVE-19971 > URL: https://issues.apache.org/jira/browse/HIVE-19971 > Project: Hive > Issue Type: Task >Reporter: Andrew Sherman >Assignee: Andrew Sherman >Priority: Major > Attachments: HIVE-19971.1.patch, HIVE-19971.2.patch, > HIVE-19971.3.patch, HIVE-19971.4.patch > > > This test is timing dependent and sometimes fails. [You can see that it > sometimes fails in otherwise clean > runs|https://issues.apache.org/jira/issues/?jql=text%20~%20%22TestRuntimeStats%22]. > The test inserts a stat, sleeps for 2 seconds, inserts another stat, then > deletes stats that are older than 1 second. The test asserts that exactly one > stat is deleted. If the deletion is slow for some reason (perhaps a GC?) then > 2 stats will be deleted and the test will fail. The trouble is that the 1 > second window is too small to work consistently. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-19971) TestRuntimeStats.testCleanup() is flaky
[
https://issues.apache.org/jira/browse/HIVE-19971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524757#comment-16524757
]
Hive QA commented on HIVE-19971:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12929258/HIVE-19971.3.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 14609 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druid_timestamptz]
(batchId=191)
org.apache.hadoop.hive.cli.TestMiniDruidCliDriver.testCliDriver[druidmini_joins]
(batchId=191)
org.apache.hive.jdbc.TestJdbcWithMiniHS2.testParallelCompilation3 (batchId=250)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/12180/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12180/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12180/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12929258 - PreCommit-HIVE-Build
> TestRuntimeStats.testCleanup() is flaky
> ---
>
> Key: HIVE-19971
> URL: https://issues.apache.org/jira/browse/HIVE-19971
> Project: Hive
> Issue Type: Task
>Reporter: Andrew Sherman
>Assignee: Andrew Sherman
>Priority: Major
> Attachments: HIVE-19971.1.patch, HIVE-19971.2.patch,
> HIVE-19971.3.patch
>
>
> This test is timing dependent and sometimes fails. [You can see that it
> sometimes fails in otherwise clean
> runs|https://issues.apache.org/jira/issues/?jql=text%20~%20%22TestRuntimeStats%22].
> The test inserts a stat, sleeps for 2 seconds, inserts another stat, then
> deletes stats that are older than 1 second. The test asserts that exactly one
> stat is deleted. If the deletion is slow for some reason (perhaps a GC?) then
> 2 stats will be deleted and the test will fail. The trouble is that the 1
> second window is too small to work consistently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19971) TestRuntimeStats.testCleanup() is flaky
[
https://issues.apache.org/jira/browse/HIVE-19971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524711#comment-16524711
]
Hive QA commented on HIVE-19971:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
13s{color} | {color:blue} standalone-metastore in master has 228 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
54s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 19m 53s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12180/dev-support/hive-personality.sh
|
| git revision | master / 966b83e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: standalone-metastore U: standalone-metastore |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12180/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> TestRuntimeStats.testCleanup() is flaky
> ---
>
> Key: HIVE-19971
> URL: https://issues.apache.org/jira/browse/HIVE-19971
> Project: Hive
> Issue Type: Task
>Reporter: Andrew Sherman
>Assignee: Andrew Sherman
>Priority: Major
> Attachments: HIVE-19971.1.patch, HIVE-19971.2.patch,
> HIVE-19971.3.patch
>
>
> This test is timing dependent and sometimes fails. [You can see that it
> sometimes fails in otherwise clean
> runs|https://issues.apache.org/jira/issues/?jql=text%20~%20%22TestRuntimeStats%22].
> The test inserts a stat, sleeps for 2 seconds, inserts another stat, then
> deletes stats that are older than 1 second. The test asserts that exactly one
> stat is deleted. If the deletion is slow for some reason (perhaps a GC?) then
> 2 stats will be deleted and the test will fail. The trouble is that the 1
> second window is too small to work consistently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19971) TestRuntimeStats.testCleanup() is flaky
[
https://issues.apache.org/jira/browse/HIVE-19971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521320#comment-16521320
]
Hive QA commented on HIVE-19971:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12928816/HIVE-19971.1.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 14590 tests
executed
*Failed tests:*
{noformat}
org.apache.hive.jdbc.TestTriggersNoTezSessionPool.testTriggerSlowQueryExecutionTime
(batchId=243)
org.apache.hive.jdbc.TestTriggersNoTezSessionPool.testTriggerTotalLaunchedTasks
(batchId=243)
org.apache.hive.jdbc.TestTriggersNoTezSessionPool.testTriggerVertexTotalTasks
(batchId=243)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/12041/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/12041/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-12041/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12928816 - PreCommit-HIVE-Build
> TestRuntimeStats.testCleanup() is flaky
> ---
>
> Key: HIVE-19971
> URL: https://issues.apache.org/jira/browse/HIVE-19971
> Project: Hive
> Issue Type: Task
>Reporter: Andrew Sherman
>Assignee: Andrew Sherman
>Priority: Major
> Attachments: HIVE-19971.1.patch
>
>
> This test is timing dependent and sometimes fails. [You can see that it
> sometimes fails in otherwise clean
> runs|https://issues.apache.org/jira/issues/?jql=text%20~%20%22TestRuntimeStats%22].
> The test inserts a stat, sleeps for 2 seconds, inserts another stat, then
> deletes stats that are older than 1 second. The test asserts that exactly one
> stat is deleted. If the deletion is slow for some reason (perhaps a GC?) then
> 2 stats will be deleted and the test will fail. The trouble is that the 1
> second window is too small to work consistently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19971) TestRuntimeStats.testCleanup() is flaky
[
https://issues.apache.org/jira/browse/HIVE-19971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521309#comment-16521309
]
Hive QA commented on HIVE-19971:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
15s{color} | {color:blue} standalone-metastore in master has 228 extant
Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 19m 57s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-12041/dev-support/hive-personality.sh
|
| git revision | master / 98c2df1 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: standalone-metastore U: standalone-metastore |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-12041/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> TestRuntimeStats.testCleanup() is flaky
> ---
>
> Key: HIVE-19971
> URL: https://issues.apache.org/jira/browse/HIVE-19971
> Project: Hive
> Issue Type: Task
>Reporter: Andrew Sherman
>Assignee: Andrew Sherman
>Priority: Major
> Attachments: HIVE-19971.1.patch
>
>
> This test is timing dependent and sometimes fails. [You can see that it
> sometimes fails in otherwise clean
> runs|https://issues.apache.org/jira/issues/?jql=text%20~%20%22TestRuntimeStats%22].
> The test inserts a stat, sleeps for 2 seconds, inserts another stat, then
> deletes stats that are older than 1 second. The test asserts that exactly one
> stat is deleted. If the deletion is slow for some reason (perhaps a GC?) then
> 2 stats will be deleted and the test will fail. The trouble is that the 1
> second window is too small to work consistently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-19971) TestRuntimeStats.testCleanup() is flaky
[ https://issues.apache.org/jira/browse/HIVE-19971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16521227#comment-16521227 ] Peter Vary commented on HIVE-19971: --- +1 LGTM - Although I do not like arbitrary sleeps in tests, but this is good as a temporary fix for sure. > TestRuntimeStats.testCleanup() is flaky > --- > > Key: HIVE-19971 > URL: https://issues.apache.org/jira/browse/HIVE-19971 > Project: Hive > Issue Type: Task >Reporter: Andrew Sherman >Assignee: Andrew Sherman >Priority: Major > Attachments: HIVE-19971.1.patch > > > This test is timing dependent and sometimes fails. [You can see that it > sometimes fails in otherwise clean > runs|https://issues.apache.org/jira/issues/?jql=text%20~%20%22TestRuntimeStats%22]. > The test inserts a stat, sleeps for 2 seconds, inserts another stat, then > deletes stats that are older than 1 second. The test asserts that exactly one > stat is deleted. If the deletion is slow for some reason (perhaps a GC?) then > 2 stats will be deleted and the test will fail. The trouble is that the 1 > second window is too small to work consistently. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
