[jira] [Commented] (HIVE-20279) HiveContextAwareRecordReader slows down Druid Scan queries.
[
https://issues.apache.org/jira/browse/HIVE-20279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573274#comment-16573274
]
Hive QA commented on HIVE-20279:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12934802/HIVE-20279.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14868 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13100/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13100/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13100/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12934802 - PreCommit-HIVE-Build
> HiveContextAwareRecordReader slows down Druid Scan queries.
>
>
> Key: HIVE-20279
> URL: https://issues.apache.org/jira/browse/HIVE-20279
> Project: Hive
> Issue Type: Improvement
>Reporter: Nishant Bangarwa
>Assignee: Nishant Bangarwa
>Priority: Major
> Attachments: HIVE-20279.1.patch, HIVE-20279.2.patch,
> HIVE-20279.patch, scan2.svg
>
>
> HiveContextAwareRecordReader add lots of overhead for Druid Scan Queries.
> See attached flame graph.
> Looks like the operations for checking for existence of footer/header buffer
> takes most of time For druid and other storage handlers that do not have
> footer buffer we should skip the logic for checking the existence for storage
> handlers atleast.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20279) HiveContextAwareRecordReader slows down Druid Scan queries.
[
https://issues.apache.org/jira/browse/HIVE-20279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573147#comment-16573147
]
Hive QA commented on HIVE-20279:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
25s{color} | {color:blue} druid-handler in master has 13 extant Findbugs
warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
11s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 11m 14s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13100/dev-support/hive-personality.sh
|
| git revision | master / c0f63bf |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: druid-handler U: druid-handler |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13100/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> HiveContextAwareRecordReader slows down Druid Scan queries.
>
>
> Key: HIVE-20279
> URL: https://issues.apache.org/jira/browse/HIVE-20279
> Project: Hive
> Issue Type: Improvement
>Reporter: Nishant Bangarwa
>Assignee: Nishant Bangarwa
>Priority: Major
> Attachments: HIVE-20279.1.patch, HIVE-20279.2.patch,
> HIVE-20279.patch, scan2.svg
>
>
> HiveContextAwareRecordReader add lots of overhead for Druid Scan Queries.
> See attached flame graph.
> Looks like the operations for checking for existence of footer/header buffer
> takes most of time For druid and other storage handlers that do not have
> footer buffer we should skip the logic for checking the existence for storage
> handlers atleast.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20279) HiveContextAwareRecordReader slows down Druid Scan queries.
[ https://issues.apache.org/jira/browse/HIVE-20279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573091#comment-16573091 ] Nishant Bangarwa commented on HIVE-20279: - Thanks [~gopalv] [~ashutoshc] updated the patch to return -1 for druid record reader. > HiveContextAwareRecordReader slows down Druid Scan queries. > > > Key: HIVE-20279 > URL: https://issues.apache.org/jira/browse/HIVE-20279 > Project: Hive > Issue Type: Improvement >Reporter: Nishant Bangarwa >Assignee: Nishant Bangarwa >Priority: Major > Attachments: HIVE-20279.1.patch, HIVE-20279.2.patch, > HIVE-20279.patch, scan2.svg > > > HiveContextAwareRecordReader add lots of overhead for Druid Scan Queries. > See attached flame graph. > Looks like the operations for checking for existence of footer/header buffer > takes most of time For druid and other storage handlers that do not have > footer buffer we should skip the logic for checking the existence for storage > handlers atleast. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20279) HiveContextAwareRecordReader slows down Druid Scan queries.
[ https://issues.apache.org/jira/browse/HIVE-20279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572493#comment-16572493 ] Ashutosh Chauhan commented on HIVE-20279: - OK. [~nishantbangarwa] Suggestion is to make getPos() in DruidRecordReader to return -1; (instead of 0) so that we never get in this loop. > HiveContextAwareRecordReader slows down Druid Scan queries. > > > Key: HIVE-20279 > URL: https://issues.apache.org/jira/browse/HIVE-20279 > Project: Hive > Issue Type: Improvement >Reporter: Nishant Bangarwa >Assignee: Nishant Bangarwa >Priority: Major > Attachments: HIVE-20279.1.patch, HIVE-20279.patch, scan2.svg > > > HiveContextAwareRecordReader add lots of overhead for Druid Scan Queries. > See attached flame graph. > Looks like the operations for checking for existence of footer/header buffer > takes most of time For druid and other storage handlers that do not have > footer buffer we should skip the logic for checking the existence for storage > handlers atleast. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20279) HiveContextAwareRecordReader slows down Druid Scan queries.
[
https://issues.apache.org/jira/browse/HIVE-20279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572395#comment-16572395
]
Hive QA commented on HIVE-20279:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12934697/HIVE-20279.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14868 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13087/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13087/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13087/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12934697 - PreCommit-HIVE-Build
> HiveContextAwareRecordReader slows down Druid Scan queries.
>
>
> Key: HIVE-20279
> URL: https://issues.apache.org/jira/browse/HIVE-20279
> Project: Hive
> Issue Type: Improvement
>Reporter: Nishant Bangarwa
>Assignee: Nishant Bangarwa
>Priority: Major
> Attachments: HIVE-20279.1.patch, HIVE-20279.patch, scan2.svg
>
>
> HiveContextAwareRecordReader add lots of overhead for Druid Scan Queries.
> See attached flame graph.
> Looks like the operations for checking for existence of footer/header buffer
> takes most of time For druid and other storage handlers that do not have
> footer buffer we should skip the logic for checking the existence for storage
> handlers atleast.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20279) HiveContextAwareRecordReader slows down Druid Scan queries.
[
https://issues.apache.org/jira/browse/HIVE-20279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572349#comment-16572349
]
Hive QA commented on HIVE-20279:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
59s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
48s{color} | {color:blue} ql in master has 2305 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
1s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 22m 54s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13087/dev-support/hive-personality.sh
|
| git revision | master / c0f63bf |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13087/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> HiveContextAwareRecordReader slows down Druid Scan queries.
>
>
> Key: HIVE-20279
> URL: https://issues.apache.org/jira/browse/HIVE-20279
> Project: Hive
> Issue Type: Improvement
>Reporter: Nishant Bangarwa
>Assignee: Nishant Bangarwa
>Priority: Major
> Attachments: HIVE-20279.1.patch, HIVE-20279.patch, scan2.svg
>
>
> HiveContextAwareRecordReader add lots of overhead for Druid Scan Queries.
> See attached flame graph.
> Looks like the operations for checking for existence of footer/header buffer
> takes most of time For druid and other storage handlers that do not have
> footer buffer we should skip the logic for checking the existence for storage
> handlers atleast.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20279) HiveContextAwareRecordReader slows down Druid Scan queries.
[ https://issues.apache.org/jira/browse/HIVE-20279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572326#comment-16572326 ] Gopal V commented on HIVE-20279: No, headers are used for other binary sensor formats (footers only work for TextInputFormat). > HiveContextAwareRecordReader slows down Druid Scan queries. > > > Key: HIVE-20279 > URL: https://issues.apache.org/jira/browse/HIVE-20279 > Project: Hive > Issue Type: Improvement >Reporter: Nishant Bangarwa >Assignee: Nishant Bangarwa >Priority: Major > Attachments: HIVE-20279.1.patch, HIVE-20279.patch, scan2.svg > > > HiveContextAwareRecordReader add lots of overhead for Druid Scan Queries. > See attached flame graph. > Looks like the operations for checking for existence of footer/header buffer > takes most of time For druid and other storage handlers that do not have > footer buffer we should skip the logic for checking the existence for storage > handlers atleast. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20279) HiveContextAwareRecordReader slows down Druid Scan queries.
[ https://issues.apache.org/jira/browse/HIVE-20279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572295#comment-16572295 ] Ashutosh Chauhan commented on HIVE-20279: - Isnt header/footer only relevant for TextInputFormat ? > HiveContextAwareRecordReader slows down Druid Scan queries. > > > Key: HIVE-20279 > URL: https://issues.apache.org/jira/browse/HIVE-20279 > Project: Hive > Issue Type: Improvement >Reporter: Nishant Bangarwa >Assignee: Nishant Bangarwa >Priority: Major > Attachments: HIVE-20279.1.patch, HIVE-20279.patch, scan2.svg > > > HiveContextAwareRecordReader add lots of overhead for Druid Scan Queries. > See attached flame graph. > Looks like the operations for checking for existence of footer/header buffer > takes most of time For druid and other storage handlers that do not have > footer buffer we should skip the logic for checking the existence for storage > handlers atleast. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20279) HiveContextAwareRecordReader slows down Druid Scan queries.
[ https://issues.apache.org/jira/browse/HIVE-20279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572272#comment-16572272 ] Gopal V commented on HIVE-20279: [~ashutoshc]: this patch is probably too fragile - I chased this bug down to DruidQueryRecordReader not implementing ::getPos(). > HiveContextAwareRecordReader slows down Druid Scan queries. > > > Key: HIVE-20279 > URL: https://issues.apache.org/jira/browse/HIVE-20279 > Project: Hive > Issue Type: Improvement >Reporter: Nishant Bangarwa >Assignee: Nishant Bangarwa >Priority: Major > Attachments: HIVE-20279.1.patch, HIVE-20279.patch, scan2.svg > > > HiveContextAwareRecordReader add lots of overhead for Druid Scan Queries. > See attached flame graph. > Looks like the operations for checking for existence of footer/header buffer > takes most of time For druid and other storage handlers that do not have > footer buffer we should skip the logic for checking the existence for storage > handlers atleast. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20279) HiveContextAwareRecordReader slows down Druid Scan queries.
[ https://issues.apache.org/jira/browse/HIVE-20279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572239#comment-16572239 ] Ashutosh Chauhan commented on HIVE-20279: - +1 > HiveContextAwareRecordReader slows down Druid Scan queries. > > > Key: HIVE-20279 > URL: https://issues.apache.org/jira/browse/HIVE-20279 > Project: Hive > Issue Type: Improvement >Reporter: Nishant Bangarwa >Assignee: Nishant Bangarwa >Priority: Major > Attachments: HIVE-20279.1.patch, HIVE-20279.patch, scan2.svg > > > HiveContextAwareRecordReader add lots of overhead for Druid Scan Queries. > See attached flame graph. > Looks like the operations for checking for existence of footer/header buffer > takes most of time For druid and other storage handlers that do not have > footer buffer we should skip the logic for checking the existence for storage > handlers atleast. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20279) HiveContextAwareRecordReader slows down Druid Scan queries.
[ https://issues.apache.org/jira/browse/HIVE-20279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563948#comment-16563948 ] Gopal V commented on HIVE-20279: This is a good catch, also because it is easier to fix this via the block-offset (all handlers can be set to -1, after first entry into loop). > HiveContextAwareRecordReader slows down Druid Scan queries. > > > Key: HIVE-20279 > URL: https://issues.apache.org/jira/browse/HIVE-20279 > Project: Hive > Issue Type: Improvement >Reporter: Nishant Bangarwa >Assignee: Nishant Bangarwa >Priority: Major > Attachments: scan2.svg > > > HiveContextAwareRecordReader add lots of overhead for Druid Scan Queries. > See attached flame graph. > Looks like the operations for checking for existence of footer/header buffer > takes most of time For druid and other storage handlers that do not have > footer buffer we should skip the logic for checking the existence for storage > handlers atleast. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20279) HiveContextAwareRecordReader slows down Druid Scan queries.
[ https://issues.apache.org/jira/browse/HIVE-20279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563800#comment-16563800 ] Ashutosh Chauhan commented on HIVE-20279: - Footer and Header logic is only relevant for csv tables which may contain it. For storage handlers we can completely bypass it. > HiveContextAwareRecordReader slows down Druid Scan queries. > > > Key: HIVE-20279 > URL: https://issues.apache.org/jira/browse/HIVE-20279 > Project: Hive > Issue Type: Improvement >Reporter: Nishant Bangarwa >Assignee: Nishant Bangarwa >Priority: Major > Attachments: scan2.svg > > > HiveContextAwareRecordReader add lots of overhead for Druid Scan Queries. > See attached flame graph. > Looks like the operations for checking for existence of footer/header buffer > takes most of time For druid and other storage handlers that do not have > footer buffer we should skip the logic for checking the existence for storage > handlers atleast. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20279) HiveContextAwareRecordReader slows down Druid Scan queries.
[ https://issues.apache.org/jira/browse/HIVE-20279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563552#comment-16563552 ] Nishant Bangarwa commented on HIVE-20279: - +cc [~ashutoshc] Can you point to more details about the header/footer functionality. I don't think we need to check any of the checks for header/footer buffer for Druid - https://github.com/nishantmonu51/hive/blob/ba0217ff17501fb849d8999e808d37579db7b4f1/ql/src/java/org/apache/hadoop/hive/ql/io/HiveContextAwareRecordReader.java#L317 Can you please confirm ? > HiveContextAwareRecordReader slows down Druid Scan queries. > > > Key: HIVE-20279 > URL: https://issues.apache.org/jira/browse/HIVE-20279 > Project: Hive > Issue Type: Improvement >Reporter: Nishant Bangarwa >Assignee: Nishant Bangarwa >Priority: Major > Attachments: scan2.svg > > > HiveContextAwareRecordReader add lots of overhead for Druid Scan Queries. > See attached flame graph. > Looks like the operations for checking for existence of footer/header buffer > takes most of time For druid and other storage handlers that do not have > footer buffer we should skip the logic for checking the existence for storage > handlers atleast. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
