[jira] [Commented] (HIVE-20582) Make hflush in hive proto logging configurable
[ https://issues.apache.org/jira/browse/HIVE-20582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619667#comment-16619667 ] Prasanth Jayachandran commented on HIVE-20582: -- Committed to master and branch-3. > Make hflush in hive proto logging configurable > -- > > Key: HIVE-20582 > URL: https://issues.apache.org/jira/browse/HIVE-20582 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0, 3.2.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Fix For: 4.0.0, 3.2.0 > > Attachments: HIVE-20582.1.patch > > > Hive proto logging does hflush to avoid small files issue in hdfs. This may > not be ideal for blobstorage where hflush gets applied only on closing of the > file. Make hflush configurable so that blobstorage can do close instead of > hflush. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20582) Make hflush in hive proto logging configurable
[ https://issues.apache.org/jira/browse/HIVE-20582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619584#comment-16619584 ] Thejas M Nair commented on HIVE-20582: -- +1 > Make hflush in hive proto logging configurable > -- > > Key: HIVE-20582 > URL: https://issues.apache.org/jira/browse/HIVE-20582 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0, 3.2.0 >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-20582.1.patch > > > Hive proto logging does hflush to avoid small files issue in hdfs. This may > not be ideal for blobstorage where hflush gets applied only on closing of the > file. Make hflush configurable so that blobstorage can do close instead of > hflush. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20582) Make hflush in hive proto logging configurable
[
https://issues.apache.org/jira/browse/HIVE-20582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618860#comment-16618860
]
Hive QA commented on HIVE-20582:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12940060/HIVE-20582.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 14976 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/13878/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/13878/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-13878/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12940060 - PreCommit-HIVE-Build
> Make hflush in hive proto logging configurable
> --
>
> Key: HIVE-20582
> URL: https://issues.apache.org/jira/browse/HIVE-20582
> Project: Hive
> Issue Type: Bug
>Affects Versions: 4.0.0, 3.2.0
>Reporter: Prasanth Jayachandran
>Assignee: Prasanth Jayachandran
>Priority: Major
> Attachments: HIVE-20582.1.patch
>
>
> Hive proto logging does hflush to avoid small files issue in hdfs. This may
> not be ideal for blobstorage where hflush gets applied only on closing of the
> file. Make hflush configurable so that blobstorage can do close instead of
> hflush.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20582) Make hflush in hive proto logging configurable
[
https://issues.apache.org/jira/browse/HIVE-20582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618779#comment-16618779
]
Hive QA commented on HIVE-20582:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
42s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
35s{color} | {color:blue} common in master has 65 extant Findbugs warnings.
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
12s{color} | {color:blue} ql in master has 2326 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
13s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 48s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-13878/dev-support/hive-personality.sh
|
| git revision | master / 366eace |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: common ql U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-13878/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Make hflush in hive proto logging configurable
> --
>
> Key: HIVE-20582
> URL: https://issues.apache.org/jira/browse/HIVE-20582
> Project: Hive
> Issue Type: Bug
>Affects Versions: 4.0.0, 3.2.0
>Reporter: Prasanth Jayachandran
>Assignee: Prasanth Jayachandran
>Priority: Major
> Attachments: HIVE-20582.1.patch
>
>
> Hive proto logging does hflush to avoid small files issue in hdfs. This may
> not be ideal for blobstorage where hflush gets applied only on closing of the
> file. Make hflush configurable so that blobstorage can do close instead of
> hflush.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20582) Make hflush in hive proto logging configurable
[ https://issues.apache.org/jira/browse/HIVE-20582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618088#comment-16618088 ] Prasanth Jayachandran commented on HIVE-20582: -- [~thejas] can you please take a look? [~harishjp] already review this. > Make hflush in hive proto logging configurable > -- > > Key: HIVE-20582 > URL: https://issues.apache.org/jira/browse/HIVE-20582 > Project: Hive > Issue Type: New Feature >Affects Versions: 4.0.0, 3.2.0 > Environment: Hive proto logging does hflush to avoid small files > issue in hdfs. This may not be ideal for blobstorage where hflush gets > applied only on closing of the file. Make hflush configurable so that > blobstorage can do close instead of hflush. >Reporter: Prasanth Jayachandran >Assignee: Prasanth Jayachandran >Priority: Major > Attachments: HIVE-20582.1.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
