[jira] [Commented] (HIVE-21019) Fix autoColumnStats tests to make auto stats gather possible.
[ https://issues.apache.org/jira/browse/HIVE-21019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16715590#comment-16715590 ] Yongzhi Chen commented on HIVE-21019: - Sure, I can work on the test once you fix HIVE-16100. > Fix autoColumnStats tests to make auto stats gather possible. > - > > Key: HIVE-21019 > URL: https://issues.apache.org/jira/browse/HIVE-21019 > Project: Hive > Issue Type: Bug > Components: Test >Affects Versions: 4.0.0 >Reporter: Yongzhi Chen >Assignee: Yongzhi Chen >Priority: Major > Attachments: HIVE-21019.1.patch > > > Before https://issues.apache.org/jira/browse/HIVE-20915 , the optimizer sort > dynamic partitions is turn off for these tests. So these test can have group > by in the query plan which can trigger compute statistics. After the jira, > the optimizer is enabled, because of a a known bug with dynamic sorted > partition optimization (HIVE-16100), the computer statistics does not happen. > Fix the tests to disable the optimizer to test the same code path as before. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21019) Fix autoColumnStats tests to make auto stats gather possible.
[
https://issues.apache.org/jira/browse/HIVE-21019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713800#comment-16713800
]
Vineet Garg commented on HIVE-21019:
Hi [~ychena] These tests are testing {{stats auto gathering}} functionality on
"default configuration". since HIVE-20703 and HIVE-20915 have updated the
default configuration by enabling SDPO these tests should continue testing the
original functionality on that configuration.
{quote}as long as you can add more test when fix HIVE-16100 to test both case
(the optimization is on or off).
{quote}
I closed this JIRA since you were updating existing tests. If you would like to
add tests for auto gather statistics for both cases feel free to reopen the
JIRA and add new tests (without disabling the optimization for existing ones).
> Fix autoColumnStats tests to make auto stats gather possible.
> -
>
> Key: HIVE-21019
> URL: https://issues.apache.org/jira/browse/HIVE-21019
> Project: Hive
> Issue Type: Bug
> Components: Test
>Affects Versions: 4.0.0
>Reporter: Yongzhi Chen
>Assignee: Yongzhi Chen
>Priority: Major
> Attachments: HIVE-21019.1.patch
>
>
> Before https://issues.apache.org/jira/browse/HIVE-20915 , the optimizer sort
> dynamic partitions is turn off for these tests. So these test can have group
> by in the query plan which can trigger compute statistics. After the jira,
> the optimizer is enabled, because of a a known bug with dynamic sorted
> partition optimization (HIVE-16100), the computer statistics does not happen.
> Fix the tests to disable the optimizer to test the same code path as before.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21019) Fix autoColumnStats tests to make auto stats gather possible.
[ https://issues.apache.org/jira/browse/HIVE-21019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713796#comment-16713796 ] Yongzhi Chen commented on HIVE-21019: - [~vgarg], turn off because the test is always tested the case when the optimization is off before, just recent changes of https://issues.apache.org/jira/browse/HIVE-20703 . makes the optimization can be turn on in default setup. Turn off it explicitly just do not want to lose the test scenario. You can add more test when fix HIVE-16100 to test the case when the optimization is on. > Fix autoColumnStats tests to make auto stats gather possible. > - > > Key: HIVE-21019 > URL: https://issues.apache.org/jira/browse/HIVE-21019 > Project: Hive > Issue Type: Bug > Components: Test >Affects Versions: 4.0.0 >Reporter: Yongzhi Chen >Assignee: Yongzhi Chen >Priority: Major > Attachments: HIVE-21019.1.patch > > > Before https://issues.apache.org/jira/browse/HIVE-20915 , the optimizer sort > dynamic partitions is turn off for these tests. So these test can have group > by in the query plan which can trigger compute statistics. After the jira, > the optimizer is enabled, because of a a known bug with dynamic sorted > partition optimization (HIVE-16100), the computer statistics does not happen. > Fix the tests to disable the optimizer to test the same code path as before. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21019) Fix autoColumnStats tests to make auto stats gather possible.
[ https://issues.apache.org/jira/browse/HIVE-21019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16713414#comment-16713414 ] Vineet Garg commented on HIVE-21019: [~ychena] I don't think it is not a good idea to turn off the optimization in tests. We should fix the underlying issue. I am closing this and marking it as duplicate of HIVE-16100 since that fixes the problem. > Fix autoColumnStats tests to make auto stats gather possible. > - > > Key: HIVE-21019 > URL: https://issues.apache.org/jira/browse/HIVE-21019 > Project: Hive > Issue Type: Bug > Components: Test >Affects Versions: 4.0.0 >Reporter: Yongzhi Chen >Assignee: Yongzhi Chen >Priority: Major > Attachments: HIVE-21019.1.patch > > > Before https://issues.apache.org/jira/browse/HIVE-20915 , the optimizer sort > dynamic partitions is turn off for these tests. So these test can have group > by in the query plan which can trigger compute statistics. After the jira, > the optimizer is enabled, because of a a known bug with dynamic sorted > partition optimization (HIVE-16100), the computer statistics does not happen. > Fix the tests to disable the optimizer to test the same code path as before. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
