[jira] [Commented] (HIVE-21303) Update TextRecordReader
[
https://issues.apache.org/jira/browse/HIVE-21303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957496#comment-16957496
]
Hive QA commented on HIVE-21303:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983743/HIVE-21303.3.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 24 failed/errored test(s), 17545 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby_bigdata]
(batchId=129)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[input14]
(batchId=149)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[input17]
(batchId=130)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[input18]
(batchId=121)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[insert_into1]
(batchId=123)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[insert_into2]
(batchId=154)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[insert_into3]
(batchId=125)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapreduce1]
(batchId=144)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapreduce2]
(batchId=124)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_transform]
(batchId=148)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[rcfile_bigdata]
(batchId=123)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[script_env_var1]
(batchId=115)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[script_env_var2]
(batchId=140)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[script_pipe]
(batchId=147)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[scriptfile1]
(batchId=151)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform1]
(batchId=130)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform2]
(batchId=131)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform_ppr1]
(batchId=119)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform_ppr2]
(batchId=133)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union23]
(batchId=114)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union_script]
(batchId=144)
org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.testCliDriver[spark_job_max_tasks]
(batchId=301)
org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.testCliDriver[spark_stage_max_tasks]
(batchId=301)
org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.testCliDriver[spark_task_failure]
(batchId=301)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19115/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19115/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19115/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 24 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12983743 - PreCommit-HIVE-Build
> Update TextRecordReader
> ---
>
> Key: HIVE-21303
> URL: https://issues.apache.org/jira/browse/HIVE-21303
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
>Affects Versions: 4.0.0, 3.2.0
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-21303.1.patch, HIVE-21303.2.patch,
> HIVE-21303.3.patch
>
>
> Remove use of Deprecated
> {{org.apache.hadoop.mapred.LineRecordReader.LineReader}}
> For every call to {{next}}, the code dives into the configuration map to see
> if this feature is enabled. Just look it up once and cache the value.
> {code:java}
> public int next(Writable row) throws IOException {
> ...
> if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVESCRIPTESCAPE)) {
> return HiveUtils.unescapeText((Text) row);
> }
> return bytesConsumed;
> }
> {code}
> Other clean up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-21303) Update TextRecordReader
[
https://issues.apache.org/jira/browse/HIVE-21303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957483#comment-16957483
]
Hive QA commented on HIVE-21303:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
35s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
52s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
4s{color} | {color:blue} ql in master has 1545 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
32s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 27m 35s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc xml compile findbugs
checkstyle |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19115/dev-support/hive-personality.sh
|
| git revision | master / f1e59e9 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql itests itests/qtest-spark U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19115/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Update TextRecordReader
> ---
>
> Key: HIVE-21303
> URL: https://issues.apache.org/jira/browse/HIVE-21303
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
>Affects Versions: 4.0.0, 3.2.0
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-21303.1.patch, HIVE-21303.2.patch,
> HIVE-21303.3.patch
>
>
> Remove use of Deprecated
> {{org.apache.hadoop.mapred.LineRecordReader.LineReader}}
> For every call to {{next}}, the code dives into the configuration map to see
> if this feature is enabled. Just look it up once and cache the value.
> {code:java}
> public int next(Writable row) throws IOException {
> ...
> if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVESCRIPTESCAPE)) {
> return HiveUtils.unescapeText((Text) row);
> }
> return bytesConsumed;
> }
> {code}
> Other clean up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-21303) Update TextRecordReader
[
https://issues.apache.org/jira/browse/HIVE-21303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956677#comment-16956677
]
Hive QA commented on HIVE-21303:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983670/HIVE-21303.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 24 failed/errored test(s), 17545 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby_bigdata]
(batchId=129)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[input14]
(batchId=149)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[input17]
(batchId=130)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[input18]
(batchId=121)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[insert_into1]
(batchId=123)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[insert_into2]
(batchId=154)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[insert_into3]
(batchId=125)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapreduce1]
(batchId=144)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapreduce2]
(batchId=124)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_transform]
(batchId=148)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[rcfile_bigdata]
(batchId=123)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[script_env_var1]
(batchId=115)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[script_env_var2]
(batchId=140)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[script_pipe]
(batchId=147)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[scriptfile1]
(batchId=151)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform1]
(batchId=130)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform2]
(batchId=131)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform_ppr1]
(batchId=119)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform_ppr2]
(batchId=133)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union23]
(batchId=114)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union_script]
(batchId=144)
org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.testCliDriver[spark_job_max_tasks]
(batchId=301)
org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.testCliDriver[spark_stage_max_tasks]
(batchId=301)
org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.testCliDriver[spark_task_failure]
(batchId=301)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19098/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19098/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19098/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 24 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12983670 - PreCommit-HIVE-Build
> Update TextRecordReader
> ---
>
> Key: HIVE-21303
> URL: https://issues.apache.org/jira/browse/HIVE-21303
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
>Affects Versions: 4.0.0, 3.2.0
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-21303.1.patch, HIVE-21303.2.patch,
> HIVE-21303.2.patch
>
>
> Remove use of Deprecated
> {{org.apache.hadoop.mapred.LineRecordReader.LineReader}}
> For every call to {{next}}, the code dives into the configuration map to see
> if this feature is enabled. Just look it up once and cache the value.
> {code:java}
> public int next(Writable row) throws IOException {
> ...
> if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVESCRIPTESCAPE)) {
> return HiveUtils.unescapeText((Text) row);
> }
> return bytesConsumed;
> }
> {code}
> Other clean up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-21303) Update TextRecordReader
[
https://issues.apache.org/jira/browse/HIVE-21303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956651#comment-16956651
]
Hive QA commented on HIVE-21303:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
1s{color} | {color:blue} ql in master has 1545 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 34s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19098/dev-support/hive-personality.sh
|
| git revision | master / 40cd40d |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19098/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Update TextRecordReader
> ---
>
> Key: HIVE-21303
> URL: https://issues.apache.org/jira/browse/HIVE-21303
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
>Affects Versions: 4.0.0, 3.2.0
>Reporter: David Mollitor
>Assignee: David Mollitor
>Priority: Major
> Attachments: HIVE-21303.1.patch, HIVE-21303.2.patch,
> HIVE-21303.2.patch
>
>
> Remove use of Deprecated
> {{org.apache.hadoop.mapred.LineRecordReader.LineReader}}
> For every call to {{next}}, the code dives into the configuration map to see
> if this feature is enabled. Just look it up once and cache the value.
> {code:java}
> public int next(Writable row) throws IOException {
> ...
> if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVESCRIPTESCAPE)) {
> return HiveUtils.unescapeText((Text) row);
> }
> return bytesConsumed;
> }
> {code}
> Other clean up.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-21303) Update TextRecordReader
[
https://issues.apache.org/jira/browse/HIVE-21303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777103#comment-16777103
]
Hive QA commented on HIVE-21303:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12960038/HIVE-21303.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 24 failed/errored test(s), 15811 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[groupby_bigdata]
(batchId=127)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[input14]
(batchId=147)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[input17]
(batchId=128)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[input18]
(batchId=119)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[insert_into1]
(batchId=121)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[insert_into2]
(batchId=152)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[insert_into3]
(batchId=123)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapreduce1]
(batchId=142)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[mapreduce2]
(batchId=122)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_transform]
(batchId=146)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[rcfile_bigdata]
(batchId=121)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[script_env_var1]
(batchId=113)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[script_env_var2]
(batchId=138)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[script_pipe]
(batchId=145)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[scriptfile1]
(batchId=149)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform1]
(batchId=128)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform2]
(batchId=129)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform_ppr1]
(batchId=117)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[transform_ppr2]
(batchId=131)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union23]
(batchId=112)
org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[union_script]
(batchId=142)
org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.testCliDriver[spark_job_max_tasks]
(batchId=277)
org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.testCliDriver[spark_stage_max_tasks]
(batchId=277)
org.apache.hadoop.hive.cli.TestSparkNegativeCliDriver.testCliDriver[spark_task_failure]
(batchId=277)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/16236/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16236/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16236/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 24 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12960038 - PreCommit-HIVE-Build
> Update TextRecordReader
> ---
>
> Key: HIVE-21303
> URL: https://issues.apache.org/jira/browse/HIVE-21303
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
>Affects Versions: 4.0.0, 3.2.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Major
> Attachments: HIVE-21303.1.patch, HIVE-21303.2.patch
>
>
> Remove use of Deprecated
> {{org.apache.hadoop.mapred.LineRecordReader.LineReader}}
> For every call to {{next}}, the code dives into the configuration map to see
> if this feature is enabled. Just look it up once and cache the value.
> {code:java}
> public int next(Writable row) throws IOException {
> ...
> if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVESCRIPTESCAPE)) {
> return HiveUtils.unescapeText((Text) row);
> }
> return bytesConsumed;
> }
> {code}
> Other clean up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21303) Update TextRecordReader
[
https://issues.apache.org/jira/browse/HIVE-21303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777067#comment-16777067
]
Hive QA commented on HIVE-21303:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
37s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
10s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
10s{color} | {color:blue} ql in master has 2261 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 9s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16236/dev-support/hive-personality.sh
|
| git revision | master / 2daaed7 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16236/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Update TextRecordReader
> ---
>
> Key: HIVE-21303
> URL: https://issues.apache.org/jira/browse/HIVE-21303
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
>Affects Versions: 4.0.0, 3.2.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Major
> Attachments: HIVE-21303.1.patch, HIVE-21303.2.patch
>
>
> Remove use of Deprecated
> {{org.apache.hadoop.mapred.LineRecordReader.LineReader}}
> For every call to {{next}}, the code dives into the configuration map to see
> if this feature is enabled. Just look it up once and cache the value.
> {code:java}
> public int next(Writable row) throws IOException {
> ...
> if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVESCRIPTESCAPE)) {
> return HiveUtils.unescapeText((Text) row);
> }
> return bytesConsumed;
> }
> {code}
> Other clean up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21303) Update TextRecordReader
[
https://issues.apache.org/jira/browse/HIVE-21303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776641#comment-16776641
]
Peter Vary commented on HIVE-21303:
---
+1
> Update TextRecordReader
> ---
>
> Key: HIVE-21303
> URL: https://issues.apache.org/jira/browse/HIVE-21303
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
>Affects Versions: 4.0.0, 3.2.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Major
> Attachments: HIVE-21303.1.patch
>
>
> Remove use of Deprecated
> {{org.apache.hadoop.mapred.LineRecordReader.LineReader}}
> For every call to {{next}}, the code dives into the configuration map to see
> if this feature is enabled. Just look it up once and cache the value.
> {code:java}
> public int next(Writable row) throws IOException {
> ...
> if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVESCRIPTESCAPE)) {
> return HiveUtils.unescapeText((Text) row);
> }
> return bytesConsumed;
> }
> {code}
> Other clean up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21303) Update TextRecordReader
[
https://issues.apache.org/jira/browse/HIVE-21303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775944#comment-16775944
]
BELUGA BEHR commented on HIVE-21303:
[~pvary] [~ngangam] :)
> Update TextRecordReader
> ---
>
> Key: HIVE-21303
> URL: https://issues.apache.org/jira/browse/HIVE-21303
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
>Affects Versions: 4.0.0, 3.2.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Major
> Attachments: HIVE-21303.1.patch
>
>
> Remove use of Deprecated
> {{org.apache.hadoop.mapred.LineRecordReader.LineReader}}
> For every call to {{next}}, the code dives into the configuration map to see
> if this feature is enabled. Just look it up once and cache the value.
> {code:java}
> public int next(Writable row) throws IOException {
> ...
> if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVESCRIPTESCAPE)) {
> return HiveUtils.unescapeText((Text) row);
> }
> return bytesConsumed;
> }
> {code}
> Other clean up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21303) Update TextRecordReader
[
https://issues.apache.org/jira/browse/HIVE-21303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774774#comment-16774774
]
Hive QA commented on HIVE-21303:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12959705/HIVE-21303.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 15810 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/16194/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16194/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16194/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12959705 - PreCommit-HIVE-Build
> Update TextRecordReader
> ---
>
> Key: HIVE-21303
> URL: https://issues.apache.org/jira/browse/HIVE-21303
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
>Affects Versions: 4.0.0, 3.2.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Major
> Attachments: HIVE-21303.1.patch, HIVE-21303.1.patch
>
>
> Remove use of Deprecated
> {{org.apache.hadoop.mapred.LineRecordReader.LineReader}}
> For every call to {{next}}, the code dives into the configuration map to see
> if this feature is enabled. Just look it up once and cache the value.
> {code:java}
> public int next(Writable row) throws IOException {
> ...
> if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVESCRIPTESCAPE)) {
> return HiveUtils.unescapeText((Text) row);
> }
> return bytesConsumed;
> }
> {code}
> Other clean up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21303) Update TextRecordReader
[
https://issues.apache.org/jira/browse/HIVE-21303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774758#comment-16774758
]
Hive QA commented on HIVE-21303:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
5s{color} | {color:blue} ql in master has 2261 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 31s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16194/dev-support/hive-personality.sh
|
| git revision | master / c45751f |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16194/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Update TextRecordReader
> ---
>
> Key: HIVE-21303
> URL: https://issues.apache.org/jira/browse/HIVE-21303
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
>Affects Versions: 4.0.0, 3.2.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Major
> Attachments: HIVE-21303.1.patch, HIVE-21303.1.patch
>
>
> Remove use of Deprecated
> {{org.apache.hadoop.mapred.LineRecordReader.LineReader}}
> For every call to {{next}}, the code dives into the configuration map to see
> if this feature is enabled. Just look it up once and cache the value.
> {code:java}
> public int next(Writable row) throws IOException {
> ...
> if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVESCRIPTESCAPE)) {
> return HiveUtils.unescapeText((Text) row);
> }
> return bytesConsumed;
> }
> {code}
> Other clean up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21303) Update TextRecordReader
[
https://issues.apache.org/jira/browse/HIVE-21303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774644#comment-16774644
]
Hive QA commented on HIVE-21303:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12959666/HIVE-21303.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15780 tests
executed
*Failed tests:*
{noformat}
TestMiniLlapLocalCliDriver - did not produce a TEST-*.xml file (likely timed
out) (batchId=171)
[authorization_view_8.q,load_dyn_part5.q,vector_groupby_grouping_sets5.q,vector_complex_join.q,orc_llap.q,vectorization_7.q,cbo_gby.q,bucket_num_reducers_acid2.q,auto_sortmerge_join_1.q,results_cache_empty_result.q,lineage3.q,materialized_view_rewrite_empty.q,q93_with_constraints.q,vector_struct_in.q,bucketmapjoin3.q,vectorization_16.q,current_date_timestamp.q,orc_ppd_schema_evol_2a.q,partition_ctas.q,vector_windowing_multipartitioning.q,vectorized_join46.q,orc_ppd_date.q,create_merge_compressed.q,vector_outer_join1.q,dynpart_sort_optimization_acid.q,vectorization_not.q,having.q,vectorization_input_format_excludes.q,leftsemijoin.q,special_character_in_tabnames_1.q]
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/16191/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16191/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16191/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12959666 - PreCommit-HIVE-Build
> Update TextRecordReader
> ---
>
> Key: HIVE-21303
> URL: https://issues.apache.org/jira/browse/HIVE-21303
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
>Affects Versions: 4.0.0, 3.2.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Major
> Attachments: HIVE-21303.1.patch
>
>
> Remove use of Deprecated
> {{org.apache.hadoop.mapred.LineRecordReader.LineReader}}
> For every call to {{next}}, the code dives into the configuration map to see
> if this feature is enabled. Just look it up once and cache the value.
> {code:java}
> public int next(Writable row) throws IOException {
> ...
> if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVESCRIPTESCAPE)) {
> return HiveUtils.unescapeText((Text) row);
> }
> return bytesConsumed;
> }
> {code}
> Other clean up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-21303) Update TextRecordReader
[
https://issues.apache.org/jira/browse/HIVE-21303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774623#comment-16774623
]
Hive QA commented on HIVE-21303:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
0s{color} | {color:blue} ql in master has 2260 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 51s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16191/dev-support/hive-personality.sh
|
| git revision | master / e71b096 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-16191/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Update TextRecordReader
> ---
>
> Key: HIVE-21303
> URL: https://issues.apache.org/jira/browse/HIVE-21303
> Project: Hive
> Issue Type: Improvement
> Components: Query Processor
>Affects Versions: 4.0.0, 3.2.0
>Reporter: BELUGA BEHR
>Assignee: BELUGA BEHR
>Priority: Major
> Attachments: HIVE-21303.1.patch
>
>
> Remove use of Deprecated
> {{org.apache.hadoop.mapred.LineRecordReader.LineReader}}
> For every call to {{next}}, the code dives into the configuration map to see
> if this feature is enabled. Just look it up once and cache the value.
> {code:java}
> public int next(Writable row) throws IOException {
> ...
> if (HiveConf.getBoolVar(conf, HiveConf.ConfVars.HIVESCRIPTESCAPE)) {
> return HiveUtils.unescapeText((Text) row);
> }
> return bytesConsumed;
> }
> {code}
> Other clean up.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
