[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779456#comment-16779456 ] Hive QA commented on HIVE-21320: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12960361/HIVE-21320.010.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15820 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16270/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16270/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16270/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12960361 - PreCommit-HIVE-Build > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch, HIVE-21320.005.patch, > HIVE-21320.005.patch, HIVE-21320.006.patch, HIVE-21320.007.patch, > HIVE-21320.008.patch, HIVE-21320.008.patch, HIVE-21320.009.patch, > HIVE-21320.010.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779416#comment-16779416 ] Hive QA commented on HIVE-21320: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 34s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 23s{color} | {color:blue} standalone-metastore/metastore-server in master has 179 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 23s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 23s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 16m 30s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16270/dev-support/hive-personality.sh | | git revision | master / 66533e2 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16270/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch, HIVE-21320.005.patch, > HIVE-21320.005.patch, HIVE-21320.006.patch, HIVE-21320.007.patch, > HIVE-21320.008.patch, HIVE-21320.008.patch, HIVE-21320.009.patch, > HIVE-21320.010.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779290#comment-16779290 ] Na Li commented on HIVE-21320: -- I cannot reproduce the test failure with patch 9. Patch 10 is rebased on https://github.com/apache/hive/commit/66533e2c4ed3f00f4795c1ffa9bed4c1a7aa6bf6 > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch, HIVE-21320.005.patch, > HIVE-21320.005.patch, HIVE-21320.006.patch, HIVE-21320.007.patch, > HIVE-21320.008.patch, HIVE-21320.008.patch, HIVE-21320.009.patch, > HIVE-21320.010.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779177#comment-16779177 ] Hive QA commented on HIVE-21320: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12960309/HIVE-21320.009.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16266/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16266/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16266/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12960309/HIVE-21320.009.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12960309 - PreCommit-HIVE-Build > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch, HIVE-21320.005.patch, > HIVE-21320.005.patch, HIVE-21320.006.patch, HIVE-21320.007.patch, > HIVE-21320.008.patch, HIVE-21320.008.patch, HIVE-21320.009.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779045#comment-16779045 ] Hive QA commented on HIVE-21320: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12960309/HIVE-21320.009.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 49 failed/errored test(s), 15820 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.metastore.client.TestGetPartitions.getPartitionBogusCatalog[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.getPartitionByNameBogusCatalog[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.getPartitionWithAuthBogusCatalog[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.getPartitionsByNamesBogusCatalog[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.otherCatalog[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesEmptyPartVals[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesNoDbName[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesNoDb[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesNoTable[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesNoTblName[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesNullDbName[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesNullTblName[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesNullValues[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesWrongNumOfPartVals[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValuesWrongPart[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionByValues[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionCaseSensitive[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionEmptyPartName[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionIncompletePartName[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNoDbName[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNoDb[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNoTable[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNoTblName[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNonexistingPart[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNullDbName[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNullPartName[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionNullTblName[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoEmptyUserGroup[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNoDbName[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNoPrivilagesSet[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNoSuchPart[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNoTblName[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNullDbName[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNullGroups[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNullTblName[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNullUser[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoNullValues[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfoWrongNumOfPartVals[Remote] (batchId=222) org.apache.hadoop.hive.metastore.client.TestGetPartitions.testGetPartitionWithAuthInfo[Remote] (
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16779025#comment-16779025 ] Hive QA commented on HIVE-21320: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 40s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 28s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 15s{color} | {color:blue} standalone-metastore/metastore-server in master has 181 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 14m 36s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16263/dev-support/hive-personality.sh | | git revision | master / 77b9c3c | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16263/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch, HIVE-21320.005.patch, > HIVE-21320.005.patch, HIVE-21320.006.patch, HIVE-21320.007.patch, > HIVE-21320.008.patch, HIVE-21320.008.patch, HIVE-21320.009.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778977#comment-16778977 ] Na Li commented on HIVE-21320: -- patch 9 is rebased on latest code at https://github.com/apache/hive/commit/77b9c3c79953121c19554a7de6953a6e21de9db6 The failed tests are likely caused by daijy 's commit at https://github.com/apache/hive/commit/3e9614eebd19f9843b28d97aaee1c3dfb815fb3d, which is reverted now. > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch, HIVE-21320.005.patch, > HIVE-21320.005.patch, HIVE-21320.006.patch, HIVE-21320.007.patch, > HIVE-21320.008.patch, HIVE-21320.008.patch, HIVE-21320.009.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778887#comment-16778887 ] Hive QA commented on HIVE-21320: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12960274/HIVE-21320.008.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 14 failed/errored test(s), 15820 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.metastore.TestObjectStore.catalogs (batchId=230) org.apache.hadoop.hive.metastore.TestObjectStore.testDatabaseOps (batchId=230) org.apache.hadoop.hive.metastore.TestObjectStore.testDeprecatedConfigIsOverwritten (batchId=230) org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSQLDropParitionsCleanup (batchId=230) org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSQLDropPartitionsCacheCrossSession (batchId=230) org.apache.hadoop.hive.metastore.TestObjectStore.testDirectSqlErrorMetrics (batchId=230) org.apache.hadoop.hive.metastore.TestObjectStore.testEmptyTrustStoreProps (batchId=230) org.apache.hadoop.hive.metastore.TestObjectStore.testMasterKeyOps (batchId=230) org.apache.hadoop.hive.metastore.TestObjectStore.testMaxEventResponse (batchId=230) org.apache.hadoop.hive.metastore.TestObjectStore.testPartitionOps (batchId=230) org.apache.hadoop.hive.metastore.TestObjectStore.testQueryCloseOnError (batchId=230) org.apache.hadoop.hive.metastore.TestObjectStore.testRoleOps (batchId=230) org.apache.hadoop.hive.metastore.TestObjectStore.testTableOps (batchId=230) org.apache.hadoop.hive.metastore.TestObjectStore.testUseSSLProperty (batchId=230) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16260/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16260/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16260/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 14 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12960274 - PreCommit-HIVE-Build > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch, HIVE-21320.005.patch, > HIVE-21320.005.patch, HIVE-21320.006.patch, HIVE-21320.007.patch, > HIVE-21320.008.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778862#comment-16778862 ] Hive QA commented on HIVE-21320: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 21s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 6s{color} | {color:blue} standalone-metastore/metastore-server in master has 181 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 14m 17s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16260/dev-support/hive-personality.sh | | git revision | master / 77b9c3c | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16260/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch, HIVE-21320.005.patch, > HIVE-21320.005.patch, HIVE-21320.006.patch, HIVE-21320.007.patch, > HIVE-21320.008.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778809#comment-16778809 ] Na Li commented on HIVE-21320: -- [~pvary] Patch 6 did not trigger test. Patch 7 is the same as patch 6. Its tests failed because it was not rebased on latest code. Patch 8 is uploaded now. The difference between patch 6 and patch 8 + Patch 8 is rebased on lated code + Patch 8 fixed style issues of Patch 6 and 7 > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch, HIVE-21320.005.patch, > HIVE-21320.005.patch, HIVE-21320.006.patch, HIVE-21320.007.patch, > HIVE-21320.008.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778799#comment-16778799 ] Hive QA commented on HIVE-21320: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12960246/HIVE-21320.007.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 15820 tests executed *Failed tests:* {noformat} org.apache.hive.hcatalog.templeton.TestWebHCatE2e.getHadoopVersion (batchId=205) org.apache.hive.hcatalog.templeton.TestWebHCatE2e.getHiveVersion (batchId=205) org.apache.hive.hcatalog.templeton.TestWebHCatE2e.getPigVersion (batchId=205) org.apache.hive.hcatalog.templeton.TestWebHCatE2e.getStatus (batchId=205) org.apache.hive.hcatalog.templeton.TestWebHCatE2e.invalidPath (batchId=205) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16258/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16258/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16258/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 5 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12960246 - PreCommit-HIVE-Build > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch, HIVE-21320.005.patch, > HIVE-21320.005.patch, HIVE-21320.006.patch, HIVE-21320.007.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16778773#comment-16778773 ] Hive QA commented on HIVE-21320: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 22s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 14s{color} | {color:blue} standalone-metastore/metastore-server in master has 181 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 22s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 5 new + 413 unchanged - 0 fixed = 418 total (was 413) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 19s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 14m 54s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16258/dev-support/hive-personality.sh | | git revision | master / 3e9614e | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-16258/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16258/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch, HIVE-21320.005.patch, > HIVE-21320.005.patch, HIVE-21320.006.patch, HIVE-21320.007.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777912#comment-16777912 ] Peter Vary commented on HIVE-21320: --- +1 for patch 06, pending tests - please check the checkstyle errors too.. Thanks, Peter > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch, HIVE-21320.005.patch, > HIVE-21320.005.patch, HIVE-21320.006.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777388#comment-16777388 ] Hive QA commented on HIVE-21320: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12960081/HIVE-21320.005.patch {color:green}SUCCESS:{color} +1 due to 10 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15812 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16240/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16240/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16240/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12960081 - PreCommit-HIVE-Build > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch, HIVE-21320.005.patch, > HIVE-21320.006.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777331#comment-16777331 ] Hive QA commented on HIVE-21320: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 7s{color} | {color:red} /data/hiveptest/logs/PreCommit-HIVE-Build-16240/patches/PreCommit-HIVE-Build-16240.patch does not apply to master. Rebase required? Wrong Branch? See http://cwiki.apache.org/confluence/display/Hive/HowToContribute for help. {color} | \\ \\ || Subsystem || Report/Notes || | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16240/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch, HIVE-21320.005.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777290#comment-16777290 ] Hive QA commented on HIVE-21320: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12960066/HIVE-21320.001.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15812 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/16239/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16239/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16239/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12960066 - PreCommit-HIVE-Build > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21320) get_fields() and get_tables_by_type() are not protected by HMS server access control
[ https://issues.apache.org/jira/browse/HIVE-21320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16777265#comment-16777265 ] Hive QA commented on HIVE-21320: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 29s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 22s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 1m 12s{color} | {color:blue} standalone-metastore/metastore-server in master has 181 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 26s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 23s{color} | {color:red} standalone-metastore/metastore-server: The patch generated 25 new + 413 unchanged - 0 fixed = 438 total (was 413) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 19s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 21s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 15s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 15m 10s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-16239/dev-support/hive-personality.sh | | git revision | master / 2daaed7 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-16239/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt | | modules | C: standalone-metastore/metastore-server U: standalone-metastore/metastore-server | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-16239/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > get_fields() and get_tables_by_type() are not protected by HMS server access > control > > > Key: HIVE-21320 > URL: https://issues.apache.org/jira/browse/HIVE-21320 > Project: Hive > Issue Type: Bug >Affects Versions: 4.0.0 >Reporter: Na Li >Assignee: Na Li >Priority: Major > Attachments: HIVE-21320.001.patch > > > User without any privilege can call these functions and get all meta data > back as if user has full access privilege. -- This message was sent by Atlassian JIRA (v7.6.3#76005)