[jira] [Commented] (HIVE-21457) Perf optimizations in ORC split-generation

2019-03-28 Thread Gopal V (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804278#comment-16804278
 ] 

Gopal V commented on HIVE-21457:


LGTM - +1 

FYI [~vgumashta]

> Perf optimizations in ORC split-generation
> --
>
> Key: HIVE-21457
> URL: https://issues.apache.org/jira/browse/HIVE-21457
> Project: Hive
>  Issue Type: Improvement
>  Components: Transactions
>Affects Versions: 4.0.0
>Reporter: Prasanth Jayachandran
>Assignee: Prasanth Jayachandran
>Priority: Minor
> Attachments: HIVE-21457.1.patch
>
>
> Minor split generation optimizations
>  * Reuse vectorization checks
>  * Reuse isAcid checks
>  * Reuse filesystem objects
>  * Improved logging (log at top-level instead of inside the thread pool)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21457) Perf optimizations in ORC split-generation

2019-03-15 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794111#comment-16794111
 ] 

Hive QA commented on HIVE-21457:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12962675/HIVE-21457.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 15833 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/16537/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/16537/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-16537/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12962675 - PreCommit-HIVE-Build

> Perf optimizations in ORC split-generation
> --
>
> Key: HIVE-21457
> URL: https://issues.apache.org/jira/browse/HIVE-21457
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Prasanth Jayachandran
>Assignee: Prasanth Jayachandran
>Priority: Minor
> Attachments: HIVE-21457.1.patch
>
>
> Minor split generation optimizations
>  * Reuse vectorization checks
>  * Reuse isAcid checks
>  * Reuse filesystem objects
>  * Improved logging (log at top-level instead of inside the thread pool)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21457) Perf optimizations in ORC split-generation

2019-03-15 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794102#comment-16794102
 ] 

Hive QA commented on HIVE-21457:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
31s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
46s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 
14s{color} | {color:blue} ql in master has 2257 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
45s{color} | {color:red} ql: The patch generated 18 new + 505 unchanged - 4 
fixed = 523 total (was 509) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
1s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 23s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-16537/dev-support/hive-personality.sh
 |
| git revision | master / 6a33d26 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-16537/yetus/diff-checkstyle-ql.txt
 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-16537/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Perf optimizations in ORC split-generation
> --
>
> Key: HIVE-21457
> URL: https://issues.apache.org/jira/browse/HIVE-21457
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Prasanth Jayachandran
>Assignee: Prasanth Jayachandran
>Priority: Minor
> Attachments: HIVE-21457.1.patch
>
>
> Minor split generation optimizations
>  * Reuse vectorization checks
>  * Reuse isAcid checks
>  * Reuse filesystem objects
>  * Improved logging (log at top-level instead of inside the thread pool)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21457) Perf optimizations in ORC split-generation

2019-03-15 Thread Prasanth Jayachandran (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16794057#comment-16794057
 ] 

Prasanth Jayachandran commented on HIVE-21457:
--

[~gopalv] can you please take a look?

> Perf optimizations in ORC split-generation
> --
>
> Key: HIVE-21457
> URL: https://issues.apache.org/jira/browse/HIVE-21457
> Project: Hive
>  Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Prasanth Jayachandran
>Assignee: Prasanth Jayachandran
>Priority: Minor
> Attachments: HIVE-21457.1.patch
>
>
> Minor split generation optimizations
>  * Reuse vectorization checks
>  * Reuse isAcid checks
>  * Reuse filesystem objects
>  * Improved logging (log at top-level instead of inside the thread pool)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)