[jira] [Commented] (HIVE-21842) Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics

2019-06-18 Thread Laszlo Bodor (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16866629#comment-16866629
 ] 

Laszlo Bodor commented on HIVE-21842:
-

pushed to master, thanks [~isuller] for the patch!

> Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics
> 
>
> Key: HIVE-21842
> URL: https://issues.apache.org/jira/browse/HIVE-21842
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Ivan Suller
>Assignee: Ivan Suller
>Priority: Trivial
> Fix For: 4.0.0
>
> Attachments: HIVE-21842.1.patch, HIVE-21842.1.patch
>
>
> There are several unnecessary or inefficient solution in the aforementioned 
> method. A little code cleanup could help to reduce the complexity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21842) Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics

2019-06-17 Thread Laszlo Bodor (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16865434#comment-16865434
 ] 

Laszlo Bodor commented on HIVE-21842:
-

+1

> Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics
> 
>
> Key: HIVE-21842
> URL: https://issues.apache.org/jira/browse/HIVE-21842
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Ivan Suller
>Assignee: Ivan Suller
>Priority: Trivial
> Attachments: HIVE-21842.1.patch, HIVE-21842.1.patch
>
>
> There are several unnecessary or inefficient solution in the aforementioned 
> method. A little code cleanup could help to reduce the complexity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21842) Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics

2019-06-07 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859060#comment-16859060
 ] 

Hive QA commented on HIVE-21842:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12971166/HIVE-21842.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 16044 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/17480/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17480/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17480/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12971166 - PreCommit-HIVE-Build

> Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics
> 
>
> Key: HIVE-21842
> URL: https://issues.apache.org/jira/browse/HIVE-21842
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Ivan Suller
>Assignee: Ivan Suller
>Priority: Trivial
> Attachments: HIVE-21842.1.patch, HIVE-21842.1.patch
>
>
> There are several unnecessary or inefficient solution in the aforementioned 
> method. A little code cleanup could help to reduce the complexity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21842) Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics

2019-06-07 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859046#comment-16859046
 ] 

Hive QA commented on HIVE-21842:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
9s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  
9s{color} | {color:blue} ql in master has 2256 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
40s{color} | {color:green} ql: The patch generated 0 new + 59 unchanged - 1 
fixed = 59 total (was 60) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
0s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 27s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17480/dev-support/hive-personality.sh
 |
| git revision | master / 51b1c6b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17480/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics
> 
>
> Key: HIVE-21842
> URL: https://issues.apache.org/jira/browse/HIVE-21842
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Ivan Suller
>Assignee: Ivan Suller
>Priority: Trivial
> Attachments: HIVE-21842.1.patch, HIVE-21842.1.patch
>
>
> There are several unnecessary or inefficient solution in the aforementioned 
> method. A little code cleanup could help to reduce the complexity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21842) Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics

2019-06-06 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858240#comment-16858240
 ] 

Hive QA commented on HIVE-21842:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12971058/HIVE-21842.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 16079 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[orc_merge_diff_fs]
 (batchId=192)
org.apache.hadoop.hive.ql.parse.TestReplAcidTablesBootstrapWithJsonMessage.testBootstrapAcidTablesDuringIncrementalWithConcurrentWrites
 (batchId=248)
org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerCustomCreatedDynamicPartitions
 (batchId=274)
org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerCustomCreatedDynamicPartitionsUnionAll
 (batchId=274)
org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerHighShuffleBytes
 (batchId=274)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/17460/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17460/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17460/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12971058 - PreCommit-HIVE-Build

> Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics
> 
>
> Key: HIVE-21842
> URL: https://issues.apache.org/jira/browse/HIVE-21842
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Ivan Suller
>Assignee: Ivan Suller
>Priority: Trivial
> Attachments: HIVE-21842.1.patch
>
>
> There are several unnecessary or inefficient solution in the aforementioned 
> method. A little code cleanup could help to reduce the complexity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21842) Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics

2019-06-06 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16858222#comment-16858222
 ] 

Hive QA commented on HIVE-21842:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
45s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 
15s{color} | {color:blue} ql in master has 2256 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
11s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
43s{color} | {color:green} ql: The patch generated 0 new + 59 unchanged - 1 
fixed = 59 total (was 60) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 10s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17460/dev-support/hive-personality.sh
 |
| git revision | master / e7f2fccd |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17460/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Code cleanup in org.apache.hadoop.hive.ql.stats.StatsUtils.collectStatistics
> 
>
> Key: HIVE-21842
> URL: https://issues.apache.org/jira/browse/HIVE-21842
> Project: Hive
>  Issue Type: Improvement
>  Components: Hive
>Reporter: Ivan Suller
>Assignee: Ivan Suller
>Priority: Trivial
> Attachments: HIVE-21842.1.patch
>
>
> There are several unnecessary or inefficient solution in the aforementioned 
> method. A little code cleanup could help to reduce the complexity.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)