[jira] [Commented] (HIVE-21963) TransactionalValidationListener.validateTableStructure should check the partition directories in the case of partitioned tables

2019-07-11 Thread Vaibhav Gumashta (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882710#comment-16882710
 ] 

Vaibhav Gumashta commented on HIVE-21963:
-

+1

> TransactionalValidationListener.validateTableStructure should check the 
> partition directories in the case of partitioned tables
> ---
>
> Key: HIVE-21963
> URL: https://issues.apache.org/jira/browse/HIVE-21963
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-21963.1.patch
>
>
> The transactional validation check is checking just the base table directory, 
> but for partitioned tables this should be checking the partitioned 
> directories (some of which may not even be in the base table directory).



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (HIVE-21963) TransactionalValidationListener.validateTableStructure should check the partition directories in the case of partitioned tables

2019-07-10 Thread Jason Dere (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882499#comment-16882499
 ] 

Jason Dere commented on HIVE-21963:
---

[~vgumashta] can you review the patch?

> TransactionalValidationListener.validateTableStructure should check the 
> partition directories in the case of partitioned tables
> ---
>
> Key: HIVE-21963
> URL: https://issues.apache.org/jira/browse/HIVE-21963
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-21963.1.patch
>
>
> The transactional validation check is checking just the base table directory, 
> but for partitioned tables this should be checking the partitioned 
> directories (some of which may not even be in the base table directory).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21963) TransactionalValidationListener.validateTableStructure should check the partition directories in the case of partitioned tables

2019-07-09 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881116#comment-16881116
 ] 

Hive QA commented on HIVE-21963:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12973978/HIVE-21963.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 16366 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/17923/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17923/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17923/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12973978 - PreCommit-HIVE-Build

> TransactionalValidationListener.validateTableStructure should check the 
> partition directories in the case of partitioned tables
> ---
>
> Key: HIVE-21963
> URL: https://issues.apache.org/jira/browse/HIVE-21963
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-21963.1.patch
>
>
> The transactional validation check is checking just the base table directory, 
> but for partitioned tables this should be checking the partitioned 
> directories (some of which may not even be in the base table directory).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21963) TransactionalValidationListener.validateTableStructure should check the partition directories in the case of partitioned tables

2019-07-09 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881078#comment-16881078
 ] 

Hive QA commented on HIVE-21963:


| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
 2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
30s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
20s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 
16s{color} | {color:blue} standalone-metastore/metastore-server in master has 
179 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
26s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
17s{color} | {color:red} standalone-metastore/metastore-server: The patch 
generated 1 new + 20 unchanged - 1 fixed = 21 total (was 21) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 14s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-17923/dev-support/hive-personality.sh
 |
| git revision | master / f923b74 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| checkstyle | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17923/yetus/diff-checkstyle-standalone-metastore_metastore-server.txt
 |
| modules | C: standalone-metastore/metastore-server U: 
standalone-metastore/metastore-server |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-17923/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> TransactionalValidationListener.validateTableStructure should check the 
> partition directories in the case of partitioned tables
> ---
>
> Key: HIVE-21963
> URL: https://issues.apache.org/jira/browse/HIVE-21963
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-21963.1.patch
>
>
> The transactional validation check is checking just the base table directory, 
> but for partitioned tables this should be checking the partitioned 
> directories (some of which may not even be in the base table directory).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HIVE-21963) TransactionalValidationListener.validateTableStructure should check the partition directories in the case of partitioned tables

2019-07-06 Thread Hive QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/HIVE-21963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16879621#comment-16879621
 ] 

Hive QA commented on HIVE-21963:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12973820/HIVE-21963.1.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/17888/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17888/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17888/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit 
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2019-07-06 09:13:10.963
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ 
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-17888/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2019-07-06 09:13:10.966
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at 6e4c500 HIVE-21947: Move Materialized View Update under DDL 
(Miklos Gergely, reviewed by Jesus Camacho Rodriguez)
+ git clean -f -d
Removing standalone-metastore/metastore-server/src/gen/
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at 6e4c500 HIVE-21947: Move Materialized View Update under DDL 
(Miklos Gergely, reviewed by Jesus Camacho Rodriguez)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2019-07-06 09:13:11.678
+ rm -rf ../yetus_PreCommit-HIVE-Build-17888
+ mkdir ../yetus_PreCommit-HIVE-Build-17888
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-17888
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-17888/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh 
/data/hiveptest/working/scratch/build.patch
error: 
a/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/TransactionalValidationListener.java:
 does not exist in index
error: patch failed: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/TransactionalValidationListener.java:452
error: repository lacks the necessary blob to fall back on 3-way merge.
error: 
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/TransactionalValidationListener.java:
 patch does not apply
error: 
metastore-server/src/main/java/org/apache/hadoop/hive/metastore/TransactionalValidationListener.java:
 does not exist in index
The patch does not appear to apply with p0, p1, or p2
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-17888
+ exit 1
'
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12973820 - PreCommit-HIVE-Build

> TransactionalValidationListener.validateTableStructure should check the 
> partition directories in the case of partitioned tables
> ---
>
> Key: HIVE-21963
> URL: https://issues.apache.org/jira/browse/HIVE-21963
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-21963.1.patch
>
>
> The transactional validation check is checking just the base table directory, 
> but for partitioned tables this should be checking the partitioned 
> directories (some of which may not even be in the base table directory).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)