[jira] [Commented] (HIVE-21968) Remove index related codes
[ https://issues.apache.org/jira/browse/HIVE-21968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882563#comment-16882563 ] Hive QA commented on HIVE-21968: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12974119/HIVE-21968.02.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 16647 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/17950/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17950/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17950/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12974119 - PreCommit-HIVE-Build > Remove index related codes > -- > > Key: HIVE-21968 > URL: https://issues.apache.org/jira/browse/HIVE-21968 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.1 >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21968.01.patch, HIVE-21968.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Hive doesn't support indexes since 3.0.0, still some index related tests were > left behind, and some code to disable them. Also some index related code is > still in the codebase. They should be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21968) Remove index related codes
[ https://issues.apache.org/jira/browse/HIVE-21968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16882530#comment-16882530 ] Hive QA commented on HIVE-21968: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 44s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 8s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 48s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 0s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 0s{color} | {color:blue} ql in master has 2255 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 40s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 26s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 28s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 41s{color} | {color:green} ql: The patch generated 0 new + 18 unchanged - 322 fixed = 18 total (was 340) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} itests/hive-unit: The patch generated 0 new + 44 unchanged - 7 fixed = 44 total (was 51) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 24s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 30m 36s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17950/dev-support/hive-personality.sh | | git revision | master / 505a733 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: ql itests itests/hive-unit U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17950/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Remove index related codes > -- > > Key: HIVE-21968 > URL: https://issues.apache.org/jira/browse/HIVE-21968 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.1 >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21968.01.patch, HIVE-21968.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Hive doesn't support indexes since 3.0.0, still some index related tests were > left behind, and some code to disable them. Also some index related code is > still in the codebase. They should be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21968) Remove index related codes
[ https://issues.apache.org/jira/browse/HIVE-21968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881657#comment-16881657 ] Hive QA commented on HIVE-21968: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12974040/HIVE-21968.02.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 16632 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.llap.cache.TestBuddyAllocator.testMTT[2] (batchId=350) org.apache.hadoop.hive.ql.exec.tez.TestCustomPartitionVertex.testGetBytePayload (batchId=331) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/17934/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17934/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17934/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12974040 - PreCommit-HIVE-Build > Remove index related codes > -- > > Key: HIVE-21968 > URL: https://issues.apache.org/jira/browse/HIVE-21968 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.1 >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21968.01.patch, HIVE-21968.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Hive doesn't support indexes since 3.0.0, still some index related tests were > left behind, and some code to disable them. Also some index related code is > still in the codebase. They should be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21968) Remove index related codes
[ https://issues.apache.org/jira/browse/HIVE-21968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881642#comment-16881642 ] Hive QA commented on HIVE-21968: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 51s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 44s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 48s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 58s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 7s{color} | {color:blue} ql in master has 2252 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 38s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 22s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 26s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 48s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 40s{color} | {color:red} ql: The patch generated 3 new + 20 unchanged - 320 fixed = 23 total (was 340) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} itests/hive-unit: The patch generated 0 new + 44 unchanged - 7 fixed = 44 total (was 51) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 24s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 32m 18s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17934/dev-support/hive-personality.sh | | git revision | master / 33d2995 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17934/yetus/diff-checkstyle-ql.txt | | modules | C: ql itests itests/hive-unit U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17934/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Remove index related codes > -- > > Key: HIVE-21968 > URL: https://issues.apache.org/jira/browse/HIVE-21968 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.1 >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21968.01.patch, HIVE-21968.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Hive doesn't support indexes since 3.0.0, still some index related tests were > left behind, and some code to disable them. Also some index related code is > still in the codebase. They should be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21968) Remove index related codes
[ https://issues.apache.org/jira/browse/HIVE-21968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881057#comment-16881057 ] Hive QA commented on HIVE-21968: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12973970/HIVE-21968.01.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 16366 tests executed *Failed tests:* {noformat} org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerCustomCreatedDynamicPartitions (batchId=275) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerCustomCreatedDynamicPartitionsUnionAll (batchId=275) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerCustomNonExistent (batchId=275) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerHighBytesRead (batchId=275) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerHighShuffleBytes (batchId=275) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerSlowQueryElapsedTime (batchId=275) org.apache.hive.jdbc.TestTriggersTezSessionPoolManager.testTriggerSlowQueryExecutionTime (batchId=275) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/17922/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/17922/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-17922/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 7 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12973970 - PreCommit-HIVE-Build > Remove index related codes > -- > > Key: HIVE-21968 > URL: https://issues.apache.org/jira/browse/HIVE-21968 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.1 >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21968.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Hive doesn't support indexes since 3.0.0, still some index related tests were > left behind, and some code to disable them. Also some index related code is > still in the codebase. They should be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21968) Remove index related codes
[ https://issues.apache.org/jira/browse/HIVE-21968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16881032#comment-16881032 ] Hive QA commented on HIVE-21968: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 40s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 56s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 47s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 0s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 5s{color} | {color:blue} ql in master has 2252 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 39s{color} | {color:blue} itests/hive-unit in master has 2 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 22s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 26s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 48s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 41s{color} | {color:red} ql: The patch generated 3 new + 20 unchanged - 320 fixed = 23 total (was 340) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} itests/hive-unit: The patch generated 0 new + 44 unchanged - 7 fixed = 44 total (was 51) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 22s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 30m 15s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-17922/dev-support/hive-personality.sh | | git revision | master / f923b74 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-17922/yetus/diff-checkstyle-ql.txt | | modules | C: ql itests itests/hive-unit U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-17922/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Remove index related codes > -- > > Key: HIVE-21968 > URL: https://issues.apache.org/jira/browse/HIVE-21968 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.1 >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21968.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Hive doesn't support indexes since 3.0.0, still some index related tests were > left behind, and some code to disable them. Also some index related code is > still in the codebase. They should be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21968) Remove index related codes
[ https://issues.apache.org/jira/browse/HIVE-21968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880672#comment-16880672 ] Jesus Camacho Rodriguez commented on HIVE-21968: +1 (pending tests) > Remove index related codes > -- > > Key: HIVE-21968 > URL: https://issues.apache.org/jira/browse/HIVE-21968 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.1 >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21968.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Hive doesn't support indexes since 3.0.0, still some index related tests were > left behind, and some code to disable them. Also some index related code is > still in the codebase. They should be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-21968) Remove index related codes
[ https://issues.apache.org/jira/browse/HIVE-21968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16880595#comment-16880595 ] Miklos Gergely commented on HIVE-21968: --- Created [https://github.com/apache/hive/pull/707], [~jcamachorodriguez] please review. Also fixed tons of formatting issues in Operation2Privilege.java > Remove index related codes > -- > > Key: HIVE-21968 > URL: https://issues.apache.org/jira/browse/HIVE-21968 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.1.1 >Reporter: Miklos Gergely >Assignee: Miklos Gergely >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-21968.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Hive doesn't support indexes since 3.0.0, still some index related tests were > left behind, and some code to disable them. Also some index related code is > still in the codebase. They should be removed. -- This message was sent by Atlassian JIRA (v7.6.3#76005)