[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[ https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16934021#comment-16934021 ] Himanshu Mishra commented on HIVE-22201: [~ashutoshc] all tests passed now > ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws > ArrayIndexOutOfBoundsException if no big table is selected > -- > > Key: HIVE-22201 > URL: https://issues.apache.org/jira/browse/HIVE-22201 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch, > HIVE-22201.03.patch, HIVE-22201.04.patch, HIVE-22201.05.patch > > Time Spent: 10m > Remaining Estimate: 0h > > In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end > up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1, > resulting in {{ArrayIndexOutOfBoundsException}}. > Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[ https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933847#comment-16933847 ] Hive QA commented on HIVE-22201: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12980739/HIVE-22201.05.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 16833 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18654/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18654/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18654/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12980739 - PreCommit-HIVE-Build > ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws > ArrayIndexOutOfBoundsException if no big table is selected > -- > > Key: HIVE-22201 > URL: https://issues.apache.org/jira/browse/HIVE-22201 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch, > HIVE-22201.03.patch, HIVE-22201.04.patch, HIVE-22201.05.patch > > Time Spent: 10m > Remaining Estimate: 0h > > In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end > up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1, > resulting in {{ArrayIndexOutOfBoundsException}}. > Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[ https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933820#comment-16933820 ] Hive QA commented on HIVE-22201: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 40s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 6s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 6s{color} | {color:blue} ql in master has 1571 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 26s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 37s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18654/dev-support/hive-personality.sh | | git revision | master / 5d1a949 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18654/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws > ArrayIndexOutOfBoundsException if no big table is selected > -- > > Key: HIVE-22201 > URL: https://issues.apache.org/jira/browse/HIVE-22201 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch, > HIVE-22201.03.patch, HIVE-22201.04.patch, HIVE-22201.05.patch > > Time Spent: 10m > Remaining Estimate: 0h > > In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end > up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1, > resulting in {{ArrayIndexOutOfBoundsException}}. > Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[ https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933224#comment-16933224 ] Hive QA commented on HIVE-22201: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12980673/HIVE-22201.04.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 16833 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[updateBasicStats] (batchId=69) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18647/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18647/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18647/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12980673 - PreCommit-HIVE-Build > ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws > ArrayIndexOutOfBoundsException if no big table is selected > -- > > Key: HIVE-22201 > URL: https://issues.apache.org/jira/browse/HIVE-22201 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch, > HIVE-22201.03.patch, HIVE-22201.04.patch > > Time Spent: 10m > Remaining Estimate: 0h > > In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end > up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1, > resulting in {{ArrayIndexOutOfBoundsException}}. > Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[ https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933189#comment-16933189 ] Hive QA commented on HIVE-22201: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 7s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 40s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 4s{color} | {color:blue} ql in master has 1571 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 59s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 42s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 43s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18647/dev-support/hive-personality.sh | | git revision | master / f7d5ef2 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18647/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws > ArrayIndexOutOfBoundsException if no big table is selected > -- > > Key: HIVE-22201 > URL: https://issues.apache.org/jira/browse/HIVE-22201 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch, > HIVE-22201.03.patch, HIVE-22201.04.patch > > Time Spent: 10m > Remaining Estimate: 0h > > In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end > up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1, > resulting in {{ArrayIndexOutOfBoundsException}}. > Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[ https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932944#comment-16932944 ] Hive QA commented on HIVE-22201: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12980599/HIVE-22201.03.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 16833 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.llap.cache.TestBuddyAllocator.testMTT[2] (batchId=361) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18640/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18640/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18640/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12980599 - PreCommit-HIVE-Build > ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws > ArrayIndexOutOfBoundsException if no big table is selected > -- > > Key: HIVE-22201 > URL: https://issues.apache.org/jira/browse/HIVE-22201 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch, > HIVE-22201.03.patch > > Time Spent: 10m > Remaining Estimate: 0h > > In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end > up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1, > resulting in {{ArrayIndexOutOfBoundsException}}. > Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[ https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932258#comment-16932258 ] Ashutosh Chauhan commented on HIVE-22201: - +1 [~himanshum] we require a green run. Can you please re-upload your patch one more time to get a new run. > ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws > ArrayIndexOutOfBoundsException if no big table is selected > -- > > Key: HIVE-22201 > URL: https://issues.apache.org/jira/browse/HIVE-22201 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end > up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1, > resulting in {{ArrayIndexOutOfBoundsException}}. > Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[ https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932065#comment-16932065 ] Himanshu Mishra commented on HIVE-22201: [~jcamachorodriguez] can you please review > ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws > ArrayIndexOutOfBoundsException if no big table is selected > -- > > Key: HIVE-22201 > URL: https://issues.apache.org/jira/browse/HIVE-22201 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end > up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1, > resulting in {{ArrayIndexOutOfBoundsException}}. > Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[ https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932062#comment-16932062 ] Himanshu Mishra commented on HIVE-22201: Failures are not related to patch, they passed on the first run and failed on second, without any code change. [testPartitionDiscoveryTransactionalTable|https://builds.apache.org/job/PreCommit-HIVE-Build/18590/testReport/org.apache.hadoop.hive.metastore/TestPartitionManagement/testPartitionDiscoveryTransactionalTable/] [loadDataNonAcid2AcidConversion|https://builds.apache.org/job/PreCommit-HIVE-Build/18590/testReport/org.apache.hadoop.hive.ql/TestTxnLoadData/loadDataNonAcid2AcidConversion/] > ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws > ArrayIndexOutOfBoundsException if no big table is selected > -- > > Key: HIVE-22201 > URL: https://issues.apache.org/jira/browse/HIVE-22201 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end > up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1, > resulting in {{ArrayIndexOutOfBoundsException}}. > Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[ https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931948#comment-16931948 ] Hive QA commented on HIVE-22201: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12980509/HIVE-22201.02.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 16760 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.metastore.TestPartitionManagement.testPartitionDiscoveryTransactionalTable (batchId=223) org.apache.hadoop.hive.ql.TestTxnLoadData.loadDataNonAcid2AcidConversion (batchId=308) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18626/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18626/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18626/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12980509 - PreCommit-HIVE-Build > ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws > ArrayIndexOutOfBoundsException if no big table is selected > -- > > Key: HIVE-22201 > URL: https://issues.apache.org/jira/browse/HIVE-22201 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end > up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1, > resulting in {{ArrayIndexOutOfBoundsException}}. > Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[ https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931932#comment-16931932 ] Hive QA commented on HIVE-22201: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 23s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 56s{color} | {color:blue} ql in master has 1571 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 56s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 3s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 23m 42s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18626/dev-support/hive-personality.sh | | git revision | master / 5c83924 | | Default Java | 1.8.0_111 | | findbugs | v3.0.1 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18626/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws > ArrayIndexOutOfBoundsException if no big table is selected > -- > > Key: HIVE-22201 > URL: https://issues.apache.org/jira/browse/HIVE-22201 > Project: Hive > Issue Type: Bug >Affects Versions: 3.0.0 >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22201.01.patch, HIVE-22201.02.patch > > Time Spent: 10m > Remaining Estimate: 0h > > In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end > up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1, > resulting in {{ArrayIndexOutOfBoundsException}}. > Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[ https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929574#comment-16929574 ] Hive QA commented on HIVE-22201: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12980281/HIVE-22201.01.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 16738 tests executed *Failed tests:* {noformat} TestMiniLlapCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=159) [parquet_complex_types_vectorization.q,cte_4.q,explainuser_2.q,mm_all.q,rcfile_merge2.q,alter_table_location2.q,bucket5.q,mm_dp.q,orc_struct_type_vectorization.q,parquet_map_type_vectorization.q,reduce_deduplicate.q,load_fs2.q,rcfile_merge3.q,external_table_purge.q,intersect_distinct.q] {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/18590/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18590/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18590/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12980281 - PreCommit-HIVE-Build > ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws > ArrayIndexOutOfBoundsException if no big table is selected > -- > > Key: HIVE-22201 > URL: https://issues.apache.org/jira/browse/HIVE-22201 > Project: Hive > Issue Type: Bug >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22201.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end > up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1, > resulting in {{ArrayIndexOutOfBoundsException}}. > Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ? -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Commented] (HIVE-22201) ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws ArrayIndexOutOfBoundsException if no big table is selected
[ https://issues.apache.org/jira/browse/HIVE-22201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16929555#comment-16929555 ] Hive QA commented on HIVE-22201: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 0s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 7s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 5s{color} | {color:blue} ql in master has 2225 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 0s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 5s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 58s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 17s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 24m 55s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-18590/dev-support/hive-personality.sh | | git revision | master / 38190f3 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-18590/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > ConvertJoinMapJoin#checkShuffleSizeForLargeTable throws > ArrayIndexOutOfBoundsException if no big table is selected > -- > > Key: HIVE-22201 > URL: https://issues.apache.org/jira/browse/HIVE-22201 > Project: Hive > Issue Type: Bug >Reporter: Himanshu Mishra >Assignee: Himanshu Mishra >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22201.01.patch > > Time Spent: 10m > Remaining Estimate: 0h > > In case when {{bigTableCandidateSet}} is empty e.g. full outer join, we end > up calling {{checkShuffleSizeForLargeTable}} with {{bigTablePosition}} as -1, > resulting in {{ArrayIndexOutOfBoundsException}}. > Also, should we return as soon as we see {{bigTableCandidateSet}} is empty ? -- This message was sent by Atlassian Jira (v8.3.2#803003)