[jira] [Commented] (HIVE-22210) Vectorization may reuse computation output columns involved in filtering
[
https://issues.apache.org/jira/browse/HIVE-22210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931925#comment-16931925
]
Hive QA commented on HIVE-22210:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12980501/HIVE-22210.02.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18625/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18625/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18625/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL
https://issues.apache.org/jira/secure/attachment/12980501/HIVE-22210.02.patch
was found in seen patch url's cache and a test was probably run already on it.
Aborting...
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12980501 - PreCommit-HIVE-Build
> Vectorization may reuse computation output columns involved in filtering
>
>
> Key: HIVE-22210
> URL: https://issues.apache.org/jira/browse/HIVE-22210
> Project: Hive
> Issue Type: Bug
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-22210.01.patch, HIVE-22210.02.patch
>
>
> running the following test with TestMiniLlapLocalCliDriver leads to an
> unexpected results; the coalesce calculated inside the subquery has a value
> of 1 instead of the correct(922) value.
> {code}
> drop table if exists u_table_4;
> create table u_table_4(smallint_col_22 smallint, int_col_5 int);
> insert into u_table_4 values(238,922);
> drop table u_table_7;
> create table u_table_7 ( bigint_col_3 bigint, int_col_10 int);
> insert into u_table_7 values (571,198);
> drop table u_table_19;
> create table u_table_19 (bigint_col_18 bigint ,int_col_19 int, STRING_COL_7
> string);
> insert into u_table_19 values (922,5,'500');
> set hive.mapjoin.full.outer=true;
> set hive.auto.convert.join=true;
> set hive.query.results.cache.enabled=false;
> set hive.merge.nway.joins=true;
> set hive.vectorized.execution.enabled=true;
> --explain analyze
> SELECT
> a5.int_col,
> 922 as expected,
> COALESCE(a5.int_col, a5.aa) as expected2,
> a5.int_col_3 as reality
> FROMu_table_19 a1
> FULL OUTER JOIN
> (
>SELECT a2.int_col_5 AS int_col,
> a2.smallint_col_22 as aa,
> COALESCE(a2.int_col_5, a2.smallint_col_22) AS
> int_col_3
>FROM u_table_4 a2
> ) a5
> ON (
> a1.bigint_col_18) = (a5.int_col_3)
> INNER JOIN
> (
> SELECT a3.bigint_col_3
> AS int_col,
> Cast (COALESCE(a3.bigint_col_3,
> a3.bigint_col_3, a3.int_col_10) AS BIGINT) * Cast (a3.bigint_col_3 AS BIGINT)
> AS int_col_3
> FROM u_table_7 a3
> WHEREbigint_col_3=571
> ) a4
> ON (a1.int_col_19=5)
> OR ((a5.int_col_3) IN (a4.int_col, 10))
> where
> a1.STRING_COL_7='500'
> ORDER BYint_col DESC nulls last limit 100
> ;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22210) Vectorization may reuse computation output columns involved in filtering
[
https://issues.apache.org/jira/browse/HIVE-22210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931924#comment-16931924
]
Hive QA commented on HIVE-22210:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12980501/HIVE-22210.02.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 16761 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18624/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18624/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18624/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12980501 - PreCommit-HIVE-Build
> Vectorization may reuse computation output columns involved in filtering
>
>
> Key: HIVE-22210
> URL: https://issues.apache.org/jira/browse/HIVE-22210
> Project: Hive
> Issue Type: Bug
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-22210.01.patch, HIVE-22210.02.patch
>
>
> running the following test with TestMiniLlapLocalCliDriver leads to an
> unexpected results; the coalesce calculated inside the subquery has a value
> of 1 instead of the correct(922) value.
> {code}
> drop table if exists u_table_4;
> create table u_table_4(smallint_col_22 smallint, int_col_5 int);
> insert into u_table_4 values(238,922);
> drop table u_table_7;
> create table u_table_7 ( bigint_col_3 bigint, int_col_10 int);
> insert into u_table_7 values (571,198);
> drop table u_table_19;
> create table u_table_19 (bigint_col_18 bigint ,int_col_19 int, STRING_COL_7
> string);
> insert into u_table_19 values (922,5,'500');
> set hive.mapjoin.full.outer=true;
> set hive.auto.convert.join=true;
> set hive.query.results.cache.enabled=false;
> set hive.merge.nway.joins=true;
> set hive.vectorized.execution.enabled=true;
> --explain analyze
> SELECT
> a5.int_col,
> 922 as expected,
> COALESCE(a5.int_col, a5.aa) as expected2,
> a5.int_col_3 as reality
> FROMu_table_19 a1
> FULL OUTER JOIN
> (
>SELECT a2.int_col_5 AS int_col,
> a2.smallint_col_22 as aa,
> COALESCE(a2.int_col_5, a2.smallint_col_22) AS
> int_col_3
>FROM u_table_4 a2
> ) a5
> ON (
> a1.bigint_col_18) = (a5.int_col_3)
> INNER JOIN
> (
> SELECT a3.bigint_col_3
> AS int_col,
> Cast (COALESCE(a3.bigint_col_3,
> a3.bigint_col_3, a3.int_col_10) AS BIGINT) * Cast (a3.bigint_col_3 AS BIGINT)
> AS int_col_3
> FROM u_table_7 a3
> WHEREbigint_col_3=571
> ) a4
> ON (a1.int_col_19=5)
> OR ((a5.int_col_3) IN (a4.int_col, 10))
> where
> a1.STRING_COL_7='500'
> ORDER BYint_col DESC nulls last limit 100
> ;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22210) Vectorization may reuse computation output columns involved in filtering
[
https://issues.apache.org/jira/browse/HIVE-22210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931912#comment-16931912
]
Hive QA commented on HIVE-22210:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
47s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
7s{color} | {color:blue} ql in master has 1571 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
43s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
0s{color} | {color:red} The patch has 28 line(s) that end in whitespace. Use
git apply --whitespace=fix <>. Refer
https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m
1s{color} | {color:red} The patch 6 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
59s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 26m 44s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18624/dev-support/hive-personality.sh
|
| git revision | master / 5c83924 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18624/yetus/whitespace-eol.txt
|
| whitespace |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18624/yetus/whitespace-tabs.txt
|
| modules | C: ql itests U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18624/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Vectorization may reuse computation output columns involved in filtering
>
>
> Key: HIVE-22210
> URL: https://issues.apache.org/jira/browse/HIVE-22210
> Project: Hive
> Issue Type: Bug
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-22210.01.patch, HIVE-22210.02.patch
>
>
> running the following test with TestMiniLlapLocalCliDriver leads to an
> unexpected results; the coalesce calculated inside the subquery has a value
> of 1 instead of the correct(922) value.
> {code}
> drop table if exists u_table_4;
> create table u_table_4(smallint_col_22 smallint, int_col_5 int);
> insert into u_table_4 values(238,922);
> drop table u_table_7;
> create table u_table_7 ( bigint_col_3 bigint, int_col_10 int);
> insert into u_table_7 values (571,198);
> drop table u_table_19;
> create
[jira] [Commented] (HIVE-22210) Vectorization may reuse computation output columns involved in filtering
[
https://issues.apache.org/jira/browse/HIVE-22210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16931288#comment-16931288
]
Laszlo Bodor commented on HIVE-22210:
-
+1, pending tests
> Vectorization may reuse computation output columns involved in filtering
>
>
> Key: HIVE-22210
> URL: https://issues.apache.org/jira/browse/HIVE-22210
> Project: Hive
> Issue Type: Bug
>Reporter: Zoltan Haindrich
>Assignee: Zoltan Haindrich
>Priority: Major
> Attachments: HIVE-22210.01.patch
>
>
> running the following test with TestMiniLlapLocalCliDriver leads to an
> unexpected results; the coalesce calculated inside the subquery has a value
> of 1 instead of the correct(922) value.
> {code}
> drop table if exists u_table_4;
> create table u_table_4(smallint_col_22 smallint, int_col_5 int);
> insert into u_table_4 values(238,922);
> drop table u_table_7;
> create table u_table_7 ( bigint_col_3 bigint, int_col_10 int);
> insert into u_table_7 values (571,198);
> drop table u_table_19;
> create table u_table_19 (bigint_col_18 bigint ,int_col_19 int, STRING_COL_7
> string);
> insert into u_table_19 values (922,5,'500');
> set hive.mapjoin.full.outer=true;
> set hive.auto.convert.join=true;
> set hive.query.results.cache.enabled=false;
> set hive.merge.nway.joins=true;
> set hive.vectorized.execution.enabled=true;
> --explain analyze
> SELECT
> a5.int_col,
> 922 as expected,
> COALESCE(a5.int_col, a5.aa) as expected2,
> a5.int_col_3 as reality
> FROMu_table_19 a1
> FULL OUTER JOIN
> (
>SELECT a2.int_col_5 AS int_col,
> a2.smallint_col_22 as aa,
> COALESCE(a2.int_col_5, a2.smallint_col_22) AS
> int_col_3
>FROM u_table_4 a2
> ) a5
> ON (
> a1.bigint_col_18) = (a5.int_col_3)
> INNER JOIN
> (
> SELECT a3.bigint_col_3
> AS int_col,
> Cast (COALESCE(a3.bigint_col_3,
> a3.bigint_col_3, a3.int_col_10) AS BIGINT) * Cast (a3.bigint_col_3 AS BIGINT)
> AS int_col_3
> FROM u_table_7 a3
> WHEREbigint_col_3=571
> ) a4
> ON (a1.int_col_19=5)
> OR ((a5.int_col_3) IN (a4.int_col, 10))
> where
> a1.STRING_COL_7='500'
> ORDER BYint_col DESC nulls last limit 100
> ;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
