[jira] [Commented] (HIVE-22242) Move TempTable and PartitionTree out of SessionHiveMetastoreClient
[
https://issues.apache.org/jira/browse/HIVE-22242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938733#comment-16938733
]
Hive QA commented on HIVE-22242:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12981414/HIVE-22242.03.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17007 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18746/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18746/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18746/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12981414 - PreCommit-HIVE-Build
> Move TempTable and PartitionTree out of SessionHiveMetastoreClient
> --
>
> Key: HIVE-22242
> URL: https://issues.apache.org/jira/browse/HIVE-22242
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-22242.01.patch, HIVE-22242.02.patch,
> HIVE-22242.03.patch
>
>
> SessionHiveMetastoreClient is getting too crowded and unreadable. TempTable
> and PartitionTree should moved into a separate class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22242) Move TempTable and PartitionTree out of SessionHiveMetastoreClient
[
https://issues.apache.org/jira/browse/HIVE-22242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938682#comment-16938682
]
Hive QA commented on HIVE-22242:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
48s{color} | {color:blue} ql in master has 1567 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
0s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
5s{color} | {color:green} ql generated 0 new + 1566 unchanged - 1 fixed = 1566
total (was 1567) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 31s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18746/dev-support/hive-personality.sh
|
| git revision | master / 50862a6 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18746/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Move TempTable and PartitionTree out of SessionHiveMetastoreClient
> --
>
> Key: HIVE-22242
> URL: https://issues.apache.org/jira/browse/HIVE-22242
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-22242.01.patch, HIVE-22242.02.patch,
> HIVE-22242.03.patch
>
>
> SessionHiveMetastoreClient is getting too crowded and unreadable. TempTable
> and PartitionTree should moved into a separate class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22242) Move TempTable and PartitionTree out of SessionHiveMetastoreClient
[
https://issues.apache.org/jira/browse/HIVE-22242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937823#comment-16937823
]
Hive QA commented on HIVE-22242:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12981313/HIVE-22242.02.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17007 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.metastore.TestPartitionManagement.testPartitionDiscoveryTransactionalTable
(batchId=223)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18722/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18722/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18722/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12981313 - PreCommit-HIVE-Build
> Move TempTable and PartitionTree out of SessionHiveMetastoreClient
> --
>
> Key: HIVE-22242
> URL: https://issues.apache.org/jira/browse/HIVE-22242
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-22242.01.patch, HIVE-22242.02.patch
>
>
> SessionHiveMetastoreClient is getting too crowded and unreadable. TempTable
> and PartitionTree should moved into a separate class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22242) Move TempTable and PartitionTree out of SessionHiveMetastoreClient
[
https://issues.apache.org/jira/browse/HIVE-22242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937776#comment-16937776
]
Hive QA commented on HIVE-22242:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
54s{color} | {color:blue} ql in master has 1567 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
39s{color} | {color:red} ql: The patch generated 1 new + 75 unchanged - 0 fixed
= 76 total (was 75) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
3s{color} | {color:red} ql generated 1 new + 1566 unchanged - 1 fixed = 1567
total (was 1567) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 23m 37s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| |
org.apache.hadoop.hive.ql.metadata.PartitionTree.getPartitionsByPartitionVals(List)
makes inefficient use of keySet iterator instead of entrySet iterator At
PartitionTree.java:keySet iterator instead of entrySet iterator At
PartitionTree.java:[line 123] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-18722/dev-support/hive-personality.sh
|
| git revision | master / d6668c7 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18722/yetus/diff-checkstyle-ql.txt
|
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18722/yetus/new-findbugs-ql.html
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-18722/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Move TempTable and PartitionTree out of SessionHiveMetastoreClient
> --
>
> Key: HIVE-22242
> URL: https://issues.apache.org/jira/browse/HIVE-22242
> Project: Hive
> Issue Type: Sub-task
> Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-22242.01.patch, HIVE-22242.02.patch
>
>
> SessionHiveMetastoreClient is getting too crowded and unreadable. TempTable
> and PartitionTree should moved into a separate class.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22242) Move TempTable and PartitionTree out of SessionHiveMetastoreClient
[ https://issues.apache.org/jira/browse/HIVE-22242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937763#comment-16937763 ] Peter Vary commented on HIVE-22242: --- +1 pending tests > Move TempTable and PartitionTree out of SessionHiveMetastoreClient > -- > > Key: HIVE-22242 > URL: https://issues.apache.org/jira/browse/HIVE-22242 > Project: Hive > Issue Type: Sub-task > Components: Hive >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-22242.01.patch, HIVE-22242.02.patch > > > SessionHiveMetastoreClient is getting too crowded and unreadable. TempTable > and PartitionTree should moved into a separate class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22242) Move TempTable and PartitionTree out of SessionHiveMetastoreClient
[
https://issues.apache.org/jira/browse/HIVE-22242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937627#comment-16937627
]
Hive QA commented on HIVE-22242:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12981297/HIVE-22242.01.patch
{color:red}ERROR:{color} -1 due to build exiting with an error
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/18719/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/18719/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-18719/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Tests exited with: NonZeroExitCodeException
Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit
status 1 and output '+ date '+%Y-%m-%d %T.%3N'
2019-09-25 10:57:54.805
+ [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]]
+ export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64
+ export
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+
PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games
+ export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m '
+ ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m '
+ export 'MAVEN_OPTS=-Xmx1g '
+ MAVEN_OPTS='-Xmx1g '
+ cd /data/hiveptest/working/
+ tee /data/hiveptest/logs/PreCommit-HIVE-Build-18719/source-prep.txt
+ [[ false == \t\r\u\e ]]
+ mkdir -p maven ivy
+ [[ git = \s\v\n ]]
+ [[ git = \g\i\t ]]
+ [[ -z master ]]
+ [[ -d apache-github-source-source ]]
+ [[ ! -d apache-github-source-source/.git ]]
+ [[ ! -d apache-github-source-source ]]
+ date '+%Y-%m-%d %T.%3N'
2019-09-25 10:57:54.808
+ cd apache-github-source-source
+ git fetch origin
+ git reset --hard HEAD
HEAD is now at d6668c7 HIVE-1: Llap external client - Need to reduce
LlapBaseInputFormat#getSplits() footprint (Shubham Chaurasia, reviewed by Jason
Dere)
+ git clean -f -d
+ git checkout master
Already on 'master'
Your branch is up-to-date with 'origin/master'.
+ git reset --hard origin/master
HEAD is now at d6668c7 HIVE-1: Llap external client - Need to reduce
LlapBaseInputFormat#getSplits() footprint (Shubham Chaurasia, reviewed by Jason
Dere)
+ git merge --ff-only origin/master
Already up-to-date.
+ date '+%Y-%m-%d %T.%3N'
2019-09-25 10:57:55.389
+ rm -rf ../yetus_PreCommit-HIVE-Build-18719
+ mkdir ../yetus_PreCommit-HIVE-Build-18719
+ git gc
+ cp -R . ../yetus_PreCommit-HIVE-Build-18719
+ mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-18719/yetus
+ patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh
+ patchFilePath=/data/hiveptest/working/scratch/build.patch
+ [[ -f /data/hiveptest/working/scratch/build.patch ]]
+ chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh
+ /data/hiveptest/working/scratch/smart-apply-patch.sh
/data/hiveptest/working/scratch/build.patch
Going to apply patch with: git apply -p0
+ [[ maven == \m\a\v\e\n ]]
+ rm -rf /data/hiveptest/working/maven/org/apache/hive
+ mvn -B clean install -DskipTests -T 4 -q
-Dmaven.repo.local=/data/hiveptest/working/maven
protoc-jar: executing: [/tmp/protoc8024280360608502582.exe, --version]
libprotoc 2.5.0
protoc-jar: executing: [/tmp/protoc8024280360608502582.exe,
-I/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore,
--java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/target/generated-sources,
/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto]
ANTLR Parser Generator Version 3.5.2
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process
(process-resource-bundles) on project hive-shims-0.23: Execution
process-resource-bundles of goal
org.apache.maven.plugins:maven-remote-resources-plugin:1.5:process failed.
ConcurrentModificationException -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/PluginExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :hive-shims-0.23
+ result=1
+ '[' 1 -ne 0 ']'
+ rm -rf yetus_PreCommit-HIVE-Build-18719
+ exit 1
'
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12981297 - PreCommit-HIVE-Build
> Move TempTable and PartitionTree out of SessionHiveMetastoreClient
>
