[jira] [Commented] (HIVE-22367) Transaction type not retrieved from OpenTxnRequest

2019-10-25 Thread Jira 


[ 
https://issues.apache.org/jira/browse/HIVE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959805#comment-16959805
 ] 

Ádám Szita commented on HIVE-22367:
---

+1

> Transaction type not retrieved from OpenTxnRequest
> --
>
> Key: HIVE-22367
> URL: https://issues.apache.org/jira/browse/HIVE-22367
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22367.1.patch, HIVE-22367.2.patch, 
> HIVE-22367.3.patch, HIVE-22367.4.patch, HIVE-22367.5.patch
>
>
> When opening a transaction, its type should be extracted from OpenTxnRequest 
> object. Currently it's hardcoded with TxnType.DEFAULT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22367) Transaction type not retrieved from OpenTxnRequest

2019-10-23 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958519#comment-16958519
 ] 

Hive QA commented on HIVE-22367:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983870/HIVE-22367.5.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17546 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19136/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19136/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19136/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12983870 - PreCommit-HIVE-Build

> Transaction type not retrieved from OpenTxnRequest
> --
>
> Key: HIVE-22367
> URL: https://issues.apache.org/jira/browse/HIVE-22367
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22367.1.patch, HIVE-22367.2.patch, 
> HIVE-22367.3.patch, HIVE-22367.4.patch, HIVE-22367.5.patch
>
>
> When opening a transaction, its type should be extracted from OpenTxnRequest 
> object. Currently it's hardcoded with TxnType.DEFAULT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22367) Transaction type not retrieved from OpenTxnRequest

2019-10-23 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958491#comment-16958491
 ] 

Hive QA commented on HIVE-22367:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 
10s{color} | {color:blue} standalone-metastore/metastore-server in master has 
171 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 27s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19136/dev-support/hive-personality.sh
 |
| git revision | master / 463dae9 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: standalone-metastore/metastore-server U: 
standalone-metastore/metastore-server |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19136/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Transaction type not retrieved from OpenTxnRequest
> --
>
> Key: HIVE-22367
> URL: https://issues.apache.org/jira/browse/HIVE-22367
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22367.1.patch, HIVE-22367.2.patch, 
> HIVE-22367.3.patch, HIVE-22367.4.patch, HIVE-22367.5.patch
>
>
> When opening a transaction, its type should be extracted from OpenTxnRequest 
> object. Currently it's hardcoded with TxnType.DEFAULT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22367) Transaction type not retrieved from OpenTxnRequest

2019-10-23 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957970#comment-16957970
 ] 

Hive QA commented on HIVE-22367:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983825/HIVE-22367.4.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17517 tests 
executed
*Failed tests:*
{noformat}
TestMiniLlapLocalCliDriver - did not produce a TEST-*.xml file (likely timed 
out) (batchId=179)

[auto_sortmerge_join_13.q,vector_left_outer_join2.q,schema_evol_text_vecrow_part_all_primitive.q,constprog_semijoin.q,update_where_partitioned.q,vectorized_multi_output_select.q,vector_retry_failure.q,schema_evol_orc_vec_part_llap_io.q,smb_mapjoin_14.q,skiphf_aggr.q,vectorized_ptf.q,materialized_view_partitioned_3.q,vector_char_cast.q,join_reordering_no_stats.q,insert_orig_table.q,join_filters.q,subquery_in.q,auto_sortmerge_join_4.q,bucket_many.q,vectorization_15.q,union7.q,materialized_view_rewrite_9.q,vectorization_nested_udf.q,vector_list_constant.q,vector_groupby_3.q,insert_values_orig_table_use_metadata.q,vector_mr_diff_schema_alias.q,vector_mapjoin_complex_values.q,materialized_view_distribute_sort.q,reduce_deduplicate_extended.q]
org.apache.hadoop.hive.metastore.TestPartitionManagement.testPartitionDiscoveryTransactionalTable
 (batchId=223)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19126/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19126/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19126/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12983825 - PreCommit-HIVE-Build

> Transaction type not retrieved from OpenTxnRequest
> --
>
> Key: HIVE-22367
> URL: https://issues.apache.org/jira/browse/HIVE-22367
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22367.1.patch, HIVE-22367.2.patch, 
> HIVE-22367.3.patch, HIVE-22367.4.patch
>
>
> When opening a transaction, its type should be extracted from OpenTxnRequest 
> object. Currently it's hardcoded with TxnType.DEFAULT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22367) Transaction type not retrieved from OpenTxnRequest

2019-10-23 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957899#comment-16957899
 ] 

Hive QA commented on HIVE-22367:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
32s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 
16s{color} | {color:blue} standalone-metastore/metastore-server in master has 
171 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 14m 36s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19126/dev-support/hive-personality.sh
 |
| git revision | master / f1e59e9 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: standalone-metastore/metastore-server U: 
standalone-metastore/metastore-server |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19126/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Transaction type not retrieved from OpenTxnRequest
> --
>
> Key: HIVE-22367
> URL: https://issues.apache.org/jira/browse/HIVE-22367
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22367.1.patch, HIVE-22367.2.patch, 
> HIVE-22367.3.patch, HIVE-22367.4.patch
>
>
> When opening a transaction, its type should be extracted from OpenTxnRequest 
> object. Currently it's hardcoded with TxnType.DEFAULT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22367) Transaction type not retrieved from OpenTxnRequest

2019-10-22 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957422#comment-16957422
 ] 

Hive QA commented on HIVE-22367:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983738/HIVE-22367.3.patch

{color:red}ERROR:{color} -1 due to build exiting with an error

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19113/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19113/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19113/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Tests exited with: Exception: Patch URL 
https://issues.apache.org/jira/secure/attachment/12983738/HIVE-22367.3.patch 
was found in seen patch url's cache and a test was probably run already on it. 
Aborting...
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12983738 - PreCommit-HIVE-Build

> Transaction type not retrieved from OpenTxnRequest
> --
>
> Key: HIVE-22367
> URL: https://issues.apache.org/jira/browse/HIVE-22367
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22367.1.patch, HIVE-22367.2.patch, 
> HIVE-22367.3.patch
>
>
> When opening a transaction, its type should be extracted from OpenTxnRequest 
> object. Currently it's hardcoded with TxnType.DEFAULT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22367) Transaction type not retrieved from OpenTxnRequest

2019-10-22 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957199#comment-16957199
 ] 

Hive QA commented on HIVE-22367:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983738/HIVE-22367.3.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17531 tests 
executed
*Failed tests:*
{noformat}
TestMiniLlapCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=157)

[unionDistinct_1.q,table_nonprintable.q,file_with_header_footer_aggregation.q,vector_offset_limit.q,orc_llap_counters1.q,mm_cttas.q,whroot_external1.q,global_limit.q,rcfile_createas1.q,dynamic_partition_pruning_2.q,intersect_merge.q,results_cache_diff_fs.q,cttl.q,parallel_colstats.q,load_hdfs_file_with_space_in_the_name.q]
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[hybridgrace_hashjoin_2]
 (batchId=111)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19107/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19107/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19107/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12983738 - PreCommit-HIVE-Build

> Transaction type not retrieved from OpenTxnRequest
> --
>
> Key: HIVE-22367
> URL: https://issues.apache.org/jira/browse/HIVE-22367
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22367.1.patch, HIVE-22367.2.patch, 
> HIVE-22367.3.patch
>
>
> When opening a transaction, its type should be extracted from OpenTxnRequest 
> object. Currently it's hardcoded with TxnType.DEFAULT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22367) Transaction type not retrieved from OpenTxnRequest

2019-10-22 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957153#comment-16957153
 ] 

Hive QA commented on HIVE-22367:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
36s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 
13s{color} | {color:blue} standalone-metastore/metastore-server in master has 
171 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
20s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
16s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 52s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19107/dev-support/hive-personality.sh
 |
| git revision | master / f1e59e9 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: standalone-metastore/metastore-server U: 
standalone-metastore/metastore-server |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19107/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Transaction type not retrieved from OpenTxnRequest
> --
>
> Key: HIVE-22367
> URL: https://issues.apache.org/jira/browse/HIVE-22367
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22367.1.patch, HIVE-22367.2.patch, 
> HIVE-22367.3.patch
>
>
> When opening a transaction, its type should be extracted from OpenTxnRequest 
> object. Currently it's hardcoded with TxnType.DEFAULT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22367) Transaction type not retrieved from OpenTxnRequest

2019-10-22 Thread Peter Vary (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957079#comment-16957079
 ] 

Peter Vary commented on HIVE-22367:
---

I tend to think about HMS as a separate entity, which can be used by other 
components, so I think setting these defaults makes sense on HMS side as well.

> Transaction type not retrieved from OpenTxnRequest
> --
>
> Key: HIVE-22367
> URL: https://issues.apache.org/jira/browse/HIVE-22367
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22367.1.patch, HIVE-22367.2.patch
>
>
> When opening a transaction, its type should be extracted from OpenTxnRequest 
> object. Currently it's hardcoded with TxnType.DEFAULT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22367) Transaction type not retrieved from OpenTxnRequest

2019-10-22 Thread Denys Kuzmenko (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957066#comment-16957066
 ] 

Denys Kuzmenko commented on HIVE-22367:
---

It's set to DEFAULT in Driver: private TxnType queryTxnType = TxnType.DEFAULT;
However I'll add the check, just in case.

> Transaction type not retrieved from OpenTxnRequest
> --
>
> Key: HIVE-22367
> URL: https://issues.apache.org/jira/browse/HIVE-22367
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22367.1.patch, HIVE-22367.2.patch
>
>
> When opening a transaction, its type should be extracted from OpenTxnRequest 
> object. Currently it's hardcoded with TxnType.DEFAULT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22367) Transaction type not retrieved from OpenTxnRequest

2019-10-22 Thread Peter Vary (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957053#comment-16957053
 ] 

Peter Vary commented on HIVE-22367:
---

What happens, if the value is not set in the request. Maybe we should fall back 
to DEFAULT? 

Thanks, Peter 

> Transaction type not retrieved from OpenTxnRequest
> --
>
> Key: HIVE-22367
> URL: https://issues.apache.org/jira/browse/HIVE-22367
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22367.1.patch, HIVE-22367.2.patch
>
>
> When opening a transaction, its type should be extracted from OpenTxnRequest 
> object. Currently it's hardcoded with TxnType.DEFAULT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22367) Transaction type not retrieved from OpenTxnRequest

2019-10-22 Thread Denys Kuzmenko (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957010#comment-16957010
 ] 

Denys Kuzmenko commented on HIVE-22367:
---

[~ashutosh.bapat], [~pvary] could you please take a look. Thanks!

> Transaction type not retrieved from OpenTxnRequest
> --
>
> Key: HIVE-22367
> URL: https://issues.apache.org/jira/browse/HIVE-22367
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22367.1.patch, HIVE-22367.2.patch
>
>
> When opening a transaction, its type should be extracted from OpenTxnRequest 
> object. Currently it's hardcoded with TxnType.DEFAULT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22367) Transaction type not retrieved from OpenTxnRequest

2019-10-21 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956371#comment-16956371
 ] 

Hive QA commented on HIVE-22367:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12983611/HIVE-22367.1.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17546 tests 
executed
*Failed tests:*
{noformat}
org.apache.hive.jdbc.authorization.TestJdbcWithSQLAuthUDFBlacklist.testBlackListedUdfUsage
 (batchId=287)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/19090/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19090/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19090/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12983611 - PreCommit-HIVE-Build

> Transaction type not retrieved from OpenTxnRequest
> --
>
> Key: HIVE-22367
> URL: https://issues.apache.org/jira/browse/HIVE-22367
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22367.1.patch
>
>
> When opening a transaction, its type should be extracted from OpenTxnRequest 
> object. Currently it's hardcoded with TxnType.DEFAULT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22367) Transaction type not retrieved from OpenTxnRequest

2019-10-21 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956313#comment-16956313
 ] 

Hive QA commented on HIVE-22367:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
24s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 
20s{color} | {color:blue} standalone-metastore/metastore-server in master has 
171 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
29s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  1m 
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
21s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 15m 21s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19090/dev-support/hive-personality.sh
 |
| git revision | master / c9850b4 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| modules | C: standalone-metastore/metastore-server U: 
standalone-metastore/metastore-server |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-19090/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Transaction type not retrieved from OpenTxnRequest
> --
>
> Key: HIVE-22367
> URL: https://issues.apache.org/jira/browse/HIVE-22367
> Project: Hive
>  Issue Type: Bug
>  Components: Transactions
>Reporter: Denys Kuzmenko
>Assignee: Denys Kuzmenko
>Priority: Major
> Attachments: HIVE-22367.1.patch
>
>
> When opening a transaction, its type should be extracted from OpenTxnRequest 
> object. Currently it's hardcoded with TxnType.DEFAULT.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)