[jira] [Commented] (HIVE-22511) Fix case of Month token in datetime to string conversion
[
https://issues.apache.org/jira/browse/HIVE-22511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980044#comment-16980044
]
Marta Kuczora commented on HIVE-22511:
--
Pushed to master. Thanks again [~klcopp].
> Fix case of Month token in datetime to string conversion
>
>
> Key: HIVE-22511
> URL: https://issues.apache.org/jira/browse/HIVE-22511
> Project: Hive
> Issue Type: Bug
>Reporter: Gabor Kaszab
>Assignee: Karen Coppage
>Priority: Major
> Attachments: HIVE-22511.01.patch
>
>
> Currently Hive doesn't allow month tokens with weird spelling like 'MONth',
> 'mONTH' etc. However, Oracle does and Hive should follow that approach.
> The rules:
> - If the first letter is lowercase then the output is lowercase: 'mONTH' ->
> 'may'
> - If the first two letters are uppercase then the output is uppercase:
> 'MOnth' -> 'MAY'
> - If the first letter is uppercase and the second is lowercase then the
> output is capitalized: 'Month' -> 'May'.
> Oracle:
> {code:java}
> select to_char(to_timestamp('2019-05-10', '-MM-DD'), 'MOnth') from
> DUAL;
> MAY 2019
> select to_char(to_timestamp('2019-05-10', '-MM-DD'), 'mONTH') from
> DUAL;
> may 2019
> select to_char(to_timestamp('2019-05-10', '-MM-DD'), 'MoNTH') from
> DUAL;
> May 2019
> {code}
> Please check the same for 'Name of the day' tokens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22511) Fix case of Month token in datetime to string conversion
[
https://issues.apache.org/jira/browse/HIVE-22511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979103#comment-16979103
]
Marta Kuczora commented on HIVE-22511:
--
+1
Thanks [~klcopp] for the patch.
> Fix case of Month token in datetime to string conversion
>
>
> Key: HIVE-22511
> URL: https://issues.apache.org/jira/browse/HIVE-22511
> Project: Hive
> Issue Type: Bug
>Reporter: Gabor Kaszab
>Assignee: Karen Coppage
>Priority: Major
> Attachments: HIVE-22511.01.patch
>
>
> Currently Hive doesn't allow month tokens with weird spelling like 'MONth',
> 'mONTH' etc. However, Oracle does and Hive should follow that approach.
> The rules:
> - If the first letter is lowercase then the output is lowercase: 'mONTH' ->
> 'may'
> - If the first two letters are uppercase then the output is uppercase:
> 'MOnth' -> 'MAY'
> - If the first letter is uppercase and the second is lowercase then the
> output is capitalized: 'Month' -> 'May'.
> Oracle:
> {code:java}
> select to_char(to_timestamp('2019-05-10', '-MM-DD'), 'MOnth') from
> DUAL;
> MAY 2019
> select to_char(to_timestamp('2019-05-10', '-MM-DD'), 'mONTH') from
> DUAL;
> may 2019
> select to_char(to_timestamp('2019-05-10', '-MM-DD'), 'MoNTH') from
> DUAL;
> May 2019
> {code}
> Please check the same for 'Name of the day' tokens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22511) Fix case of Month token in datetime to string conversion
[
https://issues.apache.org/jira/browse/HIVE-22511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978807#comment-16978807
]
Hive QA commented on HIVE-22511:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12986347/HIVE-22511.01.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17709 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19516/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19516/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19516/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12986347 - PreCommit-HIVE-Build
> Fix case of Month token in datetime to string conversion
>
>
> Key: HIVE-22511
> URL: https://issues.apache.org/jira/browse/HIVE-22511
> Project: Hive
> Issue Type: Bug
>Reporter: Gabor Kaszab
>Assignee: Karen Coppage
>Priority: Major
> Attachments: HIVE-22511.01.patch
>
>
> Currently Hive doesn't allow month tokens with weird spelling like 'MONth',
> 'mONTH' etc. However, Oracle does and Hive should follow that approach.
> The rules:
> - If the first letter is lowercase then the output is lowercase: 'mONTH' ->
> 'may'
> - If the first two letters are uppercase then the output is uppercase:
> 'MOnth' -> 'MAY'
> - If the first letter is uppercase and the second is lowercase then the
> output is capitalized: 'Month' -> 'May'.
> Oracle:
> {code:java}
> select to_char(to_timestamp('2019-05-10', '-MM-DD'), 'MOnth') from
> DUAL;
> MAY 2019
> select to_char(to_timestamp('2019-05-10', '-MM-DD'), 'mONTH') from
> DUAL;
> may 2019
> select to_char(to_timestamp('2019-05-10', '-MM-DD'), 'MoNTH') from
> DUAL;
> May 2019
> {code}
> Please check the same for 'Name of the day' tokens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22511) Fix case of Month token in datetime to string conversion
[
https://issues.apache.org/jira/browse/HIVE-22511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978771#comment-16978771
]
Hive QA commented on HIVE-22511:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
43s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
36s{color} | {color:blue} common in master has 65 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
15s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
16s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 13m 36s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19516/dev-support/hive-personality.sh
|
| git revision | master / df8e185 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: common U: common |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19516/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Fix case of Month token in datetime to string conversion
>
>
> Key: HIVE-22511
> URL: https://issues.apache.org/jira/browse/HIVE-22511
> Project: Hive
> Issue Type: Bug
>Reporter: Gabor Kaszab
>Assignee: Karen Coppage
>Priority: Major
> Attachments: HIVE-22511.01.patch
>
>
> Currently Hive doesn't allow month tokens with weird spelling like 'MONth',
> 'mONTH' etc. However, Oracle does and Hive should follow that approach.
> The rules:
> - If the first letter is lowercase then the output is lowercase: 'mONTH' ->
> 'may'
> - If the first two letters are uppercase then the output is uppercase:
> 'MOnth' -> 'MAY'
> - If the first letter is uppercase and the second is lowercase then the
> output is capitalized: 'Month' -> 'May'.
> Oracle:
> {code:java}
> select to_char(to_timestamp('2019-05-10', '-MM-DD'), 'MOnth') from
> DUAL;
> MAY 2019
> select to_char(to_timestamp('2019-05-10', '-MM-DD'), 'mONTH') from
> DUAL;
> may 2019
> select to_char(to_timestamp('2019-05-10', '-MM-DD'), 'MoNTH') from
> DUAL;
> May 2019
> {code}
> Please check the same for 'Name of the day' tokens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22511) Fix case of Month token in datetime to string conversion
[
https://issues.apache.org/jira/browse/HIVE-22511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16977366#comment-16977366
]
Gabor Kaszab commented on HIVE-22511:
-
[~klcopp]
> Fix case of Month token in datetime to string conversion
>
>
> Key: HIVE-22511
> URL: https://issues.apache.org/jira/browse/HIVE-22511
> Project: Hive
> Issue Type: Bug
>Reporter: Gabor Kaszab
>Priority: Major
>
> Currently Hive doesn't allow month tokens with weird spelling like 'MONth',
> 'mONTH' etc. However, Oracle does and Hive should follow that approach.
> The rules:
> - If the first letter is lowercase then the output is lowercase: 'mONTH' ->
> 'may'
> - If the first two letters are uppercase then the output is uppercase:
> 'MOnth' -> 'MAY'
> - If the first letter is uppercase and the second is lowercase then the
> output is capitalized: 'Month' -> 'May'.
> Oracle:
> {code:java}
> select to_char(to_timestamp('2019-05-10', '-MM-DD'), 'MOnth') from
> DUAL;
> MAY 2019
> select to_char(to_timestamp('2019-05-10', '-MM-DD'), 'mONTH') from
> DUAL;
> may 2019
> select to_char(to_timestamp('2019-05-10', '-MM-DD'), 'MoNTH') from
> DUAL;
> May 2019
> {code}
> Please check the same for 'Name of the day' tokens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
