[jira] [Commented] (HIVE-22535) ACID: Check for already running compactions in Worker
[ https://issues.apache.org/jira/browse/HIVE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008729#comment-17008729 ] Laszlo Pinter commented on HIVE-22535: -- Meanwhile it turned out, that CompactionTxnHandler#findNextToCompact() already does this check, therefore I'm closing this jira. > ACID: Check for already running compactions in Worker > -- > > Key: HIVE-22535 > URL: https://issues.apache.org/jira/browse/HIVE-22535 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-22535.01.patch, HIVE-22535.02.patch > > > Compactor worker doesn't check if a compaction is already running for a given > resource. Initiator does this, but in case of manual compaction, this check > is missing. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22535) ACID: Check for already running compactions in Worker
[
https://issues.apache.org/jira/browse/HIVE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007728#comment-17007728
]
Hive QA commented on HIVE-22535:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12989894/HIVE-22535.02.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 172 failed/errored test(s), 17788 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.metastore.client.TestDropPartitions.otherCatalog[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionArchivedPartition[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionBogusCatalog[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameBogusCatalog[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameEmptyName[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameInvalidNameFormat[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameInvalidNameNoValues[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameInvalidName[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameLessValue[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameMoreValue[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameNonExistingDB[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameNonExistingPart[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameNonExistingTable[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByNameNullName[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionByName[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionDeleteDataAndPurgeExternalTable[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionDeleteDataAndPurge[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionDeleteDataNoPurge[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionDeleteDataPurge[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionDeleteData[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionDeleteParentDir[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionEmptyDB[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionEmptyPartVals[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionEmptyTable[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionEmptyVal[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionExternalTable[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionLessValsInList[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionMoreValsInList[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNonExistingDB[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNonExistingPartVals[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNonExistingTable[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNotDeleteDataPurge[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNotDeleteData[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNullDB[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNullPartDropOptions[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNullPartVals[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNullTable[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestDropPartitions.testDropPartitionNullVal[Remote]
(batchId=225)
[jira] [Commented] (HIVE-22535) ACID: Check for already running compactions in Worker
[
https://issues.apache.org/jira/browse/HIVE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007701#comment-17007701
]
Hive QA commented on HIVE-22535:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
5s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s{color} | {color:green} ql: The patch generated 0 new + 54 unchanged - 4
fixed = 54 total (was 58) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
13s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 6s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20070/dev-support/hive-personality.sh
|
| git revision | master / d981e8d |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20070/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> ACID: Check for already running compactions in Worker
> --
>
> Key: HIVE-22535
> URL: https://issues.apache.org/jira/browse/HIVE-22535
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-22535.01.patch, HIVE-22535.02.patch
>
>
> Compactor worker doesn't check if a compaction is already running for a given
> resource. Initiator does this, but in case of manual compaction, this check
> is missing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22535) ACID: Check for already running compactions in Worker
[
https://issues.apache.org/jira/browse/HIVE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007517#comment-17007517
]
Hive QA commented on HIVE-22535:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12989873/HIVE-22535.01.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 150 failed/errored test(s), 17788 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.catalogPatternsDontWork[Embedded]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.catalogPatternsDontWork[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.noSuchCatalog[Embedded]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.noSuchCatalog[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.tablesInDifferentCatalog[Embedded]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.tablesInDifferentCatalog[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaCaseSensitive[Embedded]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaCaseSensitive[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaNullNoDbNoTbl[Embedded]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaNullNoDbNoTbl[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaNullOrEmptyDb[Embedded]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaNullOrEmptyDb[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaNullOrEmptyTbl[Embedded]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaNullOrEmptyTbl[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaNullOrEmptyTypes[Embedded]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMetaNullOrEmptyTypes[Remote]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMeta[Embedded]
(batchId=225)
org.apache.hadoop.hive.metastore.client.TestGetTableMeta.testGetTableMeta[Remote]
(batchId=225)
org.apache.hadoop.hive.ql.TestAcidOnTez.testInsertWithRemoveUnion (batchId=248)
org.apache.hadoop.hive.ql.TestAcidOnTez.testMapJoinOnMR (batchId=248)
org.apache.hadoop.hive.ql.TestAcidOnTez.testMapJoinOnTez (batchId=248)
org.apache.hadoop.hive.ql.TestAcidOnTez.testMergeJoinOnMR (batchId=248)
org.apache.hadoop.hive.ql.TestAcidOnTez.testMergeJoinOnTez (batchId=248)
org.apache.hadoop.hive.ql.TestTxnCommands.testNonAcidToAcidConversion01
(batchId=356)
org.apache.hadoop.hive.ql.TestTxnCommands.testVersioning (batchId=356)
org.apache.hadoop.hive.ql.TestTxnCommands2.testACIDwithSchemaEvolutionAndCompaction
(batchId=337)
org.apache.hadoop.hive.ql.TestTxnCommands2.testCleanerForTxnToWriteId
(batchId=337)
org.apache.hadoop.hive.ql.TestTxnCommands2.testCompactWithDelete (batchId=337)
org.apache.hadoop.hive.ql.TestTxnCommands2.testEmptyInTblproperties
(batchId=337)
org.apache.hadoop.hive.ql.TestTxnCommands2.testInitiatorWithMultipleFailedCompactions
(batchId=337)
org.apache.hadoop.hive.ql.TestTxnCommands2.testInsertOverwrite1 (batchId=337)
org.apache.hadoop.hive.ql.TestTxnCommands2.testInsertOverwrite2 (batchId=337)
org.apache.hadoop.hive.ql.TestTxnCommands2.testMmTableCompaction (batchId=337)
org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion02
(batchId=337)
org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion1
(batchId=337)
org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion2
(batchId=337)
org.apache.hadoop.hive.ql.TestTxnCommands2.testNonAcidToAcidConversion3
(batchId=337)
org.apache.hadoop.hive.ql.TestTxnCommands2.testOriginalFileReaderWhenNonAcidConvertedToAcid
(batchId=337)
org.apache.hadoop.hive.ql.TestTxnCommands2.writeBetweenWorkerAndCleaner
(batchId=337)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testACIDwithSchemaEvolutionAndCompaction
(batchId=351)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testCleanerForTxnToWriteId
(batchId=351)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testCompactWithDelete
(batchId=351)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testEmptyInTblproperties
(batchId=351)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testInitiatorWithMultipleFailedCompactions
(batchId=351)
org.apache.hadoop.hive.ql.TestTxnCommands2WithSplitUpdateAndVectorization.testInsertOverwrite1
(batchId=351)
[jira] [Commented] (HIVE-22535) ACID: Check for already running compactions in Worker
[
https://issues.apache.org/jira/browse/HIVE-22535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007485#comment-17007485
]
Hive QA commented on HIVE-22535:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
49s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
38s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
5s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
58s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
37s{color} | {color:green} ql: The patch generated 0 new + 54 unchanged - 4
fixed = 54 total (was 58) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m
13s{color} | {color:red} ql generated 1 new + 1530 unchanged - 1 fixed = 1531
total (was 1531) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 34s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:ql |
| | ci could be null and is guaranteed to be dereferenced in
org.apache.hadoop.hive.ql.txn.compactor.Worker.run() Method invoked at
Worker.java:is guaranteed to be dereferenced in
org.apache.hadoop.hive.ql.txn.compactor.Worker.run() Method invoked at
Worker.java:[line 124] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20065/dev-support/hive-personality.sh
|
| git revision | master / 01faca2 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| findbugs |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20065/yetus/new-findbugs-ql.html
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-20065/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> ACID: Check for already running compactions in Worker
> --
>
> Key: HIVE-22535
> URL: https://issues.apache.org/jira/browse/HIVE-22535
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-22535.01.patch
>
>
> Compactor worker doesn't check if a compaction is already running for a given
> resource. Initiator does this, but in case of manual compaction, this check
> is missing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
