[jira] [Commented] (HIVE-22599) Query results cache: 733 permissions check is not necessary
[
https://issues.apache.org/jira/browse/HIVE-22599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995423#comment-16995423
]
Gopal Vijayaraghavan commented on HIVE-22599:
-
LGTM - +1
> Query results cache: 733 permissions check is not necessary
> ---
>
> Key: HIVE-22599
> URL: https://issues.apache.org/jira/browse/HIVE-22599
> Project: Hive
> Issue Type: Bug
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-22599.1.patch
>
>
> The query results cache initialization makes a call to
> Utilties.ensurePathIsWritable(), which checks the results cache directory for
> 733 permissions (default cache dir is
> {{/tmp/hive/_resultscache_).}}
> The 733 permissions (at least the 033 part) are not actually necessary - we
> actually don't really want the results cache directory to be world-writable,
> and the subdirectories we create within this one are actually done with 700
> perms. So I think the call to Utilties.ensurePathIsWritable() can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22599) Query results cache: 733 permissions check is not necessary
[
https://issues.apache.org/jira/browse/HIVE-22599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993059#comment-16993059
]
Jason Dere commented on HIVE-22599:
---
[~gopalv], do you mind reviewing this small change?
> Query results cache: 733 permissions check is not necessary
> ---
>
> Key: HIVE-22599
> URL: https://issues.apache.org/jira/browse/HIVE-22599
> Project: Hive
> Issue Type: Bug
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-22599.1.patch
>
>
> The query results cache initialization makes a call to
> Utilties.ensurePathIsWritable(), which checks the results cache directory for
> 733 permissions (default cache dir is
> {{/tmp/hive/_resultscache_).}}
> The 733 permissions (at least the 033 part) are not actually necessary - we
> actually don't really want the results cache directory to be world-writable,
> and the subdirectories we create within this one are actually done with 700
> perms. So I think the call to Utilties.ensurePathIsWritable() can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22599) Query results cache: 733 permissions check is not necessary
[
https://issues.apache.org/jira/browse/HIVE-22599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993056#comment-16993056
]
Hive QA commented on HIVE-22599:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988465/HIVE-22599.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 17762 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19860/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19860/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19860/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12988465 - PreCommit-HIVE-Build
> Query results cache: 733 permissions check is not necessary
> ---
>
> Key: HIVE-22599
> URL: https://issues.apache.org/jira/browse/HIVE-22599
> Project: Hive
> Issue Type: Bug
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-22599.1.patch
>
>
> The query results cache initialization makes a call to
> Utilties.ensurePathIsWritable(), which checks the results cache directory for
> 733 permissions (default cache dir is
> {{/tmp/hive/_resultscache_).}}
> The 733 permissions (at least the 033 part) are not actually necessary - we
> actually don't really want the results cache directory to be world-writable,
> and the subdirectories we create within this one are actually done with 700
> perms. So I think the call to Utilties.ensurePathIsWritable() can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22599) Query results cache: 733 permissions check is not necessary
[
https://issues.apache.org/jira/browse/HIVE-22599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16993036#comment-16993036
]
Hive QA commented on HIVE-22599:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m
27s{color} | {color:blue} ql in master has 1532 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
8s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
48s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
7s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m
15s{color} | {color:red} The patch generated 1 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 28m 28s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19860/dev-support/hive-personality.sh
|
| git revision | master / 22e298c |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| asflicense |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19860/yetus/patch-asflicense-problems.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19860/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Query results cache: 733 permissions check is not necessary
> ---
>
> Key: HIVE-22599
> URL: https://issues.apache.org/jira/browse/HIVE-22599
> Project: Hive
> Issue Type: Bug
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-22599.1.patch
>
>
> The query results cache initialization makes a call to
> Utilties.ensurePathIsWritable(), which checks the results cache directory for
> 733 permissions (default cache dir is
> {{/tmp/hive/_resultscache_).}}
> The 733 permissions (at least the 033 part) are not actually necessary - we
> actually don't really want the results cache directory to be world-writable,
> and the subdirectories we create within this one are actually done with 700
> perms. So I think the call to Utilties.ensurePathIsWritable() can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22599) Query results cache: 733 permissions check is not necessary
[
https://issues.apache.org/jira/browse/HIVE-22599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991227#comment-16991227
]
Hive QA commented on HIVE-22599:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12988285/HIVE-22599.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 17758 tests
executed
*Failed tests:*
{noformat}
TestStatsReplicationScenariosACIDNoAutogather - did not produce a TEST-*.xml
file (likely timed out) (batchId=257)
org.apache.hadoop.hive.ql.TestMTQueries.testMTQueries1 (batchId=276)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/19828/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19828/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19828/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12988285 - PreCommit-HIVE-Build
> Query results cache: 733 permissions check is not necessary
> ---
>
> Key: HIVE-22599
> URL: https://issues.apache.org/jira/browse/HIVE-22599
> Project: Hive
> Issue Type: Bug
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-22599.1.patch
>
>
> The query results cache initialization makes a call to
> Utilties.ensurePathIsWritable(), which checks the results cache directory for
> 733 permissions (default cache dir is
> {{/tmp/hive/_resultscache_).}}
> The 733 permissions (at least the 033 part) are not actually necessary - we
> actually don't really want the results cache directory to be world-writable,
> and the subdirectories we create within this one are actually done with 700
> perms. So I think the call to Utilties.ensurePathIsWritable() can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-22599) Query results cache: 733 permissions check is not necessary
[
https://issues.apache.org/jira/browse/HIVE-22599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991206#comment-16991206
]
Hive QA commented on HIVE-22599:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
39s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
58s{color} | {color:blue} ql in master has 1532 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
0s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
9s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m
3s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 23s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-19828/dev-support/hive-personality.sh
|
| git revision | master / a245e79 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-19828/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Query results cache: 733 permissions check is not necessary
> ---
>
> Key: HIVE-22599
> URL: https://issues.apache.org/jira/browse/HIVE-22599
> Project: Hive
> Issue Type: Bug
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-22599.1.patch
>
>
> The query results cache initialization makes a call to
> Utilties.ensurePathIsWritable(), which checks the results cache directory for
> 733 permissions (default cache dir is
> {{/tmp/hive/_resultscache_).}}
> The 733 permissions (at least the 033 part) are not actually necessary - we
> actually don't really want the results cache directory to be world-writable,
> and the subdirectories we create within this one are actually done with 700
> perms. So I think the call to Utilties.ensurePathIsWritable() can be removed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
