[jira] [Commented] (HIVE-22700) Compactions may leak memory when unauthorized

2020-01-07 Thread Peter Vary (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009814#comment-17009814
 ] 

Peter Vary commented on HIVE-22700:
---

+1

> Compactions may leak memory when unauthorized
> -
>
> Key: HIVE-22700
> URL: https://issues.apache.org/jira/browse/HIVE-22700
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-22700.01.patch
>
>
> Initiator class determines compaction type periodically. Initiator either 
> runs as hive user or impersonates the owner of the table. When impersonation 
> is used, Initiator#checkForCompaction may leak memory. If impersonation 
> (ugi.doAs()) call fails, FileSystem.closeAllForUGI does not run, therefore 
> does not clean the file system cache.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22700) Compactions may leak memory when unauthorized

2020-01-07 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009787#comment-17009787
 ] 

Hive QA commented on HIVE-22700:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12990086/HIVE-22700.01.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:green}SUCCESS:{color} +1 due to 17852 tests passed

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/20096/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20096/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20096/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12990086 - PreCommit-HIVE-Build

> Compactions may leak memory when unauthorized
> -
>
> Key: HIVE-22700
> URL: https://issues.apache.org/jira/browse/HIVE-22700
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-22700.01.patch
>
>
> Initiator class determines compaction type periodically. Initiator either 
> runs as hive user or impersonates the owner of the table. When impersonation 
> is used, Initiator#checkForCompaction may leak memory. If impersonation 
> (ugi.doAs()) call fails, FileSystem.closeAllForUGI does not run, therefore 
> does not clean the file system cache.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (HIVE-22700) Compactions may leak memory when unauthorized

2020-01-07 Thread Hive QA (Jira)


[ 
https://issues.apache.org/jira/browse/HIVE-22700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17009737#comment-17009737
 ] 

Hive QA commented on HIVE-22700:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  9m 
 8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
11s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
40s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m  
6s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
0s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
30s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m  
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m  
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m  
4s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 25m 27s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-20096/dev-support/hive-personality.sh
 |
| git revision | master / 47b22ce |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: ql U: ql |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-20096/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Compactions may leak memory when unauthorized
> -
>
> Key: HIVE-22700
> URL: https://issues.apache.org/jira/browse/HIVE-22700
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Attachments: HIVE-22700.01.patch
>
>
> Initiator class determines compaction type periodically. Initiator either 
> runs as hive user or impersonates the owner of the table. When impersonation 
> is used, Initiator#checkForCompaction may leak memory. If impersonation 
> (ugi.doAs()) call fails, FileSystem.closeAllForUGI does not run, therefore 
> does not clean the file system cache.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)