[jira] [Commented] (HIVE-22795) Create new parser and udf module from ql
[ https://issues.apache.org/jira/browse/HIVE-22795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17029137#comment-17029137 ] Vineet Garg commented on HIVE-22795: I went over it and it looks good to me. +1 > Create new parser and udf module from ql > > > Key: HIVE-22795 > URL: https://issues.apache.org/jira/browse/HIVE-22795 > Project: Hive > Issue Type: Improvement > Components: Build Infrastructure >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-22795.01.patch, HIVE-22795.02.patch, > HIVE-22795.03.patch, HIVE-22795.patch > > > ql is a huge module. I propose to start splitting it by creating new module > `parser` and `udf` to encapsulate some classes related to SQL parsing and UDF > declaration, respectively. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22795) Create new parser and udf module from ql
[ https://issues.apache.org/jira/browse/HIVE-22795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027828#comment-17027828 ] Jesus Camacho Rodriguez commented on HIVE-22795: https://github.com/apache/hive/pull/891 I am not sure why it was not linked. > Create new parser and udf module from ql > > > Key: HIVE-22795 > URL: https://issues.apache.org/jira/browse/HIVE-22795 > Project: Hive > Issue Type: Improvement > Components: Build Infrastructure >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-22795.01.patch, HIVE-22795.02.patch, > HIVE-22795.03.patch, HIVE-22795.patch > > > ql is a huge module. I propose to start splitting it by creating new module > `parser` and `udf` to encapsulate some classes related to SQL parsing and UDF > declaration, respectively. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22795) Create new parser and udf module from ql
[ https://issues.apache.org/jira/browse/HIVE-22795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027776#comment-17027776 ] Vineet Garg commented on HIVE-22795: [~jcamachorodriguez] Can you create pull request for this? > Create new parser and udf module from ql > > > Key: HIVE-22795 > URL: https://issues.apache.org/jira/browse/HIVE-22795 > Project: Hive > Issue Type: Improvement > Components: Build Infrastructure >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-22795.01.patch, HIVE-22795.02.patch, > HIVE-22795.03.patch, HIVE-22795.patch > > > ql is a huge module. I propose to start splitting it by creating new module > `parser` and `udf` to encapsulate some classes related to SQL parsing and UDF > declaration, respectively. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22795) Create new parser and udf module from ql
[ https://issues.apache.org/jira/browse/HIVE-22795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027212#comment-17027212 ] Hive QA commented on HIVE-22795: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 25s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 13s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m 39s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 31s{color} | {color:blue} common in master has 63 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 58s{color} | {color:blue} ql in master has 1537 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 30s{color} | {color:blue} accumulo-handler in master has 20 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 21s{color} | {color:blue} kudu-handler in master has 1 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m 36s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 24s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 33s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 9m 33s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s{color} | {color:red} common: The patch generated 27 new + 0 unchanged - 0 fixed = 27 total (was 0) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 9s{color} | {color:red} parser: The patch generated 32 new + 0 unchanged - 0 fixed = 32 total (was 0) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 8s{color} | {color:red} udf: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 4s{color} | {color:red} ql: The patch generated 60 new + 2985 unchanged - 165 fixed = 3045 total (was 3150) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} accumulo-handler: The patch generated 0 new + 55 unchanged - 14 fixed = 55 total (was 69) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 8s{color} | {color:green} The patch kudu-handler passed checkstyle {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 13s{color} | {color:red} root: The patch generated 109 new + 3060 unchanged - 159 fixed = 3169 total (was 3219) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} The patch qtest-accumulo passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} The patch qtest-kudu passed checkstyle {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} The patch qtest-spark passed checkstyle {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 104 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 1s{color} | {color:red} The patch 46 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 9s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 40s{color} | {color:green} common in the patch passed. {color} | |
[jira] [Commented] (HIVE-22795) Create new parser and udf module from ql
[ https://issues.apache.org/jira/browse/HIVE-22795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027211#comment-17027211 ] Hive QA commented on HIVE-22795: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12992296/HIVE-22795.03.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/20420/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20420/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20420/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Tests exited with: Exception: Patch URL https://issues.apache.org/jira/secure/attachment/12992296/HIVE-22795.03.patch was found in seen patch url's cache and a test was probably run already on it. Aborting... {noformat} This message is automatically generated. ATTACHMENT ID: 12992296 - PreCommit-HIVE-Build > Create new parser and udf module from ql > > > Key: HIVE-22795 > URL: https://issues.apache.org/jira/browse/HIVE-22795 > Project: Hive > Issue Type: Improvement > Components: Build Infrastructure >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-22795.01.patch, HIVE-22795.02.patch, > HIVE-22795.03.patch, HIVE-22795.patch > > > ql is a huge module. I propose to start splitting it by creating new module > `parser` and `udf` to encapsulate some classes related to SQL parsing and UDF > declaration, respectively. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22795) Create new parser and udf module from ql
[ https://issues.apache.org/jira/browse/HIVE-22795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027209#comment-17027209 ] Hive QA commented on HIVE-22795: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12992296/HIVE-22795.03.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 17958 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/20419/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20419/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20419/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12992296 - PreCommit-HIVE-Build > Create new parser and udf module from ql > > > Key: HIVE-22795 > URL: https://issues.apache.org/jira/browse/HIVE-22795 > Project: Hive > Issue Type: Improvement > Components: Build Infrastructure >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-22795.01.patch, HIVE-22795.02.patch, > HIVE-22795.03.patch, HIVE-22795.patch > > > ql is a huge module. I propose to start splitting it by creating new module > `parser` and `udf` to encapsulate some classes related to SQL parsing and UDF > declaration, respectively. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22795) Create new parser and udf module from ql
[ https://issues.apache.org/jira/browse/HIVE-22795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027175#comment-17027175 ] Hive QA commented on HIVE-22795: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12992287/HIVE-22795.02.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 17952 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestAccumuloCliDriver.org.apache.hadoop.hive.cli.TestAccumuloCliDriver (batchId=295) org.apache.hadoop.hive.cli.TestKuduCliDriver.org.apache.hadoop.hive.cli.TestKuduCliDriver (batchId=294) org.apache.hadoop.hive.cli.TestKuduNegativeCliDriver.org.apache.hadoop.hive.cli.TestKuduNegativeCliDriver (batchId=294) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/20418/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20418/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20418/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12992287 - PreCommit-HIVE-Build > Create new parser and udf module from ql > > > Key: HIVE-22795 > URL: https://issues.apache.org/jira/browse/HIVE-22795 > Project: Hive > Issue Type: Improvement > Components: Build Infrastructure >Reporter: Jesus Camacho Rodriguez >Assignee: Jesus Camacho Rodriguez >Priority: Major > Attachments: HIVE-22795.01.patch, HIVE-22795.02.patch, > HIVE-22795.patch > > > ql is a huge module. I propose to start splitting it by creating new module > `parser` and `udf` to encapsulate some classes related to SQL parsing and UDF > declaration, respectively. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-22795) Create new parser and udf module from ql
[ https://issues.apache.org/jira/browse/HIVE-22795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027172#comment-17027172 ] Hive QA commented on HIVE-22795: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 22s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 33s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 9m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m 3s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 33s{color} | {color:blue} common in master has 63 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 56s{color} | {color:blue} ql in master has 1537 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 30s{color} | {color:blue} accumulo-handler in master has 20 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m 24s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 25s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 10m 8s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m 43s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 11s{color} | {color:red} common: The patch generated 27 new + 0 unchanged - 0 fixed = 27 total (was 0) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 9s{color} | {color:red} parser: The patch generated 32 new + 0 unchanged - 0 fixed = 32 total (was 0) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 8s{color} | {color:red} udf: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 6s{color} | {color:red} ql: The patch generated 60 new + 2985 unchanged - 165 fixed = 3045 total (was 3150) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} accumulo-handler: The patch generated 0 new + 55 unchanged - 14 fixed = 55 total (was 69) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 18s{color} | {color:red} root: The patch generated 109 new + 3060 unchanged - 159 fixed = 3169 total (was 3219) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 12s{color} | {color:green} The patch qtest-spark passed checkstyle {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 104 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 1s{color} | {color:red} The patch 46 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 5s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 40s{color} | {color:green} common in the patch passed. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 56s{color} | {color:green} parser in the patch passed. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 21s{color} | {color:green} udf in the patch passed. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 42s{color} | {color:green} ql generated 0 new + 1533 unchanged - 4 fixed = 1533 total (was 1537) {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 35s{color} | {color:green} accumulo-handler in the patch passed. {color} | | {color:red}-1{color} |
[jira] [Commented] (HIVE-22795) Create new parser and udf module from ql
[ https://issues.apache.org/jira/browse/HIVE-22795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027086#comment-17027086 ] Hive QA commented on HIVE-22795: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12992281/HIVE-22795.01.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 610 failed/errored test(s), 17958 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestHBaseNegativeCliDriver.testCliDriver[hbase_ddl] (batchId=301) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[alter_non_native] (batchId=105) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[add_part_multiple] (batchId=148) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[alter_merge_orc] (batchId=146) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[alter_merge_stats_orc] (batchId=134) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join0] (batchId=156) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join10] (batchId=132) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join11] (batchId=120) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join12] (batchId=127) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join13] (batchId=153) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join14] (batchId=122) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join15] (batchId=123) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join16] (batchId=134) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join17] (batchId=154) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join18] (batchId=121) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join18_multi_distinct] (batchId=128) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join19] (batchId=146) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join1] (batchId=152) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join20] (batchId=157) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join21] (batchId=154) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join22] (batchId=141) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join23] (batchId=124) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join24] (batchId=151) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join26] (batchId=122) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join27] (batchId=157) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join29] (batchId=141) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join2] (batchId=145) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join30] (batchId=130) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join31] (batchId=137) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join32] (batchId=155) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join3] (batchId=154) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join4] (batchId=148) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join5] (batchId=150) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join6] (batchId=155) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join7] (batchId=128) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join8] (batchId=155) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join9] (batchId=151) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join_filters] (batchId=143) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join_nulls] (batchId=147) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join_reordering_values] (batchId=119) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join_stats2] (batchId=156) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join_stats] (batchId=138) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_join_without_localtask] (batchId=116) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_smb_mapjoin_14] (batchId=143) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_sortmerge_join_12] (batchId=131) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_sortmerge_join_13] (batchId=145) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_sortmerge_join_14] (batchId=121) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_sortmerge_join_15] (batchId=121) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[auto_sortmerge_join_16]
[jira] [Commented] (HIVE-22795) Create new parser and udf module from ql
[ https://issues.apache.org/jira/browse/HIVE-22795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027087#comment-17027087 ] Hive QA commented on HIVE-22795: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 35s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 25s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 23s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m 23s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 38s{color} | {color:blue} common in master has 63 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 41s{color} | {color:blue} ql in master has 1537 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 34s{color} | {color:blue} accumulo-handler in master has 20 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m 36s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 12s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 8m 32s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 13s{color} | {color:red} common: The patch generated 27 new + 0 unchanged - 0 fixed = 27 total (was 0) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 9s{color} | {color:red} parser: The patch generated 32 new + 0 unchanged - 0 fixed = 32 total (was 0) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 9s{color} | {color:red} udf: The patch generated 10 new + 0 unchanged - 0 fixed = 10 total (was 0) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m 38s{color} | {color:red} root: The patch generated 109 new + 3060 unchanged - 159 fixed = 3169 total (was 3219) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 14s{color} | {color:green} accumulo-handler: The patch generated 0 new + 55 unchanged - 14 fixed = 55 total (was 69) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 9s{color} | {color:red} ql: The patch generated 60 new + 2985 unchanged - 165 fixed = 3045 total (was 3150) {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 104 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 1s{color} | {color:red} The patch 46 line(s) with tabs. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 5s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 40s{color} | {color:green} common in the patch passed. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 0s{color} | {color:green} parser in the patch passed. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 23s{color} | {color:green} udf in the patch passed. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m 37s{color} | {color:green} accumulo-handler in the patch passed. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 54s{color} | {color:green} ql generated 0 new + 1533 unchanged - 4 fixed = 1533 total (was 1537) {color} | | {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 9s{color} | {color:red} udf generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | |
[jira] [Commented] (HIVE-22795) Create new parser and udf module from ql
[ https://issues.apache.org/jira/browse/HIVE-22795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027003#comment-17027003 ] Hive QA commented on HIVE-22795: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12992277/HIVE-22795.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/20414/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/20414/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-20414/ Messages: {noformat} This message was trimmed, see log for full details + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-20414/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2020-01-30 21:08:12.580 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at 2412f73 HIVE-22515 : Support cast to decimal64 in Vectorization (Ramesh Kumar via Jason Dere) + git clean -f -d Removing standalone-metastore/metastore-server/src/gen/ + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at 2412f73 HIVE-22515 : Support cast to decimal64 in Vectorization (Ramesh Kumar via Jason Dere) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2020-01-30 21:08:13.946 + rm -rf ../yetus_PreCommit-HIVE-Build-20414 + mkdir ../yetus_PreCommit-HIVE-Build-20414 + git gc + cp -R . ../yetus_PreCommit-HIVE-Build-20414 + mkdir /data/hiveptest/logs/PreCommit-HIVE-Build-20414/yetus + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch Trying to apply the patch with -p0 fatal: git apply: bad git-diff - inconsistent old filename on line 238 Trying to apply the patch with -p1 Going to apply patch with: git apply -p1 + [[ maven == \m\a\v\e\n ]] + rm -rf /data/hiveptest/working/maven/org/apache/hive + mvn -B clean install -DskipTests -T 4 -q -Dmaven.repo.local=/data/hiveptest/working/maven protoc-jar: executing: [/tmp/protoc8340539359108519037.exe, --version] libprotoc 2.5.0 protoc-jar: executing: [/tmp/protoc8340539359108519037.exe, -I/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore, --java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/target/generated-sources, /data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto] ANTLR Parser Generator Version 3.5.2 protoc-jar: executing: [/tmp/protoc3809420359331057916.exe, --version] libprotoc 2.5.0 ANTLR Parser Generator Version 3.5.2 Output file /data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-server/target/generated-sources/org/apache/hadoop/hive/metastore/parser/FilterParser.java does not exist: must build /data/hiveptest/working/apache-github-source-source/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g org/apache/hadoop/hive/metastore/parser/Filter.g ANTLR Parser Generator Version 3.5.2 Output file /data/hiveptest/working/apache-github-source-source/parser/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveLexer.java does not exist: must build /data/hiveptest/working/apache-github-source-source/parser/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g org/apache/hadoop/hive/ql/parse/HiveLexer.g Output file /data/hiveptest/working/apache-github-source-source/parser/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveParser.java does not exist: must build /data/hiveptest/working/apache-github-source-source/parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g org/apache/hadoop/hive/ql/parse/HiveParser.g log4j:WARN No appenders could be found for logger (DataNucleus.Persistence).