[jira] [Commented] (HIVE-22957) Support For Filter Expression In MSCK Command

2020-03-23 Thread Syed Shameerur Rahman (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064752#comment-17064752
 ] 

Syed Shameerur Rahman commented on HIVE-22957:
--

[~thejas] [~kgyrtkirk] [~jcamachorodriguez] 

Could you take a look at the patch?

> Support For Filter Expression In MSCK Command
> -
>
> Key: HIVE-22957
> URL: https://issues.apache.org/jira/browse/HIVE-22957
> Project: Hive
>  Issue Type: Improvement
>  Components: Standalone Metastore
>Reporter: Syed Shameerur Rahman
>Assignee: Syed Shameerur Rahman
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22957.01.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently MSCK command supports full repair of table (all partitions) or some 
> subset of partitions based on partitionSpec. The aim of this jira is to 
> introduce a filterExp (=, !=, <, >, >=, <=, LIKE) in MSCK command so that a 
> larger subset of partitions can be recovered (added/deleted) without firing a 
> full repair might take time if the no. of partitions are huge.
> *Approach*:
> The initial approach is to add a where clause in MSCK command Eg: MCK REPAIR 
> TABLE  ADD|DROP|SYNC PARTITIONS WHERE   
>  AND 
> *Flow:*
> 1) Parse the where clause and generate filterExpression
> 2) fetch all the partitions from the metastore which matches the filter 
> expression
> 3) fetch all the partition file from the filesystem
> 4) remove all the partition path which does not match with the filter 
> expression
> 5) Based on ADD | DROP | SYNC do the remaining steps.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22957) Support For Filter Expression In MSCK Command

2020-03-20 Thread Syed Shameerur Rahman (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063139#comment-17063139
 ] 

Syed Shameerur Rahman commented on HIVE-22957:
--

Test failure seems unrelated, Verified them locally.

> Support For Filter Expression In MSCK Command
> -
>
> Key: HIVE-22957
> URL: https://issues.apache.org/jira/browse/HIVE-22957
> Project: Hive
>  Issue Type: Improvement
>  Components: Standalone Metastore
>Reporter: Syed Shameerur Rahman
>Assignee: Syed Shameerur Rahman
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22957.01.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently MSCK command supports full repair of table (all partitions) or some 
> subset of partitions based on partitionSpec. The aim of this jira is to 
> introduce a filterExp (=, !=, <, >, >=, <=, LIKE) in MSCK command so that a 
> larger subset of partitions can be recovered (added/deleted) without firing a 
> full repair might take time if the no. of partitions are huge.
> *Approach*:
> The initial approach is to add a where clause in MSCK command Eg: MCK REPAIR 
> TABLE  ADD|DROP|SYNC PARTITIONS WHERE   
>  AND 
> *Flow:*
> 1) Parse the where clause and generate filterExpression
> 2) fetch all the partitions from the metastore which matches the filter 
> expression
> 3) fetch all the partition file from the filesystem
> 4) remove all the partition path which does not match with the filter 
> expression
> 5) Based on ADD | DROP | SYNC do the remaining steps.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22957) Support For Filter Expression In MSCK Command

2020-03-19 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062909#comment-17062909
 ] 

Hive QA commented on HIVE-22957:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12997101/HIVE-22957.01.patch

{color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 18124 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestTezPerfConstraintsCliDriver.testCliDriver[cbo_query18]
 (batchId=306)
{noformat}

Test results: 
https://builds.apache.org/job/PreCommit-HIVE-Build/21181/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21181/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21181/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12997101 - PreCommit-HIVE-Build

> Support For Filter Expression In MSCK Command
> -
>
> Key: HIVE-22957
> URL: https://issues.apache.org/jira/browse/HIVE-22957
> Project: Hive
>  Issue Type: Improvement
>  Components: Standalone Metastore
>Reporter: Syed Shameerur Rahman
>Assignee: Syed Shameerur Rahman
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22957.01.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently MSCK command supports full repair of table (all partitions) or some 
> subset of partitions based on partitionSpec. The aim of this jira is to 
> introduce a filterExp (=, !=, <, >, >=, <=, LIKE) in MSCK command so that a 
> larger subset of partitions can be recovered (added/deleted) without firing a 
> full repair might take time if the no. of partitions are huge.
> *Approach*:
> The initial approach is to add a where clause in MSCK command Eg: MCK REPAIR 
> TABLE  ADD|DROP|SYNC PARTITIONS WHERE   
>  AND 
> *Flow:*
> 1) Parse the where clause and generate filterExpression
> 2) fetch all the partitions from the metastore which matches the filter 
> expression
> 3) fetch all the partition file from the filesystem
> 4) remove all the partition path which does not match with the filter 
> expression
> 5) Based on ADD | DROP | SYNC do the remaining steps.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-22957) Support For Filter Expression In MSCK Command

2020-03-19 Thread Hive QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062879#comment-17062879
 ] 

Hive QA commented on HIVE-22957:


| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
1s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  1m 
56s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m 
 2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
50s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
12s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 
57s{color} | {color:blue} parser in master has 3 extant Findbugs warnings. 
{color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  1m 
12s{color} | {color:blue} standalone-metastore/metastore-server in master has 
186 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  3m 
43s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings. 
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
26s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  2m 
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  1m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  1m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
 9s{color} | {color:green} The patch parser passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
19s{color} | {color:green} standalone-metastore/metastore-server: The patch 
generated 0 new + 121 unchanged - 2 fixed = 121 total (was 123) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
40s{color} | {color:green} The patch ql passed checkstyle {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  6m 
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 
36s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
14s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 35m 17s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21181/dev-support/hive-personality.sh
 |
| git revision | master / 213ca2e |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| modules | C: parser standalone-metastore/metastore-server ql U: . |
| Console output | 
http://104.198.109.242/logs//PreCommit-HIVE-Build-21181/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |


This message was automatically generated.



> Support For Filter Expression In MSCK Command
> -
>
> Key: HIVE-22957
> URL: https://issues.apache.org/jira/browse/HIVE-22957
> Project: Hive
>  Issue Type: Improvement
>  Components: Standalone Metastore
>Reporter: Syed Shameerur Rahman
>Assignee: Syed Shameerur Rahman
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
> Attachments: HIVE-22957.01.patch
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently MSCK command

[jira] [Commented] (HIVE-22957) Support For Filter Expression In MSCK Command

2020-03-19 Thread Syed Shameerur Rahman (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-22957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062404#comment-17062404
 ] 

Syed Shameerur Rahman commented on HIVE-22957:
--

Submitted initial patch for verification. Currently added support only for 
*STRING* partition column for predicate filtering with limited operators such 
as *EQUAL*, *LIKE*, *NOTEQUAL* etc. I will add support for more data types and 
operator in a separate Jira or as part of this Jira after initial verification 
of the patch.

[~jcamachorodriguez] [~prasanth_j] Can you please review the patch?

> Support For Filter Expression In MSCK Command
> -
>
> Key: HIVE-22957
> URL: https://issues.apache.org/jira/browse/HIVE-22957
> Project: Hive
>  Issue Type: Improvement
>Reporter: Syed Shameerur Rahman
>Assignee: Syed Shameerur Rahman
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-22957.01.patch
>
>
> Currently MSCK command supports full repair of table (all partitions) or some 
> subset of partitions based on partitionSpec. The aim of this jira is to 
> introduce a filterExp (=, !=, <, >, >=, <=, LIKE) in MSCK command so that a 
> larger subset of partitions can be recovered (added/deleted) without firing a 
> full repair might take time if the no. of partitions are huge.
> *Approach*:
> The initial approach is to add a where clause in MSCK command Eg: MCK REPAIR 
> TABLE  ADD|DROP|SYNC PARTITIONS WHERE   
>  AND 
> *Flow:*
> 1) Parse the where clause and generate filterExpression
> 2) fetch all the partitions from the metastore which matches the filter 
> expression
> 3) fetch all the partition file from the filesystem
> 4) remove all the partition path which does not match with the filter 
> expression
> 5) Based on ADD | DROP | SYNC do the remaining steps.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)