[jira] [Commented] (HIVE-23062) Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
[ https://issues.apache.org/jira/browse/HIVE-23062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064459#comment-17064459 ] Sam An commented on HIVE-23062: --- Thanks, guys. I made the changes accordingly and tests just ran clean. Will merge tomorrow shortly. Appreciate your time for review. > Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue > -- > > Key: HIVE-23062 > URL: https://issues.apache.org/jira/browse/HIVE-23062 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Sam An >Assignee: Sam An >Priority: Major > Attachments: HIVE-23062.1.patch, HIVE-23062.2.patch, > HIVE-23062.3.patch > > > Currently if custom Tez queue is used, Hive will only check the Http port, so > it is not handling TLS and Yarn HA mode URL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23062) Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
[
https://issues.apache.org/jira/browse/HIVE-23062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064429#comment-17064429
]
Hive QA commented on HIVE-23062:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12997370/HIVE-23062.3.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:green}SUCCESS:{color} +1 due to 18123 tests passed
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/21223/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21223/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21223/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12997370 - PreCommit-HIVE-Build
> Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
> --
>
> Key: HIVE-23062
> URL: https://issues.apache.org/jira/browse/HIVE-23062
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Reporter: Sam An
>Assignee: Sam An
>Priority: Major
> Attachments: HIVE-23062.1.patch, HIVE-23062.2.patch,
> HIVE-23062.3.patch
>
>
> Currently if custom Tez queue is used, Hive will only check the Http port, so
> it is not handling TLS and Yarn HA mode URL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-23062) Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
[
https://issues.apache.org/jira/browse/HIVE-23062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064414#comment-17064414
]
Hive QA commented on HIVE-23062:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
42s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
51s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
40s{color} | {color:red} ql: The patch generated 6 new + 7 unchanged - 0 fixed
= 13 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 55s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21223/dev-support/hive-personality.sh
|
| git revision | master / 2c0080b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-21223/yetus/diff-checkstyle-ql.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-21223/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
> --
>
> Key: HIVE-23062
> URL: https://issues.apache.org/jira/browse/HIVE-23062
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Reporter: Sam An
>Assignee: Sam An
>Priority: Major
> Attachments: HIVE-23062.1.patch, HIVE-23062.2.patch,
> HIVE-23062.3.patch
>
>
> Currently if custom Tez queue is used, Hive will only check the Http port, so
> it is not handling TLS and Yarn HA mode URL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-23062) Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
[
https://issues.apache.org/jira/browse/HIVE-23062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064168#comment-17064168
]
Hive QA commented on HIVE-23062:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12997345/HIVE-23062.2.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 18123 tests
executed
*Failed tests:*
{noformat}
org.apache.hive.hcatalog.api.TestHCatClient.testBasicDDLCommands (batchId=214)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/21220/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21220/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21220/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12997345 - PreCommit-HIVE-Build
> Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
> --
>
> Key: HIVE-23062
> URL: https://issues.apache.org/jira/browse/HIVE-23062
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Reporter: Sam An
>Assignee: Sam An
>Priority: Major
> Attachments: HIVE-23062.1.patch, HIVE-23062.2.patch
>
>
> Currently if custom Tez queue is used, Hive will only check the Http port, so
> it is not handling TLS and Yarn HA mode URL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-23062) Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
[
https://issues.apache.org/jira/browse/HIVE-23062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064161#comment-17064161
]
Hive QA commented on HIVE-23062:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
47s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
43s{color} | {color:red} ql: The patch generated 6 new + 7 unchanged - 0 fixed
= 13 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
7s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 57s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21220/dev-support/hive-personality.sh
|
| git revision | master / 2c0080b |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-21220/yetus/diff-checkstyle-ql.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-21220/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
> --
>
> Key: HIVE-23062
> URL: https://issues.apache.org/jira/browse/HIVE-23062
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Reporter: Sam An
>Assignee: Sam An
>Priority: Major
> Attachments: HIVE-23062.1.patch, HIVE-23062.2.patch
>
>
> Currently if custom Tez queue is used, Hive will only check the Http port, so
> it is not handling TLS and Yarn HA mode URL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-23062) Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
[
https://issues.apache.org/jira/browse/HIVE-23062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063789#comment-17063789
]
Hive QA commented on HIVE-23062:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12997250/HIVE-23062.1.patch
{color:red}ERROR:{color} -1 due to no test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 18109 tests
executed
*Failed tests:*
{noformat}
TestJdbcWithMiniLlapArrow - did not produce a TEST-*.xml file (likely timed
out) (batchId=293)
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-Build/21204/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/21204/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-21204/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12997250 - PreCommit-HIVE-Build
> Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
> --
>
> Key: HIVE-23062
> URL: https://issues.apache.org/jira/browse/HIVE-23062
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Reporter: Sam An
>Assignee: Sam An
>Priority: Major
> Attachments: HIVE-23062.1.patch
>
>
> Currently if custom Tez queue is used, Hive will only check the Http port, so
> it is not handling TLS and Yarn HA mode URL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-23062) Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
[
https://issues.apache.org/jira/browse/HIVE-23062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063770#comment-17063770
]
Hive QA commented on HIVE-23062:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 9m
29s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
1s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m
53s{color} | {color:blue} ql in master has 1531 extant Findbugs warnings.
{color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m
25s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
2s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
40s{color} | {color:red} ql: The patch generated 8 new + 7 unchanged - 0 fixed
= 15 total (was 7) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
15s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 24m 56s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/data/hiveptest/working/yetus_PreCommit-HIVE-Build-21204/dev-support/hive-personality.sh
|
| git revision | master / ef99369 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle |
http://104.198.109.242/logs//PreCommit-HIVE-Build-21204/yetus/diff-checkstyle-ql.txt
|
| modules | C: ql U: ql |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-21204/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
> --
>
> Key: HIVE-23062
> URL: https://issues.apache.org/jira/browse/HIVE-23062
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Reporter: Sam An
>Assignee: Sam An
>Priority: Major
> Attachments: HIVE-23062.1.patch
>
>
> Currently if custom Tez queue is used, Hive will only check the Http port, so
> it is not handling TLS and Yarn HA mode URL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-23062) Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
[ https://issues.apache.org/jira/browse/HIVE-23062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063726#comment-17063726 ] Jason Dere commented on HIVE-23062: --- Actually good point [~krisden], looks like YarnConfiguration.useHttps() can be used here > Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue > -- > > Key: HIVE-23062 > URL: https://issues.apache.org/jira/browse/HIVE-23062 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Sam An >Assignee: Sam An >Priority: Major > Attachments: HIVE-23062.1.patch > > > Currently if custom Tez queue is used, Hive will only check the Http port, so > it is not handling TLS and Yarn HA mode URL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23062) Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
[
https://issues.apache.org/jira/browse/HIVE-23062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063706#comment-17063706
]
Kevin Risden commented on HIVE-23062:
-
In the patch ssl check is on HS2 instead of checking for YARN TLS instead?
{code}
sslForHS2 = conf.getBoolVar(HiveConf.ConfVars.HIVE_SERVER2_USE_SSL);
{code}
This will work if HS2 TLS and YARN TLS are varied together, but that might not
be true?
Usually yarn-site.xml would have "yarn.http.policy=HTTPS_ONLY" which would be
what indicates if YARN is in SSL or not. Reference is here:
https://hadoop.apache.org/docs/current3/hadoop-yarn/hadoop-yarn-common/yarn-default.xml
Since this patch is already checking for other YARN configurations, it probably
makes sense to check for YARN TLS/SSL explicitly and not the HS2 value.
> Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
> --
>
> Key: HIVE-23062
> URL: https://issues.apache.org/jira/browse/HIVE-23062
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Reporter: Sam An
>Assignee: Sam An
>Priority: Major
> Attachments: HIVE-23062.1.patch
>
>
> Currently if custom Tez queue is used, Hive will only check the Http port, so
> it is not handling TLS and Yarn HA mode URL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-23062) Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue
[ https://issues.apache.org/jira/browse/HIVE-23062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063660#comment-17063660 ] Jason Dere commented on HIVE-23062: --- +1 pending test resuts > Hive to check Yarn RM URL in TLS and Yarn HA mode for custom Tez queue > -- > > Key: HIVE-23062 > URL: https://issues.apache.org/jira/browse/HIVE-23062 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Sam An >Assignee: Sam An >Priority: Major > Attachments: HIVE-23062.1.patch > > > Currently if custom Tez queue is used, Hive will only check the Http port, so > it is not handling TLS and Yarn HA mode URL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
