[jira] [Commented] (HIVE-23732) [refactor] Move allocating write IDs to ValidTxnManager.getTxnWriteIds

2020-06-24 Thread Kishen Das (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-23732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144471#comment-17144471
 ] 

Kishen Das commented on HIVE-23732:
---

Thank you [~mgergely]. I have resolved this one as duplicate of your JIRA. 

> [refactor] Move allocating write IDs to ValidTxnManager.getTxnWriteIds
> --
>
> Key: HIVE-23732
> URL: https://issues.apache.org/jira/browse/HIVE-23732
> Project: Hive
>  Issue Type: Task
>  Components: HiveServer2
>Reporter: Kishen Das
>Priority: Major
>
> Right now some of this logic is spread across in Driver.java and 
> ValidTxnManager.java . It would be nice if we can consolidate the logic of 
> allocating the write IDs and move it within ValidTxnManager. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HIVE-23732) [refactor] Move allocating write IDs to ValidTxnManager.getTxnWriteIds

2020-06-20 Thread Miklos Gergely (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-23732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141024#comment-17141024
 ] 

Miklos Gergely commented on HIVE-23732:
---

[~kishendas] please take a look at 
https://issues.apache.org/jira/browse/HIVE-23718, and to the comments at the 
pull request. It is aiming for the same goal, by first extracting the 
transaction related logic to a class called DriverTxnManager, then in a follow 
up Jira  to merge the ValidTxnManager into this new class.

> [refactor] Move allocating write IDs to ValidTxnManager.getTxnWriteIds
> --
>
> Key: HIVE-23732
> URL: https://issues.apache.org/jira/browse/HIVE-23732
> Project: Hive
>  Issue Type: Task
>  Components: HiveServer2
>Reporter: Kishen Das
>Priority: Major
>
> Right now some of this logic is spread across in Driver.java and 
> ValidTxnManager.java . It would be nice if we can consolidate the logic of 
> allocating the write IDs and move it within ValidTxnManager. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)