[jira] [Commented] (HIVE-23868) Windowing function spec: support 0 preceeding/following
[ https://issues.apache.org/jira/browse/HIVE-23868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159574#comment-17159574 ] Jesus Camacho Rodriguez commented on HIVE-23868: [~jdere], nm, the path you changed is common for Hive and Calcite. +1 > Windowing function spec: support 0 preceeding/following > --- > > Key: HIVE-23868 > URL: https://issues.apache.org/jira/browse/HIVE-23868 > Project: Hive > Issue Type: Bug > Components: Query Planning >Reporter: Jason Dere >Assignee: Jason Dere >Priority: Major > Labels: pull-request-available > Attachments: HIVE-23868.1.patch > > Time Spent: 10m > Remaining Estimate: 0h > > HIVE-12574 removed support for 0 PRECEDING/FOLLOWING in window function > specifications. We can restore support for this by converting 0 > PRECEDING/FOLLOWING to CURRENT ROW in the query plan, which should be the > same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23868) Windowing function spec: support 0 preceeding/following
[ https://issues.apache.org/jira/browse/HIVE-23868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159558#comment-17159558 ] Jason Dere commented on HIVE-23868: --- Just saw your comment. Will take a look to see if the parser change is doable > Windowing function spec: support 0 preceeding/following > --- > > Key: HIVE-23868 > URL: https://issues.apache.org/jira/browse/HIVE-23868 > Project: Hive > Issue Type: Bug > Components: Query Planning >Reporter: Jason Dere >Assignee: Jason Dere >Priority: Major > Labels: pull-request-available > Attachments: HIVE-23868.1.patch > > Time Spent: 10m > Remaining Estimate: 0h > > HIVE-12574 removed support for 0 PRECEDING/FOLLOWING in window function > specifications. We can restore support for this by converting 0 > PRECEDING/FOLLOWING to CURRENT ROW in the query plan, which should be the > same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23868) Windowing function spec: support 0 preceeding/following
[ https://issues.apache.org/jira/browse/HIVE-23868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159556#comment-17159556 ] Jason Dere commented on HIVE-23868: --- PR at https://github.com/apache/hive/pull/1269 > Windowing function spec: support 0 preceeding/following > --- > > Key: HIVE-23868 > URL: https://issues.apache.org/jira/browse/HIVE-23868 > Project: Hive > Issue Type: Bug > Components: Query Planning >Reporter: Jason Dere >Assignee: Jason Dere >Priority: Major > Labels: pull-request-available > Attachments: HIVE-23868.1.patch > > Time Spent: 10m > Remaining Estimate: 0h > > HIVE-12574 removed support for 0 PRECEDING/FOLLOWING in window function > specifications. We can restore support for this by converting 0 > PRECEDING/FOLLOWING to CURRENT ROW in the query plan, which should be the > same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HIVE-23868) Windowing function spec: support 0 preceeding/following
[
https://issues.apache.org/jira/browse/HIVE-23868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159553#comment-17159553
]
Jesus Camacho Rodriguez commented on HIVE-23868:
[~jdere], what do you think about adding the change to
{{SelectClauseParser.g}}? Maybe something like this would work?
{code}
0 KW_PRECEDING -> ^(KW_CURRENT)
{code}
The reason I am asking is that then we will get CURRENT_ROW both through Hive
and Calcite.
> Windowing function spec: support 0 preceeding/following
> ---
>
> Key: HIVE-23868
> URL: https://issues.apache.org/jira/browse/HIVE-23868
> Project: Hive
> Issue Type: Bug
> Components: Query Planning
>Reporter: Jason Dere
>Assignee: Jason Dere
>Priority: Major
> Attachments: HIVE-23868.1.patch
>
>
> HIVE-12574 removed support for 0 PRECEDING/FOLLOWING in window function
> specifications. We can restore support for this by converting 0
> PRECEDING/FOLLOWING to CURRENT ROW in the query plan, which should be the
> same.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HIVE-23868) Windowing function spec: support 0 preceeding/following
[ https://issues.apache.org/jira/browse/HIVE-23868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159549#comment-17159549 ] Jesus Camacho Rodriguez commented on HIVE-23868: [~jdere], you will need to create a PR to trigger ptests with the new workflow. > Windowing function spec: support 0 preceeding/following > --- > > Key: HIVE-23868 > URL: https://issues.apache.org/jira/browse/HIVE-23868 > Project: Hive > Issue Type: Bug > Components: Query Planning >Reporter: Jason Dere >Assignee: Jason Dere >Priority: Major > Attachments: HIVE-23868.1.patch > > > HIVE-12574 removed support for 0 PRECEDING/FOLLOWING in window function > specifications. We can restore support for this by converting 0 > PRECEDING/FOLLOWING to CURRENT ROW in the query plan, which should be the > same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
