[jira] [Commented] (HIVE-25741) HiveProtoLoggingHook EventLogger should always close old writer

2021-11-29 Thread Marton Bod (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-25741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17450495#comment-17450495
 ] 

Marton Bod commented on HIVE-25741:
---

Pushed to master. Thanks [~pvary] for reviewing!

> HiveProtoLoggingHook EventLogger should always close old writer
> ---
>
> Key: HIVE-25741
> URL: https://issues.apache.org/jira/browse/HIVE-25741
> Project: Hive
>  Issue Type: Bug
>Reporter: Marton Bod
>Assignee: Marton Bod
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> If {{hive.hook.proto.file.per.event=true}} (recommended for S3A filesystem), 
> the Hive proto {{EventLogger}} will create a new file for each proto event. 
> However, if we already had an appropriate writer (i.e. 
> maybeRolloverWriterForDay() returns false) from some previous operation - we 
> don't close the previous writer instance before creating a new one.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Commented] (HIVE-25741) HiveProtoLoggingHook EventLogger should always close old writer

2021-11-26 Thread Marton Bod (Jira) 


[ 
https://issues.apache.org/jira/browse/HIVE-25741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449565#comment-17449565
 ] 

Marton Bod commented on HIVE-25741:
---

PR: [https://github.com/apache/hive/pull/2819]

 

> HiveProtoLoggingHook EventLogger should always close old writer
> ---
>
> Key: HIVE-25741
> URL: https://issues.apache.org/jira/browse/HIVE-25741
> Project: Hive
>  Issue Type: Bug
>Reporter: Marton Bod
>Assignee: Marton Bod
>Priority: Major
>
> If {{hive.hook.proto.file.per.event=true}} (recommended for S3A filesystem), 
> the Hive proto {{EventLogger}} will create a new file for each proto event. 
> However, if we already had an appropriate writer (i.e. 
> maybeRolloverWriterForDay() returns false) from some previous operation - we 
> don't close the previous writer instance before creating a new one.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)