[jira] [Commented] (HIVE-6754) Inconsistent default for hive.exec.drop.ignorenonexistent
[ https://issues.apache.org/jira/browse/HIVE-6754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527339#comment-14527339 ] Sergio Peña commented on HIVE-6754: --- Tests are failing because developers usually add a 'DROP TABLE ' to the tests even if the does not exist. So, this patch is causing them to fail. Also, users might be using the same statement without IF EXISTS keywords on their scripts, so this patch will cause errors on them as well. This is a user experience issue, so we need to think about this solution carefully. [~szehon] [~xuefuz] Could you help me here? Would we want cause errors when dropping a table that does not exist? > Inconsistent default for hive.exec.drop.ignorenonexistent > -- > > Key: HIVE-6754 > URL: https://issues.apache.org/jira/browse/HIVE-6754 > Project: Hive > Issue Type: Bug > Components: Configuration >Affects Versions: 0.12.0 >Reporter: Natalino Busa >Assignee: Reuben Kuhnert >Priority: Trivial > Attachments: HIVE-6754.01.patch > > > Dropping a non existing table returns no errors > - when IF EXISTS is added > - when hive.exec.drop.ignorenonexistent is set to true > The default configuration in hive-default.xml.template sets > hive.exec.drop.ignorenonexistent to true. > However this create a inconsistent default behaviour when DROP TABLE is > executed on a non existing table, when the if exists clause is not used. > My suggestion would be to have the default set to false, to align the > behavior to the way it's used in SQL. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-6754) Inconsistent default for hive.exec.drop.ignorenonexistent
[
https://issues.apache.org/jira/browse/HIVE-6754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14527245#comment-14527245
]
Hive QA commented on HIVE-6754:
---
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12730213/HIVE-6754.01.patch
{color:red}ERROR:{color} -1 due to 390 failed/errored test(s), 8856 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_file_format
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_index
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_rename_partition
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_groupby2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_join_pkfk
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_archive_excludeHadoop20
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_admin_almighty2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_cli_nonsql
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avro_charvarchar
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avro_date
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avro_timestamp
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ba_table1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ba_table2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ba_table3
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ba_table_union
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_binary_table_bincolserde
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_binary_table_colserde
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucket_map_join_1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucket_map_join_2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin_negative3
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_char_1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_char_2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_char_join1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_char_nested_types
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_char_udf1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_char_union1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_columnstats_partlvl
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_columnstats_partlvl_dp
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_combine3
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_big_view
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_view
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_view_partitioned
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ctas_char
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ctas_date
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_ctas_varchar
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_date_1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_date_3
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_date_4
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_date_join1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_date_serde
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_date_udf
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_decimal_2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_describe_formatted_view_partitioned
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_describe_formatted_view_partitioned_json
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_dynpart_sort_optimization2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_dynpart_sort_optimization_acid
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_enforce_order
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_escape1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_global_limit
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_hook_context_cs
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_index_auto_mult_tables
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_index_auto_mult_tables_compact
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_index_bitmap
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_index_compact
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_index_creation
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_infer_const_type
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input16
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input43
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input_lazyserde
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_insert0
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_insert_compressed
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_insert_into1
org.apache.hadoop.hive.cli.TestCliDriv
[jira] [Commented] (HIVE-6754) Inconsistent default for hive.exec.drop.ignorenonexistent
[ https://issues.apache.org/jira/browse/HIVE-6754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494503#comment-14494503 ] Reuben Kuhnert commented on HIVE-6754: -- Patch available. > Inconsistent default for hive.exec.drop.ignorenonexistent > -- > > Key: HIVE-6754 > URL: https://issues.apache.org/jira/browse/HIVE-6754 > Project: Hive > Issue Type: Bug > Components: Configuration >Affects Versions: 0.12.0 >Reporter: Natalino Busa >Assignee: Reuben Kuhnert >Priority: Trivial > Attachments: HIVE-6754.01.patch > > > Dropping a non existing table returns no errors > - when IF EXISTS is added > - when hive.exec.drop.ignorenonexistent is set to true > The default configuration in hive-default.xml.template sets > hive.exec.drop.ignorenonexistent to true. > However this create a inconsistent default behaviour when DROP TABLE is > executed on a non existing table, when the if exists clause is not used. > My suggestion would be to have the default set to false, to align the > behavior to the way it's used in SQL. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
