[jira] [Updated] (HIVE-11591) upgrade thrift to 0.9.3 and change generation to use undated annotations
[ https://issues.apache.org/jira/browse/HIVE-11591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shelukhin updated HIVE-11591: Attachment: HIVE-11591.nogen.patch > upgrade thrift to 0.9.3 and change generation to use undated annotations > > > Key: HIVE-11591 > URL: https://issues.apache.org/jira/browse/HIVE-11591 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-11591.WIP.patch, HIVE-11591.nogen.patch > > > Thrift has added class annotations to generated classes; these contain > generation date. Because of this, all the Java thrift files change on every > re-gen, even if you only make a small change that should not affect bazillion > files. We should use undated annotations to avoid this problem. > This depends on upgrading to Thrift 0.9.3, which doesn't exist yet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-11591) upgrade thrift to 0.9.3 and change generation to use undated annotations
[ https://issues.apache.org/jira/browse/HIVE-11591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shelukhin updated HIVE-11591: Summary: upgrade thrift to 0.9.3 and change generation to use undated annotations (was: change thrift generation to use undated annotations) > upgrade thrift to 0.9.3 and change generation to use undated annotations > > > Key: HIVE-11591 > URL: https://issues.apache.org/jira/browse/HIVE-11591 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-11591.WIP.patch > > > Thrift has added class annotations to generated classes; these contain > generation date. Because of this, all the Java thrift files change on every > re-gen, even if you only make a small change that should not affect bazillion > files. We should use undated annotations to avoid this problem. > This depends on upgrading to Thrift 0.9.3, which doesn't exist yet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-11591) upgrade thrift to 0.9.3 and change generation to use undated annotations
[ https://issues.apache.org/jira/browse/HIVE-11591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shelukhin updated HIVE-11591: Attachment: HIVE-11591.patch The patch. I eyeballed the generated code, the only differences in Java files, other than the dates being gone, are the removal of Foo.valueOf(bar) when returning things (e.g. return getBlah() instead of return Long.valueOf(getBlah()) > upgrade thrift to 0.9.3 and change generation to use undated annotations > > > Key: HIVE-11591 > URL: https://issues.apache.org/jira/browse/HIVE-11591 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-11591.WIP.patch, HIVE-11591.nogen.patch, > HIVE-11591.patch > > > Thrift has added class annotations to generated classes; these contain > generation date. Because of this, all the Java thrift files change on every > re-gen, even if you only make a small change that should not affect bazillion > files. We should use undated annotations to avoid this problem. > This depends on upgrading to Thrift 0.9.3, which doesn't exist yet. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-11591) upgrade thrift to 0.9.3 and change generation to use undated annotations
[ https://issues.apache.org/jira/browse/HIVE-11591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shelukhin updated HIVE-11591: Description: Thrift has added class annotations to generated classes; these contain generation date. Because of this, all the Java thrift files change on every re-gen, even if you only make a small change that should not affect bazillion files. We should use undated annotations to avoid this problem. This depends on upgrading to Thrift 0.9.3, -which doesn't exist yet-. was: Thrift has added class annotations to generated classes; these contain generation date. Because of this, all the Java thrift files change on every re-gen, even if you only make a small change that should not affect bazillion files. We should use undated annotations to avoid this problem. This depends on upgrading to Thrift 0.9.3-, which doesn't exist yet-. > upgrade thrift to 0.9.3 and change generation to use undated annotations > > > Key: HIVE-11591 > URL: https://issues.apache.org/jira/browse/HIVE-11591 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-11591.WIP.patch, HIVE-11591.nogen.patch, > HIVE-11591.patch > > > Thrift has added class annotations to generated classes; these contain > generation date. Because of this, all the Java thrift files change on every > re-gen, even if you only make a small change that should not affect bazillion > files. We should use undated annotations to avoid this problem. > This depends on upgrading to Thrift 0.9.3, -which doesn't exist yet-. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HIVE-11591) upgrade thrift to 0.9.3 and change generation to use undated annotations
[ https://issues.apache.org/jira/browse/HIVE-11591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Shelukhin updated HIVE-11591: Description: Thrift has added class annotations to generated classes; these contain generation date. Because of this, all the Java thrift files change on every re-gen, even if you only make a small change that should not affect bazillion files. We should use undated annotations to avoid this problem. This depends on upgrading to Thrift 0.9.3-, which doesn't exist yet-. was: Thrift has added class annotations to generated classes; these contain generation date. Because of this, all the Java thrift files change on every re-gen, even if you only make a small change that should not affect bazillion files. We should use undated annotations to avoid this problem. This depends on upgrading to Thrift 0.9.3, which doesn't exist yet. > upgrade thrift to 0.9.3 and change generation to use undated annotations > > > Key: HIVE-11591 > URL: https://issues.apache.org/jira/browse/HIVE-11591 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin > Attachments: HIVE-11591.WIP.patch, HIVE-11591.nogen.patch, > HIVE-11591.patch > > > Thrift has added class annotations to generated classes; these contain > generation date. Because of this, all the Java thrift files change on every > re-gen, even if you only make a small change that should not affect bazillion > files. We should use undated annotations to avoid this problem. > This depends on upgrading to Thrift 0.9.3-, which doesn't exist yet-. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
