[jira] [Updated] (HIVE-22507) KeyWrapper comparator create field comparator instances at every comparison
[ https://issues.apache.org/jira/browse/HIVE-22507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jesus Camacho Rodriguez updated HIVE-22507: --- Resolution: Fixed Status: Resolved (was: Patch Available) Pushed to master, thanks [~kkasa]! > KeyWrapper comparator create field comparator instances at every comparison > > > Key: HIVE-22507 > URL: https://issues.apache.org/jira/browse/HIVE-22507 > Project: Hive > Issue Type: Bug > Components: Physical Optimizer >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22507.1.patch, HIVE-22507.2.patch, > HIVE-22507.2.patch > > > TopNKeyOperator.KeyWrapperComparator uses separate comparators for each field > of the keys. Every time when TopNKeyOperator.KeyWrapperComparator.compare is > called a new instance of the field operators are created. > The field comparators should be created prior any comparison. Probably in the > constructor of KeyWrapperComparator or during initializeOp. > https://github.com/apache/hive/blob/fc81b8909b1a0e6aa15900387a98bccf38ae2247/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java#L964 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22507) KeyWrapper comparator create field comparator instances at every comparison
[ https://issues.apache.org/jira/browse/HIVE-22507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krisztian Kasa updated HIVE-22507: -- Status: Patch Available (was: Open) > KeyWrapper comparator create field comparator instances at every comparison > > > Key: HIVE-22507 > URL: https://issues.apache.org/jira/browse/HIVE-22507 > Project: Hive > Issue Type: Bug > Components: Physical Optimizer >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22507.1.patch, HIVE-22507.2.patch, > HIVE-22507.2.patch > > > TopNKeyOperator.KeyWrapperComparator uses separate comparators for each field > of the keys. Every time when TopNKeyOperator.KeyWrapperComparator.compare is > called a new instance of the field operators are created. > The field comparators should be created prior any comparison. Probably in the > constructor of KeyWrapperComparator or during initializeOp. > https://github.com/apache/hive/blob/fc81b8909b1a0e6aa15900387a98bccf38ae2247/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java#L964 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22507) KeyWrapper comparator create field comparator instances at every comparison
[ https://issues.apache.org/jira/browse/HIVE-22507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krisztian Kasa updated HIVE-22507: -- Attachment: HIVE-22507.2.patch > KeyWrapper comparator create field comparator instances at every comparison > > > Key: HIVE-22507 > URL: https://issues.apache.org/jira/browse/HIVE-22507 > Project: Hive > Issue Type: Bug > Components: Physical Optimizer >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22507.1.patch, HIVE-22507.2.patch, > HIVE-22507.2.patch > > > TopNKeyOperator.KeyWrapperComparator uses separate comparators for each field > of the keys. Every time when TopNKeyOperator.KeyWrapperComparator.compare is > called a new instance of the field operators are created. > The field comparators should be created prior any comparison. Probably in the > constructor of KeyWrapperComparator or during initializeOp. > https://github.com/apache/hive/blob/fc81b8909b1a0e6aa15900387a98bccf38ae2247/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java#L964 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22507) KeyWrapper comparator create field comparator instances at every comparison
[ https://issues.apache.org/jira/browse/HIVE-22507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krisztian Kasa updated HIVE-22507: -- Status: Open (was: Patch Available) > KeyWrapper comparator create field comparator instances at every comparison > > > Key: HIVE-22507 > URL: https://issues.apache.org/jira/browse/HIVE-22507 > Project: Hive > Issue Type: Bug > Components: Physical Optimizer >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22507.1.patch, HIVE-22507.2.patch, > HIVE-22507.2.patch > > > TopNKeyOperator.KeyWrapperComparator uses separate comparators for each field > of the keys. Every time when TopNKeyOperator.KeyWrapperComparator.compare is > called a new instance of the field operators are created. > The field comparators should be created prior any comparison. Probably in the > constructor of KeyWrapperComparator or during initializeOp. > https://github.com/apache/hive/blob/fc81b8909b1a0e6aa15900387a98bccf38ae2247/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java#L964 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22507) KeyWrapper comparator create field comparator instances at every comparison
[ https://issues.apache.org/jira/browse/HIVE-22507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krisztian Kasa updated HIVE-22507: -- Attachment: HIVE-22507.2.patch > KeyWrapper comparator create field comparator instances at every comparison > > > Key: HIVE-22507 > URL: https://issues.apache.org/jira/browse/HIVE-22507 > Project: Hive > Issue Type: Bug > Components: Physical Optimizer >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22507.1.patch, HIVE-22507.2.patch > > > TopNKeyOperator.KeyWrapperComparator uses separate comparators for each field > of the keys. Every time when TopNKeyOperator.KeyWrapperComparator.compare is > called a new instance of the field operators are created. > The field comparators should be created prior any comparison. Probably in the > constructor of KeyWrapperComparator or during initializeOp. > https://github.com/apache/hive/blob/fc81b8909b1a0e6aa15900387a98bccf38ae2247/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java#L964 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22507) KeyWrapper comparator create field comparator instances at every comparison
[ https://issues.apache.org/jira/browse/HIVE-22507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krisztian Kasa updated HIVE-22507: -- Status: Open (was: Patch Available) > KeyWrapper comparator create field comparator instances at every comparison > > > Key: HIVE-22507 > URL: https://issues.apache.org/jira/browse/HIVE-22507 > Project: Hive > Issue Type: Bug > Components: Physical Optimizer >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22507.1.patch, HIVE-22507.2.patch > > > TopNKeyOperator.KeyWrapperComparator uses separate comparators for each field > of the keys. Every time when TopNKeyOperator.KeyWrapperComparator.compare is > called a new instance of the field operators are created. > The field comparators should be created prior any comparison. Probably in the > constructor of KeyWrapperComparator or during initializeOp. > https://github.com/apache/hive/blob/fc81b8909b1a0e6aa15900387a98bccf38ae2247/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java#L964 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22507) KeyWrapper comparator create field comparator instances at every comparison
[ https://issues.apache.org/jira/browse/HIVE-22507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krisztian Kasa updated HIVE-22507: -- Status: Patch Available (was: Open) > KeyWrapper comparator create field comparator instances at every comparison > > > Key: HIVE-22507 > URL: https://issues.apache.org/jira/browse/HIVE-22507 > Project: Hive > Issue Type: Bug > Components: Physical Optimizer >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22507.1.patch, HIVE-22507.2.patch > > > TopNKeyOperator.KeyWrapperComparator uses separate comparators for each field > of the keys. Every time when TopNKeyOperator.KeyWrapperComparator.compare is > called a new instance of the field operators are created. > The field comparators should be created prior any comparison. Probably in the > constructor of KeyWrapperComparator or during initializeOp. > https://github.com/apache/hive/blob/fc81b8909b1a0e6aa15900387a98bccf38ae2247/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java#L964 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22507) KeyWrapper comparator create field comparator instances at every comparison
[ https://issues.apache.org/jira/browse/HIVE-22507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krisztian Kasa updated HIVE-22507: -- Attachment: HIVE-22507.1.patch > KeyWrapper comparator create field comparator instances at every comparison > > > Key: HIVE-22507 > URL: https://issues.apache.org/jira/browse/HIVE-22507 > Project: Hive > Issue Type: Bug > Components: Physical Optimizer >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22507.1.patch > > > TopNKeyOperator.KeyWrapperComparator uses separate comparators for each field > of the keys. Every time when TopNKeyOperator.KeyWrapperComparator.compare is > called a new instance of the field operators are created. > The field comparators should be created prior any comparison. Probably in the > constructor of KeyWrapperComparator or during initializeOp. > https://github.com/apache/hive/blob/fc81b8909b1a0e6aa15900387a98bccf38ae2247/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java#L964 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22507) KeyWrapper comparator create field comparator instances at every comparison
[ https://issues.apache.org/jira/browse/HIVE-22507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krisztian Kasa updated HIVE-22507: -- Status: Patch Available (was: Open) > KeyWrapper comparator create field comparator instances at every comparison > > > Key: HIVE-22507 > URL: https://issues.apache.org/jira/browse/HIVE-22507 > Project: Hive > Issue Type: Bug > Components: Physical Optimizer >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-22507.1.patch > > > TopNKeyOperator.KeyWrapperComparator uses separate comparators for each field > of the keys. Every time when TopNKeyOperator.KeyWrapperComparator.compare is > called a new instance of the field operators are created. > The field comparators should be created prior any comparison. Probably in the > constructor of KeyWrapperComparator or during initializeOp. > https://github.com/apache/hive/blob/fc81b8909b1a0e6aa15900387a98bccf38ae2247/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java#L964 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HIVE-22507) KeyWrapper comparator create field comparator instances at every comparison
[ https://issues.apache.org/jira/browse/HIVE-22507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krisztian Kasa updated HIVE-22507: -- Summary: KeyWrapper comparator create field comparator instances at every comparison (was: KeyWrapper comparator create subcomparator instances at every comparison ) > KeyWrapper comparator create field comparator instances at every comparison > > > Key: HIVE-22507 > URL: https://issues.apache.org/jira/browse/HIVE-22507 > Project: Hive > Issue Type: Bug > Components: Physical Optimizer >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Fix For: 4.0.0 > > > TopNKeyOperator.KeyWrapperComparator uses separate comparators for each field > of the keys. Every time when TopNKeyOperator.KeyWrapperComparator.compare is > called a new instance of the field operators are created. > The field comparators should be created prior any comparison. Probably in the > constructor of KeyWrapperComparator or during initializeOp. > https://github.com/apache/hive/blob/fc81b8909b1a0e6aa15900387a98bccf38ae2247/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java#L964 > -- This message was sent by Atlassian Jira (v8.3.4#803005)
