[jira] [Updated] (HIVE-26148) Keep MetaStoreFilterHook interface compatibility after introducing catalogs
[ https://issues.apache.org/jira/browse/HIVE-26148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stamatis Zampetakis updated HIVE-26148: --- Fix Version/s: (was: 4.0.0-alpha-2) I cleared the fixVersion field since this ticket is still open. Please review this ticket and if the fix is already committed to a specific version please set the version accordingly and mark the ticket as RESOLVED. According to the [JIRA guidelines|https://cwiki.apache.org/confluence/display/Hive/HowToContribute] the fixVersion should be set only when the issue is resolved/closed. > Keep MetaStoreFilterHook interface compatibility after introducing catalogs > --- > > Key: HIVE-26148 > URL: https://issues.apache.org/jira/browse/HIVE-26148 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.0.0 >Reporter: Wechar >Assignee: Wechar >Priority: Minor > Labels: pull-request-available > Time Spent: 3h 10m > Remaining Estimate: 0h > > Hive 3.0 introduce catalog concept, when we upgrade hive dependency version > from 2.3 to 3.x, we found some interfaces of *MetaStoreFilterHook* are not > compatible: > {code:bash} > git show ba8a99e115 -- > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java > {code} > {code:bash} > --- > a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java > +++ > b/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java >/** > * Filter given list of tables > - * @param dbName > - * @param tableList > + * @param catName catalog name > + * @param dbName database name > + * @param tableList list of table returned by the metastore > * @return List of filtered table names > */ > - public List filterTableNames(String dbName, List > tableList) throws MetaException; > + List filterTableNames(String catName, String dbName, List > tableList) > + throws MetaException; > {code} > We can remain the previous interfaces and use the default catalog to > implement. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (HIVE-26148) Keep MetaStoreFilterHook interface compatibility after introducing catalogs
[ https://issues.apache.org/jira/browse/HIVE-26148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zoltan Haindrich updated HIVE-26148: Fix Version/s: 4.0.0-alpha-2 (was: 4.0.0-alpha-1) > Keep MetaStoreFilterHook interface compatibility after introducing catalogs > --- > > Key: HIVE-26148 > URL: https://issues.apache.org/jira/browse/HIVE-26148 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.0.0 >Reporter: Wechar >Assignee: Wechar >Priority: Minor > Labels: pull-request-available > Fix For: 4.0.0-alpha-2 > > Time Spent: 2h 40m > Remaining Estimate: 0h > > Hive 3.0 introduce catalog concept, when we upgrade hive dependency version > from 2.3 to 3.x, we found some interfaces of *MetaStoreFilterHook* are not > compatible: > {code:bash} > git show ba8a99e115 -- > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java > {code} > {code:bash} > --- > a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java > +++ > b/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java >/** > * Filter given list of tables > - * @param dbName > - * @param tableList > + * @param catName catalog name > + * @param dbName database name > + * @param tableList list of table returned by the metastore > * @return List of filtered table names > */ > - public List filterTableNames(String dbName, List > tableList) throws MetaException; > + List filterTableNames(String catName, String dbName, List > tableList) > + throws MetaException; > {code} > We can remain the previous interfaces and use the default catalog to > implement. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (HIVE-26148) Keep MetaStoreFilterHook interface compatibility after introducing catalogs
[ https://issues.apache.org/jira/browse/HIVE-26148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HIVE-26148: -- Labels: pull-request-available (was: ) > Keep MetaStoreFilterHook interface compatibility after introducing catalogs > --- > > Key: HIVE-26148 > URL: https://issues.apache.org/jira/browse/HIVE-26148 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 3.0.0 >Reporter: Wechar >Assignee: Wechar >Priority: Minor > Labels: pull-request-available > Fix For: 4.0.0-alpha-1 > > Time Spent: 10m > Remaining Estimate: 0h > > Hive 3.0 introduce catalog concept, when we upgrade hive dependency version > from 2.3 to 3.x, we found some interfaces of *MetaStoreFilterHook* are not > compatible: > {code:bash} > git show ba8a99e115 -- > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java > {code} > {code:bash} > --- > a/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java > +++ > b/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java >/** > * Filter given list of tables > - * @param dbName > - * @param tableList > + * @param catName catalog name > + * @param dbName database name > + * @param tableList list of table returned by the metastore > * @return List of filtered table names > */ > - public List filterTableNames(String dbName, List > tableList) throws MetaException; > + List filterTableNames(String catName, String dbName, List > tableList) > + throws MetaException; > {code} > We can remain the previous interfaces and use the default catalog to > implement. -- This message was sent by Atlassian Jira (v8.20.1#820001)