[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=442668=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442668 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 08/Jun/20 11:00 Start Date: 08/Jun/20 11:00 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #846: URL: https://github.com/apache/hive/pull/846#issuecomment-640136378 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442668) Time Spent: 4h 10m (was: 4h) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, > HIVE-22463.11.patch, HIVE-22463.12.patch, HIVE-22463.13.patch, > HIVE-22463.2.patch, HIVE-22463.3.patch, HIVE-22463.5.patch, > HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch, HIVE-22463.9.patch > > Time Spent: 4h 10m > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=442363=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442363 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 07/Jun/20 00:26 Start Date: 07/Jun/20 00:26 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #853: URL: https://github.com/apache/hive/pull/853#issuecomment-640136364 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442363) Time Spent: 3h 50m (was: 3h 40m) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, > HIVE-22463.11.patch, HIVE-22463.12.patch, HIVE-22463.13.patch, > HIVE-22463.2.patch, HIVE-22463.3.patch, HIVE-22463.5.patch, > HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch, HIVE-22463.9.patch > > Time Spent: 3h 50m > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=442373=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442373 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 07/Jun/20 00:26 Start Date: 07/Jun/20 00:26 Worklog Time Spent: 10m Work Description: github-actions[bot] closed pull request #857: URL: https://github.com/apache/hive/pull/857 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442373) Time Spent: 4h (was: 3h 50m) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, > HIVE-22463.11.patch, HIVE-22463.12.patch, HIVE-22463.13.patch, > HIVE-22463.2.patch, HIVE-22463.3.patch, HIVE-22463.5.patch, > HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch, HIVE-22463.9.patch > > Time Spent: 4h > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=442339=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442339 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 07/Jun/20 00:25 Start Date: 07/Jun/20 00:25 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #857: URL: https://github.com/apache/hive/pull/857#issuecomment-640136356 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442339) Time Spent: 2h 50m (was: 2h 40m) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, > HIVE-22463.11.patch, HIVE-22463.12.patch, HIVE-22463.13.patch, > HIVE-22463.2.patch, HIVE-22463.3.patch, HIVE-22463.5.patch, > HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch, HIVE-22463.9.patch > > Time Spent: 2h 50m > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=442346=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442346 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 07/Jun/20 00:25 Start Date: 07/Jun/20 00:25 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #846: URL: https://github.com/apache/hive/pull/846#issuecomment-640136378 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442346) Time Spent: 3h 10m (was: 3h) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, > HIVE-22463.11.patch, HIVE-22463.12.patch, HIVE-22463.13.patch, > HIVE-22463.2.patch, HIVE-22463.3.patch, HIVE-22463.5.patch, > HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch, HIVE-22463.9.patch > > Time Spent: 3h 10m > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=442342=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442342 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 07/Jun/20 00:25 Start Date: 07/Jun/20 00:25 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #856: URL: https://github.com/apache/hive/pull/856#issuecomment-640136361 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442342) Time Spent: 3h (was: 2h 50m) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, > HIVE-22463.11.patch, HIVE-22463.12.patch, HIVE-22463.13.patch, > HIVE-22463.2.patch, HIVE-22463.3.patch, HIVE-22463.5.patch, > HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch, HIVE-22463.9.patch > > Time Spent: 3h > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=442349=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442349 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 07/Jun/20 00:25 Start Date: 07/Jun/20 00:25 Worklog Time Spent: 10m Work Description: github-actions[bot] closed pull request #853: URL: https://github.com/apache/hive/pull/853 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442349) Time Spent: 3.5h (was: 3h 20m) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, > HIVE-22463.11.patch, HIVE-22463.12.patch, HIVE-22463.13.patch, > HIVE-22463.2.patch, HIVE-22463.3.patch, HIVE-22463.5.patch, > HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch, HIVE-22463.9.patch > > Time Spent: 3.5h > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=442347=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442347 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 07/Jun/20 00:25 Start Date: 07/Jun/20 00:25 Worklog Time Spent: 10m Work Description: github-actions[bot] closed pull request #846: URL: https://github.com/apache/hive/pull/846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442347) Time Spent: 3h 20m (was: 3h 10m) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, > HIVE-22463.11.patch, HIVE-22463.12.patch, HIVE-22463.13.patch, > HIVE-22463.2.patch, HIVE-22463.3.patch, HIVE-22463.5.patch, > HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch, HIVE-22463.9.patch > > Time Spent: 3h 20m > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=442351=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-442351 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 07/Jun/20 00:25 Start Date: 07/Jun/20 00:25 Worklog Time Spent: 10m Work Description: github-actions[bot] closed pull request #856: URL: https://github.com/apache/hive/pull/856 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 442351) Time Spent: 3h 40m (was: 3.5h) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, > HIVE-22463.11.patch, HIVE-22463.12.patch, HIVE-22463.13.patch, > HIVE-22463.2.patch, HIVE-22463.3.patch, HIVE-22463.5.patch, > HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch, HIVE-22463.9.patch > > Time Spent: 3h 40m > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[
https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=350073=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-350073
]
ASF GitHub Bot logged work on HIVE-22463:
-
Author: ASF GitHub Bot
Created on: 26/Nov/19 21:54
Start Date: 26/Nov/19 21:54
Worklog Time Spent: 10m
Work Description: ramesh0201 commented on pull request #857: HIVE-22463
decimal64 multiplication
URL: https://github.com/apache/hive/pull/857#discussion_r350999381
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
##
@@ -1802,6 +1805,9 @@ private VectorExpression
getDecimal64VectorExpressionForUdf(GenericUDF genericUd
returnDataTypePhysicalVariation = DataTypePhysicalVariation.NONE;
}
+if(dontRescaleArguments && hasConstants) {
Review comment:
Only use unscaled version for column * scalar or scalar * column
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 350073)
Time Spent: 2h 40m (was: 2.5h)
> Support Decimal64 column multiplication with decimal64 Column/Scalar
>
>
> Key: HIVE-22463
> URL: https://issues.apache.org/jira/browse/HIVE-22463
> Project: Hive
> Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch,
> HIVE-22463.11.patch, HIVE-22463.12.patch, HIVE-22463.13.patch,
> HIVE-22463.2.patch, HIVE-22463.3.patch, HIVE-22463.5.patch,
> HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch, HIVE-22463.9.patch
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Support Decimal64 column multiplication with decimal64 Column/Scalar
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=350065=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-350065 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 26/Nov/19 21:50 Start Date: 26/Nov/19 21:50 Worklog Time Spent: 10m Work Description: ramesh0201 commented on pull request #857: HIVE-22463 decimal64 multiplication URL: https://github.com/apache/hive/pull/857 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 350065) Time Spent: 2.5h (was: 2h 20m) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, > HIVE-22463.11.patch, HIVE-22463.12.patch, HIVE-22463.13.patch, > HIVE-22463.2.patch, HIVE-22463.3.patch, HIVE-22463.5.patch, > HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch, HIVE-22463.9.patch > > Time Spent: 2.5h > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[
https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=349590=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349590
]
ASF GitHub Bot logged work on HIVE-22463:
-
Author: ASF GitHub Bot
Created on: 26/Nov/19 06:15
Start Date: 26/Nov/19 06:15
Worklog Time Spent: 10m
Work Description: t3rmin4t0r commented on pull request #856: HIVE-22463
decimal64 multiplication
URL: https://github.com/apache/hive/pull/856#discussion_r350558292
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExpressionDescriptor.java
##
@@ -286,19 +292,24 @@ public boolean matches(Descriptor other) {
return false;
}
}
+ if (unscaled != other.unscaled) {
Review comment:
Check before args?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 349590)
Time Spent: 2h (was: 1h 50m)
> Support Decimal64 column multiplication with decimal64 Column/Scalar
>
>
> Key: HIVE-22463
> URL: https://issues.apache.org/jira/browse/HIVE-22463
> Project: Hive
> Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch,
> HIVE-22463.11.patch, HIVE-22463.2.patch, HIVE-22463.3.patch,
> HIVE-22463.5.patch, HIVE-22463.6.patch, HIVE-22463.7.patch,
> HIVE-22463.8.patch, HIVE-22463.9.patch
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Support Decimal64 column multiplication with decimal64 Column/Scalar
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[
https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=349587=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349587
]
ASF GitHub Bot logged work on HIVE-22463:
-
Author: ASF GitHub Bot
Created on: 26/Nov/19 06:15
Start Date: 26/Nov/19 06:15
Worklog Time Spent: 10m
Work Description: t3rmin4t0r commented on pull request #856: HIVE-22463
decimal64 multiplication
URL: https://github.com/apache/hive/pull/856#discussion_r350557222
##
File path:
ql/src/gen/vectorization/ExpressionTemplates/Decimal64ScalarArithmeticDecimal64Column.txt
##
@@ -38,8 +38,8 @@ public class extends VectorExpression {
private static final long serialVersionUID = 1L;
- private int colNum;
- private long value;
+ protected int colNum;
Review comment:
Make them final, to make sure the values aren't changed after init
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 349587)
Time Spent: 1h 40m (was: 1.5h)
> Support Decimal64 column multiplication with decimal64 Column/Scalar
>
>
> Key: HIVE-22463
> URL: https://issues.apache.org/jira/browse/HIVE-22463
> Project: Hive
> Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch,
> HIVE-22463.11.patch, HIVE-22463.2.patch, HIVE-22463.3.patch,
> HIVE-22463.5.patch, HIVE-22463.6.patch, HIVE-22463.7.patch,
> HIVE-22463.8.patch, HIVE-22463.9.patch
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Support Decimal64 column multiplication with decimal64 Column/Scalar
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[
https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=349589=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349589
]
ASF GitHub Bot logged work on HIVE-22463:
-
Author: ASF GitHub Bot
Created on: 26/Nov/19 06:15
Start Date: 26/Nov/19 06:15
Worklog Time Spent: 10m
Work Description: t3rmin4t0r commented on pull request #856: HIVE-22463
decimal64 multiplication
URL: https://github.com/apache/hive/pull/856#discussion_r350557269
##
File path:
ql/src/gen/vectorization/ExpressionTemplates/Decimal64ScalarArithmeticDecimal64Column.txt
##
@@ -211,4 +211,4 @@ public class extends VectorExpression {
VectorExpressionDescriptor.InputExpressionType.SCALAR,
VectorExpressionDescriptor.InputExpressionType.COLUMN).build();
}
-}
\ No newline at end of file
+}
Review comment:
ws warning
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 349589)
Time Spent: 1h 50m (was: 1h 40m)
> Support Decimal64 column multiplication with decimal64 Column/Scalar
>
>
> Key: HIVE-22463
> URL: https://issues.apache.org/jira/browse/HIVE-22463
> Project: Hive
> Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch,
> HIVE-22463.11.patch, HIVE-22463.2.patch, HIVE-22463.3.patch,
> HIVE-22463.5.patch, HIVE-22463.6.patch, HIVE-22463.7.patch,
> HIVE-22463.8.patch, HIVE-22463.9.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Support Decimal64 column multiplication with decimal64 Column/Scalar
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[
https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=349592=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349592
]
ASF GitHub Bot logged work on HIVE-22463:
-
Author: ASF GitHub Bot
Created on: 26/Nov/19 06:15
Start Date: 26/Nov/19 06:15
Worklog Time Spent: 10m
Work Description: t3rmin4t0r commented on pull request #856: HIVE-22463
decimal64 multiplication
URL: https://github.com/apache/hive/pull/856#discussion_r350557618
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExpressionDescriptor.java
##
@@ -286,19 +292,24 @@ public boolean matches(Descriptor other) {
return false;
}
}
+ if (unscaled != other.unscaled) {
+return false;
+ }
return true;
}
private final Mode mode;
private final ArgumentType [] argTypes;
private final InputExpressionType [] exprTypes;
private final int argCount;
+private boolean unscaled;
Review comment:
another missing final?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 349592)
Time Spent: 2h 10m (was: 2h)
> Support Decimal64 column multiplication with decimal64 Column/Scalar
>
>
> Key: HIVE-22463
> URL: https://issues.apache.org/jira/browse/HIVE-22463
> Project: Hive
> Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch,
> HIVE-22463.11.patch, HIVE-22463.2.patch, HIVE-22463.3.patch,
> HIVE-22463.5.patch, HIVE-22463.6.patch, HIVE-22463.7.patch,
> HIVE-22463.8.patch, HIVE-22463.9.patch
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Support Decimal64 column multiplication with decimal64 Column/Scalar
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=349593=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349593 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 26/Nov/19 06:15 Start Date: 26/Nov/19 06:15 Worklog Time Spent: 10m Work Description: t3rmin4t0r commented on pull request #856: HIVE-22463 decimal64 multiplication URL: https://github.com/apache/hive/pull/856#discussion_r350558668 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java ## @@ -3398,7 +3408,8 @@ private VectorExpression tryDecimal64Between(VectorExpressionDescriptor.Mode mod cl, childrenAfterNot, VectorExpressionDescriptor.Mode.PROJECTION, /* isDecimal64ScaleEstablished */ true, /* decimal64ColumnScale */ ((DecimalTypeInfo) colExpr.getTypeInfo()).getScale(), -returnTypeInfo, DataTypePhysicalVariation.NONE); +returnTypeInfo, DataTypePhysicalVariation.NONE, +/* dontRescaleArguments */ false); Review comment: with the comment that does look very odd - "don't = false" This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 349593) Time Spent: 2h 20m (was: 2h 10m) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, > HIVE-22463.11.patch, HIVE-22463.2.patch, HIVE-22463.3.patch, > HIVE-22463.5.patch, HIVE-22463.6.patch, HIVE-22463.7.patch, > HIVE-22463.8.patch, HIVE-22463.9.patch > > Time Spent: 2h 20m > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=349591=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349591 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 26/Nov/19 06:15 Start Date: 26/Nov/19 06:15 Worklog Time Spent: 10m Work Description: t3rmin4t0r commented on pull request #856: HIVE-22463 decimal64 multiplication URL: https://github.com/apache/hive/pull/856#discussion_r350558562 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java ## @@ -1851,6 +1857,7 @@ private VectorExpression createDecimal64VectorExpression(Class vectorClass, VectorExpression filterExpr = getFilterOnBooleanColumnExpression((ExprNodeColumnDesc) childExpr, colIndex); + Review comment: ws nit This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 349591) Time Spent: 2h 10m (was: 2h) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, > HIVE-22463.11.patch, HIVE-22463.2.patch, HIVE-22463.3.patch, > HIVE-22463.5.patch, HIVE-22463.6.patch, HIVE-22463.7.patch, > HIVE-22463.8.patch, HIVE-22463.9.patch > > Time Spent: 2h 10m > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[
https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=349588=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349588
]
ASF GitHub Bot logged work on HIVE-22463:
-
Author: ASF GitHub Bot
Created on: 26/Nov/19 06:15
Start Date: 26/Nov/19 06:15
Worklog Time Spent: 10m
Work Description: t3rmin4t0r commented on pull request #856: HIVE-22463
decimal64 multiplication
URL: https://github.com/apache/hive/pull/856#discussion_r350558504
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExpressionDescriptor.java
##
@@ -286,19 +292,24 @@ public boolean matches(Descriptor other) {
return false;
}
}
+ if (unscaled != other.unscaled) {
+return false;
+ }
return true;
}
private final Mode mode;
private final ArgumentType [] argTypes;
private final InputExpressionType [] exprTypes;
private final int argCount;
+private boolean unscaled;
Review comment:
The build has non-finals, but the actual class has all finals (that's a good
convention)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 349588)
Time Spent: 1h 50m (was: 1h 40m)
> Support Decimal64 column multiplication with decimal64 Column/Scalar
>
>
> Key: HIVE-22463
> URL: https://issues.apache.org/jira/browse/HIVE-22463
> Project: Hive
> Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch,
> HIVE-22463.11.patch, HIVE-22463.2.patch, HIVE-22463.3.patch,
> HIVE-22463.5.patch, HIVE-22463.6.patch, HIVE-22463.7.patch,
> HIVE-22463.8.patch, HIVE-22463.9.patch
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Support Decimal64 column multiplication with decimal64 Column/Scalar
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=349581=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349581 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 26/Nov/19 06:03 Start Date: 26/Nov/19 06:03 Worklog Time Spent: 10m Work Description: ramesh0201 commented on pull request #856: HIVE-22463 decimal64 multiplication URL: https://github.com/apache/hive/pull/856 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 349581) Time Spent: 1.5h (was: 1h 20m) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, > HIVE-22463.11.patch, HIVE-22463.2.patch, HIVE-22463.3.patch, > HIVE-22463.5.patch, HIVE-22463.6.patch, HIVE-22463.7.patch, > HIVE-22463.8.patch, HIVE-22463.9.patch > > Time Spent: 1.5h > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[
https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=349356=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349356
]
ASF GitHub Bot logged work on HIVE-22463:
-
Author: ASF GitHub Bot
Created on: 25/Nov/19 21:05
Start Date: 25/Nov/19 21:05
Worklog Time Spent: 10m
Work Description: t3rmin4t0r commented on pull request #853: HIVE-22463
decimal64 multiplication
URL: https://github.com/apache/hive/pull/853#discussion_r350421423
##
File path:
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java
##
@@ -1848,13 +1851,8 @@ private VectorExpression
createDecimal64VectorExpression(Class vectorClass,
} else if (childExpr instanceof ExprNodeColumnDesc) {
int colIndex = getInputColumnIndex((ExprNodeColumnDesc) childExpr);
if (childrenMode == VectorExpressionDescriptor.Mode.FILTER) {
-
VectorExpression filterExpr =
getFilterOnBooleanColumnExpression((ExprNodeColumnDesc)
childExpr, colIndex);
- if (filterExpr == null) {
Review comment:
This needs to go back in
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 349356)
Time Spent: 1h 20m (was: 1h 10m)
> Support Decimal64 column multiplication with decimal64 Column/Scalar
>
>
> Key: HIVE-22463
> URL: https://issues.apache.org/jira/browse/HIVE-22463
> Project: Hive
> Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch,
> HIVE-22463.2.patch, HIVE-22463.3.patch, HIVE-22463.5.patch,
> HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch, HIVE-22463.9.patch
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Support Decimal64 column multiplication with decimal64 Column/Scalar
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=349341=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349341 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 25/Nov/19 20:48 Start Date: 25/Nov/19 20:48 Worklog Time Spent: 10m Work Description: t3rmin4t0r commented on pull request #853: HIVE-22463 decimal64 multiplication URL: https://github.com/apache/hive/pull/853#discussion_r350414580 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java ## @@ -1810,17 +1811,19 @@ private VectorExpression getDecimal64VectorExpressionForUdf(GenericUDF genericUd } VectorExpressionDescriptor.Mode childrenMode = getChildrenMode(mode, udfClass); +boolean dontScaleArguments = (genericUdf instanceof GenericUDFOPMultiply); Review comment: Move this up, make it final and check instead of the UDF check on #L1792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 349341) Time Spent: 1h 10m (was: 1h) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, > HIVE-22463.2.patch, HIVE-22463.3.patch, HIVE-22463.5.patch, > HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch, HIVE-22463.9.patch > > Time Spent: 1h 10m > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=349340=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349340 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 25/Nov/19 20:48 Start Date: 25/Nov/19 20:48 Worklog Time Spent: 10m Work Description: t3rmin4t0r commented on pull request #853: HIVE-22463 decimal64 multiplication URL: https://github.com/apache/hive/pull/853#discussion_r350410304 ## File path: ql/src/test/results/clientpositive/vector_decimal64_mul_decimal64scalar.q.out ## @@ -0,0 +1,142 @@ +PREHOOK: query: create external table vector_decimal64_mul_decimal64scalar(ss_ext_list_price decimal(7,2), ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2), ss_ext_sales_price decimal(7,2)) ROW FORMAT DELIMITED FIELDS TERMINATED BY ',' LINES TERMINATED BY '\n' STORED AS TEXTFILE +PREHOOK: type: CREATETABLE +PREHOOK: Output: database:default +PREHOOK: Output: default@vector_decimal64_mul_decimal64scalar +POSTHOOK: query: create external table vector_decimal64_mul_decimal64scalar(ss_ext_list_price decimal(7,2), ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2), ss_ext_sales_price decimal(7,2)) ROW FORMAT DELIMITED FIELDS TERMINATED BY ',' LINES TERMINATED BY '\n' STORED AS TEXTFILE +POSTHOOK: type: CREATETABLE +POSTHOOK: Output: database:default +POSTHOOK: Output: default@vector_decimal64_mul_decimal64scalar +PREHOOK: query: LOAD DATA LOCAL INPATH '../../data/files/decimal64table.csv' OVERWRITE INTO TABLE vector_decimal64_mul_decimal64scalar +PREHOOK: type: LOAD + A masked pattern was here +PREHOOK: Output: default@vector_decimal64_mul_decimal64scalar +POSTHOOK: query: LOAD DATA LOCAL INPATH '../../data/files/decimal64table.csv' OVERWRITE INTO TABLE vector_decimal64_mul_decimal64scalar +POSTHOOK: type: LOAD + A masked pattern was here +POSTHOOK: Output: default@vector_decimal64_mul_decimal64scalar +PREHOOK: query: create table vector_decimal64_mul_decimal64scalar_tmp(ss_ext_list_price decimal(7,2), ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2), ss_ext_sales_price decimal(7,2)) stored as ORC +PREHOOK: type: CREATETABLE +PREHOOK: Output: database:default +PREHOOK: Output: default@vector_decimal64_mul_decimal64scalar_tmp +POSTHOOK: query: create table vector_decimal64_mul_decimal64scalar_tmp(ss_ext_list_price decimal(7,2), ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2), ss_ext_sales_price decimal(7,2)) stored as ORC +POSTHOOK: type: CREATETABLE +POSTHOOK: Output: database:default +POSTHOOK: Output: default@vector_decimal64_mul_decimal64scalar_tmp +PREHOOK: query: insert into table vector_decimal64_mul_decimal64scalar_tmp select * from vector_decimal64_mul_decimal64scalar +PREHOOK: type: QUERY +PREHOOK: Input: default@vector_decimal64_mul_decimal64scalar +PREHOOK: Output: default@vector_decimal64_mul_decimal64scalar_tmp +POSTHOOK: query: insert into table vector_decimal64_mul_decimal64scalar_tmp select * from vector_decimal64_mul_decimal64scalar +POSTHOOK: type: QUERY +POSTHOOK: Input: default@vector_decimal64_mul_decimal64scalar +POSTHOOK: Output: default@vector_decimal64_mul_decimal64scalar_tmp +POSTHOOK: Lineage: vector_decimal64_mul_decimal64scalar_tmp.ss_ext_discount_amt SIMPLE [(vector_decimal64_mul_decimal64scalar)vector_decimal64_mul_decimal64scalar.FieldSchema(name:ss_ext_discount_amt, type:decimal(7,2), comment:null), ] +POSTHOOK: Lineage: vector_decimal64_mul_decimal64scalar_tmp.ss_ext_list_price SIMPLE [(vector_decimal64_mul_decimal64scalar)vector_decimal64_mul_decimal64scalar.FieldSchema(name:ss_ext_list_price, type:decimal(7,2), comment:null), ] +POSTHOOK: Lineage: vector_decimal64_mul_decimal64scalar_tmp.ss_ext_sales_price SIMPLE [(vector_decimal64_mul_decimal64scalar)vector_decimal64_mul_decimal64scalar.FieldSchema(name:ss_ext_sales_price, type:decimal(7,2), comment:null), ] +POSTHOOK: Lineage: vector_decimal64_mul_decimal64scalar_tmp.ss_ext_wholesale_cost SIMPLE [(vector_decimal64_mul_decimal64scalar)vector_decimal64_mul_decimal64scalar.FieldSchema(name:ss_ext_wholesale_cost, type:decimal(7,2), comment:null), ] +PREHOOK: query: explain vectorization detail select sum(((ss_ext_list_price-ss_ext_wholesale_cost-ss_ext_discount_amt)+ss_ext_sales_price)*2.2) from vector_decimal64_mul_decimal64scalar_tmp +PREHOOK: type: QUERY +PREHOOK: Input: default@vector_decimal64_mul_decimal64scalar_tmp + A masked pattern was here +POSTHOOK: query: explain vectorization detail select sum(((ss_ext_list_price-ss_ext_wholesale_cost-ss_ext_discount_amt)+ss_ext_sales_price)*2.2) from vector_decimal64_mul_decimal64scalar_tmp +POSTHOOK: type: QUERY +POSTHOOK: Input: default@vector_decimal64_mul_decimal64scalar_tmp + A masked pattern was here +PLAN VECTORIZATION: +
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=349247=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-349247 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 25/Nov/19 18:26 Start Date: 25/Nov/19 18:26 Worklog Time Spent: 10m Work Description: ramesh0201 commented on pull request #853: HIVE-22463 decimal64 multiplication URL: https://github.com/apache/hive/pull/853 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 349247) Time Spent: 1h (was: 50m) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22463.1.patch, HIVE-22463.10.patch, > HIVE-22463.2.patch, HIVE-22463.3.patch, HIVE-22463.5.patch, > HIVE-22463.6.patch, HIVE-22463.7.patch, HIVE-22463.8.patch, HIVE-22463.9.patch > > Time Spent: 1h > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=347539=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347539 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 21/Nov/19 17:14 Start Date: 21/Nov/19 17:14 Worklog Time Spent: 10m Work Description: t3rmin4t0r commented on pull request #846: HIVE-22463 decimal64 multiplication URL: https://github.com/apache/hive/pull/846#discussion_r348781288 ## File path: ql/src/gen/vectorization/ExpressionTemplates/Decimal64ScalarMultiplyDecimal64Column.txt ## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hive.ql.exec.vector.expressions.gen; + +import java.util.Arrays; + +import org.apache.hadoop.hive.ql.exec.vector.Decimal64ColumnVector; +import org.apache.hadoop.hive.ql.exec.vector.VectorExpressionDescriptor; +import org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch; +import org.apache.hadoop.hive.ql.exec.vector.expressions.Decimal64Util; +import org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression; +import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable; +import org.apache.hadoop.hive.serde2.typeinfo.DecimalTypeInfo; +import org.apache.hadoop.hive.ql.metadata.HiveException; + +/** + * Generated from template Decimal64ScalarArithmeticDecimal64Column.txt. Review comment: We don't need 2 classes for this, because multiply is commutative This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 347539) Time Spent: 50m (was: 40m) > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22463.1.patch, HIVE-22463.2.patch, > HIVE-22463.3.patch, HIVE-22463.5.patch, HIVE-22463.6.patch, > HIVE-22463.7.patch, HIVE-22463.8.patch > > Time Spent: 50m > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[
https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=347538=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347538
]
ASF GitHub Bot logged work on HIVE-22463:
-
Author: ASF GitHub Bot
Created on: 21/Nov/19 17:14
Start Date: 21/Nov/19 17:14
Worklog Time Spent: 10m
Work Description: t3rmin4t0r commented on pull request #846: HIVE-22463
decimal64 multiplication
URL: https://github.com/apache/hive/pull/846#discussion_r348773487
##
File path:
ql/src/gen/vectorization/ExpressionTemplates/Decimal64ColumnMultiplyDecimal64Scalar.txt
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.exec.vector.expressions.gen;
+
+import java.util.Arrays;
+
+import org.apache.hadoop.hive.ql.exec.vector.Decimal64ColumnVector;
+import org.apache.hadoop.hive.ql.exec.vector.VectorExpressionDescriptor;
+import org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch;
+import org.apache.hadoop.hive.ql.exec.vector.expressions.Decimal64Util;
+import org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression;
+import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable;
+import org.apache.hadoop.hive.serde2.typeinfo.DecimalTypeInfo;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+/**
+ * Generated from template ColumnArithmeticScalar.txt, which covers decimal64
arithmetic
+ * expressions between a column and a scalar.
+ */
+public class extends VectorExpression {
+
+ private static final long serialVersionUID = 1L;
+
+ private final int colNum;
+ private final long value;
+
+ public (int colNum, long value, int outputColumnNum) {
+super(outputColumnNum);
+this.colNum = colNum;
+this.value = value;
+ }
+
+ public () {
+super();
+
+// Dummy final assignments.
+colNum = -1;
+value = 0;
+ }
+
+ @Override
+ public void evaluate(VectorizedRowBatch batch) throws HiveException {
+
+// return immediately if batch is empty
+final int n = batch.size;
+if (n == 0) {
+ return;
+}
+
+if (childExpressions != null) {
+ super.evaluateChildren(batch);
+}
+
+Decimal64ColumnVector inputColVector = (Decimal64ColumnVector)
batch.cols[colNum];
+Decimal64ColumnVector outputColVector = (Decimal64ColumnVector)
batch.cols[outputColumnNum];
+int[] sel = batch.selected;
+boolean[] inputIsNull = inputColVector.isNull;
+boolean[] outputIsNull = outputColVector.isNull;
+
+// We do not need to do a column reset since we are carefully changing the
output.
+outputColVector.isRepeating = false;
+
+long[] vector = inputColVector.vector;
+long[] outputVector = outputColVector.vector;
+
+final long outputDecimal64AbsMax =
+HiveDecimalWritable.getDecimal64AbsMax(outputColVector.precision);
+DecimalTypeInfo lDecimalTypeInfo = (DecimalTypeInfo) inputTypeInfos[0];
+DecimalTypeInfo rDecimalTypeInfo = (DecimalTypeInfo) inputTypeInfos[1];
+HiveDecimalWritable writable = new HiveDecimalWritable();
+writable.deserialize64(value, lDecimalTypeInfo.scale() -
rDecimalTypeInfo.scale());
Review comment:
Does this operation belong within the evaluate() - looks like several of
these parameters do not change across evaluate() calls
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 347538)
Time Spent: 40m (was: 0.5h)
> Support Decimal64 column multiplication with decimal64 Column/Scalar
>
>
> Key: HIVE-22463
> URL: https://issues.apache.org/jira/browse/HIVE-22463
> Project: Hive
> Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[
https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=347537=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347537
]
ASF GitHub Bot logged work on HIVE-22463:
-
Author: ASF GitHub Bot
Created on: 21/Nov/19 17:14
Start Date: 21/Nov/19 17:14
Worklog Time Spent: 10m
Work Description: t3rmin4t0r commented on pull request #846: HIVE-22463
decimal64 multiplication
URL: https://github.com/apache/hive/pull/846#discussion_r348773917
##
File path:
ql/src/gen/vectorization/ExpressionTemplates/Decimal64ColumnMultiplyDecimal64Scalar.txt
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.exec.vector.expressions.gen;
+
+import java.util.Arrays;
+
+import org.apache.hadoop.hive.ql.exec.vector.Decimal64ColumnVector;
+import org.apache.hadoop.hive.ql.exec.vector.VectorExpressionDescriptor;
+import org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch;
+import org.apache.hadoop.hive.ql.exec.vector.expressions.Decimal64Util;
+import org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression;
+import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable;
+import org.apache.hadoop.hive.serde2.typeinfo.DecimalTypeInfo;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+/**
+ * Generated from template ColumnArithmeticScalar.txt, which covers decimal64
arithmetic
+ * expressions between a column and a scalar.
+ */
+public class extends VectorExpression {
+
+ private static final long serialVersionUID = 1L;
+
+ private final int colNum;
+ private final long value;
+
+ public (int colNum, long value, int outputColumnNum) {
+super(outputColumnNum);
+this.colNum = colNum;
+this.value = value;
Review comment:
This is a better place to compute most of the constant checks within the
evaluate()
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 347537)
Time Spent: 0.5h (was: 20m)
> Support Decimal64 column multiplication with decimal64 Column/Scalar
>
>
> Key: HIVE-22463
> URL: https://issues.apache.org/jira/browse/HIVE-22463
> Project: Hive
> Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Labels: pull-request-available
> Attachments: HIVE-22463.1.patch, HIVE-22463.2.patch,
> HIVE-22463.3.patch, HIVE-22463.5.patch, HIVE-22463.6.patch,
> HIVE-22463.7.patch, HIVE-22463.8.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Support Decimal64 column multiplication with decimal64 Column/Scalar
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[
https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=347536=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347536
]
ASF GitHub Bot logged work on HIVE-22463:
-
Author: ASF GitHub Bot
Created on: 21/Nov/19 17:14
Start Date: 21/Nov/19 17:14
Worklog Time Spent: 10m
Work Description: t3rmin4t0r commented on pull request #846: HIVE-22463
decimal64 multiplication
URL: https://github.com/apache/hive/pull/846#discussion_r348781170
##
File path:
ql/src/gen/vectorization/ExpressionTemplates/Decimal64ColumnMultiplyDecimal64Scalar.txt
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.exec.vector.expressions.gen;
+
+import java.util.Arrays;
+
+import org.apache.hadoop.hive.ql.exec.vector.Decimal64ColumnVector;
+import org.apache.hadoop.hive.ql.exec.vector.VectorExpressionDescriptor;
+import org.apache.hadoop.hive.ql.exec.vector.VectorizedRowBatch;
+import org.apache.hadoop.hive.ql.exec.vector.expressions.Decimal64Util;
+import org.apache.hadoop.hive.ql.exec.vector.expressions.VectorExpression;
+import org.apache.hadoop.hive.serde2.io.HiveDecimalWritable;
+import org.apache.hadoop.hive.serde2.typeinfo.DecimalTypeInfo;
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+
+/**
+ * Generated from template ColumnArithmeticScalar.txt, which covers decimal64
arithmetic
+ * expressions between a column and a scalar.
+ */
+public class extends VectorExpression {
+
+ private static final long serialVersionUID = 1L;
+
+ private final int colNum;
+ private final long value;
+
+ public (int colNum, long value, int outputColumnNum) {
+super(outputColumnNum);
+this.colNum = colNum;
+this.value = value;
+ }
+
+ public () {
+super();
+
+// Dummy final assignments.
+colNum = -1;
+value = 0;
+ }
+
+ @Override
+ public void evaluate(VectorizedRowBatch batch) throws HiveException {
+
+// return immediately if batch is empty
+final int n = batch.size;
+if (n == 0) {
+ return;
+}
+
+if (childExpressions != null) {
+ super.evaluateChildren(batch);
+}
+
+Decimal64ColumnVector inputColVector = (Decimal64ColumnVector)
batch.cols[colNum];
+Decimal64ColumnVector outputColVector = (Decimal64ColumnVector)
batch.cols[outputColumnNum];
+int[] sel = batch.selected;
+boolean[] inputIsNull = inputColVector.isNull;
+boolean[] outputIsNull = outputColVector.isNull;
+
+// We do not need to do a column reset since we are carefully changing the
output.
+outputColVector.isRepeating = false;
+
+long[] vector = inputColVector.vector;
+long[] outputVector = outputColVector.vector;
+
+final long outputDecimal64AbsMax =
+HiveDecimalWritable.getDecimal64AbsMax(outputColVector.precision);
+DecimalTypeInfo lDecimalTypeInfo = (DecimalTypeInfo) inputTypeInfos[0];
+DecimalTypeInfo rDecimalTypeInfo = (DecimalTypeInfo) inputTypeInfos[1];
+HiveDecimalWritable writable = new HiveDecimalWritable();
+writable.deserialize64(value, lDecimalTypeInfo.scale() -
rDecimalTypeInfo.scale());
Review comment:
Also I'm confused by what it actually does for the output result scaling here
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 347536)
Time Spent: 20m (was: 10m)
> Support Decimal64 column multiplication with decimal64 Column/Scalar
>
>
> Key: HIVE-22463
> URL: https://issues.apache.org/jira/browse/HIVE-22463
> Project: Hive
> Issue Type: Bug
>Reporter: Ramesh Kumar Thangarajan
>Assignee: Ramesh Kumar Thangarajan
>Priority: Major
> Labels:
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=347540=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-347540 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 21/Nov/19 17:14 Start Date: 21/Nov/19 17:14 Worklog Time Spent: 10m Work Description: t3rmin4t0r commented on pull request #846: HIVE-22463 decimal64 multiplication URL: https://github.com/apache/hive/pull/846#discussion_r348781677 ## File path: ql/src/test/results/clientpositive/vector_decimal64_mul_decimal64column.q.out ## @@ -0,0 +1,142 @@ +PREHOOK: query: create external table vector_decimal64_mul_decimal64column(ss_ext_list_price decimal(7,2), ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2), ss_ext_sales_price decimal(7,2)) ROW FORMAT DELIMITED FIELDS TERMINATED BY ',' LINES TERMINATED BY '\n' STORED AS TEXTFILE +PREHOOK: type: CREATETABLE +PREHOOK: Output: database:default +PREHOOK: Output: default@vector_decimal64_mul_decimal64column +POSTHOOK: query: create external table vector_decimal64_mul_decimal64column(ss_ext_list_price decimal(7,2), ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2), ss_ext_sales_price decimal(7,2)) ROW FORMAT DELIMITED FIELDS TERMINATED BY ',' LINES TERMINATED BY '\n' STORED AS TEXTFILE +POSTHOOK: type: CREATETABLE +POSTHOOK: Output: database:default +POSTHOOK: Output: default@vector_decimal64_mul_decimal64column +PREHOOK: query: LOAD DATA LOCAL INPATH '../../data/files/decimal64table.csv' OVERWRITE INTO TABLE vector_decimal64_mul_decimal64column +PREHOOK: type: LOAD + A masked pattern was here +PREHOOK: Output: default@vector_decimal64_mul_decimal64column +POSTHOOK: query: LOAD DATA LOCAL INPATH '../../data/files/decimal64table.csv' OVERWRITE INTO TABLE vector_decimal64_mul_decimal64column +POSTHOOK: type: LOAD + A masked pattern was here +POSTHOOK: Output: default@vector_decimal64_mul_decimal64column +PREHOOK: query: create table vector_decimal64_mul_decimal64column_tmp(ss_ext_list_price decimal(7,2), ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2), ss_ext_sales_price decimal(7,2)) stored as ORC +PREHOOK: type: CREATETABLE +PREHOOK: Output: database:default +PREHOOK: Output: default@vector_decimal64_mul_decimal64column_tmp +POSTHOOK: query: create table vector_decimal64_mul_decimal64column_tmp(ss_ext_list_price decimal(7,2), ss_ext_wholesale_cost decimal(7,2), ss_ext_discount_amt decimal(7,2), ss_ext_sales_price decimal(7,2)) stored as ORC +POSTHOOK: type: CREATETABLE +POSTHOOK: Output: database:default +POSTHOOK: Output: default@vector_decimal64_mul_decimal64column_tmp +PREHOOK: query: insert into table vector_decimal64_mul_decimal64column_tmp select * from vector_decimal64_mul_decimal64column +PREHOOK: type: QUERY +PREHOOK: Input: default@vector_decimal64_mul_decimal64column +PREHOOK: Output: default@vector_decimal64_mul_decimal64column_tmp +POSTHOOK: query: insert into table vector_decimal64_mul_decimal64column_tmp select * from vector_decimal64_mul_decimal64column +POSTHOOK: type: QUERY +POSTHOOK: Input: default@vector_decimal64_mul_decimal64column +POSTHOOK: Output: default@vector_decimal64_mul_decimal64column_tmp +POSTHOOK: Lineage: vector_decimal64_mul_decimal64column_tmp.ss_ext_discount_amt SIMPLE [(vector_decimal64_mul_decimal64column)vector_decimal64_mul_decimal64column.FieldSchema(name:ss_ext_discount_amt, type:decimal(7,2), comment:null), ] +POSTHOOK: Lineage: vector_decimal64_mul_decimal64column_tmp.ss_ext_list_price SIMPLE [(vector_decimal64_mul_decimal64column)vector_decimal64_mul_decimal64column.FieldSchema(name:ss_ext_list_price, type:decimal(7,2), comment:null), ] +POSTHOOK: Lineage: vector_decimal64_mul_decimal64column_tmp.ss_ext_sales_price SIMPLE [(vector_decimal64_mul_decimal64column)vector_decimal64_mul_decimal64column.FieldSchema(name:ss_ext_sales_price, type:decimal(7,2), comment:null), ] +POSTHOOK: Lineage: vector_decimal64_mul_decimal64column_tmp.ss_ext_wholesale_cost SIMPLE [(vector_decimal64_mul_decimal64column)vector_decimal64_mul_decimal64column.FieldSchema(name:ss_ext_wholesale_cost, type:decimal(7,2), comment:null), ] +PREHOOK: query: explain vectorization detail select sum(ss_ext_list_price*ss_ext_discount_amt) from vector_decimal64_mul_decimal64column_tmp +PREHOOK: type: QUERY +PREHOOK: Input: default@vector_decimal64_mul_decimal64column_tmp + A masked pattern was here +POSTHOOK: query: explain vectorization detail select sum(ss_ext_list_price*ss_ext_discount_amt) from vector_decimal64_mul_decimal64column_tmp +POSTHOOK: type: QUERY +POSTHOOK: Input: default@vector_decimal64_mul_decimal64column_tmp + A masked pattern was here +PLAN VECTORIZATION: + enabled: true + enabledConditionsMet: [hive.vectorized.execution.enabled IS true] + +STAGE
[jira] [Work logged] (HIVE-22463) Support Decimal64 column multiplication with decimal64 Column/Scalar
[ https://issues.apache.org/jira/browse/HIVE-22463?focusedWorklogId=345834=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-345834 ] ASF GitHub Bot logged work on HIVE-22463: - Author: ASF GitHub Bot Created on: 19/Nov/19 06:55 Start Date: 19/Nov/19 06:55 Worklog Time Spent: 10m Work Description: ramesh0201 commented on pull request #846: HIVE-22463 decimal64 multiplication URL: https://github.com/apache/hive/pull/846 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 345834) Remaining Estimate: 0h Time Spent: 10m > Support Decimal64 column multiplication with decimal64 Column/Scalar > > > Key: HIVE-22463 > URL: https://issues.apache.org/jira/browse/HIVE-22463 > Project: Hive > Issue Type: Bug >Reporter: Ramesh Kumar Thangarajan >Assignee: Ramesh Kumar Thangarajan >Priority: Major > Labels: pull-request-available > Attachments: HIVE-22463.1.patch, HIVE-22463.2.patch, > HIVE-22463.3.patch, HIVE-22463.5.patch, HIVE-22463.6.patch, > HIVE-22463.7.patch, HIVE-22463.8.patch > > Time Spent: 10m > Remaining Estimate: 0h > > Support Decimal64 column multiplication with decimal64 Column/Scalar -- This message was sent by Atlassian Jira (v8.3.4#803005)
