[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=500511=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-500511 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 14/Oct/20 07:47 Start Date: 14/Oct/20 07:47 Worklog Time Spent: 10m Work Description: kgyrtkirk merged pull request #1205: URL: https://github.com/apache/hive/pull/1205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 500511) Time Spent: 6h 10m (was: 6h) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Assignee: Zhihua Deng >Priority: Minor > Labels: pull-request-available > Fix For: 4.0.0 > > Time Spent: 6h 10m > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=500390=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-500390 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 14/Oct/20 02:45 Start Date: 14/Oct/20 02:45 Worklog Time Spent: 10m Work Description: dengzhhu653 opened a new pull request #1205: URL: https://github.com/apache/hive/pull/1205 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g. HIVE-X: Fix a typo in YYY) For more details, please see https://cwiki.apache.org/confluence/display/Hive/HowToContribute This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 500390) Time Spent: 6h (was: 5h 50m) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Minor > Labels: pull-request-available > Time Spent: 6h > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=500386=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-500386 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 14/Oct/20 02:22 Start Date: 14/Oct/20 02:22 Worklog Time Spent: 10m Work Description: dengzhhu653 commented on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-708113764 Rerun tests to check the failed reading of xml. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 500386) Time Spent: 5h 40m (was: 5.5h) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Minor > Labels: pull-request-available > Time Spent: 5h 40m > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=500387=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-500387 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 14/Oct/20 02:22 Start Date: 14/Oct/20 02:22 Worklog Time Spent: 10m Work Description: dengzhhu653 closed pull request #1205: URL: https://github.com/apache/hive/pull/1205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 500387) Time Spent: 5h 50m (was: 5h 40m) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Minor > Labels: pull-request-available > Time Spent: 5h 50m > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[
https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=498131=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-498131
]
ASF GitHub Bot logged work on HIVE-23800:
-
Author: ASF GitHub Bot
Created on: 09/Oct/20 13:42
Start Date: 09/Oct/20 13:42
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #1205:
URL: https://github.com/apache/hive/pull/1205#discussion_r502158480
##
File path: ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java
##
@@ -45,7 +47,50 @@
public class HookContext {
static public enum HookType {
-PRE_EXEC_HOOK, POST_EXEC_HOOK, ON_FAILURE_HOOK
+
Review comment:
Checked on my test and production env, it shows that the hooks compiled
for the old api can be reused without any changes with the new implementation.
##
File path: ql/src/java/org/apache/hadoop/hive/ql/HookRunner.java
##
@@ -39,57 +36,27 @@
import org.apache.hadoop.hive.ql.parse.HiveSemanticAnalyzerHook;
import org.apache.hadoop.hive.ql.parse.HiveSemanticAnalyzerHookContext;
import org.apache.hadoop.hive.ql.session.SessionState;
-import org.apache.hadoop.hive.ql.session.SessionState.LogHelper;
import org.apache.hive.common.util.HiveStringUtils;
+import static org.apache.hadoop.hive.ql.hooks.HookContext.HookType.*;
+
/**
* Handles hook executions for {@link Driver}.
*/
public class HookRunner {
private static final String CLASS_NAME = Driver.class.getName();
private final HiveConf conf;
- private LogHelper console;
- private List queryHooks = new ArrayList<>();
- private List saHooks = new ArrayList<>();
- private List driverRunHooks = new ArrayList<>();
- private List preExecHooks = new ArrayList<>();
- private List postExecHooks = new ArrayList<>();
- private List onFailureHooks = new ArrayList<>();
- private boolean initialized = false;
+ private final HooksLoader loader;
Review comment:
Rename it to HiveHooks instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 498131)
Time Spent: 5.5h (was: 5h 20m)
> Add hooks when HiveServer2 stops due to OutOfMemoryError
>
>
> Key: HIVE-23800
> URL: https://issues.apache.org/jira/browse/HIVE-23800
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Reporter: Zhihua Deng
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Make oom hook an interface of HiveServer2, so user can implement the hook to
> do something before HS2 stops, such as dumping the heap or altering the
> devops.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[
https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=497721=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-497721
]
ASF GitHub Bot logged work on HIVE-23800:
-
Author: ASF GitHub Bot
Created on: 09/Oct/20 03:01
Start Date: 09/Oct/20 03:01
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #1205:
URL: https://github.com/apache/hive/pull/1205#discussion_r502158480
##
File path: ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java
##
@@ -45,7 +47,50 @@
public class HookContext {
static public enum HookType {
-PRE_EXEC_HOOK, POST_EXEC_HOOK, ON_FAILURE_HOOK
+
Review comment:
Checked on my test and production env, it shows that the hooks compiled
for the old api can be reused without any changes with the new implementation.
##
File path: ql/src/java/org/apache/hadoop/hive/ql/HookRunner.java
##
@@ -39,57 +36,27 @@
import org.apache.hadoop.hive.ql.parse.HiveSemanticAnalyzerHook;
import org.apache.hadoop.hive.ql.parse.HiveSemanticAnalyzerHookContext;
import org.apache.hadoop.hive.ql.session.SessionState;
-import org.apache.hadoop.hive.ql.session.SessionState.LogHelper;
import org.apache.hive.common.util.HiveStringUtils;
+import static org.apache.hadoop.hive.ql.hooks.HookContext.HookType.*;
+
/**
* Handles hook executions for {@link Driver}.
*/
public class HookRunner {
private static final String CLASS_NAME = Driver.class.getName();
private final HiveConf conf;
- private LogHelper console;
- private List queryHooks = new ArrayList<>();
- private List saHooks = new ArrayList<>();
- private List driverRunHooks = new ArrayList<>();
- private List preExecHooks = new ArrayList<>();
- private List postExecHooks = new ArrayList<>();
- private List onFailureHooks = new ArrayList<>();
- private boolean initialized = false;
+ private final HooksLoader loader;
Review comment:
Rename it to HiveHooks instead.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 497721)
Time Spent: 5h 20m (was: 5h 10m)
> Add hooks when HiveServer2 stops due to OutOfMemoryError
>
>
> Key: HIVE-23800
> URL: https://issues.apache.org/jira/browse/HIVE-23800
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Reporter: Zhihua Deng
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> Make oom hook an interface of HiveServer2, so user can implement the hook to
> do something before HS2 stops, such as dumping the heap or altering the
> devops.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[
https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=496538=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-496538
]
ASF GitHub Bot logged work on HIVE-23800:
-
Author: ASF GitHub Bot
Created on: 07/Oct/20 12:14
Start Date: 07/Oct/20 12:14
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #1205:
URL: https://github.com/apache/hive/pull/1205#discussion_r500961287
##
File path: ql/src/java/org/apache/hadoop/hive/ql/HookRunner.java
##
@@ -39,57 +36,27 @@
import org.apache.hadoop.hive.ql.parse.HiveSemanticAnalyzerHook;
import org.apache.hadoop.hive.ql.parse.HiveSemanticAnalyzerHookContext;
import org.apache.hadoop.hive.ql.session.SessionState;
-import org.apache.hadoop.hive.ql.session.SessionState.LogHelper;
import org.apache.hive.common.util.HiveStringUtils;
+import static org.apache.hadoop.hive.ql.hooks.HookContext.HookType.*;
+
/**
* Handles hook executions for {@link Driver}.
*/
public class HookRunner {
private static final String CLASS_NAME = Driver.class.getName();
private final HiveConf conf;
- private LogHelper console;
- private List queryHooks = new ArrayList<>();
- private List saHooks = new ArrayList<>();
- private List driverRunHooks = new ArrayList<>();
- private List preExecHooks = new ArrayList<>();
- private List postExecHooks = new ArrayList<>();
- private List onFailureHooks = new ArrayList<>();
- private boolean initialized = false;
+ private final HooksLoader loader;
Review comment:
this is great!
since from now on we can also dynamically add new hooks to it at runtime -
we may rename it from "Loader" to something else.
##
File path: ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java
##
@@ -45,7 +47,50 @@
public class HookContext {
static public enum HookType {
-PRE_EXEC_HOOK, POST_EXEC_HOOK, ON_FAILURE_HOOK
+
Review comment:
I like this approach - could you make a small check:
* if we have hook compiled for the old api (which uses say the enum key
`HookType.PRE_EXEC_HOOK`)
* will it work or not (without recompilation) with the new implementation
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 496538)
Time Spent: 5h 10m (was: 5h)
> Add hooks when HiveServer2 stops due to OutOfMemoryError
>
>
> Key: HIVE-23800
> URL: https://issues.apache.org/jira/browse/HIVE-23800
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Reporter: Zhihua Deng
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Make oom hook an interface of HiveServer2, so user can implement the hook to
> do something before HS2 stops, such as dumping the heap or altering the
> devops.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[
https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=484907=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-484907
]
ASF GitHub Bot logged work on HIVE-23800:
-
Author: ASF GitHub Bot
Created on: 16/Sep/20 03:48
Start Date: 16/Sep/20 03:48
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #1205:
URL: https://github.com/apache/hive/pull/1205#discussion_r489144427
##
File path: ql/src/java/org/apache/hadoop/hive/ql/hooks/HookContext.java
##
@@ -45,7 +47,50 @@
public class HookContext {
static public enum HookType {
-PRE_EXEC_HOOK, POST_EXEC_HOOK, ON_FAILURE_HOOK
+
+PRE_EXEC_HOOK(HiveConf.ConfVars.PREEXECHOOKS, ExecuteWithHookContext.class,
+"Pre-execution hooks to be invoked for each statement"),
+POST_EXEC_HOOK(HiveConf.ConfVars.POSTEXECHOOKS,
ExecuteWithHookContext.class,
+"Post-execution hooks to be invoked for each statement"),
+ON_FAILURE_HOOK(HiveConf.ConfVars.ONFAILUREHOOKS,
ExecuteWithHookContext.class,
+"On-failure hooks to be invoked for each statement"),
+QUERY_LIFETIME_HOOKS(HiveConf.ConfVars.HIVE_QUERY_LIFETIME_HOOKS,
QueryLifeTimeHook.class,
+ "Hooks that will be triggered before/after query compilation and
before/after query execution"),
+SEMANTIC_ANALYZER_HOOK(HiveConf.ConfVars.SEMANTIC_ANALYZER_HOOK,
HiveSemanticAnalyzerHook.class,
+ "Hooks that invoked before/after Hive performs its own semantic analysis
on a statement"),
+DRIVER_RUN_HOOKS(HiveConf.ConfVars.HIVE_DRIVER_RUN_HOOKS,
HiveDriverRunHook.class,
+ "Hooks that Will be run at the beginning and end of Driver.run"),
+REDACTOR(HiveConf.ConfVars.QUERYREDACTORHOOKS, Redactor.class,
+ "Hooks to be invoked for each query which can tranform the query before
it's placed in the job.xml file"),
+// The HiveSessionHook.class cannot access, use Hook.class instead
+HIVE_SERVER2_SESSION_HOOK(HiveConf.ConfVars.HIVE_SERVER2_SESSION_HOOK,
Hook.class,
+ "Hooks to be executed when session manager starts a new session"),
+OOM(HiveConf.ConfVars.HIVE_SERVER2_OOM_HOOKS, Runnable.class,
Review comment:
done, thank you
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 484907)
Time Spent: 5h (was: 4h 50m)
> Add hooks when HiveServer2 stops due to OutOfMemoryError
>
>
> Key: HIVE-23800
> URL: https://issues.apache.org/jira/browse/HIVE-23800
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Reporter: Zhihua Deng
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Make oom hook an interface of HiveServer2, so user can implement the hook to
> do something before HS2 stops, such as dumping the heap or altering the
> devops.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[
https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=484906=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-484906
]
ASF GitHub Bot logged work on HIVE-23800:
-
Author: ASF GitHub Bot
Created on: 16/Sep/20 03:48
Start Date: 16/Sep/20 03:48
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #1205:
URL: https://github.com/apache/hive/pull/1205#discussion_r489144324
##
File path: ql/src/java/org/apache/hadoop/hive/ql/hooks/HooksLoader.java
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.hooks;
+
+import com.cronutils.utils.VisibleForTesting;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.ql.exec.Utilities;
+import org.apache.hadoop.hive.ql.session.SessionState;
+import org.apache.hive.common.util.HiveStringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+/**
+ * Loads and stores different kinds of hooks, provides {@link
HooksLoader#addHook(HookContext.HookType, Object)}} to
+ * add hook alone or {@link HooksLoader#getHooks(HookContext.HookType,
Class)} to get all hooks
+ * corresponding to the specific hook type.
+ */
+public class HooksLoader {
+ private static final Logger LOG = LoggerFactory.getLogger(HooksLoader.class);
+ private final HiveConf conf;
+ private final Hooks[] hooks;
+ private SessionState.LogHelper console;
+
+ public HooksLoader(HiveConf conf) {
+this.conf = conf;
+this.hooks = new Hooks[HookContext.HookType.values().length];
+for (int i = 0; i < hooks.length; i++) {
+ hooks[i] = new Hooks();
+}
+ }
+
+ public HooksLoader(HiveConf conf, SessionState.LogHelper console) {
+this(conf);
+this.console = console;
+ }
+
+ /**
+ * Loads the configured hooks corresponding to the specific hook type.
+ * @param type hook type
+ */
+ @VisibleForTesting
+ void loadHooksFromConf(HookContext.HookType type) {
+Hooks container = hooks[type.ordinal()];
+if (!container.loadedFromConf) {
Review comment:
When we use HooksLoader to load the session hooks, redactor hooks that
running outside the HookRunner, maybe there is no need to initialize other
types of hooks, so I make the hooks loading lazily on demand.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 484906)
Time Spent: 4h 50m (was: 4h 40m)
> Add hooks when HiveServer2 stops due to OutOfMemoryError
>
>
> Key: HIVE-23800
> URL: https://issues.apache.org/jira/browse/HIVE-23800
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Reporter: Zhihua Deng
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Make oom hook an interface of HiveServer2, so user can implement the hook to
> do something before HS2 stops, such as dumping the heap or altering the
> devops.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[
https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=484904=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-484904
]
ASF GitHub Bot logged work on HIVE-23800:
-
Author: ASF GitHub Bot
Created on: 16/Sep/20 03:37
Start Date: 16/Sep/20 03:37
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on a change in pull request #1205:
URL: https://github.com/apache/hive/pull/1205#discussion_r489141594
##
File path: ql/src/java/org/apache/hadoop/hive/ql/hooks/HooksLoader.java
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.hooks;
+
+import com.cronutils.utils.VisibleForTesting;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.ql.exec.Utilities;
+import org.apache.hadoop.hive.ql.session.SessionState;
+import org.apache.hive.common.util.HiveStringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+/**
+ * Loads and stores different kinds of hooks, provides {@link
HooksLoader#addHook(HookContext.HookType, Object)}} to
+ * add hook alone or {@link HooksLoader#getHooks(HookContext.HookType,
Class)} to get all hooks
+ * corresponding to the specific hook type.
+ */
+public class HooksLoader {
+ private static final Logger LOG = LoggerFactory.getLogger(HooksLoader.class);
+ private final HiveConf conf;
+ private final Hooks[] hooks;
+ private SessionState.LogHelper console;
+
+ public HooksLoader(HiveConf conf) {
+this.conf = conf;
+this.hooks = new Hooks[HookContext.HookType.values().length];
+for (int i = 0; i < hooks.length; i++) {
+ hooks[i] = new Hooks();
+}
+ }
+
+ public HooksLoader(HiveConf conf, SessionState.LogHelper console) {
+this(conf);
+this.console = console;
+ }
+
+ /**
+ * Loads the configured hooks corresponding to the specific hook type.
+ * @param type hook type
+ */
+ @VisibleForTesting
+ void loadHooksFromConf(HookContext.HookType type) {
+Hooks container = hooks[type.ordinal()];
+if (!container.loadedFromConf) {
+ container.loadedFromConf = true;
+ List hooks = container.getHooks();
+ HiveConf.ConfVars confVars = type.getConfVar();
Review comment:
Thank you very much for the careful review! fixed.
##
File path: ql/src/java/org/apache/hadoop/hive/ql/hooks/HooksLoader.java
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.hooks;
+
+import com.cronutils.utils.VisibleForTesting;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.ql.exec.Utilities;
+import org.apache.hadoop.hive.ql.session.SessionState;
+import org.apache.hive.common.util.HiveStringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+/**
+ * Loads and stores different kinds of hooks, provides {@link
HooksLoader#addHook(HookContext.HookType, Object)}} to
+ * add hook alone or {@link HooksLoader#getHooks(HookContext.HookType,
Class)} to get all hooks
+ * corresponding to the specific hook type.
+ */
+public class HooksLoader {
+ private static final Logger LOG =
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[
https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=484452=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-484452
]
ASF GitHub Bot logged work on HIVE-23800:
-
Author: ASF GitHub Bot
Created on: 15/Sep/20 12:24
Start Date: 15/Sep/20 12:24
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on a change in pull request #1205:
URL: https://github.com/apache/hive/pull/1205#discussion_r488617988
##
File path: ql/src/java/org/apache/hadoop/hive/ql/hooks/HooksLoader.java
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.hooks;
+
+import com.cronutils.utils.VisibleForTesting;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.ql.exec.Utilities;
+import org.apache.hadoop.hive.ql.session.SessionState;
+import org.apache.hive.common.util.HiveStringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+/**
+ * Loads and stores different kinds of hooks, provides {@link
HooksLoader#addHook(HookContext.HookType, Object)}} to
+ * add hook alone or {@link HooksLoader#getHooks(HookContext.HookType,
Class)} to get all hooks
+ * corresponding to the specific hook type.
+ */
+public class HooksLoader {
+ private static final Logger LOG = LoggerFactory.getLogger(HooksLoader.class);
+ private final HiveConf conf;
+ private final Hooks[] hooks;
+ private SessionState.LogHelper console;
+
+ public HooksLoader(HiveConf conf) {
+this.conf = conf;
+this.hooks = new Hooks[HookContext.HookType.values().length];
+for (int i = 0; i < hooks.length; i++) {
+ hooks[i] = new Hooks();
+}
+ }
+
+ public HooksLoader(HiveConf conf, SessionState.LogHelper console) {
+this(conf);
+this.console = console;
+ }
+
+ /**
+ * Loads the configured hooks corresponding to the specific hook type.
+ * @param type hook type
+ */
+ @VisibleForTesting
+ void loadHooksFromConf(HookContext.HookType type) {
+Hooks container = hooks[type.ordinal()];
+if (!container.loadedFromConf) {
+ container.loadedFromConf = true;
+ List hooks = container.getHooks();
+ HiveConf.ConfVars confVars = type.getConfVar();
Review comment:
I think this should be only `confVar`
##
File path: ql/src/java/org/apache/hadoop/hive/ql/hooks/HooksLoader.java
##
@@ -0,0 +1,162 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.hooks;
+
+import com.cronutils.utils.VisibleForTesting;
+import org.apache.hadoop.hive.conf.HiveConf;
+import org.apache.hadoop.hive.ql.exec.Utilities;
+import org.apache.hadoop.hive.ql.session.SessionState;
+import org.apache.hive.common.util.HiveStringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.List;
+
+/**
+ * Loads and stores different kinds of hooks, provides {@link
HooksLoader#addHook(HookContext.HookType, Object)}} to
+ * add hook alone or {@link HooksLoader#getHooks(HookContext.HookType,
Class)} to get all hooks
+ * corresponding to the specific hook type.
+ */
+public class HooksLoader {
+ private static final Logger LOG =
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=484382=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-484382 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 15/Sep/20 09:07 Start Date: 15/Sep/20 09:07 Worklog Time Spent: 10m Work Description: dengzhhu653 opened a new pull request #1205: URL: https://github.com/apache/hive/pull/1205 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g. HIVE-X: Fix a typo in YYY) For more details, please see https://cwiki.apache.org/confluence/display/Hive/HowToContribute This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 484382) Time Spent: 4h 20m (was: 4h 10m) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Minor > Labels: pull-request-available > Time Spent: 4h 20m > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=484378=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-484378 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 15/Sep/20 09:05 Start Date: 15/Sep/20 09:05 Worklog Time Spent: 10m Work Description: dengzhhu653 closed pull request #1205: URL: https://github.com/apache/hive/pull/1205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 484378) Time Spent: 4h 10m (was: 4h) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Minor > Labels: pull-request-available > Time Spent: 4h 10m > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=483727=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-483727 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 14/Sep/20 01:37 Start Date: 14/Sep/20 01:37 Worklog Time Spent: 10m Work Description: dengzhhu653 opened a new pull request #1205: URL: https://github.com/apache/hive/pull/1205 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g. HIVE-X: Fix a typo in YYY) For more details, please see https://cwiki.apache.org/confluence/display/Hive/HowToContribute This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 483727) Time Spent: 4h (was: 3h 50m) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Minor > Labels: pull-request-available > Time Spent: 4h > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=483726=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-483726 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 14/Sep/20 01:36 Start Date: 14/Sep/20 01:36 Worklog Time Spent: 10m Work Description: dengzhhu653 closed pull request #1205: URL: https://github.com/apache/hive/pull/1205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 483726) Time Spent: 3h 50m (was: 3h 40m) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Minor > Labels: pull-request-available > Time Spent: 3h 50m > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=467192=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-467192 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 06/Aug/20 09:54 Start Date: 06/Aug/20 09:54 Worklog Time Spent: 10m Work Description: dengzhhu653 commented on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-669832758 > sorry @dengzhhu653 lately I was a little bit flooded with all kind of stuff...and right now I'm on holiday - will get back to your patch next week! sorry for disturbing you. Have a nice holiday! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 467192) Time Spent: 3.5h (was: 3h 20m) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 3.5h > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=467193=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-467193 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 06/Aug/20 09:54 Start Date: 06/Aug/20 09:54 Worklog Time Spent: 10m Work Description: dengzhhu653 edited a comment on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-669832758 > sorry @dengzhhu653 lately I was a little bit flooded with all kind of stuff...and right now I'm on holiday - will get back to your patch next week! sorry for disturbing you. Have a nice holiday! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 467193) Time Spent: 3h 40m (was: 3.5h) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 3h 40m > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=467150=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-467150 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 06/Aug/20 08:59 Start Date: 06/Aug/20 08:59 Worklog Time Spent: 10m Work Description: kgyrtkirk commented on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-669804983 sorry @dengzhhu653 lately I was a little bit flooded with all kind of stuff...and right now I'm on holiday - will get back to your patch next week! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 467150) Time Spent: 3h 20m (was: 3h 10m) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 3h 20m > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=467078=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-467078 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 06/Aug/20 05:11 Start Date: 06/Aug/20 05:11 Worklog Time Spent: 10m Work Description: dengzhhu653 commented on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-669698519 @kgyrtkirk could you take some time to look at this again? any advices are appreciated, thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 467078) Time Spent: 3h 10m (was: 3h) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 3h 10m > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=465614=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465614 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 03/Aug/20 09:47 Start Date: 03/Aug/20 09:47 Worklog Time Spent: 10m Work Description: dengzhhu653 opened a new pull request #1205: URL: https://github.com/apache/hive/pull/1205 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g. HIVE-X: Fix a typo in YYY) For more details, please see https://cwiki.apache.org/confluence/display/Hive/HowToContribute This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 465614) Time Spent: 3h (was: 2h 50m) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=465612=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465612 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 03/Aug/20 09:45 Start Date: 03/Aug/20 09:45 Worklog Time Spent: 10m Work Description: dengzhhu653 closed pull request #1205: URL: https://github.com/apache/hive/pull/1205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 465612) Time Spent: 2h 50m (was: 2h 40m) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 2h 50m > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=465280=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465280 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 01/Aug/20 06:30 Start Date: 01/Aug/20 06:30 Worklog Time Spent: 10m Work Description: dengzhhu653 commented on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-667482135 @kgyrtkirk could you please take a look at the changes? thank you:) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 465280) Time Spent: 2h 40m (was: 2.5h) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 2h 40m > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=465046=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465046 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 31/Jul/20 14:19 Start Date: 31/Jul/20 14:19 Worklog Time Spent: 10m Work Description: dengzhhu653 opened a new pull request #1205: URL: https://github.com/apache/hive/pull/1205 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g. HIVE-X: Fix a typo in YYY) For more details, please see https://cwiki.apache.org/confluence/display/Hive/HowToContribute This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 465046) Time Spent: 2.5h (was: 2h 20m) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 2.5h > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=465043=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-465043 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 31/Jul/20 14:17 Start Date: 31/Jul/20 14:17 Worklog Time Spent: 10m Work Description: dengzhhu653 closed pull request #1205: URL: https://github.com/apache/hive/pull/1205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 465043) Time Spent: 2h 20m (was: 2h 10m) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 2h 20m > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[
https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=459045=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-459045
]
ASF GitHub Bot logged work on HIVE-23800:
-
Author: ASF GitHub Bot
Created on: 15/Jul/20 00:57
Start Date: 15/Jul/20 00:57
Worklog Time Spent: 10m
Work Description: dengzhhu653 commented on pull request #1205:
URL: https://github.com/apache/hive/pull/1205#issuecomment-658484942
> when I was using some of these hooks earlier: they are too specific to
some purpose.
> right now the proposed callback is a {{Runnable}} ... which means you will
have to create a completely new one in case you want to pass some things to it
later...
>
> so...I would recommend the following:
>
> * remove the "oom" keyword from the name of the hook/etc - it could be
diag, debug or something like that
> * add a callback which has 2 arguments:
>
> * a callback type (some enum; which should have a value which is
specific to "oom")
> * some callback payload object to which we can add things later on... it
could be an object using the {{Adaptable}} pattern
>
> all this stuff is to make it a bit more reusable if we need to reuse it
later on...
...Sorry, I don't get much clear about "some callback payload object to
which we can add things later on.", is something like this:
```
public class HookRuntime {
private static final HookRuntime runtime = new HookRuntime();
public static HookRuntime getHookRuntime() {
return runtime;
}
private Map hooks = new HashMap<>();
void callback(Enum Type, HookPayloadObject payload) {
}
HookPayloadObject getHookPayLoad(Enum typs) {
return null;
}
}
public interface HookPayloadObject extends Runnable {
void addHook(Hook hook);
void setContext(T context);
}
```
Thanks a lot for your time!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 459045)
Time Spent: 2h 10m (was: 2h)
> Add hooks when HiveServer2 stops due to OutOfMemoryError
>
>
> Key: HIVE-23800
> URL: https://issues.apache.org/jira/browse/HIVE-23800
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Reporter: Zhihua Deng
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Make oom hook an interface of HiveServer2, so user can implement the hook to
> do something before HS2 stops, such as dumping the heap or altering the
> devops.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[
https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=458476=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-458476
]
ASF GitHub Bot logged work on HIVE-23800:
-
Author: ASF GitHub Bot
Created on: 14/Jul/20 06:47
Start Date: 14/Jul/20 06:47
Worklog Time Spent: 10m
Work Description: kgyrtkirk commented on pull request #1205:
URL: https://github.com/apache/hive/pull/1205#issuecomment-658002425
when I was using some of these hooks earlier: they are too specific to some
purpose.
right now the proposed callback is a {{Runnable}} ... which means you will
have to create a completely new one in case you want to pass some things to it
later...
so...I would recommend the following:
* remove the "oom" keyword from the name of the hook/etc - it could be diag,
debug or something like that
* add a callback which has 2 arguments:
* a callback type (some enum; which should have a value which is specific
to "oom")
* some callback payload object to which we can add things later on... it
could be an object using the {{Adaptable}} pattern
all this stuff is to make it a bit more reusable if we need to reuse it
later on...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 458476)
Time Spent: 2h (was: 1h 50m)
> Add hooks when HiveServer2 stops due to OutOfMemoryError
>
>
> Key: HIVE-23800
> URL: https://issues.apache.org/jira/browse/HIVE-23800
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
>Reporter: Zhihua Deng
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Make oom hook an interface of HiveServer2, so user can implement the hook to
> do something before HS2 stops, such as dumping the heap or altering the
> devops.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-23800) Add hooks when HiveServer2 stops due to OutOfMemoryError
[ https://issues.apache.org/jira/browse/HIVE-23800?focusedWorklogId=458388=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-458388 ] ASF GitHub Bot logged work on HIVE-23800: - Author: ASF GitHub Bot Created on: 14/Jul/20 00:23 Start Date: 14/Jul/20 00:23 Worklog Time Spent: 10m Work Description: dengzhhu653 commented on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-657896053 @kgyrtkirk could you please take another look at the changes? thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 458388) Time Spent: 1h 50m (was: 1h 40m) > Add hooks when HiveServer2 stops due to OutOfMemoryError > > > Key: HIVE-23800 > URL: https://issues.apache.org/jira/browse/HIVE-23800 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 >Reporter: Zhihua Deng >Priority: Major > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > > Make oom hook an interface of HiveServer2, so user can implement the hook to > do something before HS2 stops, such as dumping the heap or altering the > devops. -- This message was sent by Atlassian Jira (v8.3.4#803005)
