[jira] [Work logged] (HIVE-24022) Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer
[ https://issues.apache.org/jira/browse/HIVE-24022?focusedWorklogId=514390=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-514390 ] ASF GitHub Bot logged work on HIVE-24022: - Author: ASF GitHub Bot Created on: 20/Nov/20 00:41 Start Date: 20/Nov/20 00:41 Worklog Time Spent: 10m Work Description: github-actions[bot] closed pull request #1385: URL: https://github.com/apache/hive/pull/1385 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 514390) Time Spent: 1h 20m (was: 1h 10m) > Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer > -- > > Key: HIVE-24022 > URL: https://issues.apache.org/jira/browse/HIVE-24022 > Project: Hive > Issue Type: Improvement >Reporter: Rajesh Balamohan >Assignee: Sam An >Priority: Minor > Labels: performance, pull-request-available > Fix For: 4.0.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > For a table with 3000+ partitions, analyze table takes a lot longer time as > HiveMetaStoreAuthorizer tries to create HiveConf for every partition request. > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L319] > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L447] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24022) Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer
[ https://issues.apache.org/jira/browse/HIVE-24022?focusedWorklogId=510025=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-510025 ] ASF GitHub Bot logged work on HIVE-24022: - Author: ASF GitHub Bot Created on: 11/Nov/20 00:33 Start Date: 11/Nov/20 00:33 Worklog Time Spent: 10m Work Description: github-actions[bot] commented on pull request #1385: URL: https://github.com/apache/hive/pull/1385#issuecomment-725051526 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the d...@hive.apache.org list if the patch is in need of reviews. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 510025) Time Spent: 1h 10m (was: 1h) > Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer > -- > > Key: HIVE-24022 > URL: https://issues.apache.org/jira/browse/HIVE-24022 > Project: Hive > Issue Type: Improvement >Reporter: Rajesh Balamohan >Assignee: Sam An >Priority: Minor > Labels: performance, pull-request-available > Fix For: 4.0.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > For a table with 3000+ partitions, analyze table takes a lot longer time as > HiveMetaStoreAuthorizer tries to create HiveConf for every partition request. > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L319] > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L447] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24022) Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer
[ https://issues.apache.org/jira/browse/HIVE-24022?focusedWorklogId=483324=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-483324 ] ASF GitHub Bot logged work on HIVE-24022: - Author: ASF GitHub Bot Created on: 12/Sep/20 21:46 Start Date: 12/Sep/20 21:46 Worklog Time Spent: 10m Work Description: nrg4878 commented on pull request #1385: URL: https://github.com/apache/hive/pull/1385#issuecomment-691213984 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 483324) Time Spent: 1h (was: 50m) > Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer > -- > > Key: HIVE-24022 > URL: https://issues.apache.org/jira/browse/HIVE-24022 > Project: Hive > Issue Type: Improvement >Reporter: Rajesh Balamohan >Assignee: Sam An >Priority: Minor > Labels: performance, pull-request-available > Fix For: 4.0.0 > > Time Spent: 1h > Remaining Estimate: 0h > > For a table with 3000+ partitions, analyze table takes a lot longer time as > HiveMetaStoreAuthorizer tries to create HiveConf for every partition request. > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L319] > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L447] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24022) Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer
[ https://issues.apache.org/jira/browse/HIVE-24022?focusedWorklogId=482924=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-482924 ] ASF GitHub Bot logged work on HIVE-24022: - Author: ASF GitHub Bot Created on: 12/Sep/20 20:33 Start Date: 12/Sep/20 20:33 Worklog Time Spent: 10m Work Description: nrg4878 commented on pull request #1385: URL: https://github.com/apache/hive/pull/1385#issuecomment-691213984 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 482924) Time Spent: 50m (was: 40m) > Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer > -- > > Key: HIVE-24022 > URL: https://issues.apache.org/jira/browse/HIVE-24022 > Project: Hive > Issue Type: Improvement >Reporter: Rajesh Balamohan >Assignee: Sam An >Priority: Minor > Labels: performance, pull-request-available > Fix For: 4.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > > For a table with 3000+ partitions, analyze table takes a lot longer time as > HiveMetaStoreAuthorizer tries to create HiveConf for every partition request. > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L319] > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L447] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24022) Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer
[ https://issues.apache.org/jira/browse/HIVE-24022?focusedWorklogId=482182=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-482182 ] ASF GitHub Bot logged work on HIVE-24022: - Author: ASF GitHub Bot Created on: 11/Sep/20 17:13 Start Date: 11/Sep/20 17:13 Worklog Time Spent: 10m Work Description: nrg4878 commented on pull request #1385: URL: https://github.com/apache/hive/pull/1385#issuecomment-691213984 Fix has been committed to master. Thanks for the fix @sam-an-cloudera This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 482182) Time Spent: 40m (was: 0.5h) > Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer > -- > > Key: HIVE-24022 > URL: https://issues.apache.org/jira/browse/HIVE-24022 > Project: Hive > Issue Type: Improvement >Reporter: Rajesh Balamohan >Assignee: Sam An >Priority: Minor > Labels: performance, pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > For a table with 3000+ partitions, analyze table takes a lot longer time as > HiveMetaStoreAuthorizer tries to create HiveConf for every partition request. > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L319] > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L447] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24022) Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer
[
https://issues.apache.org/jira/browse/HIVE-24022?focusedWorklogId=476743=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476743
]
ASF GitHub Bot logged work on HIVE-24022:
-
Author: ASF GitHub Bot
Created on: 31/Aug/20 18:27
Start Date: 31/Aug/20 18:27
Worklog Time Spent: 10m
Work Description: sam-an-cloudera commented on pull request #1385:
URL: https://github.com/apache/hive/pull/1385#issuecomment-683950735
> @sam-an-cloudera initialValue() return type was Configuration and is now
HiveConf which is a sub-class of Configuration. Was there a reason for this
change? It would be more appropriate that the return type be Configuration.
Thoughts?
It was mainly to avoid having to cast. The config used in
createHiveMetastoreAuthorizer( ) method is required to be a HiveConf, the
createHiveAuthorizer( ) call in particular. If we keep it as Configuration,
then down there we have to do a cast, which is not good style, so I changed the
original to HiveConf.
HiveConf hiveConf = tConfig.get();
if(hiveConf == null){
HiveConf hiveConf1 = new HiveConf(super.getConf(), HiveConf.class);
<==If I don't change, then here would need a cast.
tConfig.set(hiveConf1);
hiveConf = hiveConf1;
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 476743)
Time Spent: 0.5h (was: 20m)
> Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer
> --
>
> Key: HIVE-24022
> URL: https://issues.apache.org/jira/browse/HIVE-24022
> Project: Hive
> Issue Type: Improvement
>Reporter: Rajesh Balamohan
>Assignee: Sam An
>Priority: Minor
> Labels: performance, pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> For a table with 3000+ partitions, analyze table takes a lot longer time as
> HiveMetaStoreAuthorizer tries to create HiveConf for every partition request.
>
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L319]
>
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L447]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24022) Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer
[ https://issues.apache.org/jira/browse/HIVE-24022?focusedWorklogId=476675=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-476675 ] ASF GitHub Bot logged work on HIVE-24022: - Author: ASF GitHub Bot Created on: 31/Aug/20 16:59 Start Date: 31/Aug/20 16:59 Worklog Time Spent: 10m Work Description: nrg4878 commented on pull request #1385: URL: https://github.com/apache/hive/pull/1385#issuecomment-683904667 @sam-an-cloudera initialValue() return type was Configuration and is now HiveConf which is a sub-class of Configuration. Was there a reason for this change? It would be more appropriate that the return type be Configuration. Thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 476675) Time Spent: 20m (was: 10m) > Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer > -- > > Key: HIVE-24022 > URL: https://issues.apache.org/jira/browse/HIVE-24022 > Project: Hive > Issue Type: Improvement >Reporter: Rajesh Balamohan >Assignee: Sam An >Priority: Minor > Labels: performance, pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > For a table with 3000+ partitions, analyze table takes a lot longer time as > HiveMetaStoreAuthorizer tries to create HiveConf for every partition request. > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L319] > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L447] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (HIVE-24022) Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer
[ https://issues.apache.org/jira/browse/HIVE-24022?focusedWorklogId=468978=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-468978 ] ASF GitHub Bot logged work on HIVE-24022: - Author: ASF GitHub Bot Created on: 11/Aug/20 02:30 Start Date: 11/Aug/20 02:30 Worklog Time Spent: 10m Work Description: sam-an-cloudera opened a new pull request #1385: URL: https://github.com/apache/hive/pull/1385 They are many calls to createHiveMetastoreAuthorizer, and for each call, we are creating HiveConf, which is slow. We can use the ThreadLocal conf, so that each thread only creates it once. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 468978) Remaining Estimate: 0h Time Spent: 10m > Optimise HiveMetaStoreAuthorizer.createHiveMetaStoreAuthorizer > -- > > Key: HIVE-24022 > URL: https://issues.apache.org/jira/browse/HIVE-24022 > Project: Hive > Issue Type: Improvement >Reporter: Rajesh Balamohan >Priority: Minor > Labels: performance > Time Spent: 10m > Remaining Estimate: 0h > > For a table with 3000+ partitions, analyze table takes a lot longer time as > HiveMetaStoreAuthorizer tries to create HiveConf for every partition request. > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L319] > > [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java#L447] -- This message was sent by Atlassian Jira (v8.3.4#803005)
