[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=483441=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-483441
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 12/Sep/20 21:56
Start Date: 12/Sep/20 21:56
Worklog Time Spent: 10m
Work Description: vineetgarg02 commented on pull request #1482:
URL: https://github.com/apache/hive/pull/1482#issuecomment-691326259
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 483441)
Time Spent: 2h 50m (was: 2h 40m)
> Include convention in JDBC converter operator in Calcite plan
> -
>
> Key: HIVE-24143
> URL: https://issues.apache.org/jira/browse/HIVE-24143
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query
> generation. For instance:
> {code}
> HiveProject(jdbc_type_conversion_table1.ikey=[$0],
> jdbc_type_conversion_table1.bkey=[$1], jdbc_type_conversion_table1.fkey=[$2],
> jdbc_type_conversion_table1.dkey=[$3],
> jdbc_type_conversion_table1.chkey=[$4],
> jdbc_type_conversion_table1.dekey=[$5],
> jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
> HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4],
> dekey=[$5], dtkey=[$6], tkey=[$7])
> ->HiveJdbcConverter(convention=[JDBC.DERBY])
> JdbcHiveTableScan(table=[[default, jdbc_type_conversion_table1]],
> table:alias=[jdbc_type_conversion_table1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=483430=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-483430
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 12/Sep/20 21:55
Start Date: 12/Sep/20 21:55
Worklog Time Spent: 10m
Work Description: jcamachor merged pull request #1482:
URL: https://github.com/apache/hive/pull/1482
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 483430)
Time Spent: 2h 40m (was: 2.5h)
> Include convention in JDBC converter operator in Calcite plan
> -
>
> Key: HIVE-24143
> URL: https://issues.apache.org/jira/browse/HIVE-24143
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query
> generation. For instance:
> {code}
> HiveProject(jdbc_type_conversion_table1.ikey=[$0],
> jdbc_type_conversion_table1.bkey=[$1], jdbc_type_conversion_table1.fkey=[$2],
> jdbc_type_conversion_table1.dkey=[$3],
> jdbc_type_conversion_table1.chkey=[$4],
> jdbc_type_conversion_table1.dekey=[$5],
> jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
> HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4],
> dekey=[$5], dtkey=[$6], tkey=[$7])
> ->HiveJdbcConverter(convention=[JDBC.DERBY])
> JdbcHiveTableScan(table=[[default, jdbc_type_conversion_table1]],
> table:alias=[jdbc_type_conversion_table1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=483227=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-483227
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 12/Sep/20 21:35
Start Date: 12/Sep/20 21:35
Worklog Time Spent: 10m
Work Description: vineetgarg02 commented on a change in pull request
#1482:
URL: https://github.com/apache/hive/pull/1482#discussion_r487292490
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
Also not sure what caused this change in plan.
##
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS
'org.apache.hadoop.hive.contrib.genericudf
FROM src
SELECT
-dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',
Review comment:
Curious as to why this changed?
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
Got it, make sense
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
Also not sure what caused this change in plan.
##
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS
'org.apache.hadoop.hive.contrib.genericudf
FROM src
SELECT
-dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',
Review comment:
Curious as to why this changed?
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
Got it, make sense
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
Also not sure what caused this change in plan.
##
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS
'org.apache.hadoop.hive.contrib.genericudf
FROM src
SELECT
-dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',
Review comment:
Curious as to why this changed?
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
Got it, make sense
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=483151=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-483151
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 12/Sep/20 21:21
Start Date: 12/Sep/20 21:21
Worklog Time Spent: 10m
Work Description: jcamachor commented on a change in pull request #1482:
URL: https://github.com/apache/hive/pull/1482#discussion_r487299089
##
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS
'org.apache.hadoop.hive.contrib.genericudf
FROM src
SELECT
-dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',
Review comment:
I changed it to avoid a clash with other test in the temp directory,
which I believe was causing HIVE-23910.
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
This change is not actually related to this patch. Note that the test
was disabled by default (HIVE-23910); it seems maybe a preliminary version of
HIVE-23716 changed these q files and it should have not.
##
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS
'org.apache.hadoop.hive.contrib.genericudf
FROM src
SELECT
-dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',
Review comment:
I changed it to avoid a clash with other test in the temp directory,
which I believe was causing HIVE-23910.
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
This change is not actually related to this patch. Note that the test
was disabled by default (HIVE-23910); it seems maybe a preliminary version of
HIVE-23716 changed these q files and it should have not.
##
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS
'org.apache.hadoop.hive.contrib.genericudf
FROM src
SELECT
-dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',
Review comment:
I changed it to avoid a clash with other test in the temp directory,
which I believe was causing HIVE-23910.
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
This change is not actually related to this patch. Note that the test
was disabled by default (HIVE-23910); it seems maybe a preliminary version of
HIVE-23716 changed these q files and it should have not.
##
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS
'org.apache.hadoop.hive.contrib.genericudf
FROM src
SELECT
-dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',
Review comment:
I changed it to avoid a clash with other test in the temp directory,
which I believe was causing HIVE-23910.
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=483081=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-483081
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 12/Sep/20 20:53
Start Date: 12/Sep/20 20:53
Worklog Time Spent: 10m
Work Description: vineetgarg02 commented on pull request #1482:
URL: https://github.com/apache/hive/pull/1482#issuecomment-691326259
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 483081)
Time Spent: 2h 10m (was: 2h)
> Include convention in JDBC converter operator in Calcite plan
> -
>
> Key: HIVE-24143
> URL: https://issues.apache.org/jira/browse/HIVE-24143
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query
> generation. For instance:
> {code}
> HiveProject(jdbc_type_conversion_table1.ikey=[$0],
> jdbc_type_conversion_table1.bkey=[$1], jdbc_type_conversion_table1.fkey=[$2],
> jdbc_type_conversion_table1.dkey=[$3],
> jdbc_type_conversion_table1.chkey=[$4],
> jdbc_type_conversion_table1.dekey=[$5],
> jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
> HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4],
> dekey=[$5], dtkey=[$6], tkey=[$7])
> ->HiveJdbcConverter(convention=[JDBC.DERBY])
> JdbcHiveTableScan(table=[[default, jdbc_type_conversion_table1]],
> table:alias=[jdbc_type_conversion_table1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=483067=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-483067
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 12/Sep/20 20:52
Start Date: 12/Sep/20 20:52
Worklog Time Spent: 10m
Work Description: jcamachor merged pull request #1482:
URL: https://github.com/apache/hive/pull/1482
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 483067)
Time Spent: 2h (was: 1h 50m)
> Include convention in JDBC converter operator in Calcite plan
> -
>
> Key: HIVE-24143
> URL: https://issues.apache.org/jira/browse/HIVE-24143
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query
> generation. For instance:
> {code}
> HiveProject(jdbc_type_conversion_table1.ikey=[$0],
> jdbc_type_conversion_table1.bkey=[$1], jdbc_type_conversion_table1.fkey=[$2],
> jdbc_type_conversion_table1.dkey=[$3],
> jdbc_type_conversion_table1.chkey=[$4],
> jdbc_type_conversion_table1.dekey=[$5],
> jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
> HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4],
> dekey=[$5], dtkey=[$6], tkey=[$7])
> ->HiveJdbcConverter(convention=[JDBC.DERBY])
> JdbcHiveTableScan(table=[[default, jdbc_type_conversion_table1]],
> table:alias=[jdbc_type_conversion_table1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=482822=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-482822
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 12/Sep/20 20:24
Start Date: 12/Sep/20 20:24
Worklog Time Spent: 10m
Work Description: vineetgarg02 commented on a change in pull request
#1482:
URL: https://github.com/apache/hive/pull/1482#discussion_r487292490
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
Also not sure what caused this change in plan.
##
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS
'org.apache.hadoop.hive.contrib.genericudf
FROM src
SELECT
-dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',
Review comment:
Curious as to why this changed?
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
Got it, make sense
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
Also not sure what caused this change in plan.
##
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS
'org.apache.hadoop.hive.contrib.genericudf
FROM src
SELECT
-dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',
Review comment:
Curious as to why this changed?
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
Got it, make sense
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 482822)
Time Spent: 1h 50m (was: 1h 40m)
> Include convention in JDBC converter operator in Calcite plan
> -
>
> Key: HIVE-24143
> URL: https://issues.apache.org/jira/browse/HIVE-24143
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query
> generation. For instance:
> {code}
> HiveProject(jdbc_type_conversion_table1.ikey=[$0],
> jdbc_type_conversion_table1.bkey=[$1], jdbc_type_conversion_table1.fkey=[$2],
> jdbc_type_conversion_table1.dkey=[$3],
> jdbc_type_conversion_table1.chkey=[$4],
> jdbc_type_conversion_table1.dekey=[$5],
> jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
> HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4],
> dekey=[$5], dtkey=[$6], tkey=[$7])
> ->
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=482740=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-482740
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 12/Sep/20 20:16
Start Date: 12/Sep/20 20:16
Worklog Time Spent: 10m
Work Description: jcamachor commented on a change in pull request #1482:
URL: https://github.com/apache/hive/pull/1482#discussion_r487299089
##
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS
'org.apache.hadoop.hive.contrib.genericudf
FROM src
SELECT
-dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',
Review comment:
I changed it to avoid a clash with other test in the temp directory,
which I believe was causing HIVE-23910.
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
This change is not actually related to this patch. Note that the test
was disabled by default (HIVE-23910); it seems maybe a preliminary version of
HIVE-23716 changed these q files and it should have not.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 482740)
Time Spent: 1h 40m (was: 1.5h)
> Include convention in JDBC converter operator in Calcite plan
> -
>
> Key: HIVE-24143
> URL: https://issues.apache.org/jira/browse/HIVE-24143
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query
> generation. For instance:
> {code}
> HiveProject(jdbc_type_conversion_table1.ikey=[$0],
> jdbc_type_conversion_table1.bkey=[$1], jdbc_type_conversion_table1.fkey=[$2],
> jdbc_type_conversion_table1.dkey=[$3],
> jdbc_type_conversion_table1.chkey=[$4],
> jdbc_type_conversion_table1.dekey=[$5],
> jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
> HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4],
> dekey=[$5], dtkey=[$6], tkey=[$7])
> ->HiveJdbcConverter(convention=[JDBC.DERBY])
> JdbcHiveTableScan(table=[[default, jdbc_type_conversion_table1]],
> table:alias=[jdbc_type_conversion_table1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=482621=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-482621
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 12/Sep/20 20:07
Start Date: 12/Sep/20 20:07
Worklog Time Spent: 10m
Work Description: vineetgarg02 commented on pull request #1482:
URL: https://github.com/apache/hive/pull/1482#issuecomment-691326259
+1, looks good to me
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 482621)
Time Spent: 1.5h (was: 1h 20m)
> Include convention in JDBC converter operator in Calcite plan
> -
>
> Key: HIVE-24143
> URL: https://issues.apache.org/jira/browse/HIVE-24143
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query
> generation. For instance:
> {code}
> HiveProject(jdbc_type_conversion_table1.ikey=[$0],
> jdbc_type_conversion_table1.bkey=[$1], jdbc_type_conversion_table1.fkey=[$2],
> jdbc_type_conversion_table1.dkey=[$3],
> jdbc_type_conversion_table1.chkey=[$4],
> jdbc_type_conversion_table1.dekey=[$5],
> jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
> HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4],
> dekey=[$5], dtkey=[$6], tkey=[$7])
> ->HiveJdbcConverter(convention=[JDBC.DERBY])
> JdbcHiveTableScan(table=[[default, jdbc_type_conversion_table1]],
> table:alias=[jdbc_type_conversion_table1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=482607=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-482607
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 12/Sep/20 20:06
Start Date: 12/Sep/20 20:06
Worklog Time Spent: 10m
Work Description: jcamachor merged pull request #1482:
URL: https://github.com/apache/hive/pull/1482
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 482607)
Time Spent: 1h 20m (was: 1h 10m)
> Include convention in JDBC converter operator in Calcite plan
> -
>
> Key: HIVE-24143
> URL: https://issues.apache.org/jira/browse/HIVE-24143
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Labels: pull-request-available
> Fix For: 4.0.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query
> generation. For instance:
> {code}
> HiveProject(jdbc_type_conversion_table1.ikey=[$0],
> jdbc_type_conversion_table1.bkey=[$1], jdbc_type_conversion_table1.fkey=[$2],
> jdbc_type_conversion_table1.dkey=[$3],
> jdbc_type_conversion_table1.chkey=[$4],
> jdbc_type_conversion_table1.dekey=[$5],
> jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
> HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4],
> dekey=[$5], dtkey=[$6], tkey=[$7])
> ->HiveJdbcConverter(convention=[JDBC.DERBY])
> JdbcHiveTableScan(table=[[default, jdbc_type_conversion_table1]],
> table:alias=[jdbc_type_conversion_table1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=482410=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-482410
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 12/Sep/20 03:12
Start Date: 12/Sep/20 03:12
Worklog Time Spent: 10m
Work Description: jcamachor merged pull request #1482:
URL: https://github.com/apache/hive/pull/1482
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 482410)
Time Spent: 1h 10m (was: 1h)
> Include convention in JDBC converter operator in Calcite plan
> -
>
> Key: HIVE-24143
> URL: https://issues.apache.org/jira/browse/HIVE-24143
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query
> generation. For instance:
> {code}
> HiveProject(jdbc_type_conversion_table1.ikey=[$0],
> jdbc_type_conversion_table1.bkey=[$1], jdbc_type_conversion_table1.fkey=[$2],
> jdbc_type_conversion_table1.dkey=[$3],
> jdbc_type_conversion_table1.chkey=[$4],
> jdbc_type_conversion_table1.dekey=[$5],
> jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
> HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4],
> dekey=[$5], dtkey=[$6], tkey=[$7])
> ->HiveJdbcConverter(convention=[JDBC.DERBY])
> JdbcHiveTableScan(table=[[default, jdbc_type_conversion_table1]],
> table:alias=[jdbc_type_conversion_table1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=482309=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-482309
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 11/Sep/20 21:47
Start Date: 11/Sep/20 21:47
Worklog Time Spent: 10m
Work Description: vineetgarg02 commented on pull request #1482:
URL: https://github.com/apache/hive/pull/1482#issuecomment-691326259
+1, looks good to me
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 482309)
Time Spent: 1h (was: 50m)
> Include convention in JDBC converter operator in Calcite plan
> -
>
> Key: HIVE-24143
> URL: https://issues.apache.org/jira/browse/HIVE-24143
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query
> generation. For instance:
> {code}
> HiveProject(jdbc_type_conversion_table1.ikey=[$0],
> jdbc_type_conversion_table1.bkey=[$1], jdbc_type_conversion_table1.fkey=[$2],
> jdbc_type_conversion_table1.dkey=[$3],
> jdbc_type_conversion_table1.chkey=[$4],
> jdbc_type_conversion_table1.dekey=[$5],
> jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
> HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4],
> dekey=[$5], dtkey=[$6], tkey=[$7])
> ->HiveJdbcConverter(convention=[JDBC.DERBY])
> JdbcHiveTableScan(table=[[default, jdbc_type_conversion_table1]],
> table:alias=[jdbc_type_conversion_table1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=482307=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-482307
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 11/Sep/20 21:46
Start Date: 11/Sep/20 21:46
Worklog Time Spent: 10m
Work Description: vineetgarg02 commented on a change in pull request
#1482:
URL: https://github.com/apache/hive/pull/1482#discussion_r487305188
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
Got it, make sense
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 482307)
Time Spent: 50m (was: 40m)
> Include convention in JDBC converter operator in Calcite plan
> -
>
> Key: HIVE-24143
> URL: https://issues.apache.org/jira/browse/HIVE-24143
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query
> generation. For instance:
> {code}
> HiveProject(jdbc_type_conversion_table1.ikey=[$0],
> jdbc_type_conversion_table1.bkey=[$1], jdbc_type_conversion_table1.fkey=[$2],
> jdbc_type_conversion_table1.dkey=[$3],
> jdbc_type_conversion_table1.chkey=[$4],
> jdbc_type_conversion_table1.dekey=[$5],
> jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
> HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4],
> dekey=[$5], dtkey=[$6], tkey=[$7])
> ->HiveJdbcConverter(convention=[JDBC.DERBY])
> JdbcHiveTableScan(table=[[default, jdbc_type_conversion_table1]],
> table:alias=[jdbc_type_conversion_table1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=482299=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-482299
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 11/Sep/20 21:35
Start Date: 11/Sep/20 21:35
Worklog Time Spent: 10m
Work Description: jcamachor commented on a change in pull request #1482:
URL: https://github.com/apache/hive/pull/1482#discussion_r487301360
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
This change is not actually related to this patch. Note that the test
was disabled by default (HIVE-23910); it seems maybe a preliminary version of
HIVE-23716 changed these q files and it should have not.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 482299)
Time Spent: 40m (was: 0.5h)
> Include convention in JDBC converter operator in Calcite plan
> -
>
> Key: HIVE-24143
> URL: https://issues.apache.org/jira/browse/HIVE-24143
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query
> generation. For instance:
> {code}
> HiveProject(jdbc_type_conversion_table1.ikey=[$0],
> jdbc_type_conversion_table1.bkey=[$1], jdbc_type_conversion_table1.fkey=[$2],
> jdbc_type_conversion_table1.dkey=[$3],
> jdbc_type_conversion_table1.chkey=[$4],
> jdbc_type_conversion_table1.dekey=[$5],
> jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
> HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4],
> dekey=[$5], dtkey=[$6], tkey=[$7])
> ->HiveJdbcConverter(convention=[JDBC.DERBY])
> JdbcHiveTableScan(table=[[default, jdbc_type_conversion_table1]],
> table:alias=[jdbc_type_conversion_table1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=482297=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-482297
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 11/Sep/20 21:29
Start Date: 11/Sep/20 21:29
Worklog Time Spent: 10m
Work Description: jcamachor commented on a change in pull request #1482:
URL: https://github.com/apache/hive/pull/1482#discussion_r487299089
##
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS
'org.apache.hadoop.hive.contrib.genericudf
FROM src
SELECT
-dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',
Review comment:
I changed it to avoid a clash with other test in the temp directory,
which I believe was causing HIVE-23910.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 482297)
Time Spent: 0.5h (was: 20m)
> Include convention in JDBC converter operator in Calcite plan
> -
>
> Key: HIVE-24143
> URL: https://issues.apache.org/jira/browse/HIVE-24143
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query
> generation. For instance:
> {code}
> HiveProject(jdbc_type_conversion_table1.ikey=[$0],
> jdbc_type_conversion_table1.bkey=[$1], jdbc_type_conversion_table1.fkey=[$2],
> jdbc_type_conversion_table1.dkey=[$3],
> jdbc_type_conversion_table1.chkey=[$4],
> jdbc_type_conversion_table1.dekey=[$5],
> jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
> HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4],
> dekey=[$5], dtkey=[$6], tkey=[$7])
> ->HiveJdbcConverter(convention=[JDBC.DERBY])
> JdbcHiveTableScan(table=[[default, jdbc_type_conversion_table1]],
> table:alias=[jdbc_type_conversion_table1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=482291=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-482291
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 11/Sep/20 21:11
Start Date: 11/Sep/20 21:11
Worklog Time Spent: 10m
Work Description: vineetgarg02 commented on a change in pull request
#1482:
URL: https://github.com/apache/hive/pull/1482#discussion_r487292490
##
File path:
ql/src/test/results/clientpositive/llap/external_jdbc_table_perf.q.out
##
@@ -6115,32 +6112,39 @@ WHERE "d_year" = 1999 AND "d_moy" BETWEEN 1 AND 3 AND
"d_date_sk" IS NOT NULL) A
Reduce Operator Tree:
Merge Join Operator
condition map:
- Anti Join 0 to 1
+ Left Outer Join 0 to 1
Review comment:
Also not sure what caused this change in plan.
##
File path: ql/src/test/queries/clientpositive/external_jdbc_table2.q
##
@@ -7,43 +6,43 @@ CREATE TEMPORARY FUNCTION dboutput AS
'org.apache.hadoop.hive.contrib.genericudf
FROM src
SELECT
-dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1;create=true','user1','passwd1',
+dboutput
('jdbc:derby:;databaseName=${system:test.tmp.dir}/test_derby_auth1_1;create=true','user1','passwd1',
Review comment:
Curious as to why this changed?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 482291)
Time Spent: 20m (was: 10m)
> Include convention in JDBC converter operator in Calcite plan
> -
>
> Key: HIVE-24143
> URL: https://issues.apache.org/jira/browse/HIVE-24143
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query
> generation. For instance:
> {code}
> HiveProject(jdbc_type_conversion_table1.ikey=[$0],
> jdbc_type_conversion_table1.bkey=[$1], jdbc_type_conversion_table1.fkey=[$2],
> jdbc_type_conversion_table1.dkey=[$3],
> jdbc_type_conversion_table1.chkey=[$4],
> jdbc_type_conversion_table1.dekey=[$5],
> jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
> HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4],
> dekey=[$5], dtkey=[$6], tkey=[$7])
> ->HiveJdbcConverter(convention=[JDBC.DERBY])
> JdbcHiveTableScan(table=[[default, jdbc_type_conversion_table1]],
> table:alias=[jdbc_type_conversion_table1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work logged] (HIVE-24143) Include convention in JDBC converter operator in Calcite plan
[
https://issues.apache.org/jira/browse/HIVE-24143?focusedWorklogId=481696=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-481696
]
ASF GitHub Bot logged work on HIVE-24143:
-
Author: ASF GitHub Bot
Created on: 10/Sep/20 21:01
Start Date: 10/Sep/20 21:01
Worklog Time Spent: 10m
Work Description: jcamachor opened a new pull request #1482:
URL: https://github.com/apache/hive/pull/1482
…plan
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 481696)
Remaining Estimate: 0h
Time Spent: 10m
> Include convention in JDBC converter operator in Calcite plan
> -
>
> Key: HIVE-24143
> URL: https://issues.apache.org/jira/browse/HIVE-24143
> Project: Hive
> Issue Type: Improvement
> Components: CBO
>Affects Versions: 4.0.0
>Reporter: Jesus Camacho Rodriguez
>Assignee: Jesus Camacho Rodriguez
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Among others, it will be useful to debug the dialect being chosen for query
> generation. For instance:
> {code}
> HiveProject(jdbc_type_conversion_table1.ikey=[$0],
> jdbc_type_conversion_table1.bkey=[$1], jdbc_type_conversion_table1.fkey=[$2],
> jdbc_type_conversion_table1.dkey=[$3],
> jdbc_type_conversion_table1.chkey=[$4],
> jdbc_type_conversion_table1.dekey=[$5],
> jdbc_type_conversion_table1.dtkey=[$6], jdbc_type_conversion_table1.tkey=[$7])
> HiveProject(ikey=[$0], bkey=[$1], fkey=[$2], dkey=[$3], chkey=[$4],
> dekey=[$5], dtkey=[$6], tkey=[$7])
> ->HiveJdbcConverter(convention=[JDBC.DERBY])
> JdbcHiveTableScan(table=[[default, jdbc_type_conversion_table1]],
> table:alias=[jdbc_type_conversion_table1])
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
