[jira] [Work logged] (HIVE-24975) Bug in ValidWriteIdList comparison in TxnIdUtils

2021-12-09 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24975?focusedWorklogId=693066&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-693066
 ]

ASF GitHub Bot logged work on HIVE-24975:
-

Author: ASF GitHub Bot
Created on: 09/Dec/21 09:21
Start Date: 09/Dec/21 09:21
Worklog Time Spent: 10m 
  Work Description: kgyrtkirk merged pull request #2641:
URL: https://github.com/apache/hive/pull/2641


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 693066)
Time Spent: 1h 10m  (was: 1h)

> Bug in ValidWriteIdList comparison in TxnIdUtils
> 
>
> Key: HIVE-24975
> URL: https://issues.apache.org/jira/browse/HIVE-24975
> Project: Hive
>  Issue Type: Bug
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
>  Labels: pull-request-available
> Fix For: 4.0.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> TxnIdUtils's 
> [compare|https://github.com/apache/hive/blob/master/storage-api/src/java/org/apache/hive/common/util/TxnIdUtils.java#L38]
>  method returns incorrect result for the following validWriteIdLists
> ValidWriteIdList a = new ValidReaderWriteIdList("default.test:1:1:1:");
>  ValidWriteIdList b = new 
> ValidReaderWriteIdList("default.test:1:9223372036854775807::");
> TxnIdUtils.compare(a, b) returns +1 whereas the expected response is -1 since 
> b is more recent.
> cc - [~kishendas] [~vihangk1]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Work logged] (HIVE-24975) Bug in ValidWriteIdList comparison in TxnIdUtils

2021-12-08 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24975?focusedWorklogId=692708&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-692708
 ]

ASF GitHub Bot logged work on HIVE-24975:
-

Author: ASF GitHub Bot
Created on: 08/Dec/21 16:23
Start Date: 08/Dec/21 16:23
Worklog Time Spent: 10m 
  Work Description: sourabh912 commented on a change in pull request #2641:
URL: https://github.com/apache/hive/pull/2641#discussion_r765021220



##
File path: storage-api/src/test/org/apache/hive/common/util/TestTxnIdUtils.java
##
@@ -190,5 +191,15 @@ public void testCompareWriteIds() throws Exception {
 new ValidReaderWriteIdList("default.table2", new long[] {8,10,11}, new 
BitSet(), 11)),
 -1);
 
+ValidWriteIdList a =

Review comment:
   Sure @kgyrtkirk . I will keep your suggestion in mind for future 
commits. Thanks for the review and approval. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 692708)
Time Spent: 1h  (was: 50m)

> Bug in ValidWriteIdList comparison in TxnIdUtils
> 
>
> Key: HIVE-24975
> URL: https://issues.apache.org/jira/browse/HIVE-24975
> Project: Hive
>  Issue Type: Bug
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> TxnIdUtils's 
> [compare|https://github.com/apache/hive/blob/master/storage-api/src/java/org/apache/hive/common/util/TxnIdUtils.java#L38]
>  method returns incorrect result for the following validWriteIdLists
> ValidWriteIdList a = new ValidReaderWriteIdList("default.test:1:1:1:");
>  ValidWriteIdList b = new 
> ValidReaderWriteIdList("default.test:1:9223372036854775807::");
> TxnIdUtils.compare(a, b) returns +1 whereas the expected response is -1 since 
> b is more recent.
> cc - [~kishendas] [~vihangk1]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Work logged] (HIVE-24975) Bug in ValidWriteIdList comparison in TxnIdUtils

2021-12-08 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24975?focusedWorklogId=692696&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-692696
 ]

ASF GitHub Bot logged work on HIVE-24975:
-

Author: ASF GitHub Bot
Created on: 08/Dec/21 16:13
Start Date: 08/Dec/21 16:13
Worklog Time Spent: 10m 
  Work Description: kgyrtkirk commented on a change in pull request #2641:
URL: https://github.com/apache/hive/pull/2641#discussion_r765012114



##
File path: storage-api/src/test/org/apache/hive/common/util/TestTxnIdUtils.java
##
@@ -190,5 +191,15 @@ public void testCompareWriteIds() throws Exception {
 new ValidReaderWriteIdList("default.table2", new long[] {8,10,11}, new 
BitSet(), 11)),
 -1);
 
+ValidWriteIdList a =

Review comment:
   putting a lot of cases into the same method is not really development 
friendly - next time please put new testcases into new test methods




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 692696)
Time Spent: 50m  (was: 40m)

> Bug in ValidWriteIdList comparison in TxnIdUtils
> 
>
> Key: HIVE-24975
> URL: https://issues.apache.org/jira/browse/HIVE-24975
> Project: Hive
>  Issue Type: Bug
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> TxnIdUtils's 
> [compare|https://github.com/apache/hive/blob/master/storage-api/src/java/org/apache/hive/common/util/TxnIdUtils.java#L38]
>  method returns incorrect result for the following validWriteIdLists
> ValidWriteIdList a = new ValidReaderWriteIdList("default.test:1:1:1:");
>  ValidWriteIdList b = new 
> ValidReaderWriteIdList("default.test:1:9223372036854775807::");
> TxnIdUtils.compare(a, b) returns +1 whereas the expected response is -1 since 
> b is more recent.
> cc - [~kishendas] [~vihangk1]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Work logged] (HIVE-24975) Bug in ValidWriteIdList comparison in TxnIdUtils

2021-12-04 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24975?focusedWorklogId=690578&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-690578
 ]

ASF GitHub Bot logged work on HIVE-24975:
-

Author: ASF GitHub Bot
Created on: 05/Dec/21 00:12
Start Date: 05/Dec/21 00:12
Worklog Time Spent: 10m 
  Work Description: github-actions[bot] commented on pull request #2641:
URL: https://github.com/apache/hive/pull/2641#issuecomment-986139795


   This pull request has been automatically marked as stale because it has not 
had recent activity. It will be closed if no further activity occurs.
   Feel free to reach out on the d...@hive.apache.org list if the patch is in 
need of reviews.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 690578)
Time Spent: 40m  (was: 0.5h)

> Bug in ValidWriteIdList comparison in TxnIdUtils
> 
>
> Key: HIVE-24975
> URL: https://issues.apache.org/jira/browse/HIVE-24975
> Project: Hive
>  Issue Type: Bug
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> TxnIdUtils's 
> [compare|https://github.com/apache/hive/blob/master/storage-api/src/java/org/apache/hive/common/util/TxnIdUtils.java#L38]
>  method returns incorrect result for the following validWriteIdLists
> ValidWriteIdList a = new ValidReaderWriteIdList("default.test:1:1:1:");
>  ValidWriteIdList b = new 
> ValidReaderWriteIdList("default.test:1:9223372036854775807::");
> TxnIdUtils.compare(a, b) returns +1 whereas the expected response is -1 since 
> b is more recent.
> cc - [~kishendas] [~vihangk1]



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[jira] [Work logged] (HIVE-24975) Bug in ValidWriteIdList comparison in TxnIdUtils

2021-10-05 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24975?focusedWorklogId=660511&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-660511
 ]

ASF GitHub Bot logged work on HIVE-24975:
-

Author: ASF GitHub Bot
Created on: 05/Oct/21 18:34
Start Date: 05/Oct/21 18:34
Worklog Time Spent: 10m 
  Work Description: sourabh912 commented on pull request #2641:
URL: https://github.com/apache/hive/pull/2641#issuecomment-934664670


   @nrg4878 @kishendas @vihangk1 : Can you please take a look and provide your 
feedback. 
   
   Thanks ! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 660511)
Time Spent: 0.5h  (was: 20m)

> Bug in ValidWriteIdList comparison in TxnIdUtils
> 
>
> Key: HIVE-24975
> URL: https://issues.apache.org/jira/browse/HIVE-24975
> Project: Hive
>  Issue Type: Bug
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> TxnIdUtils's 
> [compare|https://github.com/apache/hive/blob/master/storage-api/src/java/org/apache/hive/common/util/TxnIdUtils.java#L38]
>  method returns incorrect result for the following validWriteIdLists
> ValidWriteIdList a = new ValidReaderWriteIdList("default.test:1:1:1:");
>  ValidWriteIdList b = new 
> ValidReaderWriteIdList("default.test:1:9223372036854775807::");
> TxnIdUtils.compare(a, b) returns +1 whereas the expected response is -1 since 
> b is more recent.
> cc - [~kishendas] [~vihangk1]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-24975) Bug in ValidWriteIdList comparison in TxnIdUtils

2021-09-14 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24975?focusedWorklogId=650944&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650944
 ]

ASF GitHub Bot logged work on HIVE-24975:
-

Author: ASF GitHub Bot
Created on: 15/Sep/21 06:08
Start Date: 15/Sep/21 06:08
Worklog Time Spent: 10m 
  Work Description: sourabh912 commented on pull request #2641:
URL: https://github.com/apache/hive/pull/2641#issuecomment-919727850


   @kishendas  @vihangk1 : I have made a similar fix in Impala 
https://github.com/apache/impala/commit/5d307cbb7b2ec3432bebd7759b0bcebf54a6cc22
   
   Please review this and share your feedback.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 650944)
Time Spent: 20m  (was: 10m)

> Bug in ValidWriteIdList comparison in TxnIdUtils
> 
>
> Key: HIVE-24975
> URL: https://issues.apache.org/jira/browse/HIVE-24975
> Project: Hive
>  Issue Type: Bug
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> TxnIdUtils's 
> [compare|https://github.com/apache/hive/blob/master/storage-api/src/java/org/apache/hive/common/util/TxnIdUtils.java#L38]
>  method returns incorrect result for the following validWriteIdLists
> ValidWriteIdList a = new ValidReaderWriteIdList("default.test:1:1:1:");
>  ValidWriteIdList b = new 
> ValidReaderWriteIdList("default.test:1:9223372036854775807::");
> TxnIdUtils.compare(a, b) returns +1 whereas the expected response is -1 since 
> b is more recent.
> cc - [~kishendas] [~vihangk1]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Work logged] (HIVE-24975) Bug in ValidWriteIdList comparison in TxnIdUtils

2021-09-14 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-24975?focusedWorklogId=650943&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-650943
 ]

ASF GitHub Bot logged work on HIVE-24975:
-

Author: ASF GitHub Bot
Created on: 15/Sep/21 06:06
Start Date: 15/Sep/21 06:06
Worklog Time Spent: 10m 
  Work Description: sourabh912 opened a new pull request #2641:
URL: https://github.com/apache/hive/pull/2641


   Change-Id: I8022d5725900da08806331ac4d222a47adfe
   
   
   
   ### What changes were proposed in this pull request?
   
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
---

Worklog Id: (was: 650943)
Remaining Estimate: 0h
Time Spent: 10m

> Bug in ValidWriteIdList comparison in TxnIdUtils
> 
>
> Key: HIVE-24975
> URL: https://issues.apache.org/jira/browse/HIVE-24975
> Project: Hive
>  Issue Type: Bug
>Reporter: Sourabh Goyal
>Assignee: Sourabh Goyal
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> TxnIdUtils's 
> [compare|https://github.com/apache/hive/blob/master/storage-api/src/java/org/apache/hive/common/util/TxnIdUtils.java#L38]
>  method returns incorrect result for the following validWriteIdLists
> ValidWriteIdList a = new ValidReaderWriteIdList("default.test:1:1:1:");
>  ValidWriteIdList b = new 
> ValidReaderWriteIdList("default.test:1:9223372036854775807::");
> TxnIdUtils.compare(a, b) returns +1 whereas the expected response is -1 since 
> b is more recent.
> cc - [~kishendas] [~vihangk1]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)