[jira] [Work logged] (HIVE-25922) Upgrade Iceberg dependency to 0.13.0
[ https://issues.apache.org/jira/browse/HIVE-25922?focusedWorklogId=720130=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-720130 ] ASF GitHub Bot logged work on HIVE-25922: - Author: ASF GitHub Bot Created on: 03/Feb/22 13:31 Start Date: 03/Feb/22 13:31 Worklog Time Spent: 10m Work Description: szlta merged pull request #2994: URL: https://github.com/apache/hive/pull/2994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 720130) Time Spent: 50m (was: 40m) > Upgrade Iceberg dependency to 0.13.0 > > > Key: HIVE-25922 > URL: https://issues.apache.org/jira/browse/HIVE-25922 > Project: Hive > Issue Type: Improvement >Reporter: Ádám Szita >Assignee: Ádám Szita >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (HIVE-25922) Upgrade Iceberg dependency to 0.13.0
[ https://issues.apache.org/jira/browse/HIVE-25922?focusedWorklogId=719959=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-719959 ] ASF GitHub Bot logged work on HIVE-25922: - Author: ASF GitHub Bot Created on: 03/Feb/22 09:06 Start Date: 03/Feb/22 09:06 Worklog Time Spent: 10m Work Description: szlta commented on a change in pull request #2994: URL: https://github.com/apache/hive/pull/2994#discussion_r798351627 ## File path: iceberg/iceberg-handler/pom.xml ## @@ -106,6 +106,12 @@ assertj-core test + +org.roaringbitmap Review comment: I think this is due to roaringbitmap having a 'runtime' scope in the iceberg-core pom: https://repo1.maven.org/maven2/org/apache/iceberg/iceberg-core/0.13.0/iceberg-core-0.13.0.pom And we do need it on classpath for tests too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 719959) Time Spent: 40m (was: 0.5h) > Upgrade Iceberg dependency to 0.13.0 > > > Key: HIVE-25922 > URL: https://issues.apache.org/jira/browse/HIVE-25922 > Project: Hive > Issue Type: Improvement >Reporter: Ádám Szita >Assignee: Ádám Szita >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Work logged] (HIVE-25922) Upgrade Iceberg dependency to 0.13.0
[
https://issues.apache.org/jira/browse/HIVE-25922?focusedWorklogId=719957=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-719957
]
ASF GitHub Bot logged work on HIVE-25922:
-
Author: ASF GitHub Bot
Created on: 03/Feb/22 09:01
Start Date: 03/Feb/22 09:01
Worklog Time Spent: 10m
Work Description: szlta commented on a change in pull request #2994:
URL: https://github.com/apache/hive/pull/2994#discussion_r798348013
##
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergTimeTravel.java
##
@@ -49,8 +49,8 @@ public void testSelectAsOfTimestamp() throws IOException,
InterruptedException {
Assert.assertEquals(4, rows.size());
AssertHelpers.assertThrows("should throw exception",
IllegalArgumentException.class,
-"Cannot find a snapshot older than 1970-01-01 00:00:00", () -> {
- shell.executeStatement("SELECT * FROM customers FOR SYSTEM_TIME AS
OF '1970-01-01 00:00:00'");
+"java.lang.IllegalArgumentException: Cannot find a snapshot older than
1970-01-01", () -> {
+shell.executeStatement("SELECT * FROM customers FOR SYSTEM_TIME AS OF
'1970-01-01 00:00:00.000'");
Review comment:
Yup it does, this is probably just a leftover from something, I'll
remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 719957)
Time Spent: 0.5h (was: 20m)
> Upgrade Iceberg dependency to 0.13.0
>
>
> Key: HIVE-25922
> URL: https://issues.apache.org/jira/browse/HIVE-25922
> Project: Hive
> Issue Type: Improvement
>Reporter: Ádám Szita
>Assignee: Ádám Szita
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Work logged] (HIVE-25922) Upgrade Iceberg dependency to 0.13.0
[
https://issues.apache.org/jira/browse/HIVE-25922?focusedWorklogId=719484=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-719484
]
ASF GitHub Bot logged work on HIVE-25922:
-
Author: ASF GitHub Bot
Created on: 02/Feb/22 16:36
Start Date: 02/Feb/22 16:36
Worklog Time Spent: 10m
Work Description: marton-bod commented on a change in pull request #2994:
URL: https://github.com/apache/hive/pull/2994#discussion_r797800931
##
File path:
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergTimeTravel.java
##
@@ -49,8 +49,8 @@ public void testSelectAsOfTimestamp() throws IOException,
InterruptedException {
Assert.assertEquals(4, rows.size());
AssertHelpers.assertThrows("should throw exception",
IllegalArgumentException.class,
-"Cannot find a snapshot older than 1970-01-01 00:00:00", () -> {
- shell.executeStatement("SELECT * FROM customers FOR SYSTEM_TIME AS
OF '1970-01-01 00:00:00'");
+"java.lang.IllegalArgumentException: Cannot find a snapshot older than
1970-01-01", () -> {
+shell.executeStatement("SELECT * FROM customers FOR SYSTEM_TIME AS OF
'1970-01-01 00:00:00.000'");
Review comment:
Out of curiosity: does it not work without the `.000` part in the SQL
statement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 719484)
Time Spent: 20m (was: 10m)
> Upgrade Iceberg dependency to 0.13.0
>
>
> Key: HIVE-25922
> URL: https://issues.apache.org/jira/browse/HIVE-25922
> Project: Hive
> Issue Type: Improvement
>Reporter: Ádám Szita
>Assignee: Ádám Szita
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Work logged] (HIVE-25922) Upgrade Iceberg dependency to 0.13.0
[ https://issues.apache.org/jira/browse/HIVE-25922?focusedWorklogId=719481=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-719481 ] ASF GitHub Bot logged work on HIVE-25922: - Author: ASF GitHub Bot Created on: 02/Feb/22 16:35 Start Date: 02/Feb/22 16:35 Worklog Time Spent: 10m Work Description: marton-bod commented on a change in pull request #2994: URL: https://github.com/apache/hive/pull/2994#discussion_r797799573 ## File path: iceberg/iceberg-handler/pom.xml ## @@ -106,6 +106,12 @@ assertj-core test + +org.roaringbitmap Review comment: How come we need this here? I thought this would come transitively via iceberg-core -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 719481) Remaining Estimate: 0h Time Spent: 10m > Upgrade Iceberg dependency to 0.13.0 > > > Key: HIVE-25922 > URL: https://issues.apache.org/jira/browse/HIVE-25922 > Project: Hive > Issue Type: Improvement >Reporter: Ádám Szita >Assignee: Ádám Szita >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.1#820001)
