[jira] [Work logged] (HIVE-26274) No vectorization if query has upper case window function
[ https://issues.apache.org/jira/browse/HIVE-26274?focusedWorklogId=782359=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782359 ] ASF GitHub Bot logged work on HIVE-26274: - Author: ASF GitHub Bot Created on: 17/Jun/22 10:04 Start Date: 17/Jun/22 10:04 Worklog Time Spent: 10m Work Description: abstractdog commented on PR #3382: URL: https://github.com/apache/hive/pull/3382#issuecomment-1158716470 I'm afraid using addendum patches can make the patch contents vague (what to backport later), can you please file a separate jira for clarity sake? otherwise, looks good to me Issue Time Tracking --- Worklog Id: (was: 782359) Time Spent: 50m (was: 40m) > No vectorization if query has upper case window function > > > Key: HIVE-26274 > URL: https://issues.apache.org/jira/browse/HIVE-26274 > Project: Hive > Issue Type: Bug >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Time Spent: 50m > Remaining Estimate: 0h > > {code} > CREATE TABLE t1 (a int, b int); > EXPLAIN VECTORIZATION ONLY SELECT ROW_NUMBER() OVER(order by a) AS rn FROM t1; > {code} > {code} > PLAN VECTORIZATION: > enabled: true > enabledConditionsMet: [hive.vectorized.execution.enabled IS true] > STAGE DEPENDENCIES: > Stage-1 is a root stage > Stage-0 depends on stages: Stage-1 > STAGE PLANS: > Stage: Stage-1 > Tez > Edges: > Reducer 2 <- Map 1 (SIMPLE_EDGE) > Vertices: > Map 1 > Execution mode: vectorized, llap > LLAP IO: all inputs > Map Vectorization: > enabled: true > enabledConditionsMet: > hive.vectorized.use.vector.serde.deserialize IS true > inputFormatFeatureSupport: [DECIMAL_64] > featureSupportInUse: [DECIMAL_64] > inputFileFormats: org.apache.hadoop.mapred.TextInputFormat > allNative: true > usesVectorUDFAdaptor: false > vectorized: true > Reducer 2 > Execution mode: llap > Reduce Vectorization: > enabled: true > enableConditionsMet: hive.vectorized.execution.reduce.enabled > IS true, hive.execution.engine tez IN [tez] IS true > notVectorizedReason: PTF operator: ROW_NUMBER not in > supported functions [avg, count, dense_rank, first_value, lag, last_value, > lead, max, min, rank, row_number, sum] > vectorized: false > Stage: Stage-0 > Fetch Operator > {code} > {code} > notVectorizedReason: PTF operator: ROW_NUMBER not in > supported functions [avg, count, dense_rank, first_value, lag, last_value, > lead, max, min, rank, row_number, sum] > {code} -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26274) No vectorization if query has upper case window function
[ https://issues.apache.org/jira/browse/HIVE-26274?focusedWorklogId=782257=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-782257 ] ASF GitHub Bot logged work on HIVE-26274: - Author: ASF GitHub Bot Created on: 17/Jun/22 06:50 Start Date: 17/Jun/22 06:50 Worklog Time Spent: 10m Work Description: kasakrisz opened a new pull request, #3382: URL: https://github.com/apache/hive/pull/3382 Addendum to #3332 Issue Time Tracking --- Worklog Id: (was: 782257) Time Spent: 40m (was: 0.5h) > No vectorization if query has upper case window function > > > Key: HIVE-26274 > URL: https://issues.apache.org/jira/browse/HIVE-26274 > Project: Hive > Issue Type: Bug >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Time Spent: 40m > Remaining Estimate: 0h > > {code} > CREATE TABLE t1 (a int, b int); > EXPLAIN VECTORIZATION ONLY SELECT ROW_NUMBER() OVER(order by a) AS rn FROM t1; > {code} > {code} > PLAN VECTORIZATION: > enabled: true > enabledConditionsMet: [hive.vectorized.execution.enabled IS true] > STAGE DEPENDENCIES: > Stage-1 is a root stage > Stage-0 depends on stages: Stage-1 > STAGE PLANS: > Stage: Stage-1 > Tez > Edges: > Reducer 2 <- Map 1 (SIMPLE_EDGE) > Vertices: > Map 1 > Execution mode: vectorized, llap > LLAP IO: all inputs > Map Vectorization: > enabled: true > enabledConditionsMet: > hive.vectorized.use.vector.serde.deserialize IS true > inputFormatFeatureSupport: [DECIMAL_64] > featureSupportInUse: [DECIMAL_64] > inputFileFormats: org.apache.hadoop.mapred.TextInputFormat > allNative: true > usesVectorUDFAdaptor: false > vectorized: true > Reducer 2 > Execution mode: llap > Reduce Vectorization: > enabled: true > enableConditionsMet: hive.vectorized.execution.reduce.enabled > IS true, hive.execution.engine tez IN [tez] IS true > notVectorizedReason: PTF operator: ROW_NUMBER not in > supported functions [avg, count, dense_rank, first_value, lag, last_value, > lead, max, min, rank, row_number, sum] > vectorized: false > Stage: Stage-0 > Fetch Operator > {code} > {code} > notVectorizedReason: PTF operator: ROW_NUMBER not in > supported functions [avg, count, dense_rank, first_value, lag, last_value, > lead, max, min, rank, row_number, sum] > {code} -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26274) No vectorization if query has upper case window function
[ https://issues.apache.org/jira/browse/HIVE-26274?focusedWorklogId=777296=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777296 ] ASF GitHub Bot logged work on HIVE-26274: - Author: ASF GitHub Bot Created on: 02/Jun/22 06:54 Start Date: 02/Jun/22 06:54 Worklog Time Spent: 10m Work Description: kasakrisz merged PR #3332: URL: https://github.com/apache/hive/pull/3332 Issue Time Tracking --- Worklog Id: (was: 777296) Time Spent: 0.5h (was: 20m) > No vectorization if query has upper case window function > > > Key: HIVE-26274 > URL: https://issues.apache.org/jira/browse/HIVE-26274 > Project: Hive > Issue Type: Bug >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > {code} > CREATE TABLE t1 (a int, b int); > EXPLAIN VECTORIZATION ONLY SELECT ROW_NUMBER() OVER(order by a) AS rn FROM t1; > {code} > {code} > PLAN VECTORIZATION: > enabled: true > enabledConditionsMet: [hive.vectorized.execution.enabled IS true] > STAGE DEPENDENCIES: > Stage-1 is a root stage > Stage-0 depends on stages: Stage-1 > STAGE PLANS: > Stage: Stage-1 > Tez > Edges: > Reducer 2 <- Map 1 (SIMPLE_EDGE) > Vertices: > Map 1 > Execution mode: vectorized, llap > LLAP IO: all inputs > Map Vectorization: > enabled: true > enabledConditionsMet: > hive.vectorized.use.vector.serde.deserialize IS true > inputFormatFeatureSupport: [DECIMAL_64] > featureSupportInUse: [DECIMAL_64] > inputFileFormats: org.apache.hadoop.mapred.TextInputFormat > allNative: true > usesVectorUDFAdaptor: false > vectorized: true > Reducer 2 > Execution mode: llap > Reduce Vectorization: > enabled: true > enableConditionsMet: hive.vectorized.execution.reduce.enabled > IS true, hive.execution.engine tez IN [tez] IS true > notVectorizedReason: PTF operator: ROW_NUMBER not in > supported functions [avg, count, dense_rank, first_value, lag, last_value, > lead, max, min, rank, row_number, sum] > vectorized: false > Stage: Stage-0 > Fetch Operator > {code} > {code} > notVectorizedReason: PTF operator: ROW_NUMBER not in > supported functions [avg, count, dense_rank, first_value, lag, last_value, > lead, max, min, rank, row_number, sum] > {code} -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26274) No vectorization if query has upper case window function
[ https://issues.apache.org/jira/browse/HIVE-26274?focusedWorklogId=777293=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777293 ] ASF GitHub Bot logged work on HIVE-26274: - Author: ASF GitHub Bot Created on: 02/Jun/22 06:46 Start Date: 02/Jun/22 06:46 Worklog Time Spent: 10m Work Description: abstractdog commented on PR #3332: URL: https://github.com/apache/hive/pull/3332#issuecomment-1144501074 LGTM, thanks for the patch @kasakrisz Issue Time Tracking --- Worklog Id: (was: 777293) Time Spent: 20m (was: 10m) > No vectorization if query has upper case window function > > > Key: HIVE-26274 > URL: https://issues.apache.org/jira/browse/HIVE-26274 > Project: Hive > Issue Type: Bug >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Labels: pull-request-available > Fix For: 4.0.0 > > Time Spent: 20m > Remaining Estimate: 0h > > {code} > CREATE TABLE t1 (a int, b int); > EXPLAIN VECTORIZATION ONLY SELECT ROW_NUMBER() OVER(order by a) AS rn FROM t1; > {code} > {code} > PLAN VECTORIZATION: > enabled: true > enabledConditionsMet: [hive.vectorized.execution.enabled IS true] > STAGE DEPENDENCIES: > Stage-1 is a root stage > Stage-0 depends on stages: Stage-1 > STAGE PLANS: > Stage: Stage-1 > Tez > Edges: > Reducer 2 <- Map 1 (SIMPLE_EDGE) > Vertices: > Map 1 > Execution mode: vectorized, llap > LLAP IO: all inputs > Map Vectorization: > enabled: true > enabledConditionsMet: > hive.vectorized.use.vector.serde.deserialize IS true > inputFormatFeatureSupport: [DECIMAL_64] > featureSupportInUse: [DECIMAL_64] > inputFileFormats: org.apache.hadoop.mapred.TextInputFormat > allNative: true > usesVectorUDFAdaptor: false > vectorized: true > Reducer 2 > Execution mode: llap > Reduce Vectorization: > enabled: true > enableConditionsMet: hive.vectorized.execution.reduce.enabled > IS true, hive.execution.engine tez IN [tez] IS true > notVectorizedReason: PTF operator: ROW_NUMBER not in > supported functions [avg, count, dense_rank, first_value, lag, last_value, > lead, max, min, rank, row_number, sum] > vectorized: false > Stage: Stage-0 > Fetch Operator > {code} > {code} > notVectorizedReason: PTF operator: ROW_NUMBER not in > supported functions [avg, count, dense_rank, first_value, lag, last_value, > lead, max, min, rank, row_number, sum] > {code} -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Work logged] (HIVE-26274) No vectorization if query has upper case window function
[ https://issues.apache.org/jira/browse/HIVE-26274?focusedWorklogId=776228=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-776228 ] ASF GitHub Bot logged work on HIVE-26274: - Author: ASF GitHub Bot Created on: 31/May/22 10:45 Start Date: 31/May/22 10:45 Worklog Time Spent: 10m Work Description: kasakrisz opened a new pull request, #3332: URL: https://github.com/apache/hive/pull/3332 ### What changes were proposed in this pull request? Convert window function names to lower case when looking up in vectorizable function registry. ### Why are the changes needed? Support case insensitivity of window functions when vectorizing PTF operator. ### Does this PR introduce _any_ user-facing change? No, but explain vectorization output may change if query has window functions ### How was this patch tested? ``` mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=vector_ptf_1.q -pl itests/qtest -Pitests ``` Issue Time Tracking --- Worklog Id: (was: 776228) Remaining Estimate: 0h Time Spent: 10m > No vectorization if query has upper case window function > > > Key: HIVE-26274 > URL: https://issues.apache.org/jira/browse/HIVE-26274 > Project: Hive > Issue Type: Bug >Reporter: Krisztian Kasa >Assignee: Krisztian Kasa >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > {code} > CREATE TABLE t1 (a int, b int); > EXPLAIN VECTORIZATION ONLY SELECT ROW_NUMBER() OVER(order by a) AS rn FROM t1; > {code} > {code} > PLAN VECTORIZATION: > enabled: true > enabledConditionsMet: [hive.vectorized.execution.enabled IS true] > STAGE DEPENDENCIES: > Stage-1 is a root stage > Stage-0 depends on stages: Stage-1 > STAGE PLANS: > Stage: Stage-1 > Tez > Edges: > Reducer 2 <- Map 1 (SIMPLE_EDGE) > Vertices: > Map 1 > Execution mode: vectorized, llap > LLAP IO: all inputs > Map Vectorization: > enabled: true > enabledConditionsMet: > hive.vectorized.use.vector.serde.deserialize IS true > inputFormatFeatureSupport: [DECIMAL_64] > featureSupportInUse: [DECIMAL_64] > inputFileFormats: org.apache.hadoop.mapred.TextInputFormat > allNative: true > usesVectorUDFAdaptor: false > vectorized: true > Reducer 2 > Execution mode: llap > Reduce Vectorization: > enabled: true > enableConditionsMet: hive.vectorized.execution.reduce.enabled > IS true, hive.execution.engine tez IN [tez] IS true > notVectorizedReason: PTF operator: ROW_NUMBER not in > supported functions [avg, count, dense_rank, first_value, lag, last_value, > lead, max, min, rank, row_number, sum] > vectorized: false > Stage: Stage-0 > Fetch Operator > {code} > {code} > notVectorizedReason: PTF operator: ROW_NUMBER not in > supported functions [avg, count, dense_rank, first_value, lag, last_value, > lead, max, min, rank, row_number, sum] > {code} -- This message was sent by Atlassian Jira (v8.20.7#820007)