[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=841291=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-841291
]
ASF GitHub Bot logged work on HIVE-26809:
-
Author: ASF GitHub Bot
Created on: 24/Jan/23 06:43
Start Date: 24/Jan/23 06:43
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1084862512
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
makes sense to me, thanx Laszlo!!!
Issue Time Tracking
---
Worklog Id: (was: 841291)
Time Spent: 6h 20m (was: 6h 10m)
> Upgrade ORC to 1.8.1
>
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Dmitriy Fingerman
>Assignee: Dmitriy Fingerman
>Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=841175=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-841175
]
ASF GitHub Bot logged work on HIVE-26809:
-
Author: ASF GitHub Bot
Created on: 23/Jan/23 16:20
Start Date: 23/Jan/23 16:20
Worklog Time Spent: 10m
Work Description: abstractdog commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1084204246
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
I was trying to understand the scenario here and the way I see this: the
current PR code is not the proper one as we end up Hive on ORC 1.8.x but
without an important optimization introduced in ORC-1060, so if we have to copy
some ORC code anyway, let's have ORC-1060 at least here (sometimes I feel we
need to port changes on separate jiras, but here we can merge them together)
but what's more important is that I see the basic confusion comes from the
fact that in ORC we have a common StringTreeReader which encapsulates different
kinds of string readers like StringDirectTreeReader,
StringDictionaryTreeReader, but in hive's StringStreamReader we have
dictionary-related properties like _dictionaryStream, _lengthStream, which is
confusing...if we're already subclassing ORC tree readers, we should follow it
like:
```
HIVE -> ORC
StringStreamReader -> StringTreeReader (as it is now)
StringDictionaryStreamReader -> StringDictionaryTreeReader
StringDirectStreamReader -> StringDirectTreeReader
```
this is a change that should be done regardless of ORC 1.8 upgrade in my
opinion, and prior to ORC 1.8 upgrade
once we follow ORC tree class hierarchy, we have a better chance to adapt
changes like ORC-1060, where e.g. only the dictionary reader has been changed
guys, if you agree with this, let's address the above problem in a separate
hive ticket first, it's worth spending the time on it, especially if turns out
that the ORC 1.8 upgrade becomes a clearer thing
Issue Time Tracking
---
Worklog Id: (was: 841175)
Time Spent: 6h 10m (was: 6h)
> Upgrade ORC to 1.8.1
>
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Dmitriy Fingerman
>Assignee: Dmitriy Fingerman
>Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=841158=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-841158
]
ASF GitHub Bot logged work on HIVE-26809:
-
Author: ASF GitHub Bot
Created on: 23/Jan/23 15:34
Start Date: 23/Jan/23 15:34
Worklog Time Spent: 10m
Work Description: abstractdog commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1084204246
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
I was trying to understand the scenario here and the way I see this: the
current PR code is not the proper one as we end up Hive on ORC 1.8.x but
without an important optimization introduced in ORC-1060, so if we have to copy
some ORC code anyway, let's have ORC-1060 at least here (sometimes I feel we
need to port changes on separate jiras, but here we can merge them together)
I see that the basic confusion comes from the fact that in ORC we have a
common StringTreeReader which encapsulates different kinds of string readers
like StringDirectTreeReader, StringDictionaryTreeReader, but in hive's
StringStreamReader we have dictionary-related properties like
_dictionaryStream, _lengthStream, which is confusing...if we're already
subclassing ORC tree readers, we should follow it like:
```
HIVE -> ORC
StringStreamReader -> StringTreeReader (as it is now)
StringDictionaryStreamReader -> StringDictionaryTreeReader
StringDirectStreamReader -> StringDirectTreeReader
```
this is a change that should be done regardless of ORC 1.8 upgrade in my
opinion, and prior to ORC 1.8 upgrade
once we follow ORC tree class hierarchy, we have a better chance to adapt
changes like ORC-1060, where e.g. only the dictionary reader has been changed
guys, if you agree with this, let's address the above problem in a separate
hive ticket first, it's worth spending the time on it, especially if turns out
that the ORC 1.8 upgrade becomes a clearer thing
Issue Time Tracking
---
Worklog Id: (was: 841158)
Time Spent: 6h (was: 5h 50m)
> Upgrade ORC to 1.8.1
>
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Dmitriy Fingerman
>Assignee: Dmitriy Fingerman
>Priority: Major
> Labels: pull-request-available
> Time Spent: 6h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=841157=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-841157
]
ASF GitHub Bot logged work on HIVE-26809:
-
Author: ASF GitHub Bot
Created on: 23/Jan/23 15:32
Start Date: 23/Jan/23 15:32
Worklog Time Spent: 10m
Work Description: abstractdog commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1084204246
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
I was trying to understand the scenario here and the way I see this: the
current PR code is not the proper one as we end up Hive on ORC 1.8.x but
without an important optimization introduced in ORC-1060, so if we have to copy
some ORC code anyway, let's have ORC-1060 at least here (sometimes I feel we
need to port changes on separate jiras, but here we can merge them together)
I see that the basic confusion comes from the fact that in ORC we have a
common StringTreeReader which encapsulates different kinds of string readers
like StringDirectTreeReader, StringDictionaryTreeReader, but in hive's
StringStreamReader we have dictionary-related properties like
_dictionaryStream, _lengthStream, which is confusing...if we're already
subclassing ORC tree readers, we should follow it like:
```
HIVE -> ORC
StringStreamReader -> StringTreeReader (as it is now)
StringDictionaryStreamReader -> StringDictionaryTreeReader
StringDirectStreamReader -> StringDirectTreeReader
```
this is a change that should be done regardless of ORC 1.8 upgrade in my
opinion, and prior to ORC 1.8 upgrade
once we follow ORC tree class hierarchy, we have a better chance to adapt
changes like ORC-1060, where e.g. only the dictionary reader has been changed
guys, if you agree with this, let's address the above problem in a separate
hive ticket first, let's take the time, it's worth the time, especially if
turns out that the ORC 1.8 upgrade becomes a clearer thing
Issue Time Tracking
---
Worklog Id: (was: 841157)
Time Spent: 5h 50m (was: 5h 40m)
> Upgrade ORC to 1.8.1
>
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Dmitriy Fingerman
>Assignee: Dmitriy Fingerman
>Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=840555=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-840555
]
ASF GitHub Bot logged work on HIVE-26809:
-
Author: ASF GitHub Bot
Created on: 20/Jan/23 09:26
Start Date: 20/Jan/23 09:26
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1082276996
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
@abstractdog any pointers here? Does that sound fine thing to do for now
Issue Time Tracking
---
Worklog Id: (was: 840555)
Time Spent: 5h 40m (was: 5.5h)
> Upgrade ORC to 1.8.1
>
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Dmitriy Fingerman
>Assignee: Dmitriy Fingerman
>Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=839726=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839726
]
ASF GitHub Bot logged work on HIVE-26809:
-
Author: ASF GitHub Bot
Created on: 17/Jan/23 17:46
Start Date: 17/Jan/23 17:46
Worklog Time Spent: 10m
Work Description: difin commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1072298943
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
Hi @ayushtkn, I agree with you. It is not ideal approach. Before
implementing this approach I did try to adapt Hive, but I didn't succeed to
find how Hive could be adapted to ORC-1060 changes because those changes are
inside internal implementation of Orc StringDictionaryTreeReader class. The API
of StringDictionaryTreeReader class remained the same.
I agree with you that this approach is not ideal and will backfire in future
when we try to upgrade and the changes in ORC depends on the ones which we
ditched, but Hive already heavily depends on internal ORC API by implementing
its own column readers on top of ORC and when upgrading to different ORC
version it is often required to make adaptations in Hive.
Issue Time Tracking
---
Worklog Id: (was: 839726)
Time Spent: 5.5h (was: 5h 20m)
> Upgrade ORC to 1.8.1
>
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Dmitriy Fingerman
>Assignee: Dmitriy Fingerman
>Priority: Major
> Labels: pull-request-available
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=839725=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839725
]
ASF GitHub Bot logged work on HIVE-26809:
-
Author: ASF GitHub Bot
Created on: 17/Jan/23 17:44
Start Date: 17/Jan/23 17:44
Worklog Time Spent: 10m
Work Description: difin commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1072298943
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
Hi @ayushtkn, I agree with you. It is not ideal approach. Before
implementing this approach I did try to adapt Hive, but I didn't succeed to
find how Hive could be adapted to ORC-1060 changes because those changes are
inside internal implementation of Orc StringDictionaryTreeReader class.
I agree with you that this approach is not ideal and will backfire in future
when we try to upgrade and the changes in ORC depends on the ones which we
ditched, but Hive already heavily depends on internal ORC API by implementing
its own column readers on top of ORC and when upgrading to different ORC
version it is often required to make adaptations in Hive.
Issue Time Tracking
---
Worklog Id: (was: 839725)
Time Spent: 5h 20m (was: 5h 10m)
> Upgrade ORC to 1.8.1
>
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Dmitriy Fingerman
>Assignee: Dmitriy Fingerman
>Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=839669=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839669
]
ASF GitHub Bot logged work on HIVE-26809:
-
Author: ASF GitHub Bot
Created on: 17/Jan/23 14:45
Start Date: 17/Jan/23 14:45
Worklog Time Spent: 10m
Work Description: difin commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1072298943
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
Hi @ayushtkn, I agree with you. It is not ideal approach. Before
implementing this approach I did try to adapt Hive, but I didn't succeed to
find how Hive could be adapted to ORC-1060 changes because those changes are
only inside internal implementation of Orc StringDictionaryTreeReader class.
I agree with you that this approach is not ideal and will backfire in future
when we try to upgrade and the changes in ORC depends on the ones which we
ditched, but Hive already heavily depends on internal ORC API by implementing
its own column readers on top of ORC and when upgrading to different ORC
version it is often required to make adaptations in Hive.
Issue Time Tracking
---
Worklog Id: (was: 839669)
Time Spent: 5h 10m (was: 5h)
> Upgrade ORC to 1.8.1
>
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Dmitriy Fingerman
>Assignee: Dmitriy Fingerman
>Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=839509=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839509
]
ASF GitHub Bot logged work on HIVE-26809:
-
Author: ASF GitHub Bot
Created on: 17/Jan/23 05:27
Start Date: 17/Jan/23 05:27
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1071751361
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
Ok, that seems to be an improvement or say a bug fix in the ORC project and
we are just implementing our own varient because now the original class is
causing test failures.
This isn't the ideal approach and will backfire in future when we try to
upgrade and the changes in ORC depends on the ones which we ditched.
We should try to adapt to those changes and make sure we don't crash with
those changes in Hive by making hive changes, rather than maintaining a old
version of ORC class at Hive
Issue Time Tracking
---
Worklog Id: (was: 839509)
Time Spent: 5h (was: 4h 50m)
> Upgrade ORC to 1.8.1
>
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Dmitriy Fingerman
>Assignee: Dmitriy Fingerman
>Priority: Major
> Labels: pull-request-available
> Time Spent: 5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[ https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=839479=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839479 ] ASF GitHub Bot logged work on HIVE-26809: - Author: ASF GitHub Bot Created on: 17/Jan/23 00:31 Start Date: 17/Jan/23 00:31 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #3833: URL: https://github.com/apache/hive/pull/3833#issuecomment-1384697767 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive=3833) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3833=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3833=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3833=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_hive=3833=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_hive=3833=duplicated_lines_density=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 839479) Time Spent: 4h 50m (was: 4h 40m) > Upgrade ORC to 1.8.1 > > > Key: HIVE-26809 > URL: https://issues.apache.org/jira/browse/HIVE-26809 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0 >Reporter: Dmitriy Fingerman >Assignee: Dmitriy Fingerman >Priority: Major > Labels: pull-request-available > Time Spent: 4h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[ https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=839466=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839466 ] ASF GitHub Bot logged work on HIVE-26809: - Author: ASF GitHub Bot Created on: 16/Jan/23 19:37 Start Date: 16/Jan/23 19:37 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #3833: URL: https://github.com/apache/hive/pull/3833#issuecomment-1384475873 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive=3833) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3833=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3833=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3833=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_hive=3833=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_hive=3833=duplicated_lines_density=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 839466) Time Spent: 4h 40m (was: 4.5h) > Upgrade ORC to 1.8.1 > > > Key: HIVE-26809 > URL: https://issues.apache.org/jira/browse/HIVE-26809 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0 >Reporter: Dmitriy Fingerman >Assignee: Dmitriy Fingerman >Priority: Major > Labels: pull-request-available > Time Spent: 4h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=839455=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839455
]
ASF GitHub Bot logged work on HIVE-26809:
-
Author: ASF GitHub Bot
Created on: 16/Jan/23 17:23
Start Date: 16/Jan/23 17:23
Worklog Time Spent: 10m
Work Description: difin commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1071406567
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
This is added as a fix to many failed CI tests that happened without this
fix.
These new classes are classes from Orc project prior to changes to
StringDictionaryTreeReader that were done as part of ORC-1060.
In more detail: Hive implements its own TreeReaderFactory. In ORC project,
the ticket ORC-1060 - "Reduce memory usage when vectorized reading dictionary
string encoding columns" introduced changes to StringDictionaryTreeReader which
were causing exceptions in Hive EncodedTreeReaderFactory when attempting to
upgrade to ORC 1.8.1. To handle that I added changes to Hive's
EncodedTreeReaderFactory to use StringDictionaryTreeReader version from Orc
project prior to changes from ORC-1060.
Issue Time Tracking
---
Worklog Id: (was: 839455)
Time Spent: 4.5h (was: 4h 20m)
> Upgrade ORC to 1.8.1
>
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Dmitriy Fingerman
>Assignee: Dmitriy Fingerman
>Priority: Major
> Labels: pull-request-available
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=839454=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839454
]
ASF GitHub Bot logged work on HIVE-26809:
-
Author: ASF GitHub Bot
Created on: 16/Jan/23 17:20
Start Date: 16/Jan/23 17:20
Worklog Time Spent: 10m
Work Description: difin commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1071406567
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
This is added as a fix to many failed CI tests that happened without this
fix.
In more detail: Hive implements its own TreeReaderFactory. In ORC project,
the ticket ORC-1060 - "Reduce memory usage when vectorized reading dictionary
string encoding columns" introduced changes to StringDictionaryTreeReader which
were causing exceptions in Hive EncodedTreeReaderFactory when attempting to
upgrade to ORC 1.8.1. To handle that I added changes to Hive's
EncodedTreeReaderFactory to use StringDictionaryTreeReader version from Orc
project prior to changes from ORC-1060.
Issue Time Tracking
---
Worklog Id: (was: 839454)
Time Spent: 4h 20m (was: 4h 10m)
> Upgrade ORC to 1.8.1
>
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Dmitriy Fingerman
>Assignee: Dmitriy Fingerman
>Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[ https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=839453=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839453 ] ASF GitHub Bot logged work on HIVE-26809: - Author: ASF GitHub Bot Created on: 16/Jan/23 17:18 Start Date: 16/Jan/23 17:18 Worklog Time Spent: 10m Work Description: difin commented on code in PR #3833: URL: https://github.com/apache/hive/pull/3833#discussion_r1071459244 ## llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java: ## @@ -61,7 +61,7 @@ import org.apache.orc.impl.TreeReaderFactory.TreeReader; import org.apache.orc.impl.WriterImpl; import org.apache.orc.OrcProto; - +import org.apache.orc.impl.reader.tree.TypeReader; Review Comment: fixed Issue Time Tracking --- Worklog Id: (was: 839453) Time Spent: 4h 10m (was: 4h) > Upgrade ORC to 1.8.1 > > > Key: HIVE-26809 > URL: https://issues.apache.org/jira/browse/HIVE-26809 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0 >Reporter: Dmitriy Fingerman >Assignee: Dmitriy Fingerman >Priority: Major > Labels: pull-request-available > Time Spent: 4h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=839452=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839452
]
ASF GitHub Bot logged work on HIVE-26809:
-
Author: ASF GitHub Bot
Created on: 16/Jan/23 17:18
Start Date: 16/Jan/23 17:18
Worklog Time Spent: 10m
Work Description: difin commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1071458846
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -1249,10 +1534,13 @@ public void seek(PositionProvider index) throws
IOException {
}
@Override
-public void nextVector(
- ColumnVector previousVector, boolean[] isNull, int batchSize) throws
IOException {
+public void nextVector(ColumnVector previousVector,
+boolean[] isNull,
+final int batchSize,
+FilterContext filterContext,
+ReadPhase readPhase) throws IOException {
Review Comment:
fixed formatting
Issue Time Tracking
---
Worklog Id: (was: 839452)
Time Spent: 4h (was: 3h 50m)
> Upgrade ORC to 1.8.1
>
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Dmitriy Fingerman
>Assignee: Dmitriy Fingerman
>Priority: Major
> Labels: pull-request-available
> Time Spent: 4h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=839446=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839446
]
ASF GitHub Bot logged work on HIVE-26809:
-
Author: ASF GitHub Bot
Created on: 16/Jan/23 16:15
Start Date: 16/Jan/23 16:15
Worklog Time Spent: 10m
Work Description: difin commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1071406567
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
This is added as a fix to many failed CI tests that happened without this
fix.
Hive implements its own TreeReaderFactory. In ORC project, ORC-1060 -
"Reduce memory usage when vectorized reading dictionary string encoding
columns" introduced changes to StringDictionaryTreeReader which were causing
exceptions in Hive EncodedTreeReaderFactory when attempting to upgrade to ORC
1.8.1. To handle that I added changes to Hive's EncodedTreeReaderFactory to use
StringDictionaryTreeReader version as without ORC-1060.
Issue Time Tracking
---
Worklog Id: (was: 839446)
Time Spent: 3h 40m (was: 3.5h)
> Upgrade ORC to 1.8.1
>
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Dmitriy Fingerman
>Assignee: Dmitriy Fingerman
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=839447=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839447
]
ASF GitHub Bot logged work on HIVE-26809:
-
Author: ASF GitHub Bot
Created on: 16/Jan/23 16:15
Start Date: 16/Jan/23 16:15
Worklog Time Spent: 10m
Work Description: difin commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1071406567
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
This is added as a fix to many failed CI tests that happened without this
fix.
In more detail: Hive implements its own TreeReaderFactory. In ORC project,
ORC-1060 - "Reduce memory usage when vectorized reading dictionary string
encoding columns" introduced changes to StringDictionaryTreeReader which were
causing exceptions in Hive EncodedTreeReaderFactory when attempting to upgrade
to ORC 1.8.1. To handle that I added changes to Hive's EncodedTreeReaderFactory
to use StringDictionaryTreeReader version as without ORC-1060.
Issue Time Tracking
---
Worklog Id: (was: 839447)
Time Spent: 3h 50m (was: 3h 40m)
> Upgrade ORC to 1.8.1
>
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Dmitriy Fingerman
>Assignee: Dmitriy Fingerman
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[
https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=838987=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-838987
]
ASF GitHub Bot logged work on HIVE-26809:
-
Author: ASF GitHub Bot
Created on: 13/Jan/23 01:35
Start Date: 13/Jan/23 01:35
Worklog Time Spent: 10m
Work Description: ayushtkn commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1040356751
##
llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java:
##
@@ -61,7 +61,7 @@
import org.apache.orc.impl.TreeReaderFactory.TreeReader;
import org.apache.orc.impl.WriterImpl;
import org.apache.orc.OrcProto;
-
+import org.apache.orc.impl.reader.tree.TypeReader;
Review Comment:
import order is wrong. Imports should be alphabetically sorted
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -1249,10 +1534,13 @@ public void seek(PositionProvider index) throws
IOException {
}
@Override
-public void nextVector(
- ColumnVector previousVector, boolean[] isNull, int batchSize) throws
IOException {
+public void nextVector(ColumnVector previousVector,
+boolean[] isNull,
+final int batchSize,
+FilterContext filterContext,
+ReadPhase readPhase) throws IOException {
Review Comment:
this code doesn't look formatted
##
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
Why is this added in scope of upgrade?
Issue Time Tracking
---
Worklog Id: (was: 838987)
Time Spent: 3.5h (was: 3h 20m)
> Upgrade ORC to 1.8.1
>
>
> Key: HIVE-26809
> URL: https://issues.apache.org/jira/browse/HIVE-26809
> Project: Hive
> Issue Type: Improvement
>Affects Versions: 4.0.0
>Reporter: Dmitriy Fingerman
>Assignee: Dmitriy Fingerman
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[ https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=838925=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-838925 ] ASF GitHub Bot logged work on HIVE-26809: - Author: ASF GitHub Bot Created on: 12/Jan/23 18:35 Start Date: 12/Jan/23 18:35 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #3833: URL: https://github.com/apache/hive/pull/3833#issuecomment-1380845468 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive=3833) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3833=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3833=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3833=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_hive=3833=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_hive=3833=duplicated_lines_density=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 838925) Time Spent: 3h 20m (was: 3h 10m) > Upgrade ORC to 1.8.1 > > > Key: HIVE-26809 > URL: https://issues.apache.org/jira/browse/HIVE-26809 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0 >Reporter: Dmitriy Fingerman >Assignee: Dmitriy Fingerman >Priority: Major > Labels: pull-request-available > Time Spent: 3h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[ https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=837356=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-837356 ] ASF GitHub Bot logged work on HIVE-26809: - Author: ASF GitHub Bot Created on: 05/Jan/23 22:42 Start Date: 05/Jan/23 22:42 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #3833: URL: https://github.com/apache/hive/pull/3833#issuecomment-1372885398 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive=3833) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3833=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3833=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3833=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_hive=3833=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_hive=3833=duplicated_lines_density=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 837356) Time Spent: 3h 10m (was: 3h) > Upgrade ORC to 1.8.1 > > > Key: HIVE-26809 > URL: https://issues.apache.org/jira/browse/HIVE-26809 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0 >Reporter: Dmitriy Fingerman >Assignee: Dmitriy Fingerman >Priority: Major > Labels: pull-request-available > Time Spent: 3h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[ https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=837293=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-837293 ] ASF GitHub Bot logged work on HIVE-26809: - Author: ASF GitHub Bot Created on: 05/Jan/23 17:44 Start Date: 05/Jan/23 17:44 Worklog Time Spent: 10m Work Description: sonarcloud[bot] commented on PR #3833: URL: https://github.com/apache/hive/pull/3833#issuecomment-1372533729 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive=3833) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3833=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3833=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive=3833=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=CODE_SMELL) [10 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive=3833=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_hive=3833=coverage=list) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_hive=3833=duplicated_lines_density=list) No Duplication information Issue Time Tracking --- Worklog Id: (was: 837293) Time Spent: 3h (was: 2h 50m) > Upgrade ORC to 1.8.1 > > > Key: HIVE-26809 > URL: https://issues.apache.org/jira/browse/HIVE-26809 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0 >Reporter: Dmitriy Fingerman >Assignee: Dmitriy Fingerman >Priority: Major > Labels: pull-request-available > Time Spent: 3h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Work logged] (HIVE-26809) Upgrade ORC to 1.8.1
[ https://issues.apache.org/jira/browse/HIVE-26809?focusedWorklogId=836635=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-836635 ] ASF GitHub Bot logged work on HIVE-26809: - Author: ASF GitHub Bot Created on: 03/Jan/23 15:05 Start Date: 03/Jan/23 15:05 Worklog Time Spent: 10m Work Description: difin commented on PR #3833: URL: https://github.com/apache/hive/pull/3833#issuecomment-1369873941 Hi @abstractdog, can you please review? Issue Time Tracking --- Worklog Id: (was: 836635) Time Spent: 2h 50m (was: 2h 40m) > Upgrade ORC to 1.8.1 > > > Key: HIVE-26809 > URL: https://issues.apache.org/jira/browse/HIVE-26809 > Project: Hive > Issue Type: Improvement >Affects Versions: 4.0.0 >Reporter: Dmitriy Fingerman >Assignee: Dmitriy Fingerman >Priority: Major > Labels: pull-request-available > Time Spent: 2h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
