[jira] [Updated] (HIVE-20350) Unnecessary value assignment
[
https://issues.apache.org/jira/browse/HIVE-20350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laszlo Pinter updated HIVE-20350:
-
Status: Patch Available (was: Open)
> Unnecessary value assignment
>
>
> Key: HIVE-20350
> URL: https://issues.apache.org/jira/browse/HIVE-20350
> Project: Hive
> Issue Type: Improvement
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Minor
> Attachments: HIVE-20350.patch
>
>
> There is an unnecessary value assignment in Hive.java
> {code:java}
> newPartPath = oldPartPath == null ? newPartPath = genPartPathFromTable(tbl,
> partSpec,
> tblDataLocationPath) : oldPartPath;{code}
> This can be changed to
> {code:java}
> newPartPath = oldPartPath == null ? genPartPathFromTable(tbl, partSpec,
> tblDataLocationPath) : oldPartPath;{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HIVE-20350) Unnecessary value assignment
[
https://issues.apache.org/jira/browse/HIVE-20350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574993#comment-16574993
]
Laszlo Pinter commented on HIVE-20350:
--
[~sershe] could you please review?
> Unnecessary value assignment
>
>
> Key: HIVE-20350
> URL: https://issues.apache.org/jira/browse/HIVE-20350
> Project: Hive
> Issue Type: Improvement
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Minor
> Attachments: HIVE-20350.patch
>
>
> There is an unnecessary value assignment in Hive.java
> {code:java}
> newPartPath = oldPartPath == null ? newPartPath = genPartPathFromTable(tbl,
> partSpec,
> tblDataLocationPath) : oldPartPath;{code}
> This can be changed to
> {code:java}
> newPartPath = oldPartPath == null ? genPartPathFromTable(tbl, partSpec,
> tblDataLocationPath) : oldPartPath;{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (HIVE-20350) Unnecessary value assignment
[
https://issues.apache.org/jira/browse/HIVE-20350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laszlo Pinter reassigned HIVE-20350:
> Unnecessary value assignment
>
>
> Key: HIVE-20350
> URL: https://issues.apache.org/jira/browse/HIVE-20350
> Project: Hive
> Issue Type: Improvement
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Minor
>
> There is an unnecessary value assignment in Hive.java
> {code:java}
> newPartPath = oldPartPath == null ? newPartPath = genPartPathFromTable(tbl,
> partSpec,
> tblDataLocationPath) : oldPartPath;{code}
> This can be changed to
> {code:java}
> newPartPath = oldPartPath == null ? genPartPathFromTable(tbl, partSpec,
> tblDataLocationPath) : oldPartPath;{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HIVE-20350) Unnecessary value assignment
[
https://issues.apache.org/jira/browse/HIVE-20350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laszlo Pinter updated HIVE-20350:
-
Attachment: HIVE-20350.patch
> Unnecessary value assignment
>
>
> Key: HIVE-20350
> URL: https://issues.apache.org/jira/browse/HIVE-20350
> Project: Hive
> Issue Type: Improvement
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Minor
> Attachments: HIVE-20350.patch
>
>
> There is an unnecessary value assignment in Hive.java
> {code:java}
> newPartPath = oldPartPath == null ? newPartPath = genPartPathFromTable(tbl,
> partSpec,
> tblDataLocationPath) : oldPartPath;{code}
> This can be changed to
> {code:java}
> newPartPath = oldPartPath == null ? genPartPathFromTable(tbl, partSpec,
> tblDataLocationPath) : oldPartPath;{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter reassigned HIVE-20396: > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16582116#comment-16582116 ] Laszlo Pinter commented on HIVE-20396: -- [~jcamachorodriguez] Since you introduces this feature, which I'm trying to test now, could you please review? Thanks. > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20396.patch > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20396: - Attachment: HIVE-20396.patch > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20396.patch > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20396: - Status: Patch Available (was: Open) > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20396.patch > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20396: - Attachment: HIVE-20396.01.patch > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20396.patch > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20396: - Attachment: (was: HIVE-20396.01.patch) > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20396.patch > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20396: - Attachment: HIVE-20396.01.patch > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20396.01.patch, HIVE-20396.patch > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20396: - Attachment: HIVE-20396.02.patch > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20396.01.patch, HIVE-20396.02.patch, > HIVE-20396.patch > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20396: - Status: Patch Available (was: In Progress) > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20396.01.patch, HIVE-20396.02.patch, > HIVE-20396.patch > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20396: - Status: In Progress (was: Patch Available) > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20396.01.patch, HIVE-20396.02.patch, > HIVE-20396.patch > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20350) Unnecessary value assignment
[
https://issues.apache.org/jira/browse/HIVE-20350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laszlo Pinter updated HIVE-20350:
-
Attachment: HIVE-20350.01.patch
> Unnecessary value assignment
>
>
> Key: HIVE-20350
> URL: https://issues.apache.org/jira/browse/HIVE-20350
> Project: Hive
> Issue Type: Improvement
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Minor
> Attachments: HIVE-20350.01.patch, HIVE-20350.patch
>
>
> There is an unnecessary value assignment in Hive.java
> {code:java}
> newPartPath = oldPartPath == null ? newPartPath = genPartPathFromTable(tbl,
> partSpec,
> tblDataLocationPath) : oldPartPath;{code}
> This can be changed to
> {code:java}
> newPartPath = oldPartPath == null ? genPartPathFromTable(tbl, partSpec,
> tblDataLocationPath) : oldPartPath;{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HIVE-20374) Write Hive version information to Parquet footer
[ https://issues.apache.org/jira/browse/HIVE-20374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20374: - Fix Version/s: 4.0.0 Status: Patch Available (was: Open) > Write Hive version information to Parquet footer > > > Key: HIVE-20374 > URL: https://issues.apache.org/jira/browse/HIVE-20374 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Ivanfi >Assignee: Laszlo Pinter >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-20374.patch > > > PARQUET-352 added support for the "writer.model.name" property in the Parquet > metadata to identify the object model (application) that wrote the file. > The easiest way to write this property is by overriding getName() of > org.apache.parquet.hadoop.api.WriteSupport. In Hive, this would mean adding > getName() to the > org.apache.hadoop.hive.ql.io.parquet.write.DataWritableWriteSupport class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20374) Write Hive version information to Parquet footer
[ https://issues.apache.org/jira/browse/HIVE-20374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20374: - Attachment: HIVE-20374.patch > Write Hive version information to Parquet footer > > > Key: HIVE-20374 > URL: https://issues.apache.org/jira/browse/HIVE-20374 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Ivanfi >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20374.patch > > > PARQUET-352 added support for the "writer.model.name" property in the Parquet > metadata to identify the object model (application) that wrote the file. > The easiest way to write this property is by overriding getName() of > org.apache.parquet.hadoop.api.WriteSupport. In Hive, this would mean adding > getName() to the > org.apache.hadoop.hive.ql.io.parquet.write.DataWritableWriteSupport class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20396: - Attachment: HIVE-20396.03.patch > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20396.01.patch, HIVE-20396.02.patch, > HIVE-20396.03.patch, HIVE-20396.patch > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20396: - Attachment: HIVE-20396.04.patch > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20396.01.patch, HIVE-20396.02.patch, > HIVE-20396.03.patch, HIVE-20396.04.patch, HIVE-20396.patch > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20374) Write Hive version information to Parquet footer
[ https://issues.apache.org/jira/browse/HIVE-20374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20374: - Attachment: HIVE-20374.02.patch > Write Hive version information to Parquet footer > > > Key: HIVE-20374 > URL: https://issues.apache.org/jira/browse/HIVE-20374 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Ivanfi >Assignee: Laszlo Pinter >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-20374.01.patch, HIVE-20374.02.patch, > HIVE-20374.patch > > > PARQUET-352 added support for the "writer.model.name" property in the Parquet > metadata to identify the object model (application) that wrote the file. > The easiest way to write this property is by overriding getName() of > org.apache.parquet.hadoop.api.WriteSupport. In Hive, this would mean adding > getName() to the > org.apache.hadoop.hive.ql.io.parquet.write.DataWritableWriteSupport class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20396: - Attachment: HIVE-20396.05.patch > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20396.01.patch, HIVE-20396.02.patch, > HIVE-20396.03.patch, HIVE-20396.04.patch, HIVE-20396.05.patch, > HIVE-20396.patch > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590647#comment-16590647 ] Laszlo Pinter commented on HIVE-20396: -- [~pvary] [~szehon] Please review. Thanks. > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20396.01.patch, HIVE-20396.02.patch, > HIVE-20396.03.patch, HIVE-20396.04.patch, HIVE-20396.05.patch, > HIVE-20396.06.patch, HIVE-20396.07.patch, HIVE-20396.patch > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20374) Write Hive version information to Parquet footer
[ https://issues.apache.org/jira/browse/HIVE-20374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590772#comment-16590772 ] Laszlo Pinter commented on HIVE-20374: -- [~kuczoram] Please review. Thanks. > Write Hive version information to Parquet footer > > > Key: HIVE-20374 > URL: https://issues.apache.org/jira/browse/HIVE-20374 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Ivanfi >Assignee: Laszlo Pinter >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-20374.01.patch, HIVE-20374.02.patch, > HIVE-20374.03.patch, HIVE-20374.04.patch, HIVE-20374.patch > > > PARQUET-352 added support for the "writer.model.name" property in the Parquet > metadata to identify the object model (application) that wrote the file. > The easiest way to write this property is by overriding getName() of > org.apache.parquet.hadoop.api.WriteSupport. In Hive, this would mean adding > getName() to the > org.apache.hadoop.hive.ql.io.parquet.write.DataWritableWriteSupport class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20374) Write Hive version information to Parquet footer
[ https://issues.apache.org/jira/browse/HIVE-20374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20374: - Resolution: Resolved Status: Resolved (was: Patch Available) > Write Hive version information to Parquet footer > > > Key: HIVE-20374 > URL: https://issues.apache.org/jira/browse/HIVE-20374 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Ivanfi >Assignee: Laszlo Pinter >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-20374.01.patch, HIVE-20374.02.patch, > HIVE-20374.03.patch, HIVE-20374.04.patch, HIVE-20374.patch > > > PARQUET-352 added support for the "writer.model.name" property in the Parquet > metadata to identify the object model (application) that wrote the file. > The easiest way to write this property is by overriding getName() of > org.apache.parquet.hadoop.api.WriteSupport. In Hive, this would mean adding > getName() to the > org.apache.hadoop.hive.ql.io.parquet.write.DataWritableWriteSupport class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20396: - Attachment: HIVE-20396.06.patch > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20396.01.patch, HIVE-20396.02.patch, > HIVE-20396.03.patch, HIVE-20396.04.patch, HIVE-20396.05.patch, > HIVE-20396.06.patch, HIVE-20396.patch > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20374) Write Hive version information to Parquet footer
[ https://issues.apache.org/jira/browse/HIVE-20374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20374: - Attachment: HIVE-20374.04.patch > Write Hive version information to Parquet footer > > > Key: HIVE-20374 > URL: https://issues.apache.org/jira/browse/HIVE-20374 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Ivanfi >Assignee: Laszlo Pinter >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-20374.01.patch, HIVE-20374.02.patch, > HIVE-20374.03.patch, HIVE-20374.04.patch, HIVE-20374.patch > > > PARQUET-352 added support for the "writer.model.name" property in the Parquet > metadata to identify the object model (application) that wrote the file. > The easiest way to write this property is by overriding getName() of > org.apache.parquet.hadoop.api.WriteSupport. In Hive, this would mean adding > getName() to the > org.apache.hadoop.hive.ql.io.parquet.write.DataWritableWriteSupport class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20396) Test HS2 open_connection metrics
[ https://issues.apache.org/jira/browse/HIVE-20396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20396: - Attachment: HIVE-20396.07.patch > Test HS2 open_connection metrics > > > Key: HIVE-20396 > URL: https://issues.apache.org/jira/browse/HIVE-20396 > Project: Hive > Issue Type: Test > Components: HiveServer2 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20396.01.patch, HIVE-20396.02.patch, > HIVE-20396.03.patch, HIVE-20396.04.patch, HIVE-20396.05.patch, > HIVE-20396.06.patch, HIVE-20396.07.patch, HIVE-20396.patch > > > HiveServer2 is emitting metrics _default.General.open_connections_ in both > binary and http mode. These metrics should be tested. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20374) Write Hive version information to Parquet footer
[ https://issues.apache.org/jira/browse/HIVE-20374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20374: - Attachment: HIVE-20374.03.patch > Write Hive version information to Parquet footer > > > Key: HIVE-20374 > URL: https://issues.apache.org/jira/browse/HIVE-20374 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Ivanfi >Assignee: Laszlo Pinter >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-20374.01.patch, HIVE-20374.02.patch, > HIVE-20374.03.patch, HIVE-20374.patch > > > PARQUET-352 added support for the "writer.model.name" property in the Parquet > metadata to identify the object model (application) that wrote the file. > The easiest way to write this property is by overriding getName() of > org.apache.parquet.hadoop.api.WriteSupport. In Hive, this would mean adding > getName() to the > org.apache.hadoop.hive.ql.io.parquet.write.DataWritableWriteSupport class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20374) Write Hive version information to Parquet footer
[ https://issues.apache.org/jira/browse/HIVE-20374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20374: - Attachment: HIVE-20374.01.patch > Write Hive version information to Parquet footer > > > Key: HIVE-20374 > URL: https://issues.apache.org/jira/browse/HIVE-20374 > Project: Hive > Issue Type: Improvement >Reporter: Zoltan Ivanfi >Assignee: Laszlo Pinter >Priority: Major > Fix For: 4.0.0 > > Attachments: HIVE-20374.01.patch, HIVE-20374.patch > > > PARQUET-352 added support for the "writer.model.name" property in the Parquet > metadata to identify the object model (application) that wrote the file. > The easiest way to write this property is by overriding getName() of > org.apache.parquet.hadoop.api.WriteSupport. In Hive, this would mean adding > getName() to the > org.apache.hadoop.hive.ql.io.parquet.write.DataWritableWriteSupport class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20505) upgrade org.openjdk.jmh:jmh-core to 1.21
[ https://issues.apache.org/jira/browse/HIVE-20505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20505: - Status: Patch Available (was: Open) > upgrade org.openjdk.jmh:jmh-core to 1.21 > > > Key: HIVE-20505 > URL: https://issues.apache.org/jira/browse/HIVE-20505 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Critical > Fix For: 4.0.0 > > Attachments: HIVE-20505.patch > > > This ticket tracks the following CVE(s) that were found in the direct > dependency *org.openjdk.jmh:jmh-core:1.19*: > [CVE-2009-1896|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-1896], > [CVE-2009-2689|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-2689], > [CVE-2009-3879|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3879], > [CVE-2009-0733|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-0733], > [CVE-2009-2475|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-2475], > [CVE-2009-3883|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3883], > [CVE-2009-2476|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-2476], > [CVE-2009-3884|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3884], > [CVE-2013-0169|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2013-0169], > [CVE-2012-5373|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2012-5373], > [CVE-2009-3880|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3880], > [CVE-2009-3881|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3881], > [CVE-2009-3882|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3882], > [CVE-2009-0581|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-0581], > [CVE-2009-2690|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-2690], > [CVE-2012-2739|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2012-2739], > [CVE-2009-0723|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-0723], > [CVE-2009-3728|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3728] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HIVE-20505) upgrade org.openjdk.jmh:jmh-core to 1.21
[ https://issues.apache.org/jira/browse/HIVE-20505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter reassigned HIVE-20505: > upgrade org.openjdk.jmh:jmh-core to 1.21 > > > Key: HIVE-20505 > URL: https://issues.apache.org/jira/browse/HIVE-20505 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Critical > Fix For: 4.0.0 > > > This ticket tracks the following CVE(s) that were found in the direct > dependency *org.openjdk.jmh:jmh-core:1.19*: > [CVE-2009-1896|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-1896], > [CVE-2009-2689|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-2689], > [CVE-2009-3879|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3879], > [CVE-2009-0733|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-0733], > [CVE-2009-2475|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-2475], > [CVE-2009-3883|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3883], > [CVE-2009-2476|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-2476], > [CVE-2009-3884|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3884], > [CVE-2013-0169|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2013-0169], > [CVE-2012-5373|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2012-5373], > [CVE-2009-3880|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3880], > [CVE-2009-3881|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3881], > [CVE-2009-3882|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3882], > [CVE-2009-0581|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-0581], > [CVE-2009-2690|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-2690], > [CVE-2012-2739|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2012-2739], > [CVE-2009-0723|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-0723], > [CVE-2009-3728|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3728] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20505) upgrade org.openjdk.jmh:jmh-core to 1.21
[ https://issues.apache.org/jira/browse/HIVE-20505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20505: - Attachment: HIVE-20505.01.patch > upgrade org.openjdk.jmh:jmh-core to 1.21 > > > Key: HIVE-20505 > URL: https://issues.apache.org/jira/browse/HIVE-20505 > Project: Hive > Issue Type: Bug > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Critical > Fix For: 4.0.0 > > Attachments: HIVE-20505.01.patch, HIVE-20505.patch > > > This ticket tracks the following CVE(s) that were found in the direct > dependency *org.openjdk.jmh:jmh-core:1.19*: > [CVE-2009-1896|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-1896], > [CVE-2009-2689|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-2689], > [CVE-2009-3879|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3879], > [CVE-2009-0733|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-0733], > [CVE-2009-2475|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-2475], > [CVE-2009-3883|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3883], > [CVE-2009-2476|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-2476], > [CVE-2009-3884|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3884], > [CVE-2013-0169|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2013-0169], > [CVE-2012-5373|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2012-5373], > [CVE-2009-3880|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3880], > [CVE-2009-3881|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3881], > [CVE-2009-3882|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3882], > [CVE-2009-0581|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-0581], > [CVE-2009-2690|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-2690], > [CVE-2012-2739|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2012-2739], > [CVE-2009-0723|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-0723], > [CVE-2009-3728|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2009-3728] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20420) Provide a fallback authorizer when no other authorizer is in use
[ https://issues.apache.org/jira/browse/HIVE-20420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604211#comment-16604211 ] Laszlo Pinter commented on HIVE-20420: -- [~daijy] Could you please open a review request for this change? I would have a couple of remarks. Thanks > Provide a fallback authorizer when no other authorizer is in use > > > Key: HIVE-20420 > URL: https://issues.apache.org/jira/browse/HIVE-20420 > Project: Hive > Issue Type: New Feature >Reporter: Daniel Dai >Assignee: Daniel Dai >Priority: Major > Attachments: HIVE-20420.1.patch, HIVE-20420.2.patch, > HIVE-20420.3.patch, HIVE-20420.4.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20661) Dynamic partitions loading calls add partition for every partition 1-by-1
[ https://issues.apache.org/jira/browse/HIVE-20661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20661: - Attachment: HIVE-20661.06.patch > Dynamic partitions loading calls add partition for every partition 1-by-1 > - > > Key: HIVE-20661 > URL: https://issues.apache.org/jira/browse/HIVE-20661 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20661.01.patch, HIVE-20661.02.patch, > HIVE-20661.03.patch, HIVE-20661.04.patch, HIVE-20661.05.patch, > HIVE-20661.06.patch > > > Hive.loadDynamicPartitions creates partitions using a threadpool, but the > update of the Metastore via the MetastoreClient is done 1-by-1. This adds > unnecessary extra calls. The partitions should be created in one batch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20661) Dynamic partitions loading calls add partition for every partition 1-by-1
[ https://issues.apache.org/jira/browse/HIVE-20661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20661: - Attachment: HIVE-20661.07.patch > Dynamic partitions loading calls add partition for every partition 1-by-1 > - > > Key: HIVE-20661 > URL: https://issues.apache.org/jira/browse/HIVE-20661 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20661.01.patch, HIVE-20661.02.patch, > HIVE-20661.03.patch, HIVE-20661.04.patch, HIVE-20661.05.patch, > HIVE-20661.06.patch, HIVE-20661.07.patch > > > Hive.loadDynamicPartitions creates partitions using a threadpool, but the > update of the Metastore via the MetastoreClient is done 1-by-1. This adds > unnecessary extra calls. The partitions should be created in one batch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20661) Dynamic partitions loading calls add partition for every partition 1-by-1
[ https://issues.apache.org/jira/browse/HIVE-20661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20661: - Attachment: HIVE-20661.11.patch > Dynamic partitions loading calls add partition for every partition 1-by-1 > - > > Key: HIVE-20661 > URL: https://issues.apache.org/jira/browse/HIVE-20661 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20661.01.patch, HIVE-20661.02.patch, > HIVE-20661.03.patch, HIVE-20661.04.patch, HIVE-20661.05.patch, > HIVE-20661.06.patch, HIVE-20661.07.patch, HIVE-20661.08.patch, > HIVE-20661.09.patch, HIVE-20661.10.patch, HIVE-20661.11.patch > > > Hive.loadDynamicPartitions creates partitions using a threadpool, but the > update of the Metastore via the MetastoreClient is done 1-by-1. This adds > unnecessary extra calls. The partitions should be created in one batch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20661) Dynamic partitions loading calls add partition for every partition 1-by-1
[ https://issues.apache.org/jira/browse/HIVE-20661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20661: - Attachment: HIVE-20661.10.patch > Dynamic partitions loading calls add partition for every partition 1-by-1 > - > > Key: HIVE-20661 > URL: https://issues.apache.org/jira/browse/HIVE-20661 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20661.01.patch, HIVE-20661.02.patch, > HIVE-20661.03.patch, HIVE-20661.04.patch, HIVE-20661.05.patch, > HIVE-20661.06.patch, HIVE-20661.07.patch, HIVE-20661.08.patch, > HIVE-20661.09.patch, HIVE-20661.10.patch > > > Hive.loadDynamicPartitions creates partitions using a threadpool, but the > update of the Metastore via the MetastoreClient is done 1-by-1. This adds > unnecessary extra calls. The partitions should be created in one batch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20661) Dynamic partitions loading calls add partition for every partition 1-by-1
[ https://issues.apache.org/jira/browse/HIVE-20661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20661: - Attachment: HIVE-20661.09.patch > Dynamic partitions loading calls add partition for every partition 1-by-1 > - > > Key: HIVE-20661 > URL: https://issues.apache.org/jira/browse/HIVE-20661 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20661.01.patch, HIVE-20661.02.patch, > HIVE-20661.03.patch, HIVE-20661.04.patch, HIVE-20661.05.patch, > HIVE-20661.06.patch, HIVE-20661.07.patch, HIVE-20661.08.patch, > HIVE-20661.09.patch > > > Hive.loadDynamicPartitions creates partitions using a threadpool, but the > update of the Metastore via the MetastoreClient is done 1-by-1. This adds > unnecessary extra calls. The partitions should be created in one batch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20661) Dynamic partitions loading calls add partition for every partition 1-by-1
[ https://issues.apache.org/jira/browse/HIVE-20661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20661: - Attachment: HIVE-20661.08.patch > Dynamic partitions loading calls add partition for every partition 1-by-1 > - > > Key: HIVE-20661 > URL: https://issues.apache.org/jira/browse/HIVE-20661 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20661.01.patch, HIVE-20661.02.patch, > HIVE-20661.03.patch, HIVE-20661.04.patch, HIVE-20661.05.patch, > HIVE-20661.06.patch, HIVE-20661.07.patch, HIVE-20661.08.patch > > > Hive.loadDynamicPartitions creates partitions using a threadpool, but the > update of the Metastore via the MetastoreClient is done 1-by-1. This adds > unnecessary extra calls. The partitions should be created in one batch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HIVE-20796) jdbc URL can contain sensitive information that should not be logged
[ https://issues.apache.org/jira/browse/HIVE-20796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter reassigned HIVE-20796: > jdbc URL can contain sensitive information that should not be logged > > > Key: HIVE-20796 > URL: https://issues.apache.org/jira/browse/HIVE-20796 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > > It is possible to put passwords in the jdbc connection url and some jdbc > drivers will supposedly use that. (derby, mysql). This information is > considered sensitive, and should be masked out, while logging the connection > url. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20796) jdbc URL can contain sensitive information that should not be logged
[
https://issues.apache.org/jira/browse/HIVE-20796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662329#comment-16662329
]
Laszlo Pinter commented on HIVE-20796:
--
Indeed is similar, but I was thinking of different scenario. In the
hive-site.xml you can provide the connection url and the credentials as
different entries
{code:xml}
javax.jdo.option.ConnectionURL
jdbc:derby:memory:${test.tmp.dir}/junit_metastore_db;create=true
javax.jdo.option.ConnectionUserName
username
javax.jdo.option.ConnectionPassword
password
{code}
But it is possible to specify the credentials as part of the connection url
{code:xml}
javax.jdo.option.ConnectionURL
jdbc:derby:memory:${test.tmp.dir}/junit_metastore_db;create=true;username=username;password=password
{code}
While overriding the default configuration values from jpox.properties, the old
and new entries are logged out (ObjectStore#getDataSourceProps())
{code:java}
if (MetastoreConf.isPrintable(varName)) {
LOG.debug("Overriding {} value {} from jpox.properties with {}",
varName, prevVal, confVal);
}
{code}
Since the jdbc url is not marked as unprintable, all of it contents will be
written to debug log.
> jdbc URL can contain sensitive information that should not be logged
>
>
> Key: HIVE-20796
> URL: https://issues.apache.org/jira/browse/HIVE-20796
> Project: Hive
> Issue Type: Improvement
> Components: Hive
>Affects Versions: 4.0.0
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
>
> It is possible to put passwords in the jdbc connection url and some jdbc
> drivers will supposedly use that. (derby, mysql). This information is
> considered sensitive, and should be masked out, while logging the connection
> url.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (HIVE-20796) jdbc URL can contain sensitive information that should not be logged
[
https://issues.apache.org/jira/browse/HIVE-20796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662329#comment-16662329
]
Laszlo Pinter edited comment on HIVE-20796 at 10/24/18 2:12 PM:
Indeed, it is similar, but I was thinking of different scenario. In the
hive-site.xml you can provide the connection url and the credentials as
different entries
{code:xml}
javax.jdo.option.ConnectionURL
jdbc:derby:memory:${test.tmp.dir}/junit_metastore_db;create=true
javax.jdo.option.ConnectionUserName
username
javax.jdo.option.ConnectionPassword
password
{code}
But it is possible to specify the credentials as part of the connection url
{code:xml}
javax.jdo.option.ConnectionURL
jdbc:derby:memory:${test.tmp.dir}/junit_metastore_db;create=true;username=username;password=password
{code}
While overriding the default configuration values from jpox.properties, the old
and new entries are logged out (ObjectStore#getDataSourceProps())
{code:java}
if (MetastoreConf.isPrintable(varName)) {
LOG.debug("Overriding {} value {} from jpox.properties with {}",
varName, prevVal, confVal);
}
{code}
Since the jdbc url is not marked as unprintable, all of it contents will be
written to debug log.
was (Author: lpinter):
Indeed is similar, but I was thinking of different scenario. In the
hive-site.xml you can provide the connection url and the credentials as
different entries
{code:xml}
javax.jdo.option.ConnectionURL
jdbc:derby:memory:${test.tmp.dir}/junit_metastore_db;create=true
javax.jdo.option.ConnectionUserName
username
javax.jdo.option.ConnectionPassword
password
{code}
But it is possible to specify the credentials as part of the connection url
{code:xml}
javax.jdo.option.ConnectionURL
jdbc:derby:memory:${test.tmp.dir}/junit_metastore_db;create=true;username=username;password=password
{code}
While overriding the default configuration values from jpox.properties, the old
and new entries are logged out (ObjectStore#getDataSourceProps())
{code:java}
if (MetastoreConf.isPrintable(varName)) {
LOG.debug("Overriding {} value {} from jpox.properties with {}",
varName, prevVal, confVal);
}
{code}
Since the jdbc url is not marked as unprintable, all of it contents will be
written to debug log.
> jdbc URL can contain sensitive information that should not be logged
>
>
> Key: HIVE-20796
> URL: https://issues.apache.org/jira/browse/HIVE-20796
> Project: Hive
> Issue Type: Improvement
> Components: Hive
>Affects Versions: 4.0.0
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
>
> It is possible to put passwords in the jdbc connection url and some jdbc
> drivers will supposedly use that. (derby, mysql). This information is
> considered sensitive, and should be masked out, while logging the connection
> url.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HIVE-20796) jdbc URL can contain sensitive information that should not be logged
[ https://issues.apache.org/jira/browse/HIVE-20796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20796: - Attachment: HIVE-20796.03.patch > jdbc URL can contain sensitive information that should not be logged > > > Key: HIVE-20796 > URL: https://issues.apache.org/jira/browse/HIVE-20796 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20796.01.patch, HIVE-20796.02.patch, > HIVE-20796.03.patch > > > It is possible to put passwords in the jdbc connection url and some jdbc > drivers will supposedly use that. (derby, mysql). This information is > considered sensitive, and should be masked out, while logging the connection > url. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20796) jdbc URL can contain sensitive information that should not be logged
[ https://issues.apache.org/jira/browse/HIVE-20796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20796: - Attachment: HIVE-20796.02.patch > jdbc URL can contain sensitive information that should not be logged > > > Key: HIVE-20796 > URL: https://issues.apache.org/jira/browse/HIVE-20796 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20796.01.patch, HIVE-20796.02.patch > > > It is possible to put passwords in the jdbc connection url and some jdbc > drivers will supposedly use that. (derby, mysql). This information is > considered sensitive, and should be masked out, while logging the connection > url. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20796) jdbc URL can contain sensitive information that should not be logged
[ https://issues.apache.org/jira/browse/HIVE-20796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663631#comment-16663631 ] Laszlo Pinter commented on HIVE-20796: -- [~pvary] We were thinking the same :). Is it ok if I put this method to the MetaStoreServerUtils class? > jdbc URL can contain sensitive information that should not be logged > > > Key: HIVE-20796 > URL: https://issues.apache.org/jira/browse/HIVE-20796 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20796.01.patch > > > It is possible to put passwords in the jdbc connection url and some jdbc > drivers will supposedly use that. (derby, mysql). This information is > considered sensitive, and should be masked out, while logging the connection > url. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20796) jdbc URL can contain sensitive information that should not be logged
[ https://issues.apache.org/jira/browse/HIVE-20796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20796: - Attachment: HIVE-20796.04.patch > jdbc URL can contain sensitive information that should not be logged > > > Key: HIVE-20796 > URL: https://issues.apache.org/jira/browse/HIVE-20796 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20796.01.patch, HIVE-20796.02.patch, > HIVE-20796.03.patch, HIVE-20796.04.patch > > > It is possible to put passwords in the jdbc connection url and some jdbc > drivers will supposedly use that. (derby, mysql). This information is > considered sensitive, and should be masked out, while logging the connection > url. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20796) jdbc URL can contain sensitive information that should not be logged
[ https://issues.apache.org/jira/browse/HIVE-20796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20796: - Attachment: HIVE-20796.05.patch > jdbc URL can contain sensitive information that should not be logged > > > Key: HIVE-20796 > URL: https://issues.apache.org/jira/browse/HIVE-20796 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20796.01.patch, HIVE-20796.02.patch, > HIVE-20796.03.patch, HIVE-20796.04.patch, HIVE-20796.05.patch > > > It is possible to put passwords in the jdbc connection url and some jdbc > drivers will supposedly use that. (derby, mysql). This information is > considered sensitive, and should be masked out, while logging the connection > url. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20661) Dynamic partitions loading calls add partition for every partition 1-by-1
[ https://issues.apache.org/jira/browse/HIVE-20661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20661: - Attachment: HIVE-20661.12.patch > Dynamic partitions loading calls add partition for every partition 1-by-1 > - > > Key: HIVE-20661 > URL: https://issues.apache.org/jira/browse/HIVE-20661 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20661.01.patch, HIVE-20661.02.patch, > HIVE-20661.03.patch, HIVE-20661.04.patch, HIVE-20661.05.patch, > HIVE-20661.06.patch, HIVE-20661.07.patch, HIVE-20661.08.patch, > HIVE-20661.09.patch, HIVE-20661.10.patch, HIVE-20661.11.patch, > HIVE-20661.12.patch > > > Hive.loadDynamicPartitions creates partitions using a threadpool, but the > update of the Metastore via the MetastoreClient is done 1-by-1. This adds > unnecessary extra calls. The partitions should be created in one batch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20796) jdbc URL can contain sensitive information that should not be logged
[ https://issues.apache.org/jira/browse/HIVE-20796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20796: - Attachment: HIVE-20796.01.patch > jdbc URL can contain sensitive information that should not be logged > > > Key: HIVE-20796 > URL: https://issues.apache.org/jira/browse/HIVE-20796 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20796.01.patch > > > It is possible to put passwords in the jdbc connection url and some jdbc > drivers will supposedly use that. (derby, mysql). This information is > considered sensitive, and should be masked out, while logging the connection > url. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20796) jdbc URL can contain sensitive information that should not be logged
[ https://issues.apache.org/jira/browse/HIVE-20796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20796: - Status: Patch Available (was: Open) > jdbc URL can contain sensitive information that should not be logged > > > Key: HIVE-20796 > URL: https://issues.apache.org/jira/browse/HIVE-20796 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20796.01.patch > > > It is possible to put passwords in the jdbc connection url and some jdbc > drivers will supposedly use that. (derby, mysql). This information is > considered sensitive, and should be masked out, while logging the connection > url. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20891) Call alter_partition in batch when dynamically loading partitions
[ https://issues.apache.org/jira/browse/HIVE-20891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20891: - Status: Patch Available (was: Open) > Call alter_partition in batch when dynamically loading partitions > - > > Key: HIVE-20891 > URL: https://issues.apache.org/jira/browse/HIVE-20891 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20891.01.patch > > > When dynamically loading partitions, the setStatsPropAndAlterPartition() is > called for each partition one by one, resulting in unnecessary calls to the > metastore client. This whole logic can be changed to just one call. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HIVE-20891) Call alter_partition in batch when dynamically loading partitions
[ https://issues.apache.org/jira/browse/HIVE-20891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter reassigned HIVE-20891: > Call alter_partition in batch when dynamically loading partitions > - > > Key: HIVE-20891 > URL: https://issues.apache.org/jira/browse/HIVE-20891 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > > When dynamically loading partitions, the setStatsPropAndAlterPartition() is > called for each partition one by one, resulting in unnecessary calls to the > metastore client. This whole logic can be changed to just one call. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20891) Call alter_partition in batch when dynamically loading partitions
[ https://issues.apache.org/jira/browse/HIVE-20891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20891: - Attachment: HIVE-20891.01.patch > Call alter_partition in batch when dynamically loading partitions > - > > Key: HIVE-20891 > URL: https://issues.apache.org/jira/browse/HIVE-20891 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20891.01.patch > > > When dynamically loading partitions, the setStatsPropAndAlterPartition() is > called for each partition one by one, resulting in unnecessary calls to the > metastore client. This whole logic can be changed to just one call. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20891) Call alter_partition in batch when dynamically loading partitions
[ https://issues.apache.org/jira/browse/HIVE-20891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20891: - Attachment: HIVE-20891.02.patch > Call alter_partition in batch when dynamically loading partitions > - > > Key: HIVE-20891 > URL: https://issues.apache.org/jira/browse/HIVE-20891 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20891.01.patch, HIVE-20891.02.patch > > > When dynamically loading partitions, the setStatsPropAndAlterPartition() is > called for each partition one by one, resulting in unnecessary calls to the > metastore client. This whole logic can be changed to just one call. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20891) Call alter_partition in batch when dynamically loading partitions
[ https://issues.apache.org/jira/browse/HIVE-20891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20891: - Attachment: HIVE-20891.03.patch > Call alter_partition in batch when dynamically loading partitions > - > > Key: HIVE-20891 > URL: https://issues.apache.org/jira/browse/HIVE-20891 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20891.01.patch, HIVE-20891.02.patch, > HIVE-20891.03.patch > > > When dynamically loading partitions, the setStatsPropAndAlterPartition() is > called for each partition one by one, resulting in unnecessary calls to the > metastore client. This whole logic can be changed to just one call. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20661) Dynamic partitions loading calls add partition for every partition 1-by-1
[ https://issues.apache.org/jira/browse/HIVE-20661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20661: - Attachment: HIVE-20661.04.patch > Dynamic partitions loading calls add partition for every partition 1-by-1 > - > > Key: HIVE-20661 > URL: https://issues.apache.org/jira/browse/HIVE-20661 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20661.01.patch, HIVE-20661.02.patch, > HIVE-20661.03.patch, HIVE-20661.04.patch > > > Hive.loadDynamicPartitions creates partitions using a threadpool, but the > update of the Metastore via the MetastoreClient is done 1-by-1. This adds > unnecessary extra calls. The partitions should be created in one batch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20575) Fix flaky connection metric tests
[ https://issues.apache.org/jira/browse/HIVE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20575: - Attachment: HIVE-20575.11.patch > Fix flaky connection metric tests > - > > Key: HIVE-20575 > URL: https://issues.apache.org/jira/browse/HIVE-20575 > Project: Hive > Issue Type: Test > Components: Hive, Test >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20575.01.patch, HIVE-20575.02.patch, > HIVE-20575.03.patch, HIVE-20575.04.patch, HIVE-20575.05.patch, > HIVE-20575.06.patch, HIVE-20575.07.patch, HIVE-20575.08.patch, > HIVE-20575.09.patch, HIVE-20575.10.patch, HIVE-20575.11.patch > > > TestHs2ConnectionMetricsHttp.testOpenConnectionMetrics() is flaky. We need to > fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20575) Fix flaky connection metric tests
[ https://issues.apache.org/jira/browse/HIVE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20575: - Attachment: HIVE-20575.09.patch > Fix flaky connection metric tests > - > > Key: HIVE-20575 > URL: https://issues.apache.org/jira/browse/HIVE-20575 > Project: Hive > Issue Type: Test > Components: Hive, Test >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20575.01.patch, HIVE-20575.02.patch, > HIVE-20575.03.patch, HIVE-20575.04.patch, HIVE-20575.05.patch, > HIVE-20575.06.patch, HIVE-20575.07.patch, HIVE-20575.08.patch, > HIVE-20575.09.patch > > > TestHs2ConnectionMetricsHttp.testOpenConnectionMetrics() is flaky. We need to > fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20661) Dynamic partitions loading calls add partition for every partition 1-by-1
[ https://issues.apache.org/jira/browse/HIVE-20661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20661: - Attachment: HIVE-20661.05.patch > Dynamic partitions loading calls add partition for every partition 1-by-1 > - > > Key: HIVE-20661 > URL: https://issues.apache.org/jira/browse/HIVE-20661 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20661.01.patch, HIVE-20661.02.patch, > HIVE-20661.03.patch, HIVE-20661.04.patch, HIVE-20661.05.patch > > > Hive.loadDynamicPartitions creates partitions using a threadpool, but the > update of the Metastore via the MetastoreClient is done 1-by-1. This adds > unnecessary extra calls. The partitions should be created in one batch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HIVE-20661) Dynamic partitions loading calls add partition for every partition 1-by-1
[ https://issues.apache.org/jira/browse/HIVE-20661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter reassigned HIVE-20661: > Dynamic partitions loading calls add partition for every partition 1-by-1 > - > > Key: HIVE-20661 > URL: https://issues.apache.org/jira/browse/HIVE-20661 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > > Hive.loadDynamicPartitions creates partitions using a threadpool, but the > update of the Metastore via the MetastoreClient is done 1-by-1. This adds > unnecessary extra calls. The partitions should be created in one batch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20661) Dynamic partitions loading calls add partition for every partition 1-by-1
[ https://issues.apache.org/jira/browse/HIVE-20661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20661: - Attachment: HIVE-20661.01.patch > Dynamic partitions loading calls add partition for every partition 1-by-1 > - > > Key: HIVE-20661 > URL: https://issues.apache.org/jira/browse/HIVE-20661 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20661.01.patch > > > Hive.loadDynamicPartitions creates partitions using a threadpool, but the > update of the Metastore via the MetastoreClient is done 1-by-1. This adds > unnecessary extra calls. The partitions should be created in one batch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20661) Dynamic partitions loading calls add partition for every partition 1-by-1
[ https://issues.apache.org/jira/browse/HIVE-20661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20661: - Status: Patch Available (was: Open) > Dynamic partitions loading calls add partition for every partition 1-by-1 > - > > Key: HIVE-20661 > URL: https://issues.apache.org/jira/browse/HIVE-20661 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20661.01.patch > > > Hive.loadDynamicPartitions creates partitions using a threadpool, but the > update of the Metastore via the MetastoreClient is done 1-by-1. This adds > unnecessary extra calls. The partitions should be created in one batch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20661) Dynamic partitions loading calls add partition for every partition 1-by-1
[ https://issues.apache.org/jira/browse/HIVE-20661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20661: - Attachment: HIVE-20661.02.patch > Dynamic partitions loading calls add partition for every partition 1-by-1 > - > > Key: HIVE-20661 > URL: https://issues.apache.org/jira/browse/HIVE-20661 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20661.01.patch, HIVE-20661.02.patch > > > Hive.loadDynamicPartitions creates partitions using a threadpool, but the > update of the Metastore via the MetastoreClient is done 1-by-1. This adds > unnecessary extra calls. The partitions should be created in one batch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20661) Dynamic partitions loading calls add partition for every partition 1-by-1
[ https://issues.apache.org/jira/browse/HIVE-20661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20661: - Attachment: HIVE-20661.03.patch > Dynamic partitions loading calls add partition for every partition 1-by-1 > - > > Key: HIVE-20661 > URL: https://issues.apache.org/jira/browse/HIVE-20661 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20661.01.patch, HIVE-20661.02.patch, > HIVE-20661.03.patch > > > Hive.loadDynamicPartitions creates partitions using a threadpool, but the > update of the Metastore via the MetastoreClient is done 1-by-1. This adds > unnecessary extra calls. The partitions should be created in one batch. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20575) Fix flaky connection metric tests
[ https://issues.apache.org/jira/browse/HIVE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20575: - Attachment: HIVE-20575.10.patch > Fix flaky connection metric tests > - > > Key: HIVE-20575 > URL: https://issues.apache.org/jira/browse/HIVE-20575 > Project: Hive > Issue Type: Test > Components: Hive, Test >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20575.01.patch, HIVE-20575.02.patch, > HIVE-20575.03.patch, HIVE-20575.04.patch, HIVE-20575.05.patch, > HIVE-20575.06.patch, HIVE-20575.07.patch, HIVE-20575.08.patch, > HIVE-20575.09.patch, HIVE-20575.10.patch > > > TestHs2ConnectionMetricsHttp.testOpenConnectionMetrics() is flaky. We need to > fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20575) Fix flaky connection metric tests
[ https://issues.apache.org/jira/browse/HIVE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20575: - Attachment: HIVE-20575.07.patch > Fix flaky connection metric tests > - > > Key: HIVE-20575 > URL: https://issues.apache.org/jira/browse/HIVE-20575 > Project: Hive > Issue Type: Test > Components: Hive, Test >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20575.01.patch, HIVE-20575.02.patch, > HIVE-20575.03.patch, HIVE-20575.04.patch, HIVE-20575.05.patch, > HIVE-20575.06.patch, HIVE-20575.07.patch > > > TestHs2ConnectionMetricsHttp.testOpenConnectionMetrics() is flaky. We need to > fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20595) Add findbugs-exclude.xml to metastore-server
[ https://issues.apache.org/jira/browse/HIVE-20595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20595: - Attachment: HIVE-20595.02.patch > Add findbugs-exclude.xml to metastore-server > > > Key: HIVE-20595 > URL: https://issues.apache.org/jira/browse/HIVE-20595 > Project: Hive > Issue Type: Bug > Components: Hive, Standalone Metastore >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Blocker > Attachments: HIVE-20595.01.patch, HIVE-20595.02.patch > > > The findbugs-exclude.xml is missing from > standalone-metastore/metastore-server/findbugs. This should be added, > otherwise the findbugs check will fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20595) Add findbugs-exclude.xml to metastore-server
[ https://issues.apache.org/jira/browse/HIVE-20595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20595: - Status: Patch Available (was: Open) > Add findbugs-exclude.xml to metastore-server > > > Key: HIVE-20595 > URL: https://issues.apache.org/jira/browse/HIVE-20595 > Project: Hive > Issue Type: Bug > Components: Hive, Standalone Metastore >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Blocker > Attachments: HIVE-20595.01.patch > > > The findbugs-exclude.xml is missing from > standalone-metastore/metastore-server/findbugs. This should be added, > otherwise the findbugs check will fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[ https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20551: - Attachment: HIVE-20551.06.patch > Create PreparedStatement query dynamically when IN clause is used > - > > Key: HIVE-20551 > URL: https://issues.apache.org/jira/browse/HIVE-20551 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch, > HIVE-20551.03.patch, HIVE-20551.04.patch, HIVE-20551.05.patch, > HIVE-20551.06.patch > > > In the MetaStoreDirectSql class when IN clause is used, the query statement > is created via string concatenation. > Since JDBC API allows only one literal for one “?” parameter, > PreparedStatement doesn’t work for IN clause queries. To create the > PreparedStatement query dynamically based on the size of the elements in IN > clause, the makeParams() should be used instead of concatenation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20575) Fix flaky connection metric tests
[ https://issues.apache.org/jira/browse/HIVE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20575: - Attachment: HIVE-20575.08.patch > Fix flaky connection metric tests > - > > Key: HIVE-20575 > URL: https://issues.apache.org/jira/browse/HIVE-20575 > Project: Hive > Issue Type: Test > Components: Hive, Test >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20575.01.patch, HIVE-20575.02.patch, > HIVE-20575.03.patch, HIVE-20575.04.patch, HIVE-20575.05.patch, > HIVE-20575.06.patch, HIVE-20575.07.patch, HIVE-20575.08.patch > > > TestHs2ConnectionMetricsHttp.testOpenConnectionMetrics() is flaky. We need to > fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[ https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20551: - Attachment: HIVE-20551.07.patch > Create PreparedStatement query dynamically when IN clause is used > - > > Key: HIVE-20551 > URL: https://issues.apache.org/jira/browse/HIVE-20551 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch, > HIVE-20551.03.patch, HIVE-20551.04.patch, HIVE-20551.05.patch, > HIVE-20551.06.patch, HIVE-20551.07.patch > > > In the MetaStoreDirectSql class when IN clause is used, the query statement > is created via string concatenation. > Since JDBC API allows only one literal for one “?” parameter, > PreparedStatement doesn’t work for IN clause queries. To create the > PreparedStatement query dynamically based on the size of the elements in IN > clause, the makeParams() should be used instead of concatenation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20595) Add findbugs-exclude.xml to metastore-server
[ https://issues.apache.org/jira/browse/HIVE-20595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626924#comment-16626924 ] Laszlo Pinter commented on HIVE-20595: -- [~afan] Why did you took over this Jira from me? Is there something left to be done here? Thanks > Add findbugs-exclude.xml to metastore-server > > > Key: HIVE-20595 > URL: https://issues.apache.org/jira/browse/HIVE-20595 > Project: Hive > Issue Type: Bug > Components: Hive, Standalone Metastore >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Alice Fan >Priority: Blocker > Attachments: HIVE-20595.01.patch, HIVE-20595.02.patch > > > The findbugs-exclude.xml is missing from > standalone-metastore/metastore-server/findbugs. This should be added, > otherwise the findbugs check will fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20595) Add findbugs-exclude.xml to metastore-server
[ https://issues.apache.org/jira/browse/HIVE-20595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20595: - Attachment: HIVE-20595.03.patch > Add findbugs-exclude.xml to metastore-server > > > Key: HIVE-20595 > URL: https://issues.apache.org/jira/browse/HIVE-20595 > Project: Hive > Issue Type: Bug > Components: Hive, Standalone Metastore >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Blocker > Attachments: HIVE-20595.01.patch, HIVE-20595.02.patch, > HIVE-20595.03.patch > > > The findbugs-exclude.xml is missing from > standalone-metastore/metastore-server/findbugs. This should be added, > otherwise the findbugs check will fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20575) Fix flaky connection metric tests
[ https://issues.apache.org/jira/browse/HIVE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20575: - Attachment: HIVE-20575.05.patch > Fix flaky connection metric tests > - > > Key: HIVE-20575 > URL: https://issues.apache.org/jira/browse/HIVE-20575 > Project: Hive > Issue Type: Test > Components: Hive, Test >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20575.01.patch, HIVE-20575.02.patch, > HIVE-20575.03.patch, HIVE-20575.04.patch, HIVE-20575.05.patch > > > TestHs2ConnectionMetricsHttp.testOpenConnectionMetrics() is flaky. We need to > fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20575) Fix flaky connection metric tests
[ https://issues.apache.org/jira/browse/HIVE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20575: - Attachment: HIVE-20575.06.patch > Fix flaky connection metric tests > - > > Key: HIVE-20575 > URL: https://issues.apache.org/jira/browse/HIVE-20575 > Project: Hive > Issue Type: Test > Components: Hive, Test >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20575.01.patch, HIVE-20575.02.patch, > HIVE-20575.03.patch, HIVE-20575.04.patch, HIVE-20575.05.patch, > HIVE-20575.06.patch > > > TestHs2ConnectionMetricsHttp.testOpenConnectionMetrics() is flaky. We need to > fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20891) Call alter_partition in batch when dynamically loading partitions
[ https://issues.apache.org/jira/browse/HIVE-20891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20891: - Attachment: HIVE-20891.06.patch > Call alter_partition in batch when dynamically loading partitions > - > > Key: HIVE-20891 > URL: https://issues.apache.org/jira/browse/HIVE-20891 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20891.01.patch, HIVE-20891.02.patch, > HIVE-20891.03.patch, HIVE-20891.04.patch, HIVE-20891.05.patch, > HIVE-20891.06.patch > > > When dynamically loading partitions, the setStatsPropAndAlterPartition() is > called for each partition one by one, resulting in unnecessary calls to the > metastore client. This whole logic can be changed to just one call. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20891) Call alter_partition in batch when dynamically loading partitions
[ https://issues.apache.org/jira/browse/HIVE-20891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20891: - Attachment: HIVE-20891.07.patch > Call alter_partition in batch when dynamically loading partitions > - > > Key: HIVE-20891 > URL: https://issues.apache.org/jira/browse/HIVE-20891 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20891.01.patch, HIVE-20891.02.patch, > HIVE-20891.03.patch, HIVE-20891.04.patch, HIVE-20891.05.patch, > HIVE-20891.06.patch, HIVE-20891.07.patch > > > When dynamically loading partitions, the setStatsPropAndAlterPartition() is > called for each partition one by one, resulting in unnecessary calls to the > metastore client. This whole logic can be changed to just one call. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20891) Call alter_partition in batch when dynamically loading partitions
[ https://issues.apache.org/jira/browse/HIVE-20891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20891: - Attachment: HIVE-20891.04.patch > Call alter_partition in batch when dynamically loading partitions > - > > Key: HIVE-20891 > URL: https://issues.apache.org/jira/browse/HIVE-20891 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20891.01.patch, HIVE-20891.02.patch, > HIVE-20891.03.patch, HIVE-20891.04.patch > > > When dynamically loading partitions, the setStatsPropAndAlterPartition() is > called for each partition one by one, resulting in unnecessary calls to the > metastore client. This whole logic can be changed to just one call. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20891) Call alter_partition in batch when dynamically loading partitions
[ https://issues.apache.org/jira/browse/HIVE-20891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20891: - Attachment: HIVE-20891.05.patch > Call alter_partition in batch when dynamically loading partitions > - > > Key: HIVE-20891 > URL: https://issues.apache.org/jira/browse/HIVE-20891 > Project: Hive > Issue Type: Improvement > Components: Hive >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20891.01.patch, HIVE-20891.02.patch, > HIVE-20891.03.patch, HIVE-20891.04.patch, HIVE-20891.05.patch > > > When dynamically loading partitions, the setStatsPropAndAlterPartition() is > called for each partition one by one, resulting in unnecessary calls to the > metastore client. This whole logic can be changed to just one call. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-21086) Fetch task and MR job give back different results when multiple partitions point to the same location
[
https://issues.apache.org/jira/browse/HIVE-21086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laszlo Pinter updated HIVE-21086:
-
Attachment: HIVE-21086.03.patch
> Fetch task and MR job give back different results when multiple partitions
> point to the same location
> -
>
> Key: HIVE-21086
> URL: https://issues.apache.org/jira/browse/HIVE-21086
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Affects Versions: 4.0.0
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-21086.01.patch, HIVE-21086.02.patch,
> HIVE-21086.03.patch
>
>
> Create a table with 2 partitions where both partitions share the same
> location and inserting a single line to one of them.
> {code:sql}
> create table test (i int) partitioned by (j int);
> alter table test add partition (j=1);
> alter table test add partition (j=2) location '<>';
> insert into table test partition (j=1) values (1);{code}
> Make sure *hive.fetch.task.conversion=more*.
> {code:sql}
> set hive.fetch.task.conversion=more;{code}
> The result of a simple select * test:
> +---+---+
> |test.i |test.j |
> +---+---+
> |1 |1 |
> |1 |2 |
> +---+---+
> Change the *hive.fetch.task.conversion=none;*
> {code:sql}
> set hive.fetch.task.conversion=none;
> {code}
> The result of a simple select * test:
> +---+---+
> |test.i |test.j |
> +---+---+
> |1 |2 |
> +---+---+
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (HIVE-21086) Fetch task and MR job give back different results when multiple partitions point to the same location
[
https://issues.apache.org/jira/browse/HIVE-21086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laszlo Pinter reassigned HIVE-21086:
> Fetch task and MR job give back different results when multiple partitions
> point to the same location
> -
>
> Key: HIVE-21086
> URL: https://issues.apache.org/jira/browse/HIVE-21086
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Affects Versions: 4.0.0
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Fix For: 4.0.0
>
>
> Create a table with 2 partitions where both partitions share the same
> location and inserting a single line to one of them.
> {code:sql}
> create table test (i int) partitioned by (j int);
> alter table test add partition (j=1);
> alter table test add partition (j=2) location '<>';
> insert into table test partition (j=1) values (1);{code}
> Make sure *hive.fetch.task.conversion=more*.
> {code:sql}
> set hive.fetch.task.conversion=more;{code}
> The result of a simple select * test:
> +---+---+
> |test.i |test.j |
> +---+---+
> |1 |1 |
> |1 |2 |
> +---+---+
> Change the *hive.fetch.task.conversion=none;*
> {code:sql}
> set hive.fetch.task.conversion=none;
> {code}
> The result of a simple select * test:
> +---+---+
> |test.i |test.j |
> +---+---+
> |1 |2 |
> +---+---+
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HIVE-21086) Fetch task and MR job give back different results when multiple partitions point to the same location
[
https://issues.apache.org/jira/browse/HIVE-21086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laszlo Pinter updated HIVE-21086:
-
Attachment: HIVE-21086.02.patch
> Fetch task and MR job give back different results when multiple partitions
> point to the same location
> -
>
> Key: HIVE-21086
> URL: https://issues.apache.org/jira/browse/HIVE-21086
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Affects Versions: 4.0.0
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-21086.01.patch, HIVE-21086.02.patch
>
>
> Create a table with 2 partitions where both partitions share the same
> location and inserting a single line to one of them.
> {code:sql}
> create table test (i int) partitioned by (j int);
> alter table test add partition (j=1);
> alter table test add partition (j=2) location '<>';
> insert into table test partition (j=1) values (1);{code}
> Make sure *hive.fetch.task.conversion=more*.
> {code:sql}
> set hive.fetch.task.conversion=more;{code}
> The result of a simple select * test:
> +---+---+
> |test.i |test.j |
> +---+---+
> |1 |1 |
> |1 |2 |
> +---+---+
> Change the *hive.fetch.task.conversion=none;*
> {code:sql}
> set hive.fetch.task.conversion=none;
> {code}
> The result of a simple select * test:
> +---+---+
> |test.i |test.j |
> +---+---+
> |1 |2 |
> +---+---+
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HIVE-21086) Fetch task and MR job give back different results when multiple partitions point to the same location
[
https://issues.apache.org/jira/browse/HIVE-21086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laszlo Pinter updated HIVE-21086:
-
Status: Patch Available (was: Open)
> Fetch task and MR job give back different results when multiple partitions
> point to the same location
> -
>
> Key: HIVE-21086
> URL: https://issues.apache.org/jira/browse/HIVE-21086
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Affects Versions: 4.0.0
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-21086.01.patch
>
>
> Create a table with 2 partitions where both partitions share the same
> location and inserting a single line to one of them.
> {code:sql}
> create table test (i int) partitioned by (j int);
> alter table test add partition (j=1);
> alter table test add partition (j=2) location '<>';
> insert into table test partition (j=1) values (1);{code}
> Make sure *hive.fetch.task.conversion=more*.
> {code:sql}
> set hive.fetch.task.conversion=more;{code}
> The result of a simple select * test:
> +---+---+
> |test.i |test.j |
> +---+---+
> |1 |1 |
> |1 |2 |
> +---+---+
> Change the *hive.fetch.task.conversion=none;*
> {code:sql}
> set hive.fetch.task.conversion=none;
> {code}
> The result of a simple select * test:
> +---+---+
> |test.i |test.j |
> +---+---+
> |1 |2 |
> +---+---+
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HIVE-21086) Fetch task and MR job give back different results when multiple partitions point to the same location
[
https://issues.apache.org/jira/browse/HIVE-21086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Laszlo Pinter updated HIVE-21086:
-
Attachment: HIVE-21086.01.patch
> Fetch task and MR job give back different results when multiple partitions
> point to the same location
> -
>
> Key: HIVE-21086
> URL: https://issues.apache.org/jira/browse/HIVE-21086
> Project: Hive
> Issue Type: Bug
> Components: Hive
>Affects Versions: 4.0.0
>Reporter: Laszlo Pinter
>Assignee: Laszlo Pinter
>Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-21086.01.patch
>
>
> Create a table with 2 partitions where both partitions share the same
> location and inserting a single line to one of them.
> {code:sql}
> create table test (i int) partitioned by (j int);
> alter table test add partition (j=1);
> alter table test add partition (j=2) location '<>';
> insert into table test partition (j=1) values (1);{code}
> Make sure *hive.fetch.task.conversion=more*.
> {code:sql}
> set hive.fetch.task.conversion=more;{code}
> The result of a simple select * test:
> +---+---+
> |test.i |test.j |
> +---+---+
> |1 |1 |
> |1 |2 |
> +---+---+
> Change the *hive.fetch.task.conversion=none;*
> {code:sql}
> set hive.fetch.task.conversion=none;
> {code}
> The result of a simple select * test:
> +---+---+
> |test.i |test.j |
> +---+---+
> |1 |2 |
> +---+---+
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[ https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter reassigned HIVE-20551: > Create PreparedStatement query dynamically when IN clause is used > - > > Key: HIVE-20551 > URL: https://issues.apache.org/jira/browse/HIVE-20551 > Project: Hive > Issue Type: Bug >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > > In the MetaStoreDirectSql class when IN clause is used, the query statement > is created via string concatenation, meaning that an attacker could change > the statement meaning or insert arbitrary SQL commands. > Since JDBC API allows only one literal for one “?” parameter, > PreparedStatement doesn’t work for IN clause queries. To create the > PreparedStatement query dynamically based on the size of the elements in IN > clause, the makeParams() should be used instead of concatenation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[ https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20551: - Description: In the MetaStoreDirectSql class when IN clause is used, the query statement is created via string concatenation. Since JDBC API allows only one literal for one “?” parameter, PreparedStatement doesn’t work for IN clause queries. To create the PreparedStatement query dynamically based on the size of the elements in IN clause, the makeParams() should be used instead of concatenation. was: In the MetaStoreDirectSql class when IN clause is used, the query statement is created via string concatenation, meaning that an attacker could change the statement meaning or insert arbitrary SQL commands. Since JDBC API allows only one literal for one “?” parameter, PreparedStatement doesn’t work for IN clause queries. To create the PreparedStatement query dynamically based on the size of the elements in IN clause, the makeParams() should be used instead of concatenation. > Create PreparedStatement query dynamically when IN clause is used > - > > Key: HIVE-20551 > URL: https://issues.apache.org/jira/browse/HIVE-20551 > Project: Hive > Issue Type: Bug >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > > In the MetaStoreDirectSql class when IN clause is used, the query statement > is created via string concatenation. > Since JDBC API allows only one literal for one “?” parameter, > PreparedStatement doesn’t work for IN clause queries. To create the > PreparedStatement query dynamically based on the size of the elements in IN > clause, the makeParams() should be used instead of concatenation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[ https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20551: - Status: Patch Available (was: Open) > Create PreparedStatement query dynamically when IN clause is used > - > > Key: HIVE-20551 > URL: https://issues.apache.org/jira/browse/HIVE-20551 > Project: Hive > Issue Type: Bug >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20551.01.patch > > > In the MetaStoreDirectSql class when IN clause is used, the query statement > is created via string concatenation. > Since JDBC API allows only one literal for one “?” parameter, > PreparedStatement doesn’t work for IN clause queries. To create the > PreparedStatement query dynamically based on the size of the elements in IN > clause, the makeParams() should be used instead of concatenation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[ https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20551: - Attachment: HIVE-20551.01.patch > Create PreparedStatement query dynamically when IN clause is used > - > > Key: HIVE-20551 > URL: https://issues.apache.org/jira/browse/HIVE-20551 > Project: Hive > Issue Type: Bug >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20551.01.patch > > > In the MetaStoreDirectSql class when IN clause is used, the query statement > is created via string concatenation. > Since JDBC API allows only one literal for one “?” parameter, > PreparedStatement doesn’t work for IN clause queries. To create the > PreparedStatement query dynamically based on the size of the elements in IN > clause, the makeParams() should be used instead of concatenation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[ https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20551: - Attachment: HIVE-20551.03.patch > Create PreparedStatement query dynamically when IN clause is used > - > > Key: HIVE-20551 > URL: https://issues.apache.org/jira/browse/HIVE-20551 > Project: Hive > Issue Type: Bug >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch, > HIVE-20551.03.patch > > > In the MetaStoreDirectSql class when IN clause is used, the query statement > is created via string concatenation. > Since JDBC API allows only one literal for one “?” parameter, > PreparedStatement doesn’t work for IN clause queries. To create the > PreparedStatement query dynamically based on the size of the elements in IN > clause, the makeParams() should be used instead of concatenation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[ https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20551: - Attachment: HIVE-20551.02.patch > Create PreparedStatement query dynamically when IN clause is used > - > > Key: HIVE-20551 > URL: https://issues.apache.org/jira/browse/HIVE-20551 > Project: Hive > Issue Type: Bug >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch > > > In the MetaStoreDirectSql class when IN clause is used, the query statement > is created via string concatenation. > Since JDBC API allows only one literal for one “?” parameter, > PreparedStatement doesn’t work for IN clause queries. To create the > PreparedStatement query dynamically based on the size of the elements in IN > clause, the makeParams() should be used instead of concatenation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[ https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20551: - Attachment: HIVE-20551.05.patch > Create PreparedStatement query dynamically when IN clause is used > - > > Key: HIVE-20551 > URL: https://issues.apache.org/jira/browse/HIVE-20551 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch, > HIVE-20551.03.patch, HIVE-20551.04.patch, HIVE-20551.05.patch > > > In the MetaStoreDirectSql class when IN clause is used, the query statement > is created via string concatenation. > Since JDBC API allows only one literal for one “?” parameter, > PreparedStatement doesn’t work for IN clause queries. To create the > PreparedStatement query dynamically based on the size of the elements in IN > clause, the makeParams() should be used instead of concatenation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20575) Fix flaky connection metric tests
[ https://issues.apache.org/jira/browse/HIVE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20575: - Attachment: HIVE-20575.03.patch > Fix flaky connection metric tests > - > > Key: HIVE-20575 > URL: https://issues.apache.org/jira/browse/HIVE-20575 > Project: Hive > Issue Type: Test > Components: Hive, Test >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20575.01.patch, HIVE-20575.02.patch, > HIVE-20575.03.patch > > > TestHs2ConnectionMetricsHttp.testOpenConnectionMetrics() is flaky. We need to > fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20575) Fix flaky connection metric tests
[ https://issues.apache.org/jira/browse/HIVE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20575: - Attachment: HIVE-20575.02.patch > Fix flaky connection metric tests > - > > Key: HIVE-20575 > URL: https://issues.apache.org/jira/browse/HIVE-20575 > Project: Hive > Issue Type: Test > Components: Hive, Test >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20575.01.patch, HIVE-20575.02.patch > > > TestHs2ConnectionMetricsHttp.testOpenConnectionMetrics() is flaky. We need to > fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HIVE-20595) Add findbugs-exclude.xml to metastore-server
[ https://issues.apache.org/jira/browse/HIVE-20595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter reassigned HIVE-20595: > Add findbugs-exclude.xml to metastore-server > > > Key: HIVE-20595 > URL: https://issues.apache.org/jira/browse/HIVE-20595 > Project: Hive > Issue Type: Bug > Components: Hive, Standalone Metastore >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Blocker > > The findbugs-exclude.xml is missing from > standalone-metastore/metastore-server/findbugs. This should be added, > otherwise the findbugs check will fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20595) Add findbugs-exclude.xml to metastore-server
[ https://issues.apache.org/jira/browse/HIVE-20595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20595: - Attachment: HIVE-20595.01.patch > Add findbugs-exclude.xml to metastore-server > > > Key: HIVE-20595 > URL: https://issues.apache.org/jira/browse/HIVE-20595 > Project: Hive > Issue Type: Bug > Components: Hive, Standalone Metastore >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Blocker > Attachments: HIVE-20595.01.patch > > > The findbugs-exclude.xml is missing from > standalone-metastore/metastore-server/findbugs. This should be added, > otherwise the findbugs check will fail. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
***UNCHECKED*** [jira] [Updated] (HIVE-20575) Fix flaky connection metric tests
[ https://issues.apache.org/jira/browse/HIVE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20575: - Attachment: HIVE-20575.04.patch > Fix flaky connection metric tests > - > > Key: HIVE-20575 > URL: https://issues.apache.org/jira/browse/HIVE-20575 > Project: Hive > Issue Type: Test > Components: Hive, Test >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20575.01.patch, HIVE-20575.02.patch, > HIVE-20575.03.patch, HIVE-20575.04.patch > > > TestHs2ConnectionMetricsHttp.testOpenConnectionMetrics() is flaky. We need to > fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[ https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20551: - Component/s: Hive > Create PreparedStatement query dynamically when IN clause is used > - > > Key: HIVE-20551 > URL: https://issues.apache.org/jira/browse/HIVE-20551 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch, > HIVE-20551.03.patch > > > In the MetaStoreDirectSql class when IN clause is used, the query statement > is created via string concatenation. > Since JDBC API allows only one literal for one “?” parameter, > PreparedStatement doesn’t work for IN clause queries. To create the > PreparedStatement query dynamically based on the size of the elements in IN > clause, the makeParams() should be used instead of concatenation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (HIVE-20575) Fix flaky connection metric tests
[ https://issues.apache.org/jira/browse/HIVE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter reassigned HIVE-20575: > Fix flaky connection metric tests > - > > Key: HIVE-20575 > URL: https://issues.apache.org/jira/browse/HIVE-20575 > Project: Hive > Issue Type: Test > Components: Hive, Test >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > > TestHs2ConnectionMetricsHttp.testOpenConnectionMetrics() is flaky. We need to > fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20551) Create PreparedStatement query dynamically when IN clause is used
[ https://issues.apache.org/jira/browse/HIVE-20551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20551: - Attachment: HIVE-20551.04.patch > Create PreparedStatement query dynamically when IN clause is used > - > > Key: HIVE-20551 > URL: https://issues.apache.org/jira/browse/HIVE-20551 > Project: Hive > Issue Type: Bug > Components: Hive >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Major > Attachments: HIVE-20551.01.patch, HIVE-20551.02.patch, > HIVE-20551.03.patch, HIVE-20551.04.patch > > > In the MetaStoreDirectSql class when IN clause is used, the query statement > is created via string concatenation. > Since JDBC API allows only one literal for one “?” parameter, > PreparedStatement doesn’t work for IN clause queries. To create the > PreparedStatement query dynamically based on the size of the elements in IN > clause, the makeParams() should be used instead of concatenation. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HIVE-20575) Fix flaky connection metric tests
[ https://issues.apache.org/jira/browse/HIVE-20575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Laszlo Pinter updated HIVE-20575: - Attachment: HIVE-20575.01.patch > Fix flaky connection metric tests > - > > Key: HIVE-20575 > URL: https://issues.apache.org/jira/browse/HIVE-20575 > Project: Hive > Issue Type: Test > Components: Hive, Test >Affects Versions: 4.0.0 >Reporter: Laszlo Pinter >Assignee: Laszlo Pinter >Priority: Minor > Fix For: 4.0.0 > > Attachments: HIVE-20575.01.patch > > > TestHs2ConnectionMetricsHttp.testOpenConnectionMetrics() is flaky. We need to > fix it. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
