[GitHub] incubator-hivemall issue #79: [HIVEMALL-101] Separate optimizer implementati...
Github user coveralls commented on the issue: https://github.com/apache/incubator-hivemall/pull/79 [](https://coveralls.io/builds/11896899) Coverage increased (+0.8%) to 40.283% when pulling **5439bd80face5ef2f69650244ea8c9f0f13bed1b on takuti:HIVEMALL-101** into **1db5358767bb30a8c433e4530c39d8591bc28a36 on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #79: [HIVEMALL-101] Separate optimizer implementati...
Github user coveralls commented on the issue: https://github.com/apache/incubator-hivemall/pull/79 [](https://coveralls.io/builds/11662166) Coverage increased (+0.5%) to 39.184% when pulling **689bdbf77c985117c2064d4a042d7d45f2971165 on takuti:HIVEMALL-101** into **10e7d450fa8257efc5d614957fda514b2b91fdee on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #79: [HIVEMALL-101] Separate optimizer implementati...
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/79 @takuti well done :+1: will review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #79: [HIVEMALL-101] Separate optimizer implementati...
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/79 @myui Finished~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #79: [HIVEMALL-101] Separate optimizer implementati...
Github user myui commented on the issue: https://github.com/apache/incubator-hivemall/pull/79 @takuti It's preferred to have an abstract class. Please create it. - hivemall.LearnerBase - hivemall.GeneralLeanerBase - hivemall.classifier.GeneralClassifier - hivemall.regression.GeneralRegression --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #79: [HIVEMALL-101] Separate optimizer implementati...
Github user coveralls commented on the issue: https://github.com/apache/incubator-hivemall/pull/79 [](https://coveralls.io/builds/11661000) Coverage increased (+0.7%) to 39.422% when pulling **2724dbcc97218ae6237f5ff675027ad24f9501bb on takuti:HIVEMALL-101** into **10e7d450fa8257efc5d614957fda514b2b91fdee on apache:master**. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-hivemall issue #79: [HIVEMALL-101] Separate optimizer implementati...
Github user takuti commented on the issue: https://github.com/apache/incubator-hivemall/pull/79 @myui Almost done basically. Could you review when you get a chance? One thing I like to discuss here is that `GeneralClassifierUDTF` and `GeneralRegressionUDTF` currently has a lot of duplicated code. Thus, current class structure - Learner Base - Binary Online Classifier - General Classifier - Regression Base - General Regression can be modified to - Learner Base - General Predictor Base - General Classifier - General Regression for example. If it sounds good for @myui, I will do so. Of course it's not mandatory, so keeping the current duplicated code is no problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
