[GitHub] incubator-hivemall pull request #169: [HIVEMALL-222] Introduce Gradient Clip...

2018-10-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/incubator-hivemall/pull/169


---


[GitHub] incubator-hivemall pull request #169: [HIVEMALL-222] Introduce Gradient Clip...

2018-10-24 Thread myui
GitHub user myui opened a pull request:

https://github.com/apache/incubator-hivemall/pull/169

[HIVEMALL-222] Introduce Gradient Clipping to avoid exploding gradient to 
General Classifier/Regressor

## What changes were proposed in this pull request?

Avoid [exploding 
gradients](http://www.cs.toronto.edu/~rgrosse/courses/csc321_2017/readings/L15%20Exploding%20and%20Vanishing%20Gradients.pdf)
 by gradient clipping (by value)

## What type of PR is it?

Improvement

## What is the Jira issue?

https://issues.apache.org/jira/browse/HIVEMALL-222

## How was this patch tested?

unit tests

## Checklist

(Please remove this section if not needed; check `x` for YES, blank for NO)

- [x] Did you apply source code formatter, i.e., `./bin/format_code.sh`, 
for your commit?
- [ ] Did you run system tests on Hive (or Spark)?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/myui/incubator-hivemall clipping

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-hivemall/pull/169.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #169


commit 0c10392d2a3c96b40df57e6b406333e0a239b9f9
Author: Makoto Yui 
Date:   2018-10-24T08:14:15Z

Updated for debugging purpose

commit e0dc4b954650c6751d6e37ee5ecf6c9656872b16
Author: Makoto Yui 
Date:   2018-10-24T08:15:03Z

Introduced gradient clipping by value to avoid exploding gradients

commit 7e932e99cfd990bb47ff7acfed44c19678fadc8f
Author: Makoto Yui 
Date:   2018-10-24T08:15:52Z

Added a unit test for gradient clipping




---