[jira] [Commented] (HTRACE-368) Cannot build Javadoc with JDK1.8.X

2016-05-05 Thread Lewis John McGibbney (JIRA) 

[ 
https://issues.apache.org/jira/browse/HTRACE-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273311#comment-15273311
 ] 

Lewis John McGibbney commented on HTRACE-368:
-

Ack

On Thursday, May 5, 2016, Colin Patrick McCabe (JIRA) 



-- 
*Lewis*


> Cannot build Javadoc with JDK1.8.X
> --
>
> Key: HTRACE-368
> URL: https://issues.apache.org/jira/browse/HTRACE-368
> Project: HTrace
>  Issue Type: Improvement
>  Components: build, docs
>Affects Versions: 4.1
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Minor
> Attachments: HTRACE-368.patch, help-doc.html
>
>
> Right now if I attempt to build Javadoc in master branch with following JDK I 
> get a hellish error which indicates Javadoc in HTrace Java source needs some 
> attention. 
> {code}
> lmcgibbn@LMC-032857 /usr/local/incubator-htrace(master) $ mvn -version
> Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 
> 2015-04-22T04:57:37-07:00)
> Maven home: /usr/local/apache-maven-3.3.3
> Java version: 1.8.0_66, vendor: Oracle Corporation
> Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.9.5", arch: "x86_64", family: "mac"
> {code}
> For the interim I propose to submit a profile which would allow us to work 
> around the Javadoc issue. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HTRACE-368) Cannot build Javadoc with JDK1.8.X

2016-05-05 Thread Colin Patrick McCabe (JIRA) 

[ 
https://issues.apache.org/jira/browse/HTRACE-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273288#comment-15273288
 ] 

Colin Patrick McCabe commented on HTRACE-368:
-

Thanks for the update.  Fixing the javadoc for those subprojects could be a 
good newbie jira...

> Cannot build Javadoc with JDK1.8.X
> --
>
> Key: HTRACE-368
> URL: https://issues.apache.org/jira/browse/HTRACE-368
> Project: HTrace
>  Issue Type: Improvement
>  Components: build, docs
>Affects Versions: 4.1
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Minor
> Attachments: HTRACE-368.patch, help-doc.html
>
>
> Right now if I attempt to build Javadoc in master branch with following JDK I 
> get a hellish error which indicates Javadoc in HTrace Java source needs some 
> attention. 
> {code}
> lmcgibbn@LMC-032857 /usr/local/incubator-htrace(master) $ mvn -version
> Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 
> 2015-04-22T04:57:37-07:00)
> Maven home: /usr/local/apache-maven-3.3.3
> Java version: 1.8.0_66, vendor: Oracle Corporation
> Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.9.5", arch: "x86_64", family: "mac"
> {code}
> For the interim I propose to submit a profile which would allow us to work 
> around the Javadoc issue. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HTRACE-368) Cannot build Javadoc with JDK1.8.X

2016-05-05 Thread Lewis John McGibbney (JIRA) 

[ 
https://issues.apache.org/jira/browse/HTRACE-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273125#comment-15273125
 ] 

Lewis John McGibbney commented on HTRACE-368:
-

bq. Can you be clearer about what error you are seeing?
{code}
Generating /usr/local/incubator-htrace/target/site/apidocs/help-doc.html...
14 errors
100 warnings
[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] Apache HTrace .. FAILURE [ 10.032 s]
[INFO] htrace-c ... SKIPPED
[INFO] htrace-core4 ... SKIPPED
[INFO] htrace-webapp .. SKIPPED
[INFO] htrace-zipkin .. SKIPPED
[INFO] htrace-hbase ... SKIPPED
[INFO] htrace-flume ... SKIPPED
[INFO] htrace-htraced . SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 10.487 s
[INFO] Finished at: 2016-05-05T14:13:24-07:00
[INFO] Final Memory: 29M/1472M
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-javadoc-plugin:2.8.1:aggregate (default-cli) on 
project htrace: An error has occurred in JavaDocs report generation:
[ERROR] Exit code: 1 - 
/usr/local/incubator-htrace/htrace-core4/src/main/java/org/apache/htrace/core/Span.java:94:
 warning: no @param for description
[ERROR] Span child(String description);
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/Annotation.java:185:
 warning: no @return
[ERROR] public boolean isSetTimestamp() {
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/Annotation.java:207:
 warning: no @return
[ERROR] public boolean isSetValue() {
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/Annotation.java:231:
 warning: no @return
[ERROR] public boolean isSetHost() {
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/Annotation.java:147:
 warning: no @param for other
[ERROR] public Annotation(Annotation other) {
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/Annotation.java:67:
 warning: no @param for fieldId
[ERROR] public static _Fields findByThriftId(int fieldId) {
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/Annotation.java:67:
 warning: no @return
[ERROR] public static _Fields findByThriftId(int fieldId) {
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/Annotation.java:84:
 warning: no @param for fieldId
[ERROR] public static _Fields findByThriftIdOrThrow(int fieldId) {
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/Annotation.java:84:
 warning: no @return
[ERROR] public static _Fields findByThriftIdOrThrow(int fieldId) {
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/Annotation.java:93:
 warning: no @param for name
[ERROR] public static _Fields findByName(String name) {
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/Annotation.java:93:
 warning: no @return
[ERROR] public static _Fields findByName(String name) {
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/AnnotationType.java:40:
 warning: no @param for value
[ERROR] public static AnnotationType findByValue(int value) {
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/BinaryAnnotation.java:203:
 warning: no @return
[ERROR] public boolean isSetKey() {
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/BinaryAnnotation.java:237:
 warning: no @return
[ERROR] public boolean isSetValue() {
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/BinaryAnnotation.java:251:
 warning: no @return
[ERROR] public AnnotationType getAnnotation_type() {
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/BinaryAnnotation.java:259:
 warning: no @param for annotation_type
[ERROR] public BinaryAnnotation setAnnotation_type(AnnotationType 
annotation_type) {
[ERROR] ^
[ERROR] 
/usr/local/incubator-htrace/htrace-zipkin/src/main/java/com/twitter/zipkin/gen/BinaryAnnotation.java:259:
 warning: no @return
[ERROR] public BinaryAnnotation

[jira] [Commented] (HTRACE-368) Cannot build Javadoc with JDK1.8.X

2016-05-05 Thread Colin Patrick McCabe (JIRA) 

[ 
https://issues.apache.org/jira/browse/HTRACE-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272704#comment-15272704
 ] 

Colin Patrick McCabe commented on HTRACE-368:
-

 Can you be clearer about what error you are seeing?

We spent a lot of effort fixing jdk8 JavaDoc lint errors in HTRACE-354 and 
HTRACE-232.  The doclint should work correctly in all subprojects, except 
htrace-hbase and htrace-zipkin.  We suppress the doclint on just those 
subprojects.  Perhaps we need to fix those subprojects as well?  In any case, 
turning off doclint for everything is not the right answer, since we will just 
see errors start creeping in again with new changes.

> Cannot build Javadoc with JDK1.8.X
> --
>
> Key: HTRACE-368
> URL: https://issues.apache.org/jira/browse/HTRACE-368
> Project: HTrace
>  Issue Type: Improvement
>  Components: build, docs
>Affects Versions: 4.1
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Minor
> Attachments: HTRACE-368.patch
>
>
> Right now if I attempt to build Javadoc in master branch with following JDK I 
> get a hellish error which indicates Javadoc in HTrace Java source needs some 
> attention. 
> {code}
> lmcgibbn@LMC-032857 /usr/local/incubator-htrace(master) $ mvn -version
> Apache Maven 3.3.3 (7994120775791599e205a5524ec3e0dfe41d4a06; 
> 2015-04-22T04:57:37-07:00)
> Maven home: /usr/local/apache-maven-3.3.3
> Java version: 1.8.0_66, vendor: Oracle Corporation
> Java home: /Library/Java/JavaVirtualMachines/jdk1.8.0_66.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.9.5", arch: "x86_64", family: "mac"
> {code}
> For the interim I propose to submit a profile which would allow us to work 
> around the Javadoc issue. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)