Re: [I] Support creating tags [iceberg-python]
chinmay-bhat commented on issue #573: URL: https://github.com/apache/iceberg-python/issues/573#issuecomment-2106300079 @Fokko I saw this issue has been inactive for over a month, so I created a PR that might close the issue. Please review when possible :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Support creating tags [iceberg-python]
enkidulan commented on issue #573: URL: https://github.com/apache/iceberg-python/issues/573#issuecomment-2043897402 > Are you interested in creating the API for this? :) I am. I'll try to create a PR this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Support creating tags [iceberg-python]
Fokko commented on issue #573: URL: https://github.com/apache/iceberg-python/issues/573#issuecomment-2039233700 @enkidulan Thanks for reaching out here. Are you interested in creating the API for this? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [I] Support creating tags [iceberg-python]
enkidulan commented on issue #573: URL: https://github.com/apache/iceberg-python/issues/573#issuecomment-2033571970 For the reference, I was able to make a tag only by using some private properties of the transaction object: ```py from pyiceberg.table import SetSnapshotRefUpdate, update_table_metadata with table.transaction() as txn: update = SetSnapshotRefUpdate( ref_name=tag, type="tag", snapshot_id=snapshot_id, max_ref_age_ms=None, max_snapshot_age_ms=None, min_snapshots_to_keep=None, ) txn._updates = [update] txn.table_metadata = update_table_metadata(txn.table_metadata, [update]) ``` This seems to work fine as a temporary workaround for development purposes, but it would great to have a public method for creating tags. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
