Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]
amogh-jahagirdar closed pull request #9407: JDBC Catalog:Change SQL like escape character from '\\' to '!' URL: https://github.com/apache/iceberg/pull/9407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]
amogh-jahagirdar commented on PR #9407: URL: https://github.com/apache/iceberg/pull/9407#issuecomment-2062812347 I'll close this since #9407 has been merged, thanks @xuchuanqiu @jbonofre ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]
amogh-jahagirdar commented on PR #9407: URL: https://github.com/apache/iceberg/pull/9407#issuecomment-2061642341 Thanks @jbonofre ! Discussed offline, we'll ensure that @xuchuanqiu gets co-authorship/attribution. Thanks @xuchuanqiu -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]
jbonofre commented on PR #9407: URL: https://github.com/apache/iceberg/pull/9407#issuecomment-2061639934 Replaced by #10167 to merge the conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]
jbonofre commented on code in PR #9407:
URL: https://github.com/apache/iceberg/pull/9407#discussion_r1569078743
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -136,7 +136,7 @@ final class JdbcUtil {
+ TABLE_NAMESPACE
+ " = ? OR "
+ TABLE_NAMESPACE
- + " LIKE ? ESCAPE '\\' "
+ + " LIKE ? ESCAPE '!' "
Review Comment:
Tested without problem with PostgreSQL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]
jbonofre commented on PR #9407: URL: https://github.com/apache/iceberg/pull/9407#issuecomment-2061615460 I also tested with PostgreSQL 42.7.3 and it works fine. In order to fix the conflict, I propose to create a clean PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]
jbonofre commented on PR #9407: URL: https://github.com/apache/iceberg/pull/9407#issuecomment-2061586682 I tested with MySQL 8.3.0 (both server and JDBC driver) and I confirm the `!` notation works. I used MySQL 8.3.0 docker image, create the schema and updated the `GET_NAMESPACE_SQL` statement. No SQL statement error, and the namespace is retrieved without problem. I'm doing the same test with PostgreSQL now, to be sure the same statement works fine with PostgreSQL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]
amogh-jahagirdar commented on PR #9407: URL: https://github.com/apache/iceberg/pull/9407#issuecomment-2061567560 I've added this to the 1.5.1 milestone. If we validate that it works on all the backends as expected, then I think we can include in the patch release (we'll also discuss this in the community sync today). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]
jbonofre commented on PR #9407: URL: https://github.com/apache/iceberg/pull/9407#issuecomment-2059448849 If @xuchuanqiu doesn't have the bandwidth, I can help on this one. If it works with MySQL, SQLlite and PostgreSQL, it's a nice fix to include in Iceberg 1.5.1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]
jbonofre commented on code in PR #9407:
URL: https://github.com/apache/iceberg/pull/9407#discussion_r1567618729
##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -136,7 +136,7 @@ final class JdbcUtil {
+ TABLE_NAMESPACE
+ " = ? OR "
+ TABLE_NAMESPACE
- + " LIKE ? ESCAPE '\\' "
+ + " LIKE ? ESCAPE '!' "
Review Comment:
Does it work with any backend like PostgreSQL ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
Re: [PR] JDBC Catalog:Change SQL like escape character from '\\' to '!' [iceberg]
nastra commented on PR #9407: URL: https://github.com/apache/iceberg/pull/9407#issuecomment-2059442673 fixes https://github.com/apache/iceberg/issues/10056 @xuchuanqiu can you rebase this one please to fix the merge conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
