[jira] [Assigned] (IGNITE-9406) Improve SQL "Performance and Debugging" page
[ https://issues.apache.org/jira/browse/IGNITE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Ozerov reassigned IGNITE-9406: --- Assignee: Artem Budnikov (was: Vladimir Ozerov) > Improve SQL "Performance and Debugging" page > > > Key: IGNITE-9406 > URL: https://issues.apache.org/jira/browse/IGNITE-9406 > Project: Ignite > Issue Type: Task > Components: documentation >Reporter: Vladimir Ozerov >Assignee: Artem Budnikov >Priority: Major > Fix For: 2.7 > > Attachments: ignite_sql_perf.txt > > > I prepared a document for one of Ignite clients with some advanced > information about how various performance optimizations work in Ignite SQL. > Let's compare this document with our "Performance and Debugging" page [1], > and enhance the latter with missing info (if any). > P.S.: Document is attached. Russian language. > [1] > https://apacheignite-sql.readme.io/docs/performance-and-debugging#query-execution-flow-optimizations -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-10314) QueryEntity is not updated when column and index added or dropped
[ https://issues.apache.org/jira/browse/IGNITE-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691348#comment-16691348 ] Vladimir Ozerov edited comment on IGNITE-10314 at 11/19/18 7:49 AM: [~ldz], public configuration is unmutable, it represents initial cache parameters. So it is expected that configuration will not be updated after DDL commands. Real changes are accumulated in separate query entity which is hidden from user and used internally. was (Author: vozerov): [~ldz], public configuration is unmutable, it represents initial cache parameters. So it is expected that configuration will not be updated after DDL commands. > QueryEntity is not updated when column and index added or dropped > - > > Key: IGNITE-10314 > URL: https://issues.apache.org/jira/browse/IGNITE-10314 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.0, 2.1, 2.2, 2.3, 2.4, 2.5, 2.6, 2.7 >Reporter: Ray >Assignee: Ray >Priority: Critical > Fix For: 2.8 > > > When user performs column and index modification operation in SQL(ex create > index, drop index, add column, drop column), QueryEntity in > CacheConfiguration for the modified cache is not updated. > > Analyse > QueryEntity in QuerySchema is a local copy of the original QueryEntity, so > the original QueryEntity is not updated when modification happens. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9406) Improve SQL "Performance and Debugging" page
[ https://issues.apache.org/jira/browse/IGNITE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691346#comment-16691346 ] Vladimir Ozerov commented on IGNITE-9406: - [~Artem Budnikov], we do not have specific recommendations on how to optimize subselects. > Improve SQL "Performance and Debugging" page > > > Key: IGNITE-9406 > URL: https://issues.apache.org/jira/browse/IGNITE-9406 > Project: Ignite > Issue Type: Task > Components: documentation >Reporter: Vladimir Ozerov >Assignee: Vladimir Ozerov >Priority: Major > Fix For: 2.7 > > Attachments: ignite_sql_perf.txt > > > I prepared a document for one of Ignite clients with some advanced > information about how various performance optimizations work in Ignite SQL. > Let's compare this document with our "Performance and Debugging" page [1], > and enhance the latter with missing info (if any). > P.S.: Document is attached. Russian language. > [1] > https://apacheignite-sql.readme.io/docs/performance-and-debugging#query-execution-flow-optimizations -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9290) Make remove explicit locks async when node left.
[
https://issues.apache.org/jira/browse/IGNITE-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691332#comment-16691332
]
Ignite TC Bot commented on IGNITE-9290:
---
{panel:title=Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Inspections: Core{color} [[tests 0 BuildFailureOnMetric
|https://ci.ignite.apache.org/viewLog.html?buildId=236]]
{color:#d04437}~Build Apache Ignite~{color} [[tests 0 Exit Code ,
TC_COMPILATION_ERROR
|https://ci.ignite.apache.org/viewLog.html?buildId=2333226]]
{color:#d04437}_Javadoc_{color} [[tests 0 Exit Code , TC_COMPILATION_ERROR
|https://ci.ignite.apache.org/viewLog.html?buildId=2333286]]
{panel}
[TeamCity Run All
Results|https://ci.ignite.apache.org/viewLog.html?buildId=240buildTypeId=IgniteTests24Java8_RunAll]
> Make remove explicit locks async when node left.
>
>
> Key: IGNITE-9290
> URL: https://issues.apache.org/jira/browse/IGNITE-9290
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Reporter: Andrew Mashenkov
>Assignee: Andrew Mashenkov
>Priority: Critical
> Labels: deadlock, iep-25
> Fix For: 2.8
>
>
> GridCacheMvccManager.removeExplicitNodeLocks() run synchronously in discovery
> and exchange threads. This introduce unnecessary delays in discovery and
> exchange process.
> Also, this may cause a deadlock on node stop if user transaction holds an
> entry lock and awaits some Ignite manager response (e.g. cache store or DR or
> CQ), as manager stops right after last exchange has finished so managers
> can't detect node is stopping.
>
> [1]
> [http://apache-ignite-developers.2346864.n4.nabble.com/Synchronous-tx-entries-unlocking-in-discovery-exchange-threads-td33827.html]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (IGNITE-10316) control.sh --baseline remove outputs wrong error message when trying to remove node from baseline when cluster is inactive.
Pavel Voronkin created IGNITE-10316:
---
Summary: control.sh --baseline remove outputs wrong error message
when trying to remove node from baseline when cluster is inactive.
Key: IGNITE-10316
URL: https://issues.apache.org/jira/browse/IGNITE-10316
Project: Ignite
Issue Type: Bug
Reporter: Pavel Voronkin
1. start 2 nodes from clean lfs
2. grep node consistent ids
{noformat}
$ grep "Consistent ID" work/log/*.log
work/log/ignite-15958745.0.log:[16:59:13,190][INFO][main][PdsFoldersResolver]
Consistent ID used for local node is [7ee8018b-3f5f-4c58-b6dd-f53ed7af2679]
according to persistence data storage folders
work/log/ignite-300c7412.0.log:[16:59:15,678][INFO][main][PdsFoldersResolver]
Consistent ID used for local node is [5adcf3a1-7ad9-40fa-88ac-40b488dc6b34]
according to persistence data storage folders
{noformat}
3. try to remove node from baseline
expected: error message about cluster inactive state
actual: error message about node id not found, BUG
{noformat}
Caused by: java.lang.IllegalStateException: Node not found for consistent ID:
7ee8018b-3f5f-4c58-b6dd-f53ed7af2679
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.remove(VisorBaselineTask.java:178)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:208)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:52)
at org.apache.ignite.internal.visor.VisorJob.execute(VisorJob.java:69)
at
org.apache.ignite.internal.processors.job.GridJobWorker$2.call(GridJobWorker.java:568)
at
org.apache.ignite.internal.util.IgniteUtils.wrapThreadLoader(IgniteUtils.java:6726)
at
org.apache.ignite.internal.processors.job.GridJobWorker.execute0(GridJobWorker.java:562)
... 19 more
{noformat}
however, when trying to add node to baseline, error message is correct:
{noformat}
Caused by: class org.apache.ignite.IgniteException: Changing BaselineTopology
on inactive cluster is not allowed.
at
org.apache.ignite.internal.cluster.IgniteClusterImpl.validateBeforeBaselineChange(IgniteClusterImpl.java:406)
at
org.apache.ignite.internal.cluster.IgniteClusterImpl.setBaselineTopology(IgniteClusterImpl.java:356)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.set0(VisorBaselineTask.java:87)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.add(VisorBaselineTask.java:162)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:205)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:52)
at org.apache.ignite.internal.visor.VisorJob.execute(VisorJob.java:69)
at
org.apache.ignite.internal.processors.job.GridJobWorker$2.call(GridJobWorker.java:568)
at
org.apache.ignite.internal.util.IgniteUtils.wrapThreadLoader(IgniteUtils.java:6726)
at
org.apache.ignite.internal.processors.job.GridJobWorker.execute0(GridJobWorker.java:562)
at
org.apache.ignite.internal.processors.job.GridJobWorker.body(GridJobWorker.java:491)
at org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:110)
at
org.apache.ignite.internal.processors.job.GridJobProcessor.processJobExecuteRequest(GridJobProcessor.java:1123)
at
org.apache.ignite.internal.processors.task.GridTaskWorker.sendRequest(GridTaskWorker.java:1407)
at
org.apache.ignite.internal.processors.task.GridTaskWorker.processMappedJobs(GridTaskWorker.java:660)
at
org.apache.ignite.internal.processors.task.GridTaskWorker.body(GridTaskWorker.java:532)
... 13 more
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (IGNITE-10315) control.sh --baseline remove outputs wrong error message when trying to remove node from baseline when cluster is inactive.
Pavel Voronkin created IGNITE-10315:
---
Summary: control.sh --baseline remove outputs wrong error message
when trying to remove node from baseline when cluster is inactive.
Key: IGNITE-10315
URL: https://issues.apache.org/jira/browse/IGNITE-10315
Project: Ignite
Issue Type: Bug
Reporter: Pavel Voronkin
1. start 2 nodes from clean lfs
2. grep node consistent ids
{noformat}
$ grep "Consistent ID" work/log/*.log
work/log/ignite-15958745.0.log:[16:59:13,190][INFO][main][PdsFoldersResolver]
Consistent ID used for local node is [7ee8018b-3f5f-4c58-b6dd-f53ed7af2679]
according to persistence data storage folders
work/log/ignite-300c7412.0.log:[16:59:15,678][INFO][main][PdsFoldersResolver]
Consistent ID used for local node is [5adcf3a1-7ad9-40fa-88ac-40b488dc6b34]
according to persistence data storage folders
{noformat}
3. try to remove node from baseline
expected: error message about cluster inactive state
actual: error message about node id not found, BUG
{noformat}
Caused by: java.lang.IllegalStateException: Node not found for consistent ID:
7ee8018b-3f5f-4c58-b6dd-f53ed7af2679
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.remove(VisorBaselineTask.java:178)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:208)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:52)
at org.apache.ignite.internal.visor.VisorJob.execute(VisorJob.java:69)
at
org.apache.ignite.internal.processors.job.GridJobWorker$2.call(GridJobWorker.java:568)
at
org.apache.ignite.internal.util.IgniteUtils.wrapThreadLoader(IgniteUtils.java:6726)
at
org.apache.ignite.internal.processors.job.GridJobWorker.execute0(GridJobWorker.java:562)
... 19 more
{noformat}
however, when trying to add node to baseline, error message is correct:
{noformat}
Caused by: class org.apache.ignite.IgniteException: Changing BaselineTopology
on inactive cluster is not allowed.
at
org.apache.ignite.internal.cluster.IgniteClusterImpl.validateBeforeBaselineChange(IgniteClusterImpl.java:406)
at
org.apache.ignite.internal.cluster.IgniteClusterImpl.setBaselineTopology(IgniteClusterImpl.java:356)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.set0(VisorBaselineTask.java:87)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.add(VisorBaselineTask.java:162)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:205)
at
org.apache.ignite.internal.visor.baseline.VisorBaselineTask$VisorBaselineJob.run(VisorBaselineTask.java:52)
at org.apache.ignite.internal.visor.VisorJob.execute(VisorJob.java:69)
at
org.apache.ignite.internal.processors.job.GridJobWorker$2.call(GridJobWorker.java:568)
at
org.apache.ignite.internal.util.IgniteUtils.wrapThreadLoader(IgniteUtils.java:6726)
at
org.apache.ignite.internal.processors.job.GridJobWorker.execute0(GridJobWorker.java:562)
at
org.apache.ignite.internal.processors.job.GridJobWorker.body(GridJobWorker.java:491)
at org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:110)
at
org.apache.ignite.internal.processors.job.GridJobProcessor.processJobExecuteRequest(GridJobProcessor.java:1123)
at
org.apache.ignite.internal.processors.task.GridTaskWorker.sendRequest(GridTaskWorker.java:1407)
at
org.apache.ignite.internal.processors.task.GridTaskWorker.processMappedJobs(GridTaskWorker.java:660)
at
org.apache.ignite.internal.processors.task.GridTaskWorker.body(GridTaskWorker.java:532)
... 13 more
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9406) Improve SQL "Performance and Debugging" page
[ https://issues.apache.org/jira/browse/IGNITE-9406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691308#comment-16691308 ] Artem Budnikov commented on IGNITE-9406: [~vozerov] Ideally, we need to provide recommendations on how to improve performance using sub-selects and a good example of such a query. > Improve SQL "Performance and Debugging" page > > > Key: IGNITE-9406 > URL: https://issues.apache.org/jira/browse/IGNITE-9406 > Project: Ignite > Issue Type: Task > Components: documentation >Reporter: Vladimir Ozerov >Assignee: Vladimir Ozerov >Priority: Major > Fix For: 2.7 > > Attachments: ignite_sql_perf.txt > > > I prepared a document for one of Ignite clients with some advanced > information about how various performance optimizations work in Ignite SQL. > Let's compare this document with our "Performance and Debugging" page [1], > and enhance the latter with missing info (if any). > P.S.: Document is attached. Russian language. > [1] > https://apacheignite-sql.readme.io/docs/performance-and-debugging#query-execution-flow-optimizations -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9817) Update documentation and examples for Spark SQL Table Specification
[ https://issues.apache.org/jira/browse/IGNITE-9817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691302#comment-16691302 ] Nikolay Izhikov commented on IGNITE-9817: - [~pgarg] > Is this the only section that needs review? Yes. Unfortunately, this patch has not been included in 2.7 release. I think we should hide edits till 2.8. How can we do it? > Update documentation and examples for Spark SQL Table Specification > --- > > Key: IGNITE-9817 > URL: https://issues.apache.org/jira/browse/IGNITE-9817 > Project: Ignite > Issue Type: Sub-task > Components: documentation >Reporter: Nikolay Izhikov >Assignee: Nikolay Izhikov >Priority: Major > Fix For: 2.7 > > > We should update documentation and examples according to the results of > IGNITE-9228. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (IGNITE-9811) Web Console: Do not block "Save" button in case some inputs are invalid
[ https://issues.apache.org/jira/browse/IGNITE-9811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilya Borisov reassigned IGNITE-9811: Assignee: Alexey Kuznetsov (was: Ilya Borisov) > Web Console: Do not block "Save" button in case some inputs are invalid > --- > > Key: IGNITE-9811 > URL: https://issues.apache.org/jira/browse/IGNITE-9811 > Project: Ignite > Issue Type: Task > Components: wizards >Reporter: Alexey Kuznetsov >Assignee: Alexey Kuznetsov >Priority: Major > > Let's not block "Save" button in case some inputs invalid. > In modern UI trends it is better to set focus to invalid filed and show > tooltip with error when user clicked on "Save" button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-10314) QueryEntity is not updated when column and index added or dropped
[ https://issues.apache.org/jira/browse/IGNITE-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691221#comment-16691221 ] Ray edited comment on IGNITE-10314 at 11/19/18 6:00 AM: I have submitted a fix for this bug. [~vozerov] Can you take a look and tell me if this is a correct fix please? I'll add more tests if this is the correct fix. Also can you explain why you copy the QueryEntity in QuerySchema? was (Author: ldz): I have submitted a fix for this bug. [~vozerov] Can you take a look and tell me if this is a correct fix please? I'll fix the current tests and add more tests if this is the correct fix. Also can you explain why you copy the QueryEntity in QuerySchema? > QueryEntity is not updated when column and index added or dropped > - > > Key: IGNITE-10314 > URL: https://issues.apache.org/jira/browse/IGNITE-10314 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.0, 2.1, 2.2, 2.3, 2.4, 2.5, 2.6, 2.7 >Reporter: Ray >Assignee: Ray >Priority: Critical > Fix For: 2.8 > > > When user performs column and index modification operation in SQL(ex create > index, drop index, add column, drop column), QueryEntity in > CacheConfiguration for the modified cache is not updated. > > Analyse > QueryEntity in QuerySchema is a local copy of the original QueryEntity, so > the original QueryEntity is not updated when modification happens. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (IGNITE-9811) Web Console: Do not block "Save" button in case some inputs are invalid
[ https://issues.apache.org/jira/browse/IGNITE-9811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilya Borisov reassigned IGNITE-9811: Assignee: Ilya Borisov (was: Alexey Kuznetsov) form-field-size should support this too. > Web Console: Do not block "Save" button in case some inputs are invalid > --- > > Key: IGNITE-9811 > URL: https://issues.apache.org/jira/browse/IGNITE-9811 > Project: Ignite > Issue Type: Task > Components: wizards >Reporter: Alexey Kuznetsov >Assignee: Ilya Borisov >Priority: Major > > Let's not block "Save" button in case some inputs invalid. > In modern UI trends it is better to set focus to invalid filed and show > tooltip with error when user clicked on "Save" button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (IGNITE-10314) QueryEntity is not updated when column and index added or dropped
[ https://issues.apache.org/jira/browse/IGNITE-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ray updated IGNITE-10314: - Affects Version/s: 2.0 2.1 2.2 2.3 2.4 2.5 Ignite Flags: (was: Docs Required) > QueryEntity is not updated when column and index added or dropped > - > > Key: IGNITE-10314 > URL: https://issues.apache.org/jira/browse/IGNITE-10314 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.0, 2.1, 2.2, 2.3, 2.4, 2.5, 2.6, 2.7 >Reporter: Ray >Assignee: Ray >Priority: Critical > Fix For: 2.8 > > > When user performs column and index modification operation in SQL(ex create > index, drop index, add column, drop column), QueryEntity in > CacheConfiguration for the modified cache is not updated. > > Analyse > QueryEntity in QuerySchema is a local copy of the original QueryEntity, so > the original QueryEntity is not updated when modification happens. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-9811) Web Console: Do not block "Save" button in case some inputs are invalid
[
https://issues.apache.org/jira/browse/IGNITE-9811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691265#comment-16691265
]
Ilya Borisov edited comment on IGNITE-9811 at 11/19/18 5:14 AM:
I've updated the validation directives to work with tooltip-style validation
messages too. Call {{IgniteFormUtils.triggerValidation(form)}} to focus invalid
fields and show error messages. The form on user edit screen has been updated
to behave like requested.
[~kuaw26] please review.
was (Author: klaster_1):
I've updated the validation directives to work with tooltip-style validation
messages too. Call {{IgniteFormUtils.triggerValidation(form)}} to focus invalid
fields and show error messages. The form on user edit screen has been updated
to behave like requested.
> Web Console: Do not block "Save" button in case some inputs are invalid
> ---
>
> Key: IGNITE-9811
> URL: https://issues.apache.org/jira/browse/IGNITE-9811
> Project: Ignite
> Issue Type: Task
> Components: wizards
>Reporter: Alexey Kuznetsov
>Assignee: Alexey Kuznetsov
>Priority: Major
>
> Let's not block "Save" button in case some inputs invalid.
> In modern UI trends it is better to set focus to invalid filed and show
> tooltip with error when user clicked on "Save" button.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-9811) Web Console: Do not block "Save" button in case some inputs are invalid
[
https://issues.apache.org/jira/browse/IGNITE-9811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691265#comment-16691265
]
Ilya Borisov commented on IGNITE-9811:
--
I've updated the validation directives to work with tooltip-style validation
messages too. Call {{IgniteFormUtils.triggerValidation(form)}} to focus invalid
fields and show error messages. The form on user edit screen has been updated
to behave like requested.
> Web Console: Do not block "Save" button in case some inputs are invalid
> ---
>
> Key: IGNITE-9811
> URL: https://issues.apache.org/jira/browse/IGNITE-9811
> Project: Ignite
> Issue Type: Task
> Components: wizards
>Reporter: Alexey Kuznetsov
>Assignee: Alexander Kalinin
>Priority: Major
>
> Let's not block "Save" button in case some inputs invalid.
> In modern UI trends it is better to set focus to invalid filed and show
> tooltip with error when user clicked on "Save" button.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (IGNITE-9811) Web Console: Do not block "Save" button in case some inputs are invalid
[ https://issues.apache.org/jira/browse/IGNITE-9811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ilya Borisov reassigned IGNITE-9811: Assignee: Alexey Kuznetsov (was: Alexander Kalinin) > Web Console: Do not block "Save" button in case some inputs are invalid > --- > > Key: IGNITE-9811 > URL: https://issues.apache.org/jira/browse/IGNITE-9811 > Project: Ignite > Issue Type: Task > Components: wizards >Reporter: Alexey Kuznetsov >Assignee: Alexey Kuznetsov >Priority: Major > > Let's not block "Save" button in case some inputs invalid. > In modern UI trends it is better to set focus to invalid filed and show > tooltip with error when user clicked on "Save" button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-9811) Web Console: Do not block "Save" button in case some inputs are invalid
[ https://issues.apache.org/jira/browse/IGNITE-9811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691260#comment-16691260 ] ASF GitHub Bot commented on IGNITE-9811: GitHub user Klaster1 opened a pull request: https://github.com/apache/ignite/pull/5423 IGNITE-9811 Web console: show validation messages on form submit [The issue.](https://issues.apache.org/jira/browse/IGNITE-9811) You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-9811 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5423.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5423 commit 93350c53cc5b16bf54e2b441d2b4fc64bd383ec7 Author: Ilya Borisov Date: 2018-11-19T05:06:16Z IGNITE-9811 Show validation error message when errors are triggered too. commit a5bb7a0dccb0bc56f29d7d432e87f538361b3cbf Author: Ilya Borisov Date: 2018-11-19T05:06:57Z IGNITE-9811 Do not disable user profile save button, trigger validation instead. > Web Console: Do not block "Save" button in case some inputs are invalid > --- > > Key: IGNITE-9811 > URL: https://issues.apache.org/jira/browse/IGNITE-9811 > Project: Ignite > Issue Type: Task > Components: wizards >Reporter: Alexey Kuznetsov >Assignee: Alexander Kalinin >Priority: Major > > Let's not block "Save" button in case some inputs invalid. > In modern UI trends it is better to set focus to invalid filed and show > tooltip with error when user clicked on "Save" button. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8765) SQL event is not fired when query is reduced to local form
[
https://issues.apache.org/jira/browse/IGNITE-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691252#comment-16691252
]
Ignite TC Bot commented on IGNITE-8765:
---
{panel:title=Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Inspections: Core{color} [[tests 0 BuildFailureOnMetric
|https://ci.ignite.apache.org/viewLog.html?buildId=2348227]]
{color:#d04437}PDS 1{color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=2348213]]
{color:#d04437}Cache 7{color} [[tests 0 TIMEOUT , Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=2348198]]
{color:#d04437}Thin client: Node.js{color} [[tests 0 Exit Code
|https://ci.ignite.apache.org/viewLog.html?buildId=2348167]]
{color:#d04437}Cache 1{color} [[tests
2|https://ci.ignite.apache.org/viewLog.html?buildId=2348192]]
* IgniteBinaryCacheTestSuite: IgniteCacheEntryListenerAtomicTest.testEvents -
0,0% fails in last 100 master runs.
{color:#d04437}Scala (Visor Console){color} [[tests
1|https://ci.ignite.apache.org/viewLog.html?buildId=2348162]]
* VisorConsoleSelfTestSuite: VisorActivationCommandSpec.A top visor
command for cluster activation should deactivate cluster - 0,0% fails in last
100 master runs.
{panel}
[TeamCity Run All
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2348231buildTypeId=IgniteTests24Java8_RunAll]
> SQL event is not fired when query is reduced to local form
> --
>
> Key: IGNITE-8765
> URL: https://issues.apache.org/jira/browse/IGNITE-8765
> Project: Ignite
> Issue Type: Bug
> Components: sql
>Affects Versions: 2.4, 2.5
>Reporter: Vladimir Ozerov
>Assignee: Pavel Kuznetsov
>Priority: Major
>
> *Reproducer*
> {{org.apache.ignite.internal.processors.cache.IgniteCacheAbstractQuerySelfTest#testSqlQueryEvents}}
> *Root Cause*
> Local and non-local query execution is performed differently. Local query is
> logged early. However, non-local query could be reduced after that. As a
> result, event is missed. Try change
> {{org.apache.ignite.internal.processors.query.h2.sql.GridSqlQueryParser#isLocalQuery}}
> method to always return {{false}} and then re-run failed test to see the
> difference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-10314) QueryEntity is not updated when column and index added or dropped
[ https://issues.apache.org/jira/browse/IGNITE-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691221#comment-16691221 ] Ray edited comment on IGNITE-10314 at 11/19/18 3:54 AM: I have submitted a fix for this bug. [~vozerov] Can you take a look and tell me if this is a correct fix please? I'll fix the current tests and add more tests if this is the correct fix. Also can you explain why you copy the QueryEntity in QuerySchema? was (Author: ldz): I have submitted a fix for this bug. [~vozerov] Can you take a look and tell me if this is a correct fix please? I'll fix the tests and more tests if this is the correct fix. Also can you explain why you copy the QueryEntity in QuerySchema? > QueryEntity is not updated when column and index added or dropped > - > > Key: IGNITE-10314 > URL: https://issues.apache.org/jira/browse/IGNITE-10314 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.6, 2.7 >Reporter: Ray >Assignee: Ray >Priority: Critical > Fix For: 2.8 > > > When user performs column and index modification operation in SQL(ex create > index, drop index, add column, drop column), QueryEntity in > CacheConfiguration for the modified cache is not updated. > > Analyse > QueryEntity in QuerySchema is a local copy of the original QueryEntity, so > the original QueryEntity is not updated when modification happens. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10314) QueryEntity is not updated when column and index added or dropped
[ https://issues.apache.org/jira/browse/IGNITE-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691221#comment-16691221 ] Ray commented on IGNITE-10314: -- I have submitted a fix for this bug. [~vozerov] Can you take a look and tell me if this is a correct fix please? I'll fix the tests and more tests if this is the correct fix. Also can you explain why you copy the QueryEntity in QuerySchema? > QueryEntity is not updated when column and index added or dropped > - > > Key: IGNITE-10314 > URL: https://issues.apache.org/jira/browse/IGNITE-10314 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.6, 2.7 >Reporter: Ray >Assignee: Ray >Priority: Critical > Fix For: 2.8 > > > When user performs column and index modification operation in SQL(ex create > index, drop index, add column, drop column), QueryEntity in > CacheConfiguration for the modified cache is not updated. > > Analyse > QueryEntity in QuerySchema is a local copy of the original QueryEntity, so > the original QueryEntity is not updated when modification happens. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10314) QueryEntity is not updated when column and index added or dropped
[ https://issues.apache.org/jira/browse/IGNITE-10314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691218#comment-16691218 ] ASF GitHub Bot commented on IGNITE-10314: - GitHub user ldzhjn opened a pull request: https://github.com/apache/ignite/pull/5422 IGNITE-10314 QueryEntity is not updated when column and index added or dropped You can merge this pull request into a Git repository by running: $ git pull https://github.com/ldzhjn/ignite IGNITE-10314 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5422.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5422 commit 50081ba19ec1f0c841adf69408e7db256e22334b Author: rayliu Date: 2018-11-19T03:43:11Z Fix bug > QueryEntity is not updated when column and index added or dropped > - > > Key: IGNITE-10314 > URL: https://issues.apache.org/jira/browse/IGNITE-10314 > Project: Ignite > Issue Type: Bug >Affects Versions: 2.6, 2.7 >Reporter: Ray >Assignee: Ray >Priority: Critical > Fix For: 2.8 > > > When user performs column and index modification operation in SQL(ex create > index, drop index, add column, drop column), QueryEntity in > CacheConfiguration for the modified cache is not updated. > > Analyse > QueryEntity in QuerySchema is a local copy of the original QueryEntity, so > the original QueryEntity is not updated when modification happens. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-10314) QueryEntity is not updated when column and index added or dropped
Ray created IGNITE-10314: Summary: QueryEntity is not updated when column and index added or dropped Key: IGNITE-10314 URL: https://issues.apache.org/jira/browse/IGNITE-10314 Project: Ignite Issue Type: Bug Affects Versions: 2.6, 2.7 Reporter: Ray Assignee: Ray Fix For: 2.8 When user performs column and index modification operation in SQL(ex create index, drop index, add column, drop column), QueryEntity in CacheConfiguration for the modified cache is not updated. Analyse QueryEntity in QuerySchema is a local copy of the original QueryEntity, so the original QueryEntity is not updated when modification happens. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8765) SQL event is not fired when query is reduced to local form
[
https://issues.apache.org/jira/browse/IGNITE-8765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691142#comment-16691142
]
ASF GitHub Bot commented on IGNITE-8765:
GitHub user pavel-kuznetsov opened a pull request:
https://github.com/apache/ignite/pull/5421
IGNITE-8765: Fixed event's query type
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-8765
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/5421.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5421
commit d4ecd8454a5511c8b85fb3c3ede0072d71b2757f
Author: palmuhal
Date: 2018-11-18T23:49:42Z
ignite-8765: Enabled test for the bug.
Bug itself have been fixed during IGNITE-10253.
commit 6cad0bb22b2b7a0f3a58486c66d145a39eacb312
Author: palmuhal
Date: 2018-11-19T00:17:39Z
ignite-8765: Fixed event type.
Earlier no matter query of what type (SQL or SQL_FIELDS) got executed,
"SQL" used to be the query type of the event. Now we make a difference.
Also event message is updated.
> SQL event is not fired when query is reduced to local form
> --
>
> Key: IGNITE-8765
> URL: https://issues.apache.org/jira/browse/IGNITE-8765
> Project: Ignite
> Issue Type: Bug
> Components: sql
>Affects Versions: 2.4, 2.5
>Reporter: Vladimir Ozerov
>Assignee: Pavel Kuznetsov
>Priority: Major
>
> *Reproducer*
> {{org.apache.ignite.internal.processors.cache.IgniteCacheAbstractQuerySelfTest#testSqlQueryEvents}}
> *Root Cause*
> Local and non-local query execution is performed differently. Local query is
> logged early. However, non-local query could be reduced after that. As a
> result, event is missed. Try change
> {{org.apache.ignite.internal.processors.query.h2.sql.GridSqlQueryParser#isLocalQuery}}
> method to always return {{false}} and then re-run failed test to see the
> difference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8867) [ML] Bagging on learning sample
[ https://issues.apache.org/jira/browse/IGNITE-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1669#comment-1669 ] ASF GitHub Bot commented on IGNITE-8867: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/5058 > [ML] Bagging on learning sample > --- > > Key: IGNITE-8867 > URL: https://issues.apache.org/jira/browse/IGNITE-8867 > Project: Ignite > Issue Type: Improvement > Components: ml >Reporter: Yury Babak >Assignee: Artem Malykh >Priority: Major > Fix For: 2.8 > > > Need to implement bootstrapping algorithm in Bagging-classifier -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (IGNITE-8867) [ML] Bagging on learning sample
[ https://issues.apache.org/jira/browse/IGNITE-8867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yury Babak resolved IGNITE-8867. Resolution: Done reviewed by [~aplatonov], [~dmitrievanthony], [~chief] merged > [ML] Bagging on learning sample > --- > > Key: IGNITE-8867 > URL: https://issues.apache.org/jira/browse/IGNITE-8867 > Project: Ignite > Issue Type: Improvement > Components: ml >Reporter: Yury Babak >Assignee: Artem Malykh >Priority: Major > Fix For: 2.8 > > > Need to implement bootstrapping algorithm in Bagging-classifier -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (IGNITE-10313) Long exchange on deactivation process
ARomantsov created IGNITE-10313: --- Summary: Long exchange on deactivation process Key: IGNITE-10313 URL: https://issues.apache.org/jira/browse/IGNITE-10313 Project: Ignite Issue Type: Bug Affects Versions: 2.7 Environment: 16 host, 1 server node per host Reporter: ARomantsov Fix For: 2.8 Long exhange after start deactivation process - near to three minutes. Probably in doesn't end, but control.sh return to control to console and I stop cluster -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-10184) Missed TODO: IGNITE-5380 uncomment after fix
[
https://issues.apache.org/jira/browse/IGNITE-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690888#comment-16690888
]
Ryabov Dmitrii commented on IGNITE-10184:
-
Inspections failure was fixed in
[IGNITE-10237|https://github.com/apache/ignite/pull/5378/files].
[~aliskhakov], move ticket to Patch Available status.
[~dpavlov], test is succesfully finished on TC. Can you merge PR?
> Missed TODO: IGNITE-5380 uncomment after fix
>
>
> Key: IGNITE-10184
> URL: https://issues.apache.org/jira/browse/IGNITE-10184
> Project: Ignite
> Issue Type: Test
>Reporter: Ryabov Dmitrii
>Assignee: Albert Iskhakov
>Priority: Trivial
> Labels: newbie
> Fix For: 2.8
>
>
> Ticket is resolved, so test
> {{SqlSchemaSelfTest._testTypeConflictInPublicSchema}} should be renamed
> (remove "\_" symbol) and fixed - this test should check that second cache
> creation throws exception about conflict in the schema.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-10184) Missed TODO: IGNITE-5380 uncomment after fix
[
https://issues.apache.org/jira/browse/IGNITE-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690886#comment-16690886
]
Ignite TC Bot commented on IGNITE-10184:
{panel:title=Possible
Blockers|borderStyle=dashed|borderColor=#ccc|titleBGColor=#F7D6C1}
{color:#d04437}Inspections: Core{color} [[tests 0 BuildFailureOnMetric
|https://ci.ignite.apache.org/viewLog.html?buildId=2342420]]
{panel}
[TeamCity Run All
Results|https://ci.ignite.apache.org/viewLog.html?buildId=2342424buildTypeId=IgniteTests24Java8_RunAll]
> Missed TODO: IGNITE-5380 uncomment after fix
>
>
> Key: IGNITE-10184
> URL: https://issues.apache.org/jira/browse/IGNITE-10184
> Project: Ignite
> Issue Type: Test
>Reporter: Ryabov Dmitrii
>Assignee: Albert Iskhakov
>Priority: Trivial
> Labels: newbie
> Fix For: 2.8
>
>
> Ticket is resolved, so test
> {{SqlSchemaSelfTest._testTypeConflictInPublicSchema}} should be renamed
> (remove "\_" symbol) and fixed - this test should check that second cache
> creation throws exception about conflict in the schema.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
