[jira] [Commented] (IGNITE-12505) Improve logging of data regions on startup

2020-01-19 Thread Ivan Pavlukhin (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17019276#comment-17019276
 ] 

Ivan Pavlukhin commented on IGNITE-12505:
-

[~ilyak], the patch looks good to me.

> Improve logging of data regions on startup
> --
>
> Key: IGNITE-12505
> URL: https://issues.apache.org/jira/browse/IGNITE-12505
> Project: Ignite
>  Issue Type: Improvement
>  Components: general
>Reporter: Ilya Kasnacheev
>Assignee: Ilya Kasnacheev
>Priority: Major
>  Labels: usability
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> First we have IgniteConfiguration printed (quiet=false):
> {quote}2019-07-24 02:33:33.918[INFO 
> ][Thread-139][o.a.i.i.IgniteKernal%GridNodeName] IgniteConfiguration [... 
> dfltDataRegConf=DataRegionConfiguration [name=mem_plc, maxSize=635655159808, 
> initSize=268435456, swapPath=null, pageEvictionMode=DISABLED, 
> evictionThreshold=0.9, emptyPagesPoolSize=100, metricsEnabled=true, 
> metricsSubIntervalCount=5, metricsRateTimeInterval=1000, 
> persistenceEnabled=true, checkpointPageBufSize=17179869184], 
> storagePath=/ssd/data, checkpointFreq=3, lockWaitTime=1, 
> checkpointThreads=4, checkpointWriteOrder=SEQUENTIAL, walHistSize=2147483647, 
> walSegments=10, walSegmentSize=1073741824, walPath=/ssd/data/wal, 
> walArchivePath=/sas/wal_archive, metricsEnabled=false, walMode=LOG_ONLY, 
> walTlbSize=131072, walBuffSize=5242880, walFlushFreq=2000, 
> walFsyncDelay=1000, walRecordIterBuffSize=67108864, 
> alwaysWriteFullPages=false, 
> fileIOFactory=org.apache.ignite.internal.processors.cache.persistence.file.AsyncFileIOFactory@3612c49a,
>  metricsSubIntervalCnt=5, metricsRateTimeInterval=6, 
> walAutoArchiveAfterInactivity=-1, writeThrottlingEnabled=false, 
> walCompactionEnabled=true, walCompactionLevel=1], ...]{quote}
> Then we have all configured Data Regions printed per IGNITE-8803 (quiet=true):
> {quote} [11:30:36] Data Regions Configured:
>  [11:30:36]  ^-- plcWithMetrics [initSize=256,0 MiB, maxSize=6,3 GiB, 
> persistence=false, lazyMemoryAllocation=true]
>  [11:30:36]  ^-- plcNoMetrics [initSize=256,0 MiB, maxSize=6,3 GiB, 
> persistence=false, lazyMemoryAllocation=true]{quote}
> Then we print number of Data Regions that were initialized as per 
> IGNITE-7196, but not regions themselves (quiet=false):
> Configured data regions initialized successfully [total=4]
> I propose to keep the first one (IgniteConfiguration), remove the second one 
> (Data Regions Configured), and promote the last one to quiet mode while also 
> outputting the regions themselves like this:
> {quote} [11:30:36] Data Regions Initialized Successfully: 4
>  [11:30:36]  ^-- plcWithMetrics [initSize=256,0 MiB, maxSize=6,3 GiB, 
> persistence=true, lazyMemoryAllocation=true]
>  [11:30:36]  ^-- plcNoMetrics [initSize=256,0 MiB, maxSize=6,3 GiB, 
> persistence=true, lazyMemoryAllocation=true]
>  [11:30:36]  ^-- sysMemPlc [initSize=40,0 MiB, maxSize=100,0 MiB, 
> persistence=true, lazyMemoryAllocation=false]
>  [11:30:36]  ^-- volatileMemPlc [initSize=40,0 MiB, maxSize=100,0 MiB, 
> persistence=false, lazyMemoryAllocation=true]{quote}
> Also clearly mark default region and system regions as such.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-12225) Add enum for cluster state

2020-01-19 Thread Sergey Antonov (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-12225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17019216#comment-17019216
 ] 

Sergey Antonov commented on IGNITE-12225:
-

[~Pavlukhin] I created PR fix license fix 
https://github.com/apache/ignite/pull/7275/

> Add enum for cluster state
> --
>
> Key: IGNITE-12225
> URL: https://issues.apache.org/jira/browse/IGNITE-12225
> Project: Ignite
>  Issue Type: Improvement
>Reporter: Sergey Antonov
>Assignee: Sergey Antonov
>Priority: Major
> Fix For: 2.8
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> We have 3 cluster states at the moment: inactive, active, read-only. 
> For getting current cluster state and changing them {{IgniteCluster}} has 
> methods:
> * {{boolean active()}}, {{void active(boolean active)}} - for cluster 
> activation/deactivation 
> * {{boolean readOnly()}}, {{void readOnly(boolean readOnly)}} - for 
> enabling/disabling read-only mode.
> Also we have control.sh commans for changing cluster state:
> * {{--activate}}
> * {{--deactivate}}
> * {{--read-only-on}}
> * {{--read-only-off}}
> For me current API looks unuseful. My proposal:
> # Create enum {{ClusterState}} with values {{ACTIVE}}, {{INACTIVE}}, 
> {{READ-ONLY}}.
> # Add methods to {{IgniteCluster}}:
> #* {{ClusterState state()}} returns current cluster state
> #* {{void state(ClusterState newState)}} changes cluster state to 
> {{newState}} state
> # Mark as deprecated the following methods in {{IgniteCluster}}: {{boolean 
> active()}}, {{void active(boolean active)}}, 
> # Add new command to control.sh: {{control.sh --set-state 
> (ACTIVE|INACTIVE|READ-ONLY)}} [--yes]
> # Add warn message that command is depricated in control.sh. Commands: 
> --activate, --deactivate, 
> # Remove commands from control.sh: --read-only-on, --read-only-off (no one 
> release wasn't published with this functional)
> # Add new methods to {{IgniteConfiguration}}:
> #* {{ClusterState getClusterStateOnStart()}}
> #* {{IgniteConfiguration setClusterStateOnStart(ClusterState state)}}
> # Deprecate methods in {{IgniteConfiguration}}:
> #* {{boolean isActiveOnStart()}}
> #* {{IgniteConfiguration setActiveOnStart(boolean activeOnStart)}}
> # Depracate ClusterActivationEvent and introduce new ClusterStateChangeEvent.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IGNITE-12398) Apache Ignite Cluster(Amazon S3 Based Discovery) Nodes getting down if we connect Ignite Visor Command Line Interface

2020-01-19 Thread Emmanouil Gkatziouras (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-12398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emmanouil Gkatziouras reassigned IGNITE-12398:
--

Assignee: Emmanouil Gkatziouras

> Apache Ignite Cluster(Amazon S3 Based Discovery) Nodes getting down if we 
> connect Ignite Visor Command Line Interface
> -
>
> Key: IGNITE-12398
> URL: https://issues.apache.org/jira/browse/IGNITE-12398
> Project: Ignite
>  Issue Type: Bug
>  Components: aws, general, s3, visor
>Affects Versions: 2.7
> Environment: Production
>Reporter: Ravi Kumar Powli
>Assignee: Emmanouil Gkatziouras
>Priority: Blocker
> Fix For: None, 2.8
>
>
> We have Apache Ignite 3 node cluster setup with Amazon S3 Based Discovery. If 
> we connect any one cluster node using Ignite Visor Command Line Interface it 
> got hang and automatically cluster nodes(all the three nodes) are going down. 
> Please find the below exception stacktrace.
> [SEVERE][tcp-disco-msg-worker-#2%DataStoreIgniteCache%][] Critical system 
> error detected. Will be handled accordingly to configured handler 
> [hnd=NoOpFailureHandler [super=AbstractFailureHandler 
> [ignoredFailureTypes=[SYSTEM_WORKER_BLOCKED]]], failureCtx=FailureContext 
> [type=SYSTEM_WORKER_TERMINATION, err=java.lang.NullPointerException]]
> java.lang.NullPointerException
> at 
> org.apache.ignite.spi.discovery.tcp.ipfinder.s3.TcpDiscoveryS3IpFinder.key(TcpDiscoveryS3IpFinder.java:247)
> at 
> org.apache.ignite.spi.discovery.tcp.ipfinder.s3.TcpDiscoveryS3IpFinder.registerAddresses(TcpDiscoveryS3IpFinder.java:205)
> at 
> org.apache.ignite.spi.discovery.tcp.ServerImpl$RingMessageWorker.processNodeAddFinishedMessage(ServerImpl.java:4616)
> at 
> org.apache.ignite.spi.discovery.tcp.ServerImpl$RingMessageWorker.processNodeAddedMessage(ServerImpl.java:4232)
> at 
> org.apache.ignite.spi.discovery.tcp.ServerImpl$RingMessageWorker.processMessage(ServerImpl.java:2816)
> at 
> org.apache.ignite.spi.discovery.tcp.ServerImpl$RingMessageWorker.processMessage(ServerImpl.java:2611)
> at 
> org.apache.ignite.spi.discovery.tcp.ServerImpl$MessageWorker.body(ServerImpl.java:7188)
> at 
> org.apache.ignite.spi.discovery.tcp.ServerImpl$RingMessageWorker.body(ServerImpl.java:2700)
> at org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:120)
> at 
> org.apache.ignite.spi.discovery.tcp.ServerImpl$MessageWorkerThread.body(ServerImpl.java:7119)
> at org.apache.ignite.spi.IgniteSpiThread.run(IgniteSpiThread.java:62)
> [10:36:54,600][SEVERE][tcp-disco-msg-worker-#2%DataStoreIgniteCache%][] 
> Critical system error detected. Will be handled accordingly to configured 
> handler [hnd=NoOpFailureHandler [super=AbstractFailureHandler 
> [ignoredFailureTypes=[SYSTEM_WORKER_BLOCKED]]], failureCtx=FailureContext 
> [type=SYSTEM_WORKER_TERMINATION, err=class o.a.i.IgniteException: GridWorker 
> [name=tcp-disco-msg-worker, igniteInstanceName=DataStoreIgniteCache, 
> finished=true, heartbeatTs=1574332614423]]]
> class org.apache.ignite.IgniteException: GridWorker 
> [name=tcp-disco-msg-worker, igniteInstanceName=DataStoreIgniteCache, 
> finished=true, heartbeatTs=1574332614423]
> at 
> org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance$2.apply(IgnitionEx.java:1831)
> at 
> org.apache.ignite.internal.IgnitionEx$IgniteNamedInstance$2.apply(IgnitionEx.java:1826)
> at 
> org.apache.ignite.internal.worker.WorkersRegistry.onStopped(WorkersRegistry.java:169)
> at org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:153)
> at 
> org.apache.ignite.spi.discovery.tcp.ServerImpl$MessageWorkerThread.body(ServerImpl.java:7119)
> at org.apache.ignite.spi.IgniteSpiThread.run(IgniteSpiThread.java:62)
> [10:36:59] Ignite node stopped OK [name=DataStoreIgniteCache, 
> uptime=00:01:13.934]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (IGNITE-8617) Node Discovery Using AWS Application ELB

2020-01-19 Thread Emmanouil Gkatziouras (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018922#comment-17018922
 ] 

Emmanouil Gkatziouras edited comment on IGNITE-8617 at 1/19/20 2:31 PM:


Fixed conflicts and Tested on an AWS environment with an Application Load 
Balancer and an autoscaling group.

TcpDiscoveryAlbIpFinder works as expected.
 * On startup nodes discover each other.
 * On ec2 node down connection is lost and the cluster decreases.
 * On an extra node added the cluster size increases


was (Author: gkatzioura):
Fixed conflicts and Tested on an AWS environment with an Application Load 
Balancer and an autoscaling group on TcpDiscoveryAlbIpFinder works as expected.
 * On startup nodes discover each other.
 * On ec2 node down connection is lost and the cluster decreases.
 * On an extra node added the cluster size increases

> Node Discovery Using AWS Application ELB
> 
>
> Key: IGNITE-8617
> URL: https://issues.apache.org/jira/browse/IGNITE-8617
> Project: Ignite
>  Issue Type: New Feature
>  Components: aws
>Reporter: Uday Kale
>Assignee: Emmanouil Gkatziouras
>Priority: Critical
> Fix For: 2.9
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Support for Node discovery using AWS Application ELB. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (IGNITE-8617) Node Discovery Using AWS Application ELB

2020-01-19 Thread Emmanouil Gkatziouras (Jira)


[ 
https://issues.apache.org/jira/browse/IGNITE-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018922#comment-17018922
 ] 

Emmanouil Gkatziouras commented on IGNITE-8617:
---

Fixed conflicts and Tested on an AWS environment with an Application Load 
Balancer and an autoscaling group on TcpDiscoveryAlbIpFinder works as expected.
 * On startup nodes discover each other.
 * On ec2 node down connection is lost and the cluster decreases.
 * On an extra node added the cluster size increases

> Node Discovery Using AWS Application ELB
> 
>
> Key: IGNITE-8617
> URL: https://issues.apache.org/jira/browse/IGNITE-8617
> Project: Ignite
>  Issue Type: New Feature
>  Components: aws
>Reporter: Uday Kale
>Assignee: Emmanouil Gkatziouras
>Priority: Critical
> Fix For: 2.9
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Support for Node discovery using AWS Application ELB. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (IGNITE-8617) Node Discovery Using AWS Application ELB

2020-01-19 Thread Emmanouil Gkatziouras (Jira)


 [ 
https://issues.apache.org/jira/browse/IGNITE-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Emmanouil Gkatziouras reassigned IGNITE-8617:
-

Assignee: Emmanouil Gkatziouras  (was: Uday Kale)

> Node Discovery Using AWS Application ELB
> 
>
> Key: IGNITE-8617
> URL: https://issues.apache.org/jira/browse/IGNITE-8617
> Project: Ignite
>  Issue Type: New Feature
>  Components: aws
>Reporter: Uday Kale
>Assignee: Emmanouil Gkatziouras
>Priority: Critical
> Fix For: 2.9
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Support for Node discovery using AWS Application ELB. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)