[jira] [Commented] (IGNITE-3207) Rename IgniteConfiguration.gridName
[ https://issues.apache.org/jira/browse/IGNITE-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356748#comment-15356748 ] Biao Ma commented on IGNITE-3207: - Yes, I think I've rename most of the "gridName" to "instanceName", Now I am running "mvn clean package -DskipTests" . If there is nothing wrong, I'd format the patch and push a PR. > Rename IgniteConfiguration.gridName > --- > > Key: IGNITE-3207 > URL: https://issues.apache.org/jira/browse/IGNITE-3207 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.1.4 >Reporter: Pavel Tupitsyn >Assignee: Biao Ma > Fix For: 1.7 > > > We have got a TON of questions on gridName property. Everyone thinks that > clusters are formed based on the gridName, that is, nodes with the same grid > name will join one cluster, and nodes with a different name will be in a > separate cluster. > Let's do the following: > * Deprecate IgniteConfiguration.gridName > * Add IgniteConfiguration.localInstanceName > * Rename related parameters in Ignition class (and other places, if present) > * Update Javadoc: clearly state that this name only works locally and has no > effect on topology. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (IGNITE-3304) Fix parameter error in class GridServiceProcessor
Biao Ma created IGNITE-3304: --- Summary: Fix parameter error in class GridServiceProcessor Key: IGNITE-3304 URL: https://issues.apache.org/jira/browse/IGNITE-3304 Project: Ignite Issue Type: Bug Affects Versions: 1.6 Reporter: Biao Ma Fix For: 1.6 Method `serviceProxy` in Class `org.apache.ignite.internal.processors.service.GridServiceProcessor` seems missing type paramter "T". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (IGNITE-3304) Fix parameter error in class GridServiceProcessor
[ https://issues.apache.org/jira/browse/IGNITE-3304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Ma reassigned IGNITE-3304: --- Assignee: Biao Ma > Fix parameter error in class GridServiceProcessor > - > > Key: IGNITE-3304 > URL: https://issues.apache.org/jira/browse/IGNITE-3304 > Project: Ignite > Issue Type: Bug >Affects Versions: 1.6 >Reporter: Biao Ma >Assignee: Biao Ma > Fix For: 1.6 > > > Method `serviceProxy` in Class > `org.apache.ignite.internal.processors.service.GridServiceProcessor` seems > missing type paramter "T". -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-3231) GridCachePartitionedNearDisabledFairAffinityMultiNodeFullApiSelfTest must either be declared abstract or implement method 'gridCount()'
[ https://issues.apache.org/jira/browse/IGNITE-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311848#comment-15311848 ] Biao Ma commented on IGNITE-3231: - Sorry, it is not a bug, because I am working on other issues, during my working, I made some mistake. I rename the method `gridCount` to `instanceCount`. > GridCachePartitionedNearDisabledFairAffinityMultiNodeFullApiSelfTest must > either be declared abstract or implement method 'gridCount()' > --- > > Key: IGNITE-3231 > URL: https://issues.apache.org/jira/browse/IGNITE-3231 > Project: Ignite > Issue Type: Bug >Affects Versions: 1.6, 1.7 >Reporter: Biao Ma >Assignee: Anton Vinogradov > Fix For: 1.7 > > > It seems that here missing the implement method `instanceCout()`, so just add > it should work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (IGNITE-3231) GridCachePartitionedNearDisabledFairAffinityMultiNodeFullApiSelfTest must either be declared abstract or implement method 'gridCount()'
[ https://issues.apache.org/jira/browse/IGNITE-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Ma resolved IGNITE-3231. - Resolution: Not A Bug > GridCachePartitionedNearDisabledFairAffinityMultiNodeFullApiSelfTest must > either be declared abstract or implement method 'gridCount()' > --- > > Key: IGNITE-3231 > URL: https://issues.apache.org/jira/browse/IGNITE-3231 > Project: Ignite > Issue Type: Bug >Affects Versions: 1.6, 1.7 >Reporter: Biao Ma >Assignee: Anton Vinogradov > Fix For: 1.7 > > > It seems that here missing the implement method `instanceCout()`, so just add > it should work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (IGNITE-3234) GridCacheAtomicPrimaryWriteOrderFailoverSelfTest lacks method for GridCacheAtomicFailoverSelfTest
[ https://issues.apache.org/jira/browse/IGNITE-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Ma resolved IGNITE-3234. - Resolution: Not A Bug > GridCacheAtomicPrimaryWriteOrderFailoverSelfTest lacks method for > GridCacheAtomicFailoverSelfTest > - > > Key: IGNITE-3234 > URL: https://issues.apache.org/jira/browse/IGNITE-3234 > Project: Ignite > Issue Type: Bug >Affects Versions: 1.6 >Reporter: Biao Ma >Assignee: Biao Ma > Fix For: 1.6 > > > Now the test `GridCacheAtomicPrimaryWriteOrderFailoverSelfTest` extends > `GridCacheAtomicFailoverSelfTest`, but lacks the unimplement method > `gridCount`. So just add the implement. It would work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-3234) GridCacheAtomicPrimaryWriteOrderFailoverSelfTest lacks method for GridCacheAtomicFailoverSelfTest
[ https://issues.apache.org/jira/browse/IGNITE-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311843#comment-15311843 ] Biao Ma commented on IGNITE-3234: - This is not a bug. > GridCacheAtomicPrimaryWriteOrderFailoverSelfTest lacks method for > GridCacheAtomicFailoverSelfTest > - > > Key: IGNITE-3234 > URL: https://issues.apache.org/jira/browse/IGNITE-3234 > Project: Ignite > Issue Type: Bug >Affects Versions: 1.6 >Reporter: Biao Ma >Assignee: Biao Ma > Fix For: 1.6 > > > Now the test `GridCacheAtomicPrimaryWriteOrderFailoverSelfTest` extends > `GridCacheAtomicFailoverSelfTest`, but lacks the unimplement method > `gridCount`. So just add the implement. It would work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (IGNITE-3234) GridCacheAtomicPrimaryWriteOrderFailoverSelfTest lacks method for GridCacheAtomicFailoverSelfTest
Biao Ma created IGNITE-3234: --- Summary: GridCacheAtomicPrimaryWriteOrderFailoverSelfTest lacks method for GridCacheAtomicFailoverSelfTest Key: IGNITE-3234 URL: https://issues.apache.org/jira/browse/IGNITE-3234 Project: Ignite Issue Type: Bug Affects Versions: 1.6 Reporter: Biao Ma Fix For: 1.6 Now the test `GridCacheAtomicPrimaryWriteOrderFailoverSelfTest` extends `GridCacheAtomicFailoverSelfTest`, but lacks the unimplement method `gridCount`. So just add the implement. It would work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (IGNITE-3231) GridCachePartitionedNearDisabledFairAffinityMultiNodeFullApiSelfTest must either be declared abstract or implement method 'gridCount()'
[ https://issues.apache.org/jira/browse/IGNITE-3231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Ma updated IGNITE-3231: Summary: GridCachePartitionedNearDisabledFairAffinityMultiNodeFullApiSelfTest must either be declared abstract or implement method 'gridCount()' (was: GridCachePartitionedNearDisabledFairAffinityMultiNodeFullApiSelfTest must either be declared abstract or implement method 'instanceCount()') > GridCachePartitionedNearDisabledFairAffinityMultiNodeFullApiSelfTest must > either be declared abstract or implement method 'gridCount()' > --- > > Key: IGNITE-3231 > URL: https://issues.apache.org/jira/browse/IGNITE-3231 > Project: Ignite > Issue Type: Bug >Affects Versions: 1.6, 1.7 >Reporter: Biao Ma > Fix For: 1.6 > > > It seems that here missing the implement method `instanceCout()`, so just add > it should work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (IGNITE-3231) GridCachePartitionedNearDisabledFairAffinityMultiNodeFullApiSelfTest must either be declared abstract or implement method 'instanceCount()'
Biao Ma created IGNITE-3231: --- Summary: GridCachePartitionedNearDisabledFairAffinityMultiNodeFullApiSelfTest must either be declared abstract or implement method 'instanceCount()' Key: IGNITE-3231 URL: https://issues.apache.org/jira/browse/IGNITE-3231 Project: Ignite Issue Type: Bug Affects Versions: 1.6, 1.7 Reporter: Biao Ma Fix For: 1.6 It seems that here missing the implement method `instanceCout()`, so just add it should work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (IGNITE-3229) un existing link in Class GridCacheStoreValueBytesSelfTest
Biao Ma created IGNITE-3229: --- Summary: un existing link in Class GridCacheStoreValueBytesSelfTest Key: IGNITE-3229 URL: https://issues.apache.org/jira/browse/IGNITE-3229 Project: Ignite Issue Type: Bug Reporter: Biao Ma Class GridCacheStoreValueBytesSelfTest' s annotation has linked to an un existing method `org.apache.ignite.configuration.CacheConfiguration#isStoreValueBytes()` -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (IGNITE-3207) Rename IgniteConfiguration.gridName
[ https://issues.apache.org/jira/browse/IGNITE-3207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Ma reassigned IGNITE-3207: --- Assignee: Biao Ma > Rename IgniteConfiguration.gridName > --- > > Key: IGNITE-3207 > URL: https://issues.apache.org/jira/browse/IGNITE-3207 > Project: Ignite > Issue Type: Improvement > Components: general >Affects Versions: 1.1.4 >Reporter: Pavel Tupitsyn >Assignee: Biao Ma > Fix For: 1.7 > > > We have got a TON of questions on gridName property. Everyone thinks that > clusters are formed based on the gridName, that is, nodes with the same grid > name will join one cluster, and nodes with a different name will be in a > separate cluster. > Let's do the following: > * Deprecate IgniteConfiguration.gridName > * Add IgniteConfiguration.localInstanceName > * Rename related parameters in Ignition class (and other places, if present) > * Update Javadoc: clearly state that this name only works locally and has no > effect on topology. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (IGNITE-2929) IgniteContext should not have type parameters
[ https://issues.apache.org/jira/browse/IGNITE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Biao Ma reassigned IGNITE-2929: --- Assignee: Biao Ma > IgniteContext should not have type parameters > - > > Key: IGNITE-2929 > URL: https://issues.apache.org/jira/browse/IGNITE-2929 > Project: Ignite > Issue Type: Bug >Affects Versions: 1.5.0.final >Reporter: Valentin Kulichenko >Assignee: Biao Ma > Fix For: 1.7 > > > Currently implementation of {{SparkContext}} has type parameters {{[K, V]}} > which means that all the RDDs that are created by a particular instance of > context have to be of the same type. > Looks like type parameters on {{IgniteContext}} don't make much sense and > should be removed. {{fromCache}} method should be parameterized instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2538) RDD.isEmpty method should be overriden in IgniteRDD to use IgniteCache API
[ https://issues.apache.org/jira/browse/IGNITE-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294998#comment-15294998 ] Biao Ma commented on IGNITE-2538: - Like blow? override def isEmpty(): Boolean = { val cache = ensureCache() return cache.size() <= 0 } If my understanding is not biased, I' ll have a try. > RDD.isEmpty method should be overriden in IgniteRDD to use IgniteCache API > -- > > Key: IGNITE-2538 > URL: https://issues.apache.org/jira/browse/IGNITE-2538 > Project: Ignite > Issue Type: Improvement > Components: Ignite RDD >Reporter: Valentin Kulichenko > > Currently calling {{IgniteRDD.isEmpty}} ends up in execution of 1024 Spark > jobs, which is not fast. We should override this method and use native > {{IgniteCache}} API there. Other methods should be also revisited. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-2929) IgniteContext should not have type parameters
[ https://issues.apache.org/jira/browse/IGNITE-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15291263#comment-15291263 ] Biao Ma commented on IGNITE-2929: - Hi, Val, I am working on this one.can you assign it to me? > IgniteContext should not have type parameters > - > > Key: IGNITE-2929 > URL: https://issues.apache.org/jira/browse/IGNITE-2929 > Project: Ignite > Issue Type: Bug >Affects Versions: 1.5.0.final >Reporter: Valentin Kulichenko > Fix For: 1.7 > > > Currently implementation of {{SparkContext}} has type parameters {{[K, V]}} > which means that all the RDDs that are created by a particular instance of > context have to be of the same type. > Looks like type parameters on {{IgniteContext}} don't make much sense and > should be removed. {{fromCache}} method should be parameterized instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332)