[jira] [Comment Edited] (IGNITE-10762) migrate test suites from Junit 3 to 4
[
https://issues.apache.org/jira/browse/IGNITE-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726519#comment-16726519
]
Oleg Ignatenko edited comment on IGNITE-10762 at 12/23/18 9:54 PM:
---
(i) Searching project for {{import junit.framework.JUnit4TestAdapter;}}
currently shows 129 occurrences; searching for {{import
junit.framework.TestSuite;}} shows 193.
All of these should go away and their amount above suggests that this may be
too big task to do in one step. It would be more convenient to change this to
full-scale (parent) task and after that, split to the following smaller parts
to make in sub-tasks:
- migrate examples (sort of a small scale pilot, also most visible part of our
code (IGNITE-10773)
- migrate suites that are fixed lists of test classes that can be handled by
{{@SuiteClasses}} API (IGNITE-10774)
- migrate suites of simple dynamic lists that use
{{GridTestUtils.addTestIfNeeded}} API (IGNITE-10775)
- migrate config variations testsuites ( (IGNITE-10776)
(related: IGNITE-10739)
- migrate suites that involve {{IgniteTestSuite}} API (IGNITE-10796)
- cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test
suites (IGNITE-10777)
(ideally there should be no more imports of {{junit.framework}} stuff except
for one of {{Assert}} API expected to be inherited by many subclasses of
{{GridAbstractTest}})
If split to smaller parts like above, needed changes would be much easier and
safer to implement, test, review and merge.
was (Author: oignatenko):
(i) Searching project for {{import junit.framework.JUnit4TestAdapter;}}
currently shows 129 occurrences; searching for {{import
junit.framework.TestSuite;}} shows 193.
All of these should go away and their amount above suggests that this may be
too big task to do in one step. It would be more convenient to change this to
full-scale (parent) task and after that, split to the following smaller parts
to make in sub-tasks:
- migrate examples (sort of a small scale pilot, also most visible part of our
code (IGNITE-10773)
- migrate suites that are fixed lists of test classes that can be handled by
{{@SuiteClasses}} API (IGNITE-10774)
- migrate suites of simple dynamic lists that use
{{GridTestUtils.addTestIfNeeded}} API (IGNITE-10775)
- migrate config variations testsuites ( (IGNITE-10776)
(related: IGNITE-10739)
- cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test
suites (IGNITE-10777)
(ideally there should be no more imports of {{junit.framework}} stuff except
for one of {{Assert}} API expected to be inherited by many subclasses of
{{GridAbstractTest}})
-- possibly this can further split by "extracting" to separate sub-task
suites that involve {{IgniteTestSuite}} API
If split to smaller parts like above, needed changes would be much easier and
safer to implement, test, review and merge.
> migrate test suites from Junit 3 to 4
> -
>
> Key: IGNITE-10762
> URL: https://issues.apache.org/jira/browse/IGNITE-10762
> Project: Ignite
> Issue Type: Task
>Affects Versions: 2.8
>Reporter: Ivan Pavlukhin
>Assignee: Oleg Ignatenko
>Priority: Major
> Labels: MakeTeamcityGreenAgain, technical_debt
> Fix For: 2.8
>
>
> It seems that {{@Ignore}} annotation is processed incorrectly when a test in
> Junit 4 style is included into Junit 3 test suite (wrapped into
> {{JUnit4TestAdapter}}). Actually such test is skipped silently when it is
> called during a suite execution. So, for full a blown usage of {{@Ignore}}
> test suites must be migrated to Junit 4 as well. Expected behavior here is
> reporting that a particular test method was ignored after tests execution.
> Ignored tests should be visible in CI.
> Apparently such unexpected behavior of {{@Ignore}} can be caused by
> {{JUnit4TestAdapter}} as it explicitly filters test method marked with this
> annotation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-10762) migrate test suites from Junit 3 to 4
[
https://issues.apache.org/jira/browse/IGNITE-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726519#comment-16726519
]
Oleg Ignatenko edited comment on IGNITE-10762 at 12/22/18 10:58 PM:
(i) Searching project for {{import junit.framework.JUnit4TestAdapter;}}
currently shows 129 occurrences; searching for {{import
junit.framework.TestSuite;}} shows 193.
All of these should go away and their amount above suggests that this may be
too big task to do in one step. It would be more convenient to change this to
full-scale (parent) task and after that, split to the following smaller parts
to make in sub-tasks:
- migrate examples (sort of a small scale pilot, also most visible part of our
code (IGNITE-10773)
- migrate suites that are fixed lists of test classes that can be handled by
{{@SuiteClasses}} API (IGNITE-10774)
- migrate suites of simple dynamic lists that use
{{GridTestUtils.addTestIfNeeded}} API (IGNITE-10775)
- migrate config variations testsuites ( (IGNITE-10776)
(related: IGNITE-10739)
- cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test
suites (IGNITE-10777)
(ideally there should be no more imports of {{junit.framework}} stuff except
for one of {{Assert}} API expected to be inherited by many subclasses of
{{GridAbstractTest}})
-- possibly this can further split by "extracting" to separate sub-task
suites that involve {{IgniteTestSuite}} API
If split to smaller parts like above, needed changes would be much easier and
safer to implement, test, review and merge.
was (Author: oignatenko):
(i) Searching project for {{import junit.framework.JUnit4TestAdapter;}}
currently shows 129 occurrences; searching for {{import
junit.framework.TestSuite;}} shows 193.
All of these should go away and their amount above suggests that this may be
too big task to do in one step. It would be more convenient to change this to
full-scale (parent) task and after that, split to the following smaller parts
to make in sub-tasks:
- migrate examples (sort of a small scale pilot, also most visible part of our
code (IGNITE-10773)
- migrate suites that are fixed lists of test classes that can be handled by
{{@SuiteClasses}} API (IGNITE-10774)
- migrate suites of simple dynamic lists that use
{{GridTestUtils.addTestIfNeeded}} API (IGNITE-10775)
- migrate config variations testsuites ( (IGNITE-10776)
(related: IGNITE-10739)
- cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test
suites (IGNITE-10777)
(ideally there should be no more imports of {{junit.framework}} stuff except
for one of {{Assert}} API expected to be inherited by many subclasses of
{{GridAbstractTest}})
If split to smaller parts like above, needed changes would be much easier and
safer to implement, test, review and merge.
> migrate test suites from Junit 3 to 4
> -
>
> Key: IGNITE-10762
> URL: https://issues.apache.org/jira/browse/IGNITE-10762
> Project: Ignite
> Issue Type: Task
>Affects Versions: 2.8
>Reporter: Ivan Pavlukhin
>Assignee: Oleg Ignatenko
>Priority: Major
> Labels: MakeTeamcityGreenAgain, technical_debt
> Fix For: 2.8
>
>
> It seems that {{@Ignore}} annotation is processed incorrectly when a test in
> Junit 4 style is included into Junit 3 test suite (wrapped into
> {{JUnit4TestAdapter}}). Actually such test is skipped silently when it is
> called during a suite execution. So, for full a blown usage of {{@Ignore}}
> test suites must be migrated to Junit 4 as well. Expected behavior here is
> reporting that a particular test method was ignored after tests execution.
> Ignored tests should be visible in CI.
> Apparently such unexpected behavior of {{@Ignore}} can be caused by
> {{JUnit4TestAdapter}} as it explicitly filters test method marked with this
> annotation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (IGNITE-10762) migrate test suites from Junit 3 to 4
[
https://issues.apache.org/jira/browse/IGNITE-10762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16726519#comment-16726519
]
Oleg Ignatenko edited comment on IGNITE-10762 at 12/21/18 8:17 AM:
---
(i) Searching project for {{import junit.framework.JUnit4TestAdapter;}}
currently shows 129 occurrences; searching for {{import
junit.framework.TestSuite;}} shows 193.
All of these should go away and their amount above suggests that this may be
too big task to do in one step. It would be more convenient to change this to
full-scale (parent) task and after that, split to the following smaller parts
to make in sub-tasks:
- migrate examples (sort of a small scale pilot, also most visible part of our
code (IGNITE-10773)
- migrate suites that are fixed lists of test classes that can be handled by
{{@SuiteClasses}} API (IGNITE-10774)
- migrate suites of simple dynamic lists that use
{{GridTestUtils.addTestIfNeeded}} API (IGNITE-10775)
- migrate config variations testsuites ( (IGNITE-10776)
(related: IGNITE-10739)
- cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test
suites (IGNITE-10777)
(ideally there should be no more imports of {{junit.framework}} stuff except
for one of {{Assert}} API expected to be inherited by many subclasses of
{{GridAbstractTest}})
If split to smaller parts like above, needed changes would be much easier and
safer to implement, test, review and merge.
was (Author: oignatenko):
(i) Searching project for {{import junit.framework.JUnit4TestAdapter;}}
currently shows 129 occurrences; searching for {{import
junit.framework.TestSuite;}} shows 193.
All of these should go away and their amount above suggests that this may be
too big task to do in one step. It would be more convenient to change this to
full-scale (parent) task and after that, split to the following smaller parts
to make in sub-tasks:
- migrate examples (sort of a small scale pilot, also most visible part of our
code
- migrate suites that are fixed lists of test classes that can be handled by
{{@SuiteClasses}} API
- migrate suites of simple dynamic lists that use
{{GridTestUtils.addTestIfNeeded}} API
- migrate config variations testsuites (related: IGNITE-10739)
- cleanup remainders of JUnit4TestAdapter and other JUnit 3 API involving test
suites
(ideally there should be no more imports of {{junit.framework}} stuff except
for one of {{Assert}} API expected to be inherited by many subclasses of
{{GridAbstractTest}})
If split to smaller parts like above, needed changes would be much easier and
safer to implement, test, review and merge.
> migrate test suites from Junit 3 to 4
> -
>
> Key: IGNITE-10762
> URL: https://issues.apache.org/jira/browse/IGNITE-10762
> Project: Ignite
> Issue Type: Task
>Affects Versions: 2.8
>Reporter: Ivan Pavlukhin
>Assignee: Oleg Ignatenko
>Priority: Major
> Labels: MakeTeamcityGreenAgain, technical_debt
> Fix For: 2.8
>
>
> It seems that {{@Ignore}} annotation is processed incorrectly when a test in
> Junit 4 style is included into Junit 3 test suite (wrapped into
> {{JUnit4TestAdapter}}). Actually such test is skipped silently when it is
> called during a suite execution. So, for full a blown usage of {{@Ignore}}
> test suites must be migrated to Junit 4 as well. Expected behavior here is
> reporting that a particular test method was ignored after tests execution.
> Ignored tests should be visible in CI.
> Apparently such unexpected behavior of {{@Ignore}} can be caused by
> {{JUnit4TestAdapter}} as it explicitly filters test method marked with this
> annotation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
